Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19788
Can we just add the `ContinuousShuffleBlockId` without adding new conf
`spark.shuffle.continuousFetch`? While in classes related to shuffle read like
`ShuffleBlockFetcherIterator`, we also pattern m
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153124078
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,73 @@ abstract class C
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153123637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user kiszk closed the pull request at:
https://github.com/apache/spark/pull/18641
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18641
#19752 will cover this solution.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153123184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,73 @@ abstract class CaseWh
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84207 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84207/testReport)**
for PR 19813 at commit
[`9f848be`](https://github.com/apache/spark/commit/9f
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153120458
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153120160
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19764
@caneGuy Can you give a specific example to illustrate your change? Maybe
former partition result & later partition result?
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19788
@yucai I'm thinking of the necessity to add this new configuration
`spark.shuffle.continuousFetch` like you mentioned above. This PR you proposed
is actually a superset of previous way, it is comp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84206/testReport)**
for PR 19752 at commit
[`f4c7896`](https://github.com/apache/spark/commit/f4
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153118605
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Cas
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153118387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Cas
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153118326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Cas
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19788
What are ` external shuffle service` here? Can you explain a little bit?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r153117548
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockId.scala ---
@@ -116,8 +117,8 @@ object BlockId {
def apply(name: String): BlockId = name ma
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r153117088
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockId.scala ---
@@ -116,8 +117,8 @@ object BlockId {
def apply(name: String): BlockId = name
Github user kaklakariada closed the pull request at:
https://github.com/apache/spark/pull/11215
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.o
Github user kaklakariada commented on the issue:
https://github.com/apache/spark/pull/11215
Solved with https://issues.apache.org/jira/browse/SPARK-19911 / #17250, see
[this
comment](https://issues.apache.org/jira/browse/SPARK-10969?focusedCommentId=16266374&page=com.atlassian.jira.pl
Github user lvdongr commented on the issue:
https://github.com/apache/spark/pull/19819
Will the cached consumer to the same partition increase , when different
tasks consume the same partition and no place to remove?
---
-
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r15398
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def _me
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153110594
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61), LongType())
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19815
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19815
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153110760
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -195,18 +196,26 @@ private[spark] class MetricsSystem private (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84203/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19815
**[Test build #84203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84203/testReport)**
for PR 19815 at commit
[`5711bb2`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84202/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84202/testReport)**
for PR 11994 at commit
[`f360dac`](https://github.com/apache/spark/commit/f
Github user sriramrajendiran commented on the issue:
https://github.com/apache/spark/pull/16578
@felixcheung can you help ? we are hoping to see it in 2.3 release. Feature
underneath a default disabled flag looks safe option.
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84205/testReport)**
for PR 19607 at commit
[`40a9735`](https://github.com/apache/spark/commit/40
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84204 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84204/testReport)**
for PR 19607 at commit
[`f92eae3`](https://github.com/apache/spark/commit/f9
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153107748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -997,6 +997,14 @@ object SQLConf {
.intConf
.c
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153107765
--- Diff: python/setup.py ---
@@ -201,7 +201,7 @@ def _supports_symlinks():
extras_require={
'ml': ['numpy>=1.7'],
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19815
LGTM pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84201/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84201 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84201/testReport)**
for PR 11994 at commit
[`38bc2a4`](https://github.com/apache/spark/commit/3
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153101065
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Ca
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19752
LGTM except a few minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153100483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Ca
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153100103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -211,111 +231,73 @@ abstract class Ca
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19752
LGTM cc @cloud-fan @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19714
Just for curiosity, what if users ask to broadcast both the join side in
the hint? Shall we throw exception or pick a smaller side to broadcast
according to stats?
BTW it's a behavior cha
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153099135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153098738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153098194
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/ConsoleSink.scala ---
@@ -25,27 +25,29 @@ import com.codahale.metrics.{ConsoleReporter,
Met
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153097744
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -195,18 +196,26 @@ private[spark] class MetricsSystem private (
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153097850
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/ConsoleSink.scala ---
@@ -25,27 +25,29 @@ import com.codahale.metrics.{ConsoleReporter,
Met
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153097471
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -195,18 +196,26 @@ private[spark] class MetricsSystem private (
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153098545
--- Diff: core/src/main/scala/org/apache/spark/metrics/sink/Sink.scala ---
@@ -17,8 +17,37 @@
package org.apache.spark.metrics.sink
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19813
If we have a clear rule, I think it makes more sense to do this in
`CodegenContext`, i.e. having a `def splitExpressions(expressions:
Seq[String]): String`, which automatically extract the current
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19714
We also need to update the comment of `JoinSelection`.
cc @liufengdb @cloud-fan @rxin
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19815
**[Test build #84203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84203/testReport)**
for PR 19815 at commit
[`5711bb2`](https://github.com/apache/spark/commit/57
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19714#discussion_r153098067
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala
---
@@ -223,4 +223,36 @@ class BroadcastJoinSuite extend
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19818#discussion_r153096313
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -62,13 +62,6 @@
*/
public abstract boo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19818#discussion_r153096296
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -73,12 +75,12 @@ public OffHeapColumnVector(in
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153095567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84202/testReport)**
for PR 11994 at commit
[`f360dac`](https://github.com/apache/spark/commit/f3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84200/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19814
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19814
**[Test build #84200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84200/testReport)**
for PR 19814 at commit
[`821ee19`](https://github.com/apache/spark/commit/8
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Ping any admin help review this?Thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84201/testReport)**
for PR 11994 at commit
[`38bc2a4`](https://github.com/apache/spark/commit/38
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/17520
@nsyca Can you resolve conflicts?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19717
+CC @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153092301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153092158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19823#discussion_r153091293
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -341,6 +341,12 @@ case class LoadDataCommand(
}
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153087493
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,226 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153088979
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -0,0 +1,70 @@
+
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153088232
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,226 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153091143
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,43
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153084210
--- Diff: resource-managers/kubernetes/core/pom.xml ---
@@ -0,0 +1,94 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153087234
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,226 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153089366
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,43
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153089805
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,43
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153089664
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,43
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153087550
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153084631
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the A
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153089121
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,43
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153084513
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the A
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153090634
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,226 @@
+/*
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@felixcheung thanks for your reviewing. I think there's no next step,
current changes should be enough for user to externalize customized metrics
source and sink.
---
--
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19816
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19816
Thanks @felixcheung.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revi
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19816
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r153089584
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class IndexShuffleBlockRes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153087888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153087865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84199/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153087808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenConte
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84199/testReport)**
for PR 19752 at commit
[`9063583`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84198/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84198 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84198/testReport)**
for PR 19752 at commit
[`f9c20be`](https://github.com/apache/spark/commit/f
1 - 100 of 199 matches
Mail list logo