Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19683
**[Test build #85462 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85462/testReport)**
for PR 19683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19683
**[Test build #85461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85461/testReport)**
for PR 19683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85461/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19683
**[Test build #85461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85461/testReport)**
for PR 19683 at commit
Github user uzadude commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158906785
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -73,8 +73,10 @@ case class
Github user uzadude commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158906660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -359,12 +359,12 @@ package object dsl {
def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20062
**[Test build #85460 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85460/testReport)**
for PR 20062 at commit
Github user zhengruifeng closed the pull request at:
https://github.com/apache/spark/pull/20030
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85454/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85454/testReport)**
for PR 19977 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19527#discussion_r158904223
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoderEstimator.scala
---
@@ -0,0 +1,519 @@
+/*
+ * Licensed to the Apache
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158902856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -85,11 +86,20 @@ case class GenerateExec(
val
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158891945
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -73,8 +73,10 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158892688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -359,12 +359,12 @@ package object dsl {
def
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20029
Could you please to check this PR? Thanks @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20099
**[Test build #85459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85459/testReport)**
for PR 20099 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85451/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85451/testReport)**
for PR 19977 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20099
**[Test build #85458 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85458/testReport)**
for PR 20099 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20099
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85458/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20099
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20099
**[Test build #85458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85458/testReport)**
for PR 20099 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20096
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20096
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85455/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20096
**[Test build #85455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85455/testReport)**
for PR 20096 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85453/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20094
**[Test build #85453 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85453/testReport)**
for PR 20094 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20082
**[Test build #85457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85457/testReport)**
for PR 20082 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158899707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158899698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158899621
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ * Licensed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85450/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/20091
@jiangxb1987 I am not disagreeing with your hypothesis that default
parallelism might not be optimal in all cases within an application (example -
when different RDD's in application have widely
Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r158898080
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -150,6 +150,11 @@ abstract class TaskContext extends Serializable {
*/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20094
**[Test build #85450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85450/testReport)**
for PR 20094 at commit
Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r158897767
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -42,6 +42,7 @@ import org.apache.spark.util._
*/
private[spark]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r158897401
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -150,6 +150,11 @@ abstract class TaskContext extends Serializable {
*/
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20059
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r158897297
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -42,6 +42,7 @@ import org.apache.spark.util._
*/
private[spark]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19943
**[Test build #85456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85456/testReport)**
for PR 19943 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20059
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158897045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,442 @@
+/*
+ *
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19954
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85452/
Test FAILed.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19954
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20094
**[Test build #85452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85452/testReport)**
for PR 20094 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20094
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20093
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20093
LGTM, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20036
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20036
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20091
The major concern is that `spark.default.parallelism` usually is set a
relatively small value, so in case the safety-check failed, the value of
`defaultParallelism` can even be smaller than the
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895416
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895321
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895355
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895273
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895242
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158895185
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20096
**[Test build #85455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85455/testReport)**
for PR 20096 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r158894808
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -42,6 +42,7 @@ import org.apache.spark.util._
*/
private[spark]
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894770
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894676
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894279
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158894114
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19943
Thank you for review, @cloud-fan, @viirya, @kiszk, @HyukjinKwon, @henrify.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20100
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ameent opened a pull request:
https://github.com/apache/spark/pull/20100
[SPARK-22913][SQL] Improved Hive Partition Pruning
Adding support for Timestamp and Fractional column types. The pruning
of partitions of these types is being put behind default options
that
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158893226
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,93 @@
+-- Concatenate mixed inputs (output type
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r158893248
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,432 @@
+/*
+ *
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19979
Actually, going further than what Bago said: All of the places which use
globalCheckFunction assume that Dataset.collect() returns the Rows in a fixed
order. We should really fix those unit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #85454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85454/testReport)**
for PR 19977 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20099
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20099
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85449/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20099
**[Test build #85449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85449/testReport)**
for PR 20099 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158892653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,33 @@ object TypeCoercion {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158892598
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -658,6 +660,33 @@ object TypeCoercion {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20096
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85448/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20096
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20096
**[Test build #85448 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85448/testReport)**
for PR 20096 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20098
CC @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20094
**[Test build #85453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85453/testReport)**
for PR 20094 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20094
**[Test build #85452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85452/testReport)**
for PR 20094 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20094
LGTM with two minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20094#discussion_r158891321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1079,100 +1083,76 @@ class Analyzer(
case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158891168
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -227,4 +227,30 @@ class MiscBenchmark extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158891075
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -227,4 +227,30 @@ class MiscBenchmark extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19813
LGTM, great work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20094#discussion_r158890342
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1079,100 +1083,76 @@ class Analyzer(
case sa
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20094#discussion_r158889013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -723,7 +726,7 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r158890765
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -276,22 +276,24 @@ class PlanParserSuite extends
1 - 100 of 314 matches
Mail list logo
