Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159981422
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -240,31 +240,35 @@ class StreamingQueryManager private[sql
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159978428
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -392,6 +443,21 @@ class MicroBatchExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159980348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -166,19 +167,31 @@ final class DataStreamReader
private[sql](s
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85729/testReport)**
for PR 20142 at commit
[`46c6ad7`](https://github.com/apache/spark/commit/46
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r159983463
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -261,6 +261,10 @@ private[kafka010] case class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159983634
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -392,6 +443,21 @@ class MicroBatchExecution
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r159983977
--- Diff: python/pyspark/sql/tests.py ---
@@ -3950,6 +3974,33 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r159984700
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to t
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159985442
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
---
@@ -240,31 +240,35 @@ class StreamingQueryManager priv
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20097
**[Test build #85730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85730/testReport)**
for PR 20097 at commit
[`5f0a6e2`](https://github.com/apache/spark/commit/5f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85729/testReport)**
for PR 20142 at commit
[`46c6ad7`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85729/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r159987954
--- Diff: python/pyspark/sql/tests.py ---
@@ -3950,6 +3974,33 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally:
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/20154
@vanzin it seems using `ARG` in `FROM` is only supported since Docker
version 17.06. It does not work for earlier versions of Docker. See
https://stackoverflow.com/questions/40273070/docker-build
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/11994
@jerryshao I mean we also need to provide BaseReporter trait
```scala
trait Sink {
protected val reporter: BaseReporter = createReporter()
def createReporter():
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20154
That kinda sucks. It means the base image cannot have a tag so working with
multiple Spark versions will be a little weird. Anyway, feel free to open a PR
to revert that part.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85731/testReport)**
for PR 20142 at commit
[`0d8d943`](https://github.com/apache/spark/commit/0d
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20142#discussion_r159994714
--- Diff: python/pyspark/sql/tests.py ---
@@ -3950,6 +3974,33 @@ def
test_vectorized_udf_timestamps_respect_session_timezone(self):
finally:
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20169
[SPARK-17088][hive] Fix 'sharesHadoopClasses' option when creating client.
Because the call to the constructor of HiveClientImpl crosses class loader
boundaries, different versions of the same cl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85732/testReport)**
for PR 20142 at commit
[`b249bac`](https://github.com/apache/spark/commit/b2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20169
**[Test build #85733 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85733/testReport)**
for PR 20169 at commit
[`668fcba`](https://github.com/apache/spark/commit/66
GitHub user liyinan926 opened a pull request:
https://github.com/apache/spark/pull/20170
[SPARK-22960][K8S] Revert use of ARG base_image in images
## What changes were proposed in this pull request?
This PR reverts the `ARG base_image` before `FROM` in the images of driver,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20170
**[Test build #85734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85734/testReport)**
for PR 20170 at commit
[`2f8d0b9`](https://github.com/apache/spark/commit/2f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85731/testReport)**
for PR 20142 at commit
[`0d8d943`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85731/
Test FAILed.
---
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/20170
LGTM, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85732/testReport)**
for PR 20142 at commit
[`b249bac`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85732/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85735/testReport)**
for PR 20142 at commit
[`2de3a37`](https://github.com/apache/spark/commit/2d
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20170
LGTM. I'll merge when tests finish even though this doesn't affect them.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.a
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r159992789
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -110,107 +114,240 @@ private[spark] class AppStatusStore(
if (deta
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r159990658
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -110,107 +114,240 @@ private[spark] class AppStatusStore(
if (deta
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r159988995
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -110,107 +114,240 @@ private[spark] class AppStatusStore(
if (deta
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20142
**[Test build #85735 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85735/testReport)**
for PR 20142 at commit
[`2de3a37`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85735/
Test PASSed.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r160004385
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -110,107 +114,240 @@ private[spark] class AppStatusStore(
if (deta
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20166
@cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20135
@gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spar
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
Seems to me we can't set string indexer order for R glm.
A workaround is to encode the Species manually first. Then let R glm and
spark.glm to fit the encoded Species column, instead of the o
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20163
Thanks for all of your comments, @HyukjinKwon and @icexelloss !
I'd like to wait for more discussions / suggestions on whether or not we
want a behavior change that makes this reproducer work
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
Another workaround is, we can add some rows into iris dataset and make the
three values in Species column not frequency equal anymore.
For example, we add three more rows into iris. Now the f
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r159985929
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -145,6 +149,19 @@ private[kafka010] class KafkaO
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160008897
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSuite.scala
---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to th
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160007884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -418,11 +418,16 @@ abstract class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160006676
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousWriter.scala
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to t
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160005666
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -74,8 +56,49 @@ private[kafka010] class KafkaWriteT
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160004815
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to t
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20169
**[Test build #85733 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85733/testReport)**
for PR 20169 at commit
[`668fcba`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85733/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160009573
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -19,7 +19,8 @@ package org.apache.spark.sql.kafk
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20097
**[Test build #85730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85730/testReport)**
for PR 20097 at commit
[`5f0a6e2`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20097
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85730/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20097
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20029
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20029
lgtm!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
[`2b1e166`](https://github.com/apache/spark/commit/2b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20013
**[Test build #85737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85737/testReport)**
for PR 20013 at commit
[`c4e7f61`](https://github.com/apache/spark/commit/c4
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20098
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20135
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20135
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20135#discussion_r160012524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -271,33 +271,45 @@ case class ConcatWs(ch
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20135
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20098
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20170
Tests are taking to long...
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
F
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20170
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17968
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17968
cc @WeichenXu123 @yanboliang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17968
**[Test build #85738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85738/testReport)**
for PR 17968 at commit
[`311c94a`](https://github.com/apache/spark/commit/31
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17968
**[Test build #85738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85738/testReport)**
for PR 17968 at commit
[`311c94a`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17968
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85738/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17968
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20170
**[Test build #85734 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85734/testReport)**
for PR 20170 at commit
[`2f8d0b9`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85734/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20170
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20010
Overall, it is reasonable. What is the current behavior in Hive?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apach
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20163
Hey @rednaxelafx that's fine. We all make mistake and I usually think it's
always better then not trying. I also made a mistake at the first time. It was
easier to debug this with your comments
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20029
> The hiveClient created for the resourceLoader is only used to addJar,
which is, in turn, to add Jar to the shared IsolatedClientLoader. Then we can
just use the shared hive client for this purpose.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20166#discussion_r160016007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -228,6 +228,35 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20166
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
[`2b1e166`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85739/testReport)**
for PR 20076 at commit
[`26c1c61`](https://github.com/apache/spark/commit/26
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85736/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85740/testReport)**
for PR 20076 at commit
[`9466797`](https://github.com/apache/spark/commit/94
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ * Licen
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ * Licen
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85741/testReport)**
for PR 20076 at commit
[`1a8c654`](https://github.com/apache/spark/commit/1a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20076
**[Test build #85741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85741/testReport)**
for PR 20076 at commit
[`1a8c654`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85741/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20076
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016423
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ * Licen
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016431
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.scala
---
@@ -0,0 +1,493 @@
+/*
+ * Licen
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
---
@@ -110,4 +107,23 @@ object OrcUtils extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160016468
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala ---
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache Softwa
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19943
overall looks good, my major concern is
https://github.com/apache/spark/pull/19943/files#r159221758 , do you have an
answer? This may be a big drawback compared to the wrapper solution.
---
--
101 - 200 of 248 matches
Mail list logo
