Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20204#discussion_r161679707
--- Diff: python/run-tests-with-coverage ---
@@ -0,0 +1,69 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) un
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20153
**[Test build #86160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86160/testReport)**
for PR 20153 at commit
[`d666110`](https://github.com/apache/spark/commit/d6
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17280#discussion_r161679593
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -319,9 +323,11 @@ object FPGrowthModel extends MLReadable[FPGrowthModel]
{
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20153
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20204#discussion_r161677975
--- Diff: python/run-tests-with-coverage ---
@@ -0,0 +1,69 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (AS
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86154/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #86154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86154/testReport)**
for PR 20232 at commit
[`20bbf64`](https://github.com/apache/spark/commit/2
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20163#discussion_r161677327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
---
@@ -144,6 +145,7 @@ object EvaluatePython {
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20267
I see. Thanks for info! So, is it ready to go anyway @felixcheung?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.ap
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20265
I'll update the PR tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86158/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20275
**[Test build #86158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86158/testReport)**
for PR 20275 at commit
[`1a3cd3a`](https://github.com/apache/spark/commit/1
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20168
Overall looks good to me. Just some minor comments regarding with code
comments and naming.
---
-
To unsubscribe, e-mail: reviews
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86156/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86156/testReport)**
for PR 20168 at commit
[`896ccc2`](https://github.com/apache/spark/commit/8
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671821
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Soft
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86157/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86157/testReport)**
for PR 20164 at commit
[`e44d764`](https://github.com/apache/spark/commit/e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161672411
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Soft
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161672316
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Soft
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671868
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Soft
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20265#discussion_r161671835
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Soft
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20223
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/20223
merging to master/2.3. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20266
**[Test build #86159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86159/testReport)**
for PR 20266 at commit
[`5afaa28`](https://github.com/apache/spark/commit/5a
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/20216
LGTM now
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161668457
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Soft
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161668286
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Soft
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/20216
I agree with your second suggestion, before I did not understand what you
mean, now I passed the test I understand what you mean.
1.In order for collapsible tables to persist on reloa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20275
**[Test build #86158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86158/testReport)**
for PR 20275 at commit
[`1a3cd3a`](https://github.com/apache/spark/commit/1a
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20168
Btw, I think this isn't only to add non-integer image formats. So the PR
title may be changed too. Like "Add ImageSchema support for all OpenCV image
types"?
---
--
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/20275
[SPARK-23085][ML] API parity for mllib.linalg.Vectors.sparse
## What changes were proposed in this pull request?
`ML.Vectors#sparse(size: Int, elements: Seq[(Int, Double)])` support
zero-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665015
--- Diff: python/pyspark/ml/image.py ---
@@ -128,11 +183,17 @@ def toNDArray(self, image):
height = image.height
width = image.width
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665832
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161666778
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161661795
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664852
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664806
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664859
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161663005
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664731
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664786
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665337
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664566
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161662177
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664060
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -83,7 +83,8 @@ class ImageSchemaSuite extends SparkFunSuite with
MLli
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161663481
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664597
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86152/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20249
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20249
**[Test build #86152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86152/testReport)**
for PR 20249 at commit
[`90c4980`](https://github.com/apache/spark/commit/9
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20150
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/20150
Thanks for your review! Shixiong
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20150
Thanks! Merging to master and 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86156/testReport)**
for PR 20168 at commit
[`896ccc2`](https://github.com/apache/spark/commit/89
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86157/testReport)**
for PR 20164 at commit
[`e44d764`](https://github.com/apache/spark/commit/e4
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20258
Oh, I see! Yea, they look quite same.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20258
Is this similar to `Dataset.transform()` in Java/Scala API? But we don't
have similar APIs for RDDs.
---
-
To unsubscribe, e-mail
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86151/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86151/testReport)**
for PR 20164 at commit
[`e44d764`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #86155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86155/testReport)**
for PR 20232 at commit
[`77af798`](https://github.com/apache/spark/commit/77
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20138#discussion_r161660926
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -663,6 +665,95 @@ class FsHistoryProviderSuite extends Spa
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20232#discussion_r161660735
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -382,10 +382,10 @@ test_that("spark.mlp", {
trainidxs <- base::sample(nrow(data), nr
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20211#discussion_r161659513
--- Diff: python/pyspark/sql/group.py ---
@@ -233,6 +233,27 @@ def apply(self, udf):
| 2| 1.1094003924504583|
+---+
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161659245
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20211#discussion_r161659200
--- Diff: python/pyspark/sql/group.py ---
@@ -233,6 +233,27 @@ def apply(self, udf):
| 2| 1.1094003924504583|
+---+
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161658799
--- Diff: python/pyspark/sql/functions.py ---
@@ -2214,6 +2216,37 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
.. see
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20056
I see that `LiveListenerBus.droppedEventsCounter` and `lastReportTimestamp`
are unused, so it certainly makes sense to clean them up one way or the other
-- but that might mean we should delete them,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161657719
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20257
**[Test build #86153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)**
for PR 20257 at commit
[`262c046`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86153/
Test PASSed.
---
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/20168
@MrBago @tomasatdatabricks the changes look good to me, I went through
everything one more time, I'll sign off as soon as the python tests are fixed
(it looks like there were some style issues
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161656633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -136,10 +137,52 @@ object DecimalType extends AbstractDataType {
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161656541
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #86154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86154/testReport)**
for PR 20232 at commit
[`20bbf64`](https://github.com/apache/spark/commit/20
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20204#discussion_r161655584
--- Diff: python/run-tests-with-coverage ---
@@ -0,0 +1,69 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) un
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161656419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/20168
@MrBago @tomasatdatabricks I think the breaking changes are fine, the code
was marked experimental and it is expected that the interfaces will change a
lot initially based on early feedback.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20257
**[Test build #86153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)**
for PR 20257 at commit
[`262c046`](https://github.com/apache/spark/commit/26
Github user ozzieba commented on the issue:
https://github.com/apache/spark/pull/20272
I'm getting stuck on
https://github.com/apache-spark-on-k8s/spark-integration/blob/master/integration-test/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala#L106,
will
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20257
@MLnick Thanks for review. I think I've addressed all the comments. Please
take a look for the updates.
---
-
To unsubscribe, e-m
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161655115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -243,17 +279,43 @@ object DecimalPrecision ext
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86144/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20208
**[Test build #86144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86144/testReport)**
for PR 20208 at commit
[`499801e`](https://github.com/apache/spark/commit/4
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161654514
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sql("S
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20265
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86143/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20265
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20265
**[Test build #86143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86143/testReport)**
for PR 20265 at commit
[`440f76b`](https://github.com/apache/spark/commit/4
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20171#discussion_r161654136
--- Diff: python/pyspark/sql/catalog.py ---
@@ -256,27 +258,58 @@ def registerFunction(self, name, f,
returnType=StringType()):
>>> spark.sq
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20273
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20266
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20266#discussion_r161653628
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 368 matches
Mail list logo