[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20273 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark pull request #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema tes...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20266#discussion_r161653311 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema tes...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20266#discussion_r161653251 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20273 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86145/ Test PASSed. ---

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20273 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20273 **[Test build #86145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86145/testReport)** for PR 20273 at commit [`3de8b41`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20265 I think we need to make sure parquet row group size and orc strip size is same, to make this benchmark fair. --- - To unsubscr

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161651611 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sql("S

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652710 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652575 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652489 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652403 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652361 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161652184 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #20184: [SPARK-22987][Core] UnsafeExternalSorter cases OOM when ...

2018-01-15 Thread liutang123
Github user liutang123 commented on the issue: https://github.com/apache/spark/pull/20184 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161651566 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20223 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark pull request #20223: [SPARK-23020][core] Fix races in launcher code, t...

2018-01-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20223#discussion_r161651289 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -48,14 +48,16 @@ public synchronized void disconnect() {

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161651223 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86152/testReport)** for PR 20249 at commit [`90c4980`](https://github.com/apache/spark/commit/90

[GitHub] spark pull request #20271: [SPARK-23080][SQL] Improve error message for buil...

2018-01-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20271 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650985 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650904 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20271: [SPARK-23080][SQL] Improve error message for built-in fu...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20271 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20164 **[Test build #86151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86151/testReport)** for PR 20164 at commit [`e44d764`](https://github.com/apache/spark/commit/e4

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650716 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650635 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86150/testReport)** for PR 20249 at commit [`fc89455`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86150/ Test FAILed. ---

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/20164 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650471 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86150/testReport)** for PR 20249 at commit [`fc89455`](https://github.com/apache/spark/commit/fc

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161650341 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20164 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86149/ Test FAILed. ---

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20164 **[Test build #86147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86147/testReport)** for PR 20164 at commit [`e44d764`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86147/ Test FAILed. ---

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20168 **[Test build #86149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86149/testReport)** for PR 20168 at commit [`9ec8cd3`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20168 **[Test build #86149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86149/testReport)** for PR 20168 at commit [`9ec8cd3`](https://github.com/apache/spark/commit/9e

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161650064 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlCont

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161649821 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlConte

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161649497 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.s

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86148/ Test FAILed. ---

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20168 **[Test build #86148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86148/testReport)** for PR 20168 at commit [`68a5a94`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161649243 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sq

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for non-intege...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20168 **[Test build #86148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86148/testReport)** for PR 20168 at commit [`68a5a94`](https://github.com/apache/spark/commit/68

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161649275 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.s

[GitHub] spark pull request #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION shou...

2018-01-15 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161648924 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -751,6 +751,25 @@ class HiveDDLSuite } }

[GitHub] spark issue #20259: [SPARK-23066][WEB-UI] Master Page increase master start-...

2018-01-15 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/20259 I set the startup time to a metric. The metric instead of the master page display. --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161647635 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlCont

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161647332 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sq

[GitHub] spark issue #20271: [SPARK-23080][SQL] Improve error message for built-in fu...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20271 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark issue #20164: [SPARK-22971][ML] OneVsRestModel should use temporary Ra...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20164 **[Test build #86147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86147/testReport)** for PR 20164 at commit [`e44d764`](https://github.com/apache/spark/commit/e4

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161647061 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sq

[GitHub] spark pull request #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION shou...

2018-01-15 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161646360 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1869,6 +1869,65 @@ abstract class DDLSuite extends QueryTes

[GitHub] spark pull request #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION shou...

2018-01-15 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161645520 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -800,6 +802,15 @@ case class AlterTableSetLocationCommand(

[GitHub] spark pull request #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION shou...

2018-01-15 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161645457 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1869,6 +1869,65 @@ abstract class DDLSuite extends QueryTes

[GitHub] spark pull request #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION shou...

2018-01-15 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161645330 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1869,6 +1869,65 @@ abstract class DDLSuite extends QueryTes

[GitHub] spark issue #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to support spar...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20274 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to support spar...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20274 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86146/ Test PASSed. ---

[GitHub] spark issue #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to support spar...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20274 **[Test build #86146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86146/testReport)** for PR 20274 at commit [`83a844b`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161645057 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated s

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644962 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderEstimatorExample.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644708 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated s

[GitHub] spark pull request #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator docu...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20257#discussion_r161644705 --- Diff: docs/ml-features.md --- @@ -775,7 +775,9 @@ for more details on the API. -## OneHotEncoder +## OneHotEncoder (Deprecated s

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161643600 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sql("S

[GitHub] spark issue #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to support spar...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20274 **[Test build #86146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86146/testReport)** for PR 20274 at commit [`83a844b`](https://github.com/apache/spark/commit/83

[GitHub] spark pull request #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to suppo...

2018-01-15 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/20274 [SPARK-20120][SQL][FOLLOW-UP] Better way to support spark-sql silent mode. ## What changes were proposed in this pull request? `spark-sql` silent mode is broken now. It seems `sc.setLogLeve

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86142/ Test PASSed. ---

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #86142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86142/testReport)** for PR 20223 at commit [`8d52338`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20273 **[Test build #86145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86145/testReport)** for PR 20273 at commit [`3de8b41`](https://github.com/apache/spark/commit/3d

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20273 cc @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #20273: [SPARK-23000] Use fully qualified table names in ...

2018-01-15 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20273 [SPARK-23000] Use fully qualified table names in HiveMetastoreCatalogSuite ## What changes were proposed in this pull request? In another attempt to fix DataSourceWithHiveMetasto

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161640273 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.s

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-15 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 ping gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161639815 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlConte

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161638977 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlCont

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161638411 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlConte

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20208 **[Test build #86144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86144/testReport)** for PR 20208 at commit [`499801e`](https://github.com/apache/spark/commit/49

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161637979 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sq

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-01-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20208 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161637473 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20265 **[Test build #86143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86143/testReport)** for PR 20265 at commit [`440f76b`](https://github.com/apache/spark/commit/44

[GitHub] spark pull request #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema tes...

2018-01-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20266#discussion_r161637206 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20265 Hi, @cloud-fan and @gatorsmile . Your questions are valid for all PPD cases. According to the comments, I added the following expressions (positive and negative) for both ORC/Parquet. `

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161637065 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.s

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161635142 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,58 @@ def registerFunction(self, name, f, returnType=StringType()): >>> spark.sq

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161635087 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlConte

[GitHub] spark pull request #20270: [SPARK-23079] Fix query constraints propagation w...

2018-01-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20270#discussion_r161634560 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala --- @@ -94,56 +94,23 @@ trait QueryPlanCons

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86141/ Test PASSed. ---

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20266 **[Test build #86141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86141/testReport)** for PR 20266 at commit [`144c596`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161631616 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>> sqlCont

[GitHub] spark issue #20272: [SPARK-23078] [CORE] allow Spark Thrift Server to run in...

2018-01-15 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20272 @ozzieba, can we add a test to our integration test set to ensure this works? It's rather late in the Spark 2.3 release, and I'd be apprehensive about adding things that haven't been extensively test

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86140/ Test FAILed. ---

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

<    1   2   3   4   >