[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20510 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20510 **[Test build #87098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87098/testReport)** for PR 20510 at commit

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87101/ Test FAILed. ---

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20378: [SPARK-11222][Build][Python] Python document style check...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20378 If you happen to be busy on working this one, I can take this when I have some time. That's fine. Either way works. --- -

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20517 **[Test build #87101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87101/testReport)** for PR 20517 at commit

[GitHub] spark issue #20378: [SPARK-11222][Build][Python] Python document style check...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20378 @rekhajoshm, would you mind if I ask to take a quick look for ones causing actual problems and identify them? It might be kind of a grunt job tho. ---

[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20489 gentle ping @icexelloss --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20140: [SPARK-19228][SQL] Introduce tryParseDate method to proc...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20140 **[Test build #87107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87107/testReport)** for PR 20140 at commit

[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.2

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20511 cc @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20140: [SPARK-19228][SQL] Introduce tryParseDate method to proc...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20140 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20140: [SPARK-19228][SQL] Introduce tryParseDate method ...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20140#discussion_r166270325 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -90,7 +90,10 @@ private[csv] object

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87100/ Test FAILed. ---

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20517 **[Test build #87100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87100/testReport)** for PR 20517 at commit

[GitHub] spark pull request #19832: [SPARK-22628][CORE]Some situations, the assignm...

2018-02-06 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/19832#discussion_r166266580 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -671,10 +671,23 @@ private[deploy] class Master( // If the

[GitHub] spark pull request #20140: [SPARK-19228][SQL] Introduce tryParseDate method ...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20140#discussion_r166265374 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -150,6 +151,16 @@ class CSVOptions(

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2018-02-06 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/19077 I have updated this PR, just a little bit of improvement, please help review it again,thanks @jiangxb1987 @cloud-fan --- - To

[GitHub] spark pull request #20140: [SPARK-19228][SQL] Introduce tryParseDate method ...

2018-02-06 Thread sergey-rubtsov
Github user sergey-rubtsov commented on a diff in the pull request: https://github.com/apache/spark/pull/20140#discussion_r166264802 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -90,7 +90,10 @@ private[csv] object

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19077 **[Test build #87106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87106/testReport)** for PR 19077 at commit

[GitHub] spark pull request #20140: [SPARK-19228][SQL] Introduce tryParseDate method ...

2018-02-06 Thread sergey-rubtsov
Github user sergey-rubtsov commented on a diff in the pull request: https://github.com/apache/spark/pull/20140#discussion_r166262196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -150,6 +151,16 @@ class CSVOptions(

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/626/

[GitHub] spark pull request #20140: [SPARK-19228][SQL] Introduce tryParseDate method ...

2018-02-06 Thread sergey-rubtsov
Github user sergey-rubtsov commented on a diff in the pull request: https://github.com/apache/spark/pull/20140#discussion_r166261313 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -150,6 +151,16 @@ class CSVOptions(

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-02-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19340 @srowen honestly I don't think that we should change current implementation. Rapidminer, ELKI and nltk work like this. Matlab instead works differently and does what suggested by @Kevin-Ferret and

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/625/

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20514 **[Test build #87105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87105/testReport)** for PR 20514 at commit

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20167 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87104/ Test PASSed. ---

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20167 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20514 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20167 **[Test build #87104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87104/testReport)** for PR 20167 at commit

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87096/ Test FAILed. ---

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20514 **[Test build #87096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87096/testReport)** for PR 20514 at commit

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20167 **[Test build #87104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87104/testReport)** for PR 20167 at commit

[GitHub] spark pull request #20472: [SPARK-22751][ML]Improve ML RandomForest shuffle ...

2018-02-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20472#discussion_r166249547 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1147,4 +1150,20 @@ private[spark] object RandomForest extends

[GitHub] spark pull request #20472: [SPARK-22751][ML]Improve ML RandomForest shuffle ...

2018-02-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20472#discussion_r166250001 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -1001,11 +996,19 @@ private[spark] object RandomForest extends

[GitHub] spark issue #20513: [SPARK-23312][SQL][followup] add a config to turn off ve...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20513 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20513: [SPARK-23312][SQL][followup] add a config to turn off ve...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20513 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87097/ Test FAILed. ---

[GitHub] spark issue #20513: [SPARK-23312][SQL][followup] add a config to turn off ve...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20513 **[Test build #87097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87097/testReport)** for PR 20513 at commit

[GitHub] spark issue #20513: [SPARK-23312][SQL][followup] add a config to turn off ve...

2018-02-06 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20513 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20513: [SPARK-23312][SQL][followup] add a config to turn...

2018-02-06 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20513#discussion_r166244254 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -61,6 +61,9 @@ case class

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20514 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20167 **[Test build #87103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87103/testReport)** for PR 20167 at commit

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20167 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87103/ Test FAILed. ---

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20167 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20167 **[Test build #87103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87103/testReport)** for PR 20167 at commit

[GitHub] spark issue #19690: [SPARK-22467]Added a switch to support whether `stdout_s...

2018-02-06 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/19690 yea, so we make the default value for this configuration is `true`. I set spark.executor.extraJavaOptions=-verbose:gc -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintTenuringDistribution

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20484 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20484 **[Test build #87102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87102/testReport)** for PR 20484 at commit

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20484 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87102/ Test PASSed. ---

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20484 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/624/

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20484 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20507: [SPARK-23334][SQL][PYTHON] Fix pandas_udf with return ty...

2018-02-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20507 Thanks! @HyukjinKwon @BryanCutler --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20484 **[Test build #87102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87102/testReport)** for PR 20484 at commit

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20517 **[Test build #87101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87101/testReport)** for PR 20517 at commit

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/623/

[GitHub] spark pull request #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use date...

2018-02-06 Thread ueshin
Github user ueshin closed the pull request at: https://github.com/apache/spark/pull/20515 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20515 Thanks! @HyukjinKwon @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20506: [SPARK-23290][SQL][PYTHON] Use datetime.date for date ty...

2018-02-06 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20506 Thanks! @HyukjinKwon @BryanCutler @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20507: [SPARK-23334][SQL][PYTHON] Fix pandas_udf with re...

2018-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20507 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20507: [SPARK-23334][SQL][PYTHON] Fix pandas_udf with return ty...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20507 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20515 Merged to branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20484: [SPARK-23313][DOC] Add a migration guide for ORC

2018-02-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20484#discussion_r166231000 --- Diff: docs/sql-programming-guide.md --- @@ -1776,6 +1776,42 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/622/

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20517 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20516: [SPARK-23343][CORE][TEST] Increase the exception test fo...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20516 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20517: [SPARK-23342][SQL][TEST] Add ORC configuration tests for...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20517 **[Test build #87100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87100/testReport)** for PR 20517 at commit

[GitHub] spark pull request #20517: [SPARK-23342][SQL][TEST] Add ORC configuration te...

2018-02-06 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20517 [SPARK-23342][SQL][TEST] Add ORC configuration tests for ORC data source ## What changes were proposed in this pull request? This issue adds test coverage for ORC configuration with

[GitHub] spark issue #20516: [SPARK-23343][CORE][TEST] Increase the exception test fo...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20516 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20516: [SPARK-23343][CORE][TEST] Increase the exception ...

2018-02-06 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/20516 [SPARK-23343][CORE][TEST] Increase the exception test for the bind port ## What changes were proposed in this pull request? this PR add new test case, 1、add the boundary value

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87099/ Test PASSed. ---

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20515 **[Test build #87099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87099/testReport)** for PR 20515 at commit

[GitHub] spark issue #20499: [SPARK-23328][PYTHON] Disallow default value None in na....

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20499 I think it's a bug fix. For the context, 1. the dictionary support was added but `value` was required (and ignored) at the first place

[GitHub] spark issue #20507: [SPARK-23334][SQL][PYTHON] Fix pandas_udf with return ty...

2018-02-06 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20507 Sorry I've been travelling, but I'll try to look into this soon on the Arrow side to see if it is a bug in pyarrow. The workaround here seems fine to me. ---

[GitHub] spark issue #20499: [SPARK-23328][PYTHON] Disallow default value None in na....

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20499 is it a bug fix or a new feature? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166220816 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1545,8 +1545,8 @@ def replace(self, to_replace, value=None, subset=None): :param

[GitHub] spark issue #20499: [SPARK-23328][PYTHON] Disallow default value None in na....

2018-02-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20499 Seems RC3 is near to be cut, do we want to get this in 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20515 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20506: [SPARK-23290][SQL][PYTHON] Use datetime.date for date ty...

2018-02-06 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20506 a late +1 for me since it seems like Pandas needs an explicit conversion to get to datetime64 and doesn't directly support `datetime.date` ---

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/621/

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166217503 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1597,51 @@ def replace(self, to_replace, value=None, subset=None): |null| null|null|

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20515 **[Test build #87099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87099/testReport)** for PR 20515 at commit

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20515 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166216324 --- Diff: python/pyspark/sql/tests.py --- @@ -2175,7 +2175,7 @@ def test_replace(self): # replace with subset specified by a string of a

[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20510 **[Test build #87098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87098/testReport)** for PR 20510 at commit

[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20510 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/620/

[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20510 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20515 **[Test build #87095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87095/testReport)** for PR 20515 at commit

[GitHub] spark issue #20515: [SPARK-23290][SQL][PYTHON][BACKPORT-2.3] Use datetime.da...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20515 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87095/ Test FAILed. ---

[GitHub] spark issue #20499: [SPARK-23328][PYTHON] Disallow default value None in na....

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20499 Yup, sounds good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

2018-02-06 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/20510 jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20499: [SPARK-23328][PYTHON] Disallow default value None in na....

2018-02-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20499 I think that behavior is shipped in 2.2, right? Then we may need to add a note in migration guide. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20514: [SPARK-23310][CORE][FOLLOWUP] Fix Java style check issue...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20514 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/619/

<    1   2   3   4   5   6   >