[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20619 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87518/ Test FAILed. ---

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87518/testReport)** for PR 20619 at commit [`e08d06c`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20620: [SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL ...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20620 **[Test build #87519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87519/testReport)** for PR 20620 at commit [`23e0204`](https://github.com/apache/spark/commit/23

[GitHub] spark issue #20622: [SPARK-23441][SS] Remove queryExecutionThread.interrupt(...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20622 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20622: [SPARK-23441][SS] Remove queryExecutionThread.interrupt(...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20622 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87517/ Test PASSed. ---

[GitHub] spark issue #20622: [SPARK-23441][SS] Remove queryExecutionThread.interrupt(...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20622 **[Test build #87517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87517/testReport)** for PR 20622 at commit [`3b56232`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #20620: [SPARK-23438][DSTREAMS] Fix DStreams data loss wi...

2018-02-16 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20620#discussion_r168914525 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala --- @@ -193,12 +193,15 @@ private[streaming] class

[GitHub] spark issue #20511: [SPARK-23340][SQL] Upgrade Apache ORC to 1.4.3

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20511 Sure. @gatorsmile . I'll create a new PR for Apache Spark 2.4 default configuration and a migration guide for 2.3 to 2.4 after this PR is merged. ---

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/943/ Test

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87518/testReport)** for PR 20619 at commit [`e08d06c`](https://github.com/apache/spark/commit/e0

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 The failure is irrelevant to this PR. ``` org.apache.spark.sql.hive.client.HiveClientSuites.(It is not a test it is a sbt.testing.NestedSuiteSelector) ``` --- ---

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 Oh.. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20632 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20632 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-16 Thread asolimando
GitHub user asolimando opened a pull request: https://github.com/apache/spark/pull/20632 [SPARK-3159] added subtree pruning in the translation from LearningNode to Node, added unit tests for tree redundancy and adapted existing ones that were affected ## What changes were proposed

[GitHub] spark pull request #20568: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread mrkm4ntr
Github user mrkm4ntr closed the pull request at: https://github.com/apache/spark/pull/20568 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread mrkm4ntr
Github user mrkm4ntr commented on the issue: https://github.com/apache/spark/pull/20568 @gatorsmile Thanks! I will close it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20511: [SPARK-23340][SQL] Upgrade Apache ORC to 1.4.3

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20511 I agree on what @omalley said. The new reader based on ORC 1.4 is better than the old reader. That is why we chose the new reader as the default at the beginning. We also saw the performance impr

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87516/ Test FAILed. ---

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87516/testReport)** for PR 20619 at commit [`e08d06c`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20568 @mrkm4ntr Thank you for your contribution! The PR has been merged using your Github account. Could you close this? --- - To

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20619 He is already on vacation. : ) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #20620: [SPARK-23438][DSTREAMS] Fix DStreams data loss wi...

2018-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20620#discussion_r168911639 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala --- @@ -193,12 +193,15 @@ private[streaming] class Receiv

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

2018-02-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20442 Yeah, this is a strong reason to separate explicitly set and default Params in the near future. Let's not block 2.3 on this PR. If you still want to try for 2.3, then I vote for option 1 but don

[GitHub] spark issue #20622: [SPARK-23441][SS] Remove queryExecutionThread.interrupt(...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20622 **[Test build #87517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87517/testReport)** for PR 20622 at commit [`3b56232`](https://github.com/apache/spark/commit/3b

[GitHub] spark pull request #20622: [SPARK-23441][SS] Remove queryExecutionThread.int...

2018-02-16 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20622#discussion_r168911056 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala --- @@ -266,6 +263,16 @@ class Continuo

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 Thank you for last-minute review before vacation. :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20619 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/942/ Test

[GitHub] spark pull request #20621: [SPARK-23436][SQL] Infer partition as Date only i...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20621#discussion_r168910831 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -1120,4 +1120,16 @@ clas

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87516/testReport)** for PR 20619 at commit [`e08d06c`](https://github.com/apache/spark/commit/e0

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23390][SQL] Register task completion listeners fi...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20619 The reproducible test case is added into PR description and the code is updated according to @kiszk and @cloud-fan 's comments. --- --

[GitHub] spark pull request #20621: [SPARK-23436][SQL] Infer partition as Date only i...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20621#discussion_r168910779 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -407,6 +407,29 @@ object PartitioningUtils {

[GitHub] spark issue #20387: [SPARK-23203][SQL]: DataSourceV2: Use immutable logical ...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20387 I'm on vacation and will be back next week, will have a more thorough review at that time, sorry for the inconvenience! --- -

[GitHub] spark pull request #20387: [SPARK-23203][SQL]: DataSourceV2: Use immutable l...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20387#discussion_r168910531 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownOperatorsToDataSource.scala --- @@ -17,130 +17,55 @@ p

[GitHub] spark pull request #20387: [SPARK-23203][SQL]: DataSourceV2: Use immutable l...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20387#discussion_r168910415 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -37,22 +100,147 @@ case class DataSourc

[GitHub] spark pull request #20619: [SPARK-23390][SQL] Register task completion liste...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20619#discussion_r168910218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -414,16 +417,16 @@ class ParquetFileF

[GitHub] spark pull request #20626: [SPARK-23447][SQL] Cleanup codegen template for L...

2018-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20626 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20626: [SPARK-23447][SQL] Cleanup codegen template for Literal

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20626 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20568 I think we can close this now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2018-02-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 @rednaxelafx Thanks! Yeah, let's revisit this after 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For ad

[GitHub] spark pull request #20626: [SPARK-23447][SQL] Cleanup codegen template for L...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20626#discussion_r168909963 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -278,40 +278,45 @@ case class Literal (value: Any,

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

2018-02-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20442 `numBuckets` is a default param and can cause persistence bug too if we add multi-column error handling logic. I think we have two options: 1. Ignore `numBuckets` when `inputCols` and `numBuc

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20631 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20631 **[Test build #87515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87515/testReport)** for PR 20631 at commit [`31bf653`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87515/ Test PASSed. ---

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20631 @zsxwing can you take a look? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20631 **[Test build #87515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87515/testReport)** for PR 20631 at commit [`31bf653`](https://github.com/apache/spark/commit/31

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20631 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20631: [SPARK-23454][SS][DOCS] Added trigger information to the...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/941/ Test

[GitHub] spark pull request #20631: [SPARK-23454][SS][DOCS] Added trigger information...

2018-02-16 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/20631 [SPARK-23454][SS][DOCS] Added trigger information to the Structured Streaming programming guide ## What changes were proposed in this pull request? - Added clear information about triggers

[GitHub] spark issue #14180: [SPARK-16367][PYSPARK] Support for deploying Anaconda an...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14180 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20622: [SPARK-23441][SS] Remove queryExecutionThread.int...

2018-02-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20622#discussion_r168906511 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala --- @@ -266,6 +263,16 @@ class ContinuousExecu

[GitHub] spark pull request #20630: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20630 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20630 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20630 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87514/ Test PASSed. ---

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20630 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20630 **[Test build #87514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87514/testReport)** for PR 20630 at commit [`c406f98`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #20630: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20630#discussion_r168904179 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java --- @@ -60,6 +60,8 @@ public static int hashUnsafeWords(Object bas

[GitHub] spark pull request #20630: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20630#discussion_r168904164 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java --- @@ -51,6 +53,23 @@ public void testKnownLongInputs() {

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20630 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20571 Ping @yaooqinn --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20442 **[Test build #4099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4099/testReport)** for PR 20442 at commit [`776a179`](https://github.com/apache/spark/commit/

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20630 The ML changes LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

2018-02-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20442 I'm re-running tests since the last run is very stale, but +1 for getting this into RC4! --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #20442: [SPARK-23265][ML]Update multi-column error handling logi...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20442 **[Test build #4099 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4099/testReport)** for PR 20442 at commit [`776a179`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #20554: [SPARK-23362][SS] Migrate Kafka Microbatch source...

2018-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20554 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20630: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20630#discussion_r168885323 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java --- @@ -51,6 +53,23 @@ public void testKnownLongInputs() {

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168885013 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -860,14 +860,41 @@ class JDBCSuite extends SparkFunSuite v

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20057 Hi, @danielvdende. I finished my first round review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168884880 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -860,14 +860,41 @@ class JDBCSuite extends SparkFunSuite v

[GitHub] spark pull request #20630: [SPARK-23381][CORE] Murmur3 hash generates a diff...

2018-02-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20630#discussion_r168883881 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java --- @@ -60,6 +60,8 @@ public static int hashUnsafeWords(Object bas

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883676 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -31,4 +31,16 @@ private case object TeradataDialect extends J

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883594 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala --- @@ -94,5 +94,20 @@ private case object OracleDialect extends JdbcD

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883612 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -89,11 +89,17 @@ private object PostgresDialect extends JdbcD

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala --- @@ -46,4 +46,16 @@ private case object MySQLDialect extends JdbcDia

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883570 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala --- @@ -94,5 +94,20 @@ private case object OracleDialect extends JdbcD

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883553 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala --- @@ -46,4 +46,16 @@ private case object MySQLDialect extends JdbcDia

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883530 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala --- @@ -42,4 +42,16 @@ private object MsSqlServerDialect extends

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883267 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -49,4 +49,16 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883425 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala --- @@ -42,4 +42,16 @@ private object MsSqlServerDialect extends

[GitHub] spark issue #20511: [SPARK-23340][SQL] Upgrade Apache ORC to 1.4.3

2018-02-16 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/spark/pull/20511 I'm frustrated with the direction this has gone. The new reader is much better than the old reader, which uses Hive 1.2. ORC 1.4.3 had a pair of important, but not large or complex fixes. Ye

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883216 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -49,4 +49,16 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883182 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala --- @@ -64,7 +64,15 @@ private class AggregatedDialect(dialects:

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168883141 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala --- @@ -64,7 +64,15 @@ private class AggregatedDialect(dialects:

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168882930 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -102,7 +102,12 @@ object JdbcUtils extends L

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168882599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -119,6 +119,8 @@ class JDBCOptions(

[GitHub] spark issue #20626: [SPARK-23447][SQL] Cleanup codegen template for Literal

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20626 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20626: [SPARK-23447][SQL] Cleanup codegen template for Literal

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87513/ Test PASSed. ---

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168882085 --- Diff: docs/sql-programming-guide.md --- @@ -1372,6 +1372,13 @@ the following case-insensitive options: This is a JDBC writer related opti

[GitHub] spark issue #20626: [SPARK-23447][SQL] Cleanup codegen template for Literal

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20626 **[Test build #87513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87513/testReport)** for PR 20626 at commit [`2d89ea4`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20382: [SPARK-23097][SQL][SS] Migrate text socket source to V2

2018-02-16 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20382 Aah okay. Thanks for letting me know. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20630 **[Test build #87514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87514/testReport)** for PR 20630 at commit [`c406f98`](https://github.com/apache/spark/commit/c4

[GitHub] spark issue #20630: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20630 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

  1   2   3   >