[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20571 **[Test build #87539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87539/testReport)** for PR 20571 at commit [`b99c43c`](https://github.com/apache/spark/commit/b9

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20571 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/957/ Test

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/20571 OK, i will push a commit very soon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20611: [SPARK-23425][SQL]When wild card is been used in load co...

2018-02-18 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/20611 ![image](https://user-images.githubusercontent.com/12999161/36362491-5a8437e4-155b-11e8-80fd-885a1ebf045c.png) seems to be an invalid failure --- -

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20635 Jenkins, Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20635 lgtm assuming tests pass --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20553 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/950/ --- -

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87538/ Test PASSed. ---

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20553 **[Test build #87538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87538/testReport)** for PR 20553 at commit [`8b711ce`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20553 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/950/ --- ---

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/956/ Test

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20553: [SPARK-23285][K8S] Add a config property for specifying ...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20553 **[Test build #87538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87538/testReport)** for PR 20553 at commit [`8b711ce`](https://github.com/apache/spark/commit/8b

[GitHub] spark pull request #20553: [SPARK-23285][K8S] Add a config property for spec...

2018-02-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20553#discussion_r168972337 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -85,6 +85,12 @@ private[spark] object Config

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168971182 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -49,4 +49,17 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168971074 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -31,4 +31,19 @@ private case object TeradataDialect extends J

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168970903 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -31,4 +31,19 @@ private case object TeradataDialect extends J

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168969792 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -102,7 +102,12 @@ object JdbcUtils extends L

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168969101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -85,15 +85,24 @@ private object PostgresDialect extends JdbcD

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-02-18 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20629 yes, I agree with you @MLnick. I'd like to ping also @jkbradley and @hhbyyh who drove the PR which introduce `computeCost`. In order to move the same metric to `ClusteringEvaluator`, I thin

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168961174 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -640,4 +740,55 @@ private object RandomForestSuite {

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168961183 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -640,4 +740,55 @@ private object RandomForestSuite {

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168961088 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -303,26 +303,6 @@ class DecisionTreeSuite extends SparkFunSuite

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-02-18 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20629 Right - so while it’s perhaps a lower quality metric it is different. So I wonder if deprecation is the right approach (vs say putting the within cluster sum squares into ClusteringEvaluator)

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-02-18 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20629 Sorry I mean putting the metric in evaluator and then also deprecating computCost On Sun, 18 Feb 2018 at 20:41, Nick Pentreath wrote: > Right - so while it’s perhaps a lower qua

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-02-18 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20629 thanks for taking a look at this @MLnick. No, it doesn't, in the sense that it returns a different result: this is the sum of the squared euclidean distance between a point and the centroid of the

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20571 Yes @yaooqinn, it's easy enough to read the logic, but, my question is _why_ treat these cases differently? Why not go all the way to failing on any unexpected input? --- -

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-02-18 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20629 Just want to check - does `computeCost` do the same thing as the silhouette metric? --- - To unsubscribe, e-mail: reviews-unsubsc

[GitHub] spark issue #20571: [SPARK-23383][Build][Minor]Make a distribution should ex...

2018-02-18 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/20571 sorry for not replying in time. the logic here is that firstly unrecognized - -options show warning message and usage information,secondly the - options end the while loop and treat the current o

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87537/ Test PASSed. ---

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87537/testReport)** for PR 20619 at commit [`8bd02d8`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20611: [SPARK-23425][SQL]When wild card is been used in load co...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20611 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87536/ Test FAILed. ---

[GitHub] spark issue #20611: [SPARK-23425][SQL]When wild card is been used in load co...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20611 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20611: [SPARK-23425][SQL]When wild card is been used in load co...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20611 **[Test build #87536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87536/testReport)** for PR 20611 at commit [`51a0415`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168956209 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -640,4 +740,55 @@ private object RandomForestSuite { val

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168956144 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -640,4 +740,55 @@ private object RandomForestSuite { val

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168956108 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -303,26 +303,6 @@ class DecisionTreeSuite extends SparkFunSuite wit

[GitHub] spark issue #20244: [SPARK-23053][CORE] taskBinarySerialization and task par...

2018-02-18 Thread ivoson
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/20244 thank you for reviewing this @squito --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread ivoson
Github user ivoson commented on the issue: https://github.com/apache/spark/pull/20635 cc @squito --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20635 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20635 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySeriali...

2018-02-18 Thread ivoson
GitHub user ivoson opened a pull request: https://github.com/apache/spark/pull/20635 [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization and task partitions calculate in DagScheduler.submitMissingTasks should keep the same RDD checkpoint status ## What changes were proposed in

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87537/testReport)** for PR 20619 at commit [`8bd02d8`](https://github.com/apache/spark/commit/8b

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/955/ Test

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20619 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20611: [SPARK-23425][SQL]When wild card is been used in load co...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20611 **[Test build #87536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87536/testReport)** for PR 20611 at commit [`51a0415`](https://github.com/apache/spark/commit/51

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168946503 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -640,4 +689,96 @@ private object RandomForestSuite {

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168946478 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala --- @@ -287,6 +292,41 @@ private[tree] class LearningNode( } }

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87535/ Test FAILed. ---

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87535/testReport)** for PR 20619 at commit [`8bd02d8`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #20632: [SPARK-3159] added subtree pruning in the transla...

2018-02-18 Thread asolimando
Github user asolimando commented on a diff in the pull request: https://github.com/apache/spark/pull/20632#discussion_r168946358 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala --- @@ -287,6 +292,41 @@ private[tree] class LearningNode( } }

[GitHub] spark pull request #20621: [SPARK-23436][SQL] Infer partition as Date only i...

2018-02-18 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20621#discussion_r168945339 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -407,6 +407,34 @@ object PartitioningUtils {

[GitHub] spark pull request #20553: [SPARK-23285][K8S] Add a config property for spec...

2018-02-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20553#discussion_r168943784 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -85,6 +85,12 @@ private[spark] object Config

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87535/testReport)** for PR 20619 at commit [`8bd02d8`](https://github.com/apache/spark/commit/8b

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/954/ Test

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

2018-02-18 Thread danielvdende
Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r168943159 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -85,15 +85,24 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20619 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87534/ Test FAILed. ---

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20619 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20619: [SPARK-23457][SQL] Register task completion listeners fi...

2018-02-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20619 **[Test build #87534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87534/testReport)** for PR 20619 at commit [`8bd02d8`](https://github.com/apache/spark/commit/8