[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1171/ Tes

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2018-02-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r171443786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExprValue.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed to the

[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-02-28 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/20685 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-02-28 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/20685 ![image](https://user-images.githubusercontent.com/4058918/36822880-5f4aa9e8-1d35-11e8-8956-4081a2953d22.png) The failed test is not related, I can pass in my local --- ---

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20698 **[Test build #87806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87806/testReport)** for PR 20698 at commit [`5f066a0`](https://github.com/apache/spark/commit/5f

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20698 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20698 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1170/ Tes

[GitHub] spark issue #20382: [SPARK-23097][SQL][SS] Migrate text socket source to V2

2018-02-28 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20382 @jerryshao please address the above comment, then we are good to merge! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apac

[GitHub] spark pull request #20682: [SPARK-23522][Python] always use sys.exit over bu...

2018-02-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20682#discussion_r171442417 --- Diff: python/pyspark/util.py --- @@ -18,6 +18,8 @@ __all__ = [] +import sys + --- End diff -- Oh, I see. Thanks! -

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20698 @zsxwing @jose-torres --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20698 **[Test build #87805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87805/testReport)** for PR 20698 at commit [`ebb9b51`](https://github.com/apache/spark/commit/eb

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20698 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1169/ Tes

[GitHub] spark pull request #20698: [SPARK-23541][SS] Allow Kafka source to read data...

2018-02-28 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20698#discussion_r171441133 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala --- @@ -0,0 +1,105 @@ +/* + * Licensed

[GitHub] spark issue #20698: [SPARK-23541][SS] Allow Kafka source to read data with g...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20698 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20698: [SPARK-23541][SS] Allow Kafka source to read data...

2018-02-28 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/20698 [SPARK-23541][SS] Allow Kafka source to read data with greater parallelism than the number of topic-partitions ## What changes were proposed in this pull request? Currently, when the Kafka so

[GitHub] spark pull request #20696: [SPARK-23525] [SQL] Support ALTER TABLE CHANGE CO...

2018-02-28 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20696#discussion_r171439915 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -314,8 +314,8 @@ case class AlterTableChangeColumnCommand(

[GitHub] spark pull request #19108: [SPARK-21898][ML] Feature parity for KolmogorovSm...

2018-02-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19108#discussion_r171438289 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request #19108: [SPARK-21898][ML] Feature parity for KolmogorovSm...

2018-02-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19108#discussion_r171438156 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request #19108: [SPARK-21898][ML] Feature parity for KolmogorovSm...

2018-02-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19108#discussion_r171433430 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request #19108: [SPARK-21898][ML] Feature parity for KolmogorovSm...

2018-02-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/19108#discussion_r171423827 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request #20576: [SPARK-23389][CORE]When the shuffle dependency sp...

2018-02-28 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/20576#discussion_r171437565 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala --- @@ -188,9 +188,8 @@ private[spark] object SortShuffleManager exten

[GitHub] spark issue #20670: [SPARK-23405] Generate additional constraints for Join's...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20670 **[Test build #87804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87804/testReport)** for PR 20670 at commit [`023f2f7`](https://github.com/apache/spark/commit/02

[GitHub] spark issue #20670: [SPARK-23405] Generate additional constraints for Join's...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20670: [SPARK-23405] Generate additional constraints for Join's...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1168/ Tes

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87802/ Test FAILed. ---

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20681 **[Test build #87802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87802/testReport)** for PR 20681 at commit [`5c922ca`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #20669: [SPARK-22839][K8S] Remove the use of init-container for ...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20669 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1160/ ---

[GitHub] spark issue #20669: [SPARK-22839][K8S] Remove the use of init-container for ...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20669 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1160/ --- --

[GitHub] spark issue #20669: [SPARK-22839][K8S] Remove the use of init-container for ...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1167/ Tes

[GitHub] spark issue #20669: [SPARK-22839][K8S] Remove the use of init-container for ...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20669 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/20697#discussion_r171426248 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@ -0,0 +1

[GitHub] spark pull request #18998: [SPARK-21748][ML] Migrate the implementation of H...

2018-02-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/18998#discussion_r171425701 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala --- @@ -93,11 +97,21 @@ class HashingTF @Since("1.4.0") (@Since("1.4.0") override

[GitHub] spark issue #20669: [SPARK-22839][K8S] Remove the use of init-container for ...

2018-02-28 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/20669 @vanzin @mccheah @foxish This is ready for your review as it passes unit tests and integration tests. At the moment, it is required that we modify the integration tests to call `SparkFiles.get()`

[GitHub] spark pull request #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20692#discussion_r171421471 --- Diff: sql/core/src/test/resources/sql-tests/results/window.sql.out --- @@ -211,7 +211,7 @@ RANGE BETWEEN CURRENT ROW AND 1 FOLLOWING) FROM testData O

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87801/ Test FAILed. ---

[GitHub] spark pull request #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20692#discussion_r171421396 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala --- @@ -182,9 +182,9 @@ class HiveExplainSuite extends Quer

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20692 **[Test build #87801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87801/testReport)** for PR 20692 at commit [`c3e4227`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #18998: [SPARK-21748][ML] Migrate the implementation of H...

2018-02-28 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18998#discussion_r171412547 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala --- @@ -93,11 +97,21 @@ class HashingTF @Since("1.4.0") (@Since("1.4.0") override

[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20639 **[Test build #4137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4137/testReport)** for PR 20639 at commit [`22e6ca1`](https://github.com/apache/spark/commit/

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20618 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20618 **[Test build #87803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87803/testReport)** for PR 20618 at commit [`2ea1f18`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87803/ Test FAILed. ---

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20697 - Bug #? - Proper title: [SPARK-x][k8s] Blah. - Why isn't this hooked up to the build (both mvn and sbt)? - You have redundant stuff like a license file and a mvn script After

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20618 **[Test build #87803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87803/testReport)** for PR 20618 at commit [`2ea1f18`](https://github.com/apache/spark/commit/2e

[GitHub] spark issue #20632: [SPARK-3159][ML] Add decision tree pruning

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 Jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #20632: [SPARK-3159][ML] Add decision tree pruning

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 Squashing makes it impossible to review the history of the code review, so I don't think it's a good idea. It's fine for now. This LGTM. Let's see if @srowen or @jkbradley have any thoughts.

[GitHub] spark issue #20688: [SPARK-23096][SS] Migrate rate source to V2

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20688 **[Test build #87799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87799/testReport)** for PR 20688 at commit [`8bfadc3`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread ssuchter
Github user ssuchter commented on the issue: https://github.com/apache/spark/pull/20697 I should note that the integration test success that came from SparkQA is **not** using the copy of the integration test code mentioned in this PR. It is using the original copy of the code in htt

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87789/ Test PASSed. ---

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20692#discussion_r171387647 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala --- @@ -182,9 +182,9 @@ class HiveExplainSuite extends QueryT

[GitHub] spark issue #20669: [SPARK-22839][K8S][WIP] Remove the use of init-container...

2018-02-28 Thread ssuchter
Github user ssuchter commented on the issue: https://github.com/apache/spark/pull/20669 @vanzin I just opened this PR for putting the integration tests in the Spark repo: https://github.com/apache/spark/pull/20697 --- -

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20327 **[Test build #87789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87789/testReport)** for PR 20327 at commit [`0c4ed66`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #20674: [SPARK-23465][SQL] Introduce new function to rena...

2018-02-28 Thread misutoth
Github user misutoth commented on a diff in the pull request: https://github.com/apache/spark/pull/20674#discussion_r171386636 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2239,6 +2239,34 @@ class Dataset[T] private[sql]( } }

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87800/ Test FAILed. ---

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20692 **[Test build #87800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87800/testReport)** for PR 20692 at commit [`67f297e`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20649: [SPARK-23462][SQL] improve missing field error message i...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20649 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20649: [SPARK-23462][SQL] improve missing field error message i...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20649 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87792/ Test PASSed. ---

[GitHub] spark issue #20649: [SPARK-23462][SQL] improve missing field error message i...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20649 **[Test build #87792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87792/testReport)** for PR 20649 at commit [`8cdb1d5`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r171379498 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -79,6 +80,19 @@ private[spark] class Application

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r171381824 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -123,6 +123,10 @@ class YarnClusterSuite extends

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r171379388 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -79,6 +80,19 @@ private[spark] class Application

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-02-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r171382335 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -126,7 +126,7 @@ private[spark] abstract class WebUI( def bind(): Unit = {

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1166/ Tes

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20681 **[Test build #87802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87802/testReport)** for PR 20681 at commit [`5c922ca`](https://github.com/apache/spark/commit/5c

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20692 **[Test build #87801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87801/testReport)** for PR 20692 at commit [`c3e4227`](https://github.com/apache/spark/commit/c3

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1165/ Tes

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20681 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20697 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1157/ ---

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20697 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1157/ --- --

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20697 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20697 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1164/ Tes

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r171375731 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +681,31 @@ class JsonExpression

[GitHub] spark issue #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet files ...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20694 LGTM except one minor comment in the test case. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread liufengdb
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/20681 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20681 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87797/ Test FAILed. ---

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20681 **[Test build #87797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87797/testReport)** for PR 20681 at commit [`5c922ca`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #20671: [SPARK-23510][SQL] Support Hive 2.2 and Hive 2.3 metasto...

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20671 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark pull request #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20692#discussion_r171373420 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala --- @@ -182,9 +182,9 @@ class HiveExplainSuite extends Quer

[GitHub] spark pull request #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of ...

2018-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20693 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20697 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20632: [SPARK-3159][ML] Add decision tree pruning

2018-02-28 Thread asolimando
Github user asolimando commented on the issue: https://github.com/apache/spark/pull/20632 @sethah I have shortened the name as suggested and squashed the commits into a single one, let me know it that's ok! --- - To

[GitHub] spark pull request #20697: Initial checkin of k8s integration tests.

2018-02-28 Thread ssuchter
GitHub user ssuchter opened a pull request: https://github.com/apache/spark/pull/20697 Initial checkin of k8s integration tests. These tests were developed in the https://github.com/apache-spark-on-k8s/spark-integration repo by several contributors. This is a copy of the current

[GitHub] spark issue #20695: [SPARK-21741][ML][PySpark] Python API for DataFrame-base...

2018-02-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20695 2.4.0? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark issue #20501: [SPARK-22430][Docs] Unknown tag warnings when building R...

2018-02-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20501 can you reopen this PR and add [R] in the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addit

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20692 The failures of `SQLQueryTestSuite` are legitimate. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20671: [SPARK-23510][SQL] Support Hive 2.2 and Hive 2.3 metasto...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20671 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87795/ Test PASSed. ---

[GitHub] spark issue #20671: [SPARK-23510][SQL] Support Hive 2.2 and Hive 2.3 metasto...

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20671 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20671: [SPARK-23510][SQL] Support Hive 2.2 and Hive 2.3 metasto...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20671 **[Test build #87795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87795/testReport)** for PR 20671 at commit [`2e12c10`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20692 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87791/ Test FAILed. ---

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20692 **[Test build #87791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87791/testReport)** for PR 20692 at commit [`e076732`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 @asolimando Can you change the title to include `[ML]` and also shorten it. Maybe just: `Add decision tree pruning` --- - To unsu

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4136/testReport)** for PR 20632 at commit [`d02ff2a`](https://github.com/apache/spark/commit/

<    1   2   3   4   5   6   >