Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89041/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20904
**[Test build #89041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89041/testReport)**
for PR 20904 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89038/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20923
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20923
**[Test build #89038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89038/testReport)**
for PR 20923 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179987224
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -154,9 +165,17 @@
List buildSparkSubmitArgs()
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179987409
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -154,9 +165,17 @@
List buildSparkSubmitArgs()
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179952361
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -775,17 +781,17 @@ class SparkSubmitSuite
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2083/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2082/
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20981
@hvanhovell Addressed your comment. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20981
**[Test build #89042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89042/testReport)**
for PR 20981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2081/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20981
**[Test build #89040 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89040/testReport)**
for PR 20981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20904
**[Test build #89041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89041/testReport)**
for PR 20904 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2080/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20904
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20904
**[Test build #89039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89039/testReport)**
for PR 20904 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20319
@smurakozi Thanks for the PR! Could you resolve conflicts first? and then I
will make a review. If you're busy I can also take over it.
---
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978448
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -772,6 +772,12 @@ private[spark] class Executor(
val accumUpdates =
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978186
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +260,163 @@ class EventLoggingListenerSuite
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978222
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +260,163 @@ class EventLoggingListenerSuite
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978192
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +260,163 @@ class EventLoggingListenerSuite
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978182
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -268,6 +268,9 @@ private class LiveExecutor(val executorId: String,
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20940#discussion_r179978102
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -234,8 +244,22 @@ private[spark] class EventLoggingListener(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21005#discussion_r179971588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -117,16 +117,22 @@ abstract class BinaryArithmetic
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2079/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +289,165 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970154
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -413,6 +413,86 @@ class DataFrameFunctionsSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970092
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -3300,6 +3300,14 @@ object functions {
*/
def sort_array(e:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20923
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970006
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +289,165 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179969902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +289,165 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +289,165 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20938#discussion_r179970035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +289,165 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13599
Hey @zjffdu, would you have some time to update this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20923
**[Test build #89038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89038/testReport)**
for PR 20923 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20923
I think you should also update "test-dependencies.sh" to make the new deps
file work.
---
-
To unsubscribe, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20923
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20923
Sorry @steveloughran for the late response. most of the deps in file is
similar to "spark-deps-hadoop-2.7", so copy/rename it and run
"test-dependencies.sh" will show you the diffs, based on the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21005#discussion_r179967381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -117,16 +117,22 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179966200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,15 @@ class JacksonParser(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21005
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89036/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21005
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21005
**[Test build #89036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89036/testReport)**
for PR 21005 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89037/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89037/testReport)**
for PR 20937 at commit
Github user jsigee87 commented on the issue:
https://github.com/apache/spark/pull/13440
Is this still being considered?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21004
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21004
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89034/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21004
**[Test build #89034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89034/testReport)**
for PR 21004 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89037/testReport)**
for PR 20937 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179958997
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89035/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89035/testReport)**
for PR 20937 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179958858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21005
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21005
**[Test build #89036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89036/testReport)**
for PR 21005 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21005
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2078/
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179958785
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,15 @@ class JacksonParser(
//
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/21005
[SPARK-23898][SQL] Simplify add & subtract code generation
## What changes were proposed in this pull request?
Code generation for the `Add` and `Subtract` expressions was not done using
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89035/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89033/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89033 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89033/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20987
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89032/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20987
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20987
**[Test build #89032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89032/testReport)**
for PR 20987 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21004
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2077/
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179957573
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -366,6 +366,9 @@ class DataFrameReader private[sql](sparkSession:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21004
**[Test build #89034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89034/testReport)**
for PR 21004 at commit
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21004#discussion_r179957491
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala
---
@@ -126,35 +126,35 @@ abstract
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/21004
[SPARK-23896][SQL]Improve PartitioningAwareFileIndex
## What changes were proposed in this pull request?
Currently `PartitioningAwareFileIndex` accepts an optional parameter
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21002
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21002
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/20938
Any other comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21000
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21000
LGTM - merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179955288
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -92,26 +93,30 @@ object
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179954099
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952254
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,15 @@ class JacksonParser(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179951972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952617
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2162,4 +2162,262 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952150
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179951938
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952240
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952386
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -366,6 +366,9 @@ class DataFrameReader private[sql](sparkSession:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179951956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952127
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179951859
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -237,6 +237,8 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,15 @@ class JacksonParser(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r179952689
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -175,11 +188,15 @@ object
1 - 100 of 189 matches
Mail list logo
