[GitHub] spark pull request #21503: [SPARK-24478][SQL] Move projection and filter pus...

2018-06-12 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21503#discussion_r194829647 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -17,15 +17,56 @@ package org.ap

[GitHub] spark issue #21481: [WIP][SPARK-24452][SQL][Core] Avoid possible overflow in...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21481 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21481: [WIP][SPARK-24452][SQL][Core] Avoid possible overflow in...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21481 **[Test build #91717 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91717/testReport)** for PR 21481 at commit [`50a2585`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21541: [SPARK-20168][Streaming Kinesis] Setting the timestamp d...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21541 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21541: [SPARK-20168][Streaming Kinesis] Setting the timestamp d...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21541 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21541: [SPARK-20168][Streaming Kinesis] Setting the timestamp d...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21541 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21541: [SPARK-20168][Streaming Kinesis] Setting the timestamp d...

2018-06-12 Thread yashs360
Github user yashs360 commented on the issue: https://github.com/apache/spark/pull/21541 @brkyvz for your review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark pull request #21503: [SPARK-24478][SQL] Move projection and filter pus...

2018-06-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21503#discussion_r194828220 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -17,15 +17,56 @@ package org

[GitHub] spark pull request #21541: [SPARK-20168][Streaming Kinesis] Setting the time...

2018-06-12 Thread yashs360
GitHub user yashs360 opened a pull request: https://github.com/apache/spark/pull/21541 [SPARK-20168][Streaming Kinesis] Setting the timestamp directly would cause exception on … Setting the timestamp directly would cause exception on reading stream, it can be set directly only if

[GitHub] spark pull request #21482: [SPARK-24393][SQL] SQL builtin: isinf

2018-06-12 Thread NihalHarish
Github user NihalHarish commented on a diff in the pull request: https://github.com/apache/spark/pull/21482#discussion_r194827936 --- Diff: python/pyspark/sql/functions.py --- @@ -468,6 +468,18 @@ def input_file_name(): return Column(sc._jvm.functions.input_file_name())

[GitHub] spark issue #21481: [WIP][SPARK-24452][SQL][Core] Avoid possible overflow in...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21481 **[Test build #91717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91717/testReport)** for PR 21481 at commit [`50a2585`](https://github.com/apache/spark/commit/50

[GitHub] spark issue #21481: [WIP][SPARK-24452][SQL][Core] Avoid possible overflow in...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3942/ Tes

[GitHub] spark issue #21481: [WIP][SPARK-24452][SQL][Core] Avoid possible overflow in...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21481 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21517 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3794/ ---

[GitHub] spark issue #21503: [SPARK-24478][SQL] Move projection and filter push down ...

2018-06-12 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21503 @cloud-fan, this is the PR for moving push-down to the physical plan conversion and reporting the stats correctly. Sorry for the confusion because I sent a link to just the second commit. ---

[GitHub] spark issue #21538: [SPARK-23754][PYTHON][FOLLOWUP][BACKPORT-2.3] Move UDF s...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21538 **[Test build #91716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91716/testReport)** for PR 21538 at commit [`612781a`](https://github.com/apache/spark/commit/61

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21517 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3794/ --- --

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3941/ Tes

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/51/

[GitHub] spark issue #21523: [SPARK-24506][UI] Add UI filters to tabs added after bin...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21523 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21523: [SPARK-24506][UI] Add UI filters to tabs added after bin...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21523 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91711/ Test FAILed. ---

[GitHub] spark issue #21523: [SPARK-24506][UI] Add UI filters to tabs added after bin...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21523 **[Test build #91711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91711/testReport)** for PR 21523 at commit [`02a9f4e`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21504 Looks fine but let me leave this open for more days before merging it in case someone has some comments on it. --- - To unsu

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21504 **[Test build #91715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91715/testReport)** for PR 21504 at commit [`b87c90b`](https://github.com/apache/spark/commit/b8

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread ssuchter
Github user ssuchter commented on the issue: https://github.com/apache/spark/pull/21517 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3940/ Tes

[GitHub] spark issue #21517: Testing k8s change - please ignore (13)

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21517 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-12 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/spark/pull/21504 @HyukjinKwon , addressed comments. Can you take it forward? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.

[GitHub] spark issue #20846: [SPARK-5498][SQL][FOLLOW] add schema to table partition

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20846 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21517: Testing k9s change - please ignore (13)

2018-06-12 Thread ssuchter
Github user ssuchter commented on the issue: https://github.com/apache/spark/pull/21517 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21504: [SPARK-24479][SS] Added config for registering st...

2018-06-12 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/21504#discussion_r194817758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala --- @@ -96,6 +96,14 @@ object StaticSQLConf { .toSeq

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91713/ Test FAILed. ---

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21531 **[Test build #91713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91713/testReport)** for PR 21531 at commit [`658539a`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21540 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21540 Thanks! Merged to master/2.3/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-12 Thread krcz
Github user krcz commented on the issue: https://github.com/apache/spark/pull/20641 @skonto The command you have pasted as "At the driver side in DC/OS:" concerns me. It doesn't seem escaped properly. Is it the command to be run by shell or is it just space-joined arguments list

[GitHub] spark issue #21427: [SPARK-24324][PYTHON] Pandas Grouped Map UDF should assi...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21427 Okay .. but let's make sure this case was special ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21523: [SPARK-24506][UI] Add UI filters to tabs added after bin...

2018-06-12 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21523 LGTM pending tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark pull request #21523: [SPARK-24506][UI] Add UI filters to tabs added af...

2018-06-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21523#discussion_r194814773 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -91,7 +91,12 @@ private[spark] abstract class WebUI( /** Attach a handler to this

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21533 Seems fine to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #21533: [SPARK-24195][Core] Bug fix for local:/ path in S...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21533#discussion_r194812872 --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala --- @@ -116,49 +116,52 @@ class SparkContextSuite extends SparkFunSuite with Loca

[GitHub] spark pull request #21533: [SPARK-24195][Core] Bug fix for local:/ path in S...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21533#discussion_r194812741 --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala --- @@ -116,49 +116,52 @@ class SparkContextSuite extends SparkFunSuite with Loca

[GitHub] spark pull request #21533: [SPARK-24195][Core] Bug fix for local:/ path in S...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21533#discussion_r194812492 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1517,9 +1517,12 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] spark pull request #21532: [SPARK-24524][SQL]Improve aggregateMetrics: reduc...

2018-06-12 Thread gengliangwang
Github user gengliangwang closed the pull request at: https://github.com/apache/spark/pull/21532 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.

[GitHub] spark issue #21532: [SPARK-24524][SQL]Improve aggregateMetrics: reduce memor...

2018-06-12 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21532 Find possible issue, close this PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21427: [SPARK-24324][PYTHON] Pandas Grouped Map UDF should assi...

2018-06-12 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/21427 I agree with you @HyukjinKwon but we have had lots of discussion here and are still split, so let's just add the config. There is still the off chance that someone upgrading from 2.3.0 (without

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21540#discussion_r194810175 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -195,7 +195,7 @@ class HiveExternalCatalogVersio

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21540#discussion_r194808256 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -195,7 +195,7 @@ class HiveExternalCatalogVersions

[GitHub] spark pull request #21538: [SPARK-23754][PYTHON][FOLLOWUP][BACKPORT-2.3] Mov...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21538#discussion_r194806008 --- Diff: python/pyspark/worker.py --- @@ -122,6 +123,10 @@ def read_single_udf(pickleSer, infile, eval_type): else: row_fu

[GitHub] spark issue #21534: [SPARK-24526][build] Spaces in the build dir causes fail...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21534 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21534: [SPARK-24526][build] Spaces in the build dir causes fail...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21534 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91709/ Test FAILed. ---

[GitHub] spark issue #21534: [SPARK-24526][build] Spaces in the build dir causes fail...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21534 **[Test build #91709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91709/testReport)** for PR 21534 at commit [`bb12f3e`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #21068: [SPARK-16630][YARN] Blacklist a node if executors won't ...

2018-06-12 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21068 Tom and I had a chance to discuss this in person, and after some back and forth I think we decided that maybe its best to remove the limit but have the application fail if the entire cluster is black

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21540#discussion_r194801726 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -195,7 +195,7 @@ class HiveExternalCatalogVersio

[GitHub] spark issue #21501: [SPARK-15064][ML] Locale support in StopWordsRemover

2018-06-12 Thread dongjinleekr
Github user dongjinleekr commented on the issue: https://github.com/apache/spark/pull/21501 @mengxr Thank you very much for your kind guidance. If you have some time, please have a look at my another PR, #21525. I found this issue while I was reading [an issue on HashingTF](https://i

[GitHub] spark pull request #21067: [SPARK-23980][K8S] Resilient Spark driver on Kube...

2018-06-12 Thread baluchicken
Github user baluchicken commented on a diff in the pull request: https://github.com/apache/spark/pull/21067#discussion_r194798725 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala --- @@ -18,54 +18,87

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194797201 --- Diff: python/pyspark/sql/dataframe.py --- @@ -351,8 +354,68 @@ def show(self, n=20, truncate=True, vertical=False): else:

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194795581 --- Diff: docs/configuration.md --- @@ -456,6 +456,33 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194794968 --- Diff: python/pyspark/sql/tests.py --- @@ -3074,6 +3074,36 @@ def test_checking_csv_header(self): finally: shutil.rmtre

[GitHub] spark pull request #21067: [SPARK-23980][K8S] Resilient Spark driver on Kube...

2018-06-12 Thread baluchicken
Github user baluchicken commented on a diff in the pull request: https://github.com/apache/spark/pull/21067#discussion_r194794691 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -67,12 +68,19 @@

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194794700 --- Diff: docs/configuration.md --- @@ -456,6 +456,33 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194794493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194794284 --- Diff: docs/configuration.md --- @@ -456,6 +456,33 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194794008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194793637 --- Diff: docs/configuration.md --- @@ -456,6 +456,33 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-12 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/20641 @susanxhuynh I tested this. Here is what you get: ``` ./bin/spark-submit --deploy-mode cluster --name test --master mesos://spark.marathon.mesos:13830 --driver-cores 1.0 --driver-memory 1

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21540 Even if Marco doesn't respond I'll merge this pending tests, given this is breaking tests, and leave the new version for later. --- -

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194790063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194788437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21540#discussion_r194787724 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -195,7 +195,7 @@ class HiveExternalCatalogVersions

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21540 **[Test build #91714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91714/testReport)** for PR 21540 at commit [`8f16eda`](https://github.com/apache/spark/commit/8f

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3939/ Tes

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/50/

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21540 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from testing v...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21540 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194784664 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql]( } }

[GitHub] spark issue #21140: [SPARK-22600][SQL][WIP] Fix 64kb limit for deeply nested...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/49/

[GitHub] spark issue #21140: [SPARK-22600][SQL][WIP] Fix 64kb limit for deeply nested...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21140 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #21540: [SPARK-24531][TESTS] Remove version 2.2.0 from te...

2018-06-12 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21540 [SPARK-24531][TESTS] Remove version 2.2.0 from testing versions in HiveExternalCatalogVersionsSuite ## What changes were proposed in this pull request? Removing version 2.2.0 from testing

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement eager evaluation...

2018-06-12 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r194783738 --- Diff: python/pyspark/sql/dataframe.py --- @@ -351,8 +354,68 @@ def show(self, n=20, truncate=True, vertical=False): else:

[GitHub] spark issue #20929: [SPARK-23772][SQL] Provide an option to ignore column of...

2018-06-12 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/20929 @maropu Any updates? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21501: [SPARK-15064][ML] Locale support in StopWordsRemover

2018-06-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21501 Congratulation, @dongjinleekr ! :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comman

[GitHub] spark pull request #21501: [SPARK-15064][ML] Locale support in StopWordsRemo...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21501 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21501: [SPARK-15064][ML] Locale support in StopWordsRemover

2018-06-12 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/21501 LGTM. Merged into master. @dongjinleekr Do you have a JIRA user? Could you ping me at https://issues.apache.org/jira/browse/SPARK-15064 so I can assign the ticket to you. Thanks for your contribution

[GitHub] spark issue #21529: [SPARK-24495][SQL] EnsureRequirement returns wrong plan ...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21529 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91710/ Test FAILed. ---

[GitHub] spark issue #21529: [SPARK-24495][SQL] EnsureRequirement returns wrong plan ...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21529 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21529: [SPARK-24495][SQL] EnsureRequirement returns wrong plan ...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21529 **[Test build #91710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91710/testReport)** for PR 21529 at commit [`341f1b2`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3938/ Tes

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #21067: [SPARK-23980][K8S] Resilient Spark driver on Kube...

2018-06-12 Thread baluchicken
Github user baluchicken commented on a diff in the pull request: https://github.com/apache/spark/pull/21067#discussion_r194774780 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala --- @@ -59,16

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21531 **[Test build #91713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91713/testReport)** for PR 21531 at commit [`658539a`](https://github.com/apache/spark/commit/65

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/48/

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21531 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21531: [SPARK-24521][SQL][TEST] Fix ineffective test in CachedT...

2018-06-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/21531 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21321: [SPARK-24268][SQL] Use datatype.simpleString in error me...

2018-06-12 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21321 kindly ping @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #21475: [SPARK-24416] Fix configuration specification for killBl...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21475 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91712/ Test PASSed. ---

[GitHub] spark issue #21475: [SPARK-24416] Fix configuration specification for killBl...

2018-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21475 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

<    1   2   3   4   5   6   7   8   >