Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21582
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18544
@stanzhai Could we just fix it by changing `failFunctionLookup`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apach
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21582
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21608#discussion_r203265365
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -47,15 +48,27 @@ object CommandUtils extends Logging {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21608#discussion_r203264804
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -148,6 +148,19 @@ class StatisticsSuite extends
StatisticsCollectio
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21764
**[Test build #93217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93217/testReport)**
for PR 21764 at commit
[`84f1a6b`](https://github.com/apache/spark/commit/84
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1085/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21764
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21764
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1086/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21698
Ah I see, then we need to change DAGScheduler a lot to fix it, which may
not worth.
I still insist that `repartition` should be treated as a bug, but it's not
easy to hit(when the input o
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21770
yea, if we get the consensus to implement #21777, it sounds ok to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apac
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r203261248
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
v
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21801
**[Test build #93216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93216/testReport)**
for PR 21801 at commit
[`7f78d75`](https://github.com/apache/spark/commit/7f
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21801
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21777
Yea, as you said, the JDK compiler generates different bytecode though, I
couldn't get obvious performance gains for TPCDS as compared to the janino one.
So, I couldn't find the strong reason to impl
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93214/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21801
**[Test build #93214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93214/testReport)**
for PR 21801 at commit
[`7f78d75`](https://github.com/apache/spark/commit/7
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21131
a late LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21131#discussion_r203257926
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -764,6 +769,19 @@ private[spark] class TaskSetManager(
maybe
Github user ijuma commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203256766
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -115,7 +116,7 @@ private[kafka010] class KafkaO
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21386
Okay, I'll take this over, and ping you when I submit a PR to ask a review.
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubsc
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21795
**[Test build #93215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93215/testReport)**
for PR 21795 at commit
[`de5a232`](https://github.com/apache/spark/commit/de
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21795
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1084/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93212/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21488
**[Test build #93212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93212/testReport)**
for PR 21488 at commit
[`e7318a9`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21800
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21800
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93210/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21800
**[Test build #93210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93210/testReport)**
for PR 21800 at commit
[`d6f41e0`](https://github.com/apache/spark/commit/d
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r203252809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -726,8 +726,9 @@ private[execution] final class LongToUns
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203251175
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBufferFileRegion.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Soft
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203250619
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21669
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21669
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93211/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21669
**[Test build #93211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93211/testReport)**
for PR 21669 at commit
[`13b3adc`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21800
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93209/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21800
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21801#discussion_r203249250
--- Diff: external/avro/src/test/resources/log4j.properties ---
@@ -46,4 +46,4 @@
log4j.additivity.org.apache.hadoop.hive.metastore.RetryingHMSHandler=false
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21800
**[Test build #93209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93209/testReport)**
for PR 21800 at commit
[`6a89c65`](https://github.com/apache/spark/commit/6
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20146
Ah, I know why. Because the latest commit
https://github.com/apache/spark/pull/20146/commits/a6551b02a10428d66e0dadcfcb5a8da3798ec814
doesn't contain the changes to trigger the test. Rebasing an
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21542
H this happened to me too and I just pushed
https://github.com/apache/spark/commit/fc2e18963efdf4b50258f85c8779122742876910.
Mine was Java 8. There's reproducer in the PR description.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21801#discussion_r203248740
--- Diff: external/avro/src/test/resources/log4j.properties ---
@@ -46,4 +46,4 @@
log4j.additivity.org.apache.hadoop.hive.metastore.RetryingHMSHandler=f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93213/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21488
**[Test build #93213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93213/testReport)**
for PR 21488 at commit
[`13a7884`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21801
**[Test build #93214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93214/testReport)**
for PR 21801 at commit
[`7f78d75`](https://github.com/apache/spark/commit/7f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1083/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21801
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/21801
[SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-java and Scala 2.12
build.
## What changes were proposed in this pull request?
This pr fixes lint-java and Scala 2.12 build.
li
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r20324
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBufferFileRegion.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Softwar
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20146
it's odd appveyer tests are not getting triggered.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For add
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203245221
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:
A
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21710#discussion_r203245118
--- Diff: R/pkg/R/mllib_fpm.R ---
@@ -154,3 +160,74 @@ setMethod("write.ml", signature(object =
"FPGrowthModel", path = "character"),
fun
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21710#discussion_r203245010
--- Diff: R/pkg/R/generics.R ---
@@ -1415,6 +1415,13 @@ setGeneric("spark.freqItemsets", function(object) {
standardGeneric("spark.freqI
#' @rdname
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203244832
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:
A
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21305
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93208/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21305
**[Test build #93208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93208/testReport)**
for PR 21305 at commit
[`f041019`](https://github.com/apache/spark/commit/f
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21542
"permission" stuff might be Java 9 related?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21787
Constant variables and squashing the logic into one function look not worth
enough and overkill. Less duplication is good of course but it doesn't look
worth enough for both. I would focus on mo
Github user swapnilushinde commented on the issue:
https://github.com/apache/spark/pull/21787
true. Currently we have just 3 variations of comparing two datatypes for
equality. Adding even one more equality function would easily cause writing
same repetitive code which would negate ob
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21795#discussion_r203242468
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2336,46 +2336,40 @@ class DataFrameSuite extends QueryTest with
SharedSQ
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/21772
@hvanhovell Thanks for reviewing. Losing data because the variable
**cursor** in executor is 0 and serialization depends on it. I will add an UT
later.
---
Github user liutang123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r203241485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -726,8 +726,9 @@ private[execution] final class LongT
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/18138
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19804
Thank you @wangyum.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21795#discussion_r203240428
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2336,46 +2336,40 @@ class DataFrameSuite extends QueryTest with
Share
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21784
It's noisy when type something:
![spark-24128](https://user-images.githubusercontent.com/5399861/42857022-8afee254-8a7a-11e8-8ee0-47a19af99fa7.gif)
---
---
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/21792
@srowen I think we need to update the docs
1, Current doc in `StringIndexer` is somewhat misleading: "The indices are
in `[0, numLabels)`, ordered by label frequencies, so the most frequent
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21765
**[Test build #4218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4218/testReport)**
for PR 21765 at commit
[`e5f469a`](https://github.com/apache/spark/commit/
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/21789
yes, only in STS, i will update the title
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional c
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19804
Thanks @HyukjinKwon, already close some.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203239370
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class Hive
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21754
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/15945
I'll close for now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/15945
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/16605
I'll close for now
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h..
Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/16605
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/21460
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/19804
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/20248
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19804
@wangyum, I think you could leave close some of PRs that you are currently
not working on and have no explicit plan yet to start to work on soon. You
could reopen or create new one when you star
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203237484
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBufferFileRegion.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Soft
Github user stanzhai commented on the issue:
https://github.com/apache/spark/pull/18544
cc @gatorsmile changes in
`sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala`
has been reverted.
---
-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21192
To me, yes. If you find some times, I would appreciate if you take a look
at https://github.com/apache/spark/pull/21192#issuecomment-391405633 too so
that we can review each other whoever make a
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203236014
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21589#discussion_r203235747
--- Diff: R/pkg/R/context.R ---
@@ -437,3 +437,33 @@ setCheckpointDir <- function(directory) {
sc <- getSparkContext()
invisible(callJMetho
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21589#discussion_r203235671
--- Diff: R/pkg/R/context.R ---
@@ -437,3 +437,33 @@ setCheckpointDir <- function(directory) {
sc <- getSparkContext()
invisible(callJMetho
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203235292
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -17,17 +17,21 @@
package org.apache.spark.util.io
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/21800
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21784
Hm, yea. I don't think find this super noisy though to be honest.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apa
Github user eatoncys closed the pull request at:
https://github.com/apache/spark/pull/19819
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21785
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21785
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21785
@kiszk, let me just push this in since it fixes an actual issue and the
build passes; however, please make a followup if you see something else to fix.
---
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21635#discussion_r203232034
--- Diff: docs/monitoring.md ---
@@ -435,6 +435,7 @@ set of sinks to which metrics are reported. The
following instances are currentl
* `executor`: A
Github user lvdongr commented on the issue:
https://github.com/apache/spark/pull/19819
I've seen your PR: https://github.com/apache/spark/pull/20997, a good
solution @gaborgsomogyi
---
-
To unsubscribe, e-mail: re
1 - 100 of 645 matches
Mail list logo