Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r204805474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,18 +318,34 @@ case class AlterTableChangeColumnCommand(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21851
**[Test build #93503 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93503/testReport)**
for PR 21851 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19773
@gatorsmile @maropu Please have a look about this, solving the conflicts
takes me some time.
Also cc @jiangxb1987 because the conflict mainly with #20696, also thanks
for the work in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21857
**[Test build #93495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93495/testReport)**
for PR 21857 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19773
**[Test build #93504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93504/testReport)**
for PR 19773 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21851
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21851
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21851
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204802956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1627,6 +1627,8 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21862
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21862
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21862
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user yifeih opened a pull request:
https://github.com/apache/spark/pull/21862
[SPARK-24903][K8s] Make driver container name configurable in kubernetes
## What changes were proposed in this pull request?
Making kubernetes driver container name configurable
##
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21848
@dbtsai I have a question. How does the current code check the following
condition?
> Stateful expression must have a side effect.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16677
**[Test build #93502 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93502/testReport)**
for PR 16677 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21854
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21474
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21474
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21653
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21474
**[Test build #93501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93501/testReport)**
for PR 21474 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21474
good point @jerryshao , I've updated the docs now, please take a look,
thanks
---
-
To unsubscribe, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21440
@gatorsmile sure, thats pretty easy. I'll submit a follow up pr.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93497/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93497/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93498/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93498/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93496/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93496 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93496/testReport)**
for PR 21403 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204777353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -182,14 +182,16 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204775684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204775243
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1275,6 +1276,64 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204774985
--- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql ---
@@ -0,0 +1,146 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204774728
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204773666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204773452
--- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql ---
@@ -0,0 +1,146 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204773466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -182,14 +182,16 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204772193
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -182,14 +182,16 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21860
Could you please let us know which existing test verifies the newly added
code generation path?
---
-
To unsubscribe, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204763786
--- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql ---
@@ -0,0 +1,146 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
+
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204760604
--- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql ---
@@ -0,0 +1,146 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
---
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204760405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -182,14 +182,16 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204758133
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1919,6 +1919,21 @@ class Dataset[T] private[sql](
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204762822
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204761432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204763415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1275,6 +1276,64 @@ object ReplaceExceptWithAntiJoin
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21858
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21858
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93494/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21858
**[Test build #93494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93494/testReport)**
for PR 21858 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r204763098
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ---
@@ -68,4 +70,25 @@ class AvroOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r204762586
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ---
@@ -68,4 +70,25 @@ class AvroOptions(
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r204757826
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ---
@@ -68,4 +70,25 @@ class AvroOptions(
.map(_.toBoolean)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93493/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21802
**[Test build #93493 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93493/testReport)**
for PR 21802 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21118
**[Test build #93500 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93500/testReport)**
for PR 21118 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21118
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21118
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21118
LGTM, let's merge it when the tests pass (the last pass was 4 days ago)
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21118
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21803
@gatorsmile @rxin I moved `toDDL` to the `StructType` class and reused it
from `SHOW CREATE TABLE` (fixed the bug of unquoted field names). Please, have
take a look at the PR.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93499/testReport)**
for PR 21439 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204750587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user MaxGekk closed the pull request at:
https://github.com/apache/spark/pull/21589
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21589
I am closing the PR since there is no consensus regarding new methods.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21861
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21861
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21861
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user tengpeng opened a pull request:
https://github.com/apache/spark/pull/21861
[SPARK-24907][WIP] Migrate JDBC DataSource to JDBCDataSourceV2 Read using
DataSourceV2 API
## What changes were proposed in this pull request?
(After the update of DataSourceV2 API, this
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r204743359
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,32 @@ case class Stack(children:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21854
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21854
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93491/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21854
**[Test build #93491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93491/testReport)**
for PR 21854 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93492/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21850
**[Test build #93492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93492/testReport)**
for PR 21850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93498 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93498/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93497 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93497/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93496 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93496/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/21650
@BryanCutler I've address most of you comments and explained the ones that
I didn't change. Do you mind take another look? Thanks!
---
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/21403
Looks good to me, though I'm not very familiar with analyzer.
@cloud-fan, @hvanhovell ?
---
-
To unsubscribe,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21855
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21855
Merged to master, branch-2.3 and branch-2.1.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93489/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21855
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21855
**[Test build #93489 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93489/testReport)**
for PR 21855 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21845
@HyukjinKwon Super. Thanks a lot for fixing.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
301 - 400 of 551 matches
Mail list logo
