[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21884 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21884 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21884 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1581/ ---

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21884 @mccheah the tests didn't run because you're not an admin for the regular (non-k8s) pull request builder. i added you to that list and you'll be able to trigger tests now. ---

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207020824 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -78,7 +93,8 @@ object CommandUtils extends Logging {

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21884 **[Test build #93901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93901/testReport)** for PR 21884 at commit

[GitHub] spark issue #21883: [SPARK-24937][SQL] Datasource partition table should loa...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21883 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21883: [SPARK-24937][SQL] Datasource partition table should loa...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21883 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93886/ Test PASSed. ---

[GitHub] spark issue #21883: [SPARK-24937][SQL] Datasource partition table should loa...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21883 **[Test build #93886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93886/testReport)** for PR 21883 at commit

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21884 jenkins test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21941: [SPARK-24966][SQL] Implement precedence rules for...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21941#discussion_r207019185 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1451,6 +1451,15 @@ object SQLConf { .intConf

[GitHub] spark pull request #21941: [SPARK-24966][SQL] Implement precedence rules for...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21941#discussion_r207018987 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1451,6 +1451,15 @@ object SQLConf { .intConf

[GitHub] spark pull request #21941: [SPARK-24966][SQL] Implement precedence rules for...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21941#discussion_r207018914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1451,6 +1451,15 @@ object SQLConf { .intConf

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207017248 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1449,13 @@ object SQLConf { .intConf

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r207017122 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1449,13 @@ object SQLConf { .intConf

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207016169 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21305: [SPARK-24251][SQL] Add AppendData logical plan.

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21305#discussion_r207015951 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2217,6 +2218,100 @@ class Analyzer( } }

[GitHub] spark issue #21945: [SPARK-24989][Core] Add retrying support for OutOfDirect...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21945 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93885/ Test FAILed. ---

[GitHub] spark issue #21945: [SPARK-24989][Core] Add retrying support for OutOfDirect...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21945 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21945: [SPARK-24989][Core] Add retrying support for OutOfDirect...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21945 **[Test build #93885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93885/testReport)** for PR 21945 at commit

[GitHub] spark issue #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanRow

2018-08-01 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21921 Yeah, I'd say that if it isn't documented then lets go with the usually RTC conventions. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21884 @mccheah nope no idea why the unit tests didn't trigger. the build config hasn't changed, and the worker that this build ran on is one of the original ubuntu workers (not freshly deployed), so

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207009415 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -366,14 +423,26 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207009284 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark issue #21936: [SPARK-24981][Core] ShutdownHook timeout causes job to f...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21936 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93883/ Test PASSed. ---

[GitHub] spark issue #21936: [SPARK-24981][Core] ShutdownHook timeout causes job to f...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21936 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21948 +1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207009194 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207009085 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207008830 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark issue #21936: [SPARK-24981][Core] ShutdownHook timeout causes job to f...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21936 **[Test build #93883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93883/testReport)** for PR 21936 at commit

[GitHub] spark pull request #21930: [SPARK-14540][Core] Fix remaining major issues fo...

2018-08-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21930#discussion_r207008732 --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala --- @@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-08-01 Thread Achuth17
Github user Achuth17 commented on the issue: https://github.com/apache/spark/pull/21608 @gatorsmile, I have made the changes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21948: [SPARK-24991][SQL] use InternalRow in DataSourceW...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21948#discussion_r207006871 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -89,8 +89,7 @@ class

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207004345 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -98,14 +103,50 @@ class ExecutorSummary private[spark]( val

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207004013 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -669,6 +686,34 @@ private[spark] class AppStatusListener(

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207004094 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -98,14 +103,50 @@ class ExecutorSummary private[spark]( val

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r20799 --- Diff: core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala --- @@ -251,6 +261,214 @@ class EventLoggingListenerSuite extends

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207006413 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal fo...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21949 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #21909: [SPARK-24959][SQL] Speed up count() for JSON and ...

2018-08-01 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21909#discussion_r207005019 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FailureSafeParser.scala --- @@ -56,9 +57,14 @@ class FailureSafeParser[IN](

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207004997 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal fo...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21949 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal fo...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21949 **[Test build #93900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93900/testReport)** for PR 21949 at commit

[GitHub] spark pull request #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with dec...

2018-08-01 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21949 [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal followed by aggregation returns wrong result ## What changes were proposed in this pull request? When we do an average, the result

[GitHub] spark issue #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal fo...

2018-08-01 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21949 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21949: [SPARK-24957][SQL][BACKPORT-2.2] Average with decimal fo...

2018-08-01 Thread holdensmagicalunicorn
Github user holdensmagicalunicorn commented on the issue: https://github.com/apache/spark/pull/21949 @mgaido91, thanks! I am a bot who has found some folks who might be able to help with the review:@rxin, @marmbrus and @gatorsmile ---

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r207002859 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -669,6 +686,34 @@ private[spark] class AppStatusListener(

[GitHub] spark issue #21939: [SPARK-23874][SQL][PYTHON] Upgrade Apache Arrow to 0.10....

2018-08-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21939 i'm ready to pull the trigger on the update to arrow... i'd much prefer a pip dist, but would be ok w/a conda package. :) ---

[GitHub] spark issue #21885: [SPARK-24926][CORE] Ensure numCores is used consistently...

2018-08-01 Thread rezasafi
Github user rezasafi commented on the issue: https://github.com/apache/spark/pull/21885 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21935 **[Test build #93899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93899/testReport)** for PR 21935 at commit

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21935 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21935 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #21935: [SPARK-24773] Avro: support logical timestamp typ...

2018-08-01 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21935#discussion_r207000865 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala --- @@ -103,31 +108,49 @@ object SchemaConverters {

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21948 **[Test build #93898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93898/testReport)** for PR 21948 at commit

[GitHub] spark pull request #21884: [SPARK-24960][K8S] explicitly expose ports on dri...

2018-08-01 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21884#discussion_r206999720 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala --- @@ -203,4 +212,12 @@

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21884 @shaneknapp the unit test build doesn't seem to be triggering on this PR, any idea as to what's going on? --- - To unsubscribe,

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21948 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanRow

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21921 addressed in https://github.com/apache/spark/pull/21948#discussion_r206999480 --- - To unsubscribe, e-mail:

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21948 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21948 cc @rdblue @jose-torres @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21948: [SPARK-24991][SQL] use InternalRow in DataSourceW...

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21948#discussion_r206999480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -89,8 +89,7 @@ class

[GitHub] spark issue #21946: [SPARK-24990][SQL] merge ReadSupport and ReadSupportWith...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21946 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21946: [SPARK-24990][SQL] merge ReadSupport and ReadSupportWith...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21946 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21948: [SPARK-24991][SQL] use InternalRow in DataSourceWriter

2018-08-01 Thread holdensmagicalunicorn
Github user holdensmagicalunicorn commented on the issue: https://github.com/apache/spark/pull/21948 @cloud-fan, thanks! I am a bot who has found some folks who might be able to help with the review:@gatorsmile, @zsxwing and @tdas ---

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21884 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1575/ ---

[GitHub] spark pull request #21948: [SPARK-24991][SQL] use InternalRow in DataSourceW...

2018-08-01 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/21948 [SPARK-24991][SQL] use InternalRow in DataSourceWriter ## What changes were proposed in this pull request? A follow up of #21118 Since we use `InternalRow` in the read API of

[GitHub] spark issue #19449: [SPARK-22219][SQL] Refactor code to get a value for "spa...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19449 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanRow

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21921 It sounds like Github is experiencing a very bad delay. @cloud-fan Could you submit a follow-up PR to address the comments from @rdblue ? ---

[GitHub] spark issue #19449: [SPARK-22219][SQL] Refactor code to get a value for "spa...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19449 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21884 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21884 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r206998585 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -669,6 +686,34 @@ private[spark] class AppStatusListener(

[GitHub] spark issue #21946: [SPARK-24990][SQL] merge ReadSupport and ReadSupportWith...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21946 **[Test build #93897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93897/testReport)** for PR 21946 at commit

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21884 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1575/ ---

[GitHub] spark issue #21671: [SPARK-24682] [SQL] from_json / to_json now handle java....

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21671 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r206995945 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21946: [SPARK-24990][SQL] merge ReadSupport and ReadSupportWith...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21946 **[Test build #93896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93896/testReport)** for PR 21946 at commit

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21921 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21103 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19449: [SPARK-22219][SQL] Refactor code to get a value for "spa...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19449 **[Test build #93895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93895/testReport)** for PR 19449 at commit

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21103 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21884 (Not sure why the unit test build didn't run just now, only the integration tests did) --- - To unsubscribe, e-mail:

[GitHub] spark issue #21884: [SPARK-24960][K8S] explicitly expose ports on driver con...

2018-08-01 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21884 jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanRow

2018-08-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21921 @rdblue I do not think it is documented. Let us be more conservative. Collect LGTM from the committers no matter whether the PR author is a committer or not. ---

[GitHub] spark issue #21947: [MINOR][DOCS] Add note about Spark network security

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21947 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21947: [MINOR][DOCS] Add note about Spark network security

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93892/ Test PASSed. ---

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21935 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93884/ Test FAILed. ---

[GitHub] spark issue #21947: [MINOR][DOCS] Add note about Spark network security

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21947 **[Test build #93892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93892/testReport)** for PR 21947 at commit

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21935 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #17185: [SPARK-19602][SQL] Support column resolution of f...

2018-08-01 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/17185#discussion_r206988504 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -120,22 +120,54 @@ abstract class LogicalPlan

[GitHub] spark issue #21935: [SPARK-24773] Avro: support logical timestamp type with ...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21935 **[Test build #93884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93884/testReport)** for PR 21935 at commit

[GitHub] spark issue #21895: [SPARK-24948][SHS] Delegate check access permissions to ...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21895 **[Test build #93894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93894/testReport)** for PR 21895 at commit

[GitHub] spark issue #21895: [SPARK-24948][SHS] Delegate check access permissions to ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21895 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21895: [SPARK-24948][SHS] Delegate check access permissions to ...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21895 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21943: [SPARK-24795][Core][FOLLOWUP] Kill all running tasks whe...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21943 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21943: [SPARK-24795][Core][FOLLOWUP] Kill all running tasks whe...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21943 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93882/ Test FAILed. ---

[GitHub] spark issue #21943: [SPARK-24795][Core][FOLLOWUP] Kill all running tasks whe...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21943 **[Test build #93882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93882/testReport)** for PR 21943 at commit

[GitHub] spark issue #21927: [SPARK-24820][SPARK-24821][Core] Fail fast when submitte...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21927 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21927: [SPARK-24820][SPARK-24821][Core] Fail fast when submitte...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21927 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93880/ Test PASSed. ---

<    1   2   3   4   5   6   7   8   9   >