Github user jzhuge commented on the issue:
https://github.com/apache/spark/pull/21911
Thanks @gatorsmile for the review and commit! Thanks @rdblue @mgaido91 for
the reviews!
---
-
To unsubscribe, e-mail:
Github user dvogelbacher commented on the issue:
https://github.com/apache/spark/pull/21993
@gatorsmile yes, I found that workaround. Very useful :)
I think it would still be good to handle this better by default. I can see
that introducing such an arbitrary configuration param
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21102
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21102
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94213/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21102
**[Test build #94213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94213/testReport)**
for PR 21102 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21975
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21975
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94211/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21975
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21975
**[Test build #94211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94211/testReport)**
for PR 21975 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94210/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21994
**[Test build #94210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94210/testReport)**
for PR 21994 at commit
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21985#discussion_r207712639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -446,3 +448,88 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21985#discussion_r207712323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -446,3 +448,88 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21956
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21956
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94212/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21956
**[Test build #94212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94212/testReport)**
for PR 21956 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20823
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21885
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21980
**[Test build #94215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94215/testReport)**
for PR 21980 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16677
**[Test build #94216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94216/testReport)**
for PR 16677 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16677
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21980
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21991#discussion_r207711059
--- Diff: dev/merge_spark_pr.py ---
@@ -154,20 +154,22 @@ def merge_pr(pr_num, target_ref, title, body,
pr_repo_desc):
# to people every time
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21987
**[Test build #4234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4234/testReport)**
for PR 21987 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94214/testReport)**
for PR 21898 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21898
I don't know why the `SparkSubmitSuite` keeps failing, they are definitely
not related to the changes, and I tested them in a local environment and the
tests are happy.
---
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207710500
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala ---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207710151
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21102
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21102
**[Test build #94213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94213/testReport)**
for PR 21102 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21102
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94209/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94209/testReport)**
for PR 21898 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94208/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21937
**[Test build #94208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94208/testReport)**
for PR 21937 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21994
**[Test build #94210 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94210/testReport)**
for PR 21994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21956
**[Test build #94212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94212/testReport)**
for PR 21956 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21975
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21975
**[Test build #94211 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94211/testReport)**
for PR 21975 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21975
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21994
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21956
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21975
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94204/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21991
**[Test build #94204 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94204/testReport)**
for PR 21991 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94207/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21982
**[Test build #94207 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94207/testReport)**
for PR 21982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94206/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94206/testReport)**
for PR 17185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94205/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21982
**[Test build #94205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94205/testReport)**
for PR 21982 at commit
Github user zecevicp commented on the issue:
https://github.com/apache/spark/pull/21109
That is a restriction if you regard this as an implementation of a range
join, which it is not. This is an *optimization of an equi join*. The intention
never was for it to work as a range join.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21898
LGTM except some nitpicking comments. The code is much cleaner than before,
great work!
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207704241
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala ---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207704198
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207704135
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207704089
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207704051
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207703995
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207703930
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207703895
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207702606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -123,7 +125,10 @@ trait
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207702742
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -94,4 +94,53 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207702649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -123,7 +125,10 @@ trait
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207703208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -210,3 +221,66 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94209 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94209/testReport)**
for PR 21898 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21898
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21109
> Regarding the second point, this is not an ordinary range join, but an
equi-join with a secondary range condition.
"an equi-join with a secondary range condition" is a restriction isn't
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207702706
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -536,12 +536,13 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207701939
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -316,8 +345,8 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207702684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/21996#discussion_r207702588
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -98,17 +98,24 @@ private[spark] class SparkSubmit extends Logging {
Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/21996
> I'm not sure how the PR title is related to the change here?
As an user perspective, when they don't see any o/p for status/kill
commands, they would probably assume that not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21966
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21997
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21966
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21982
**[Test build #94207 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94207/testReport)**
for PR 21982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21937
**[Test build #94208 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94208/testReport)**
for PR 21937 at commit
Github user YuvalItzchakov commented on the issue:
https://github.com/apache/spark/pull/21997
This is the same as https://github.com/apache/spark/pull/21983 only merged
against master (after @felixcheung comment). Should be merged to branch-2.3.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21997
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
201 - 300 of 398 matches
Mail list logo
