[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22746 **[Test build #97500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97500/testReport)** for PR 22746 at commit [`b3fc39d`](https://github.com/apache/spark/commit/b3

[GitHub] spark pull request #22746: [SPARK-24499][SQL][DOC] Split the page of sql-pro...

2018-10-17 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22746#discussion_r226011439 --- Diff: docs/sql-reference.md --- @@ -0,0 +1,641 @@ +--- +layout: global +title: Reference +displayTitle: Reference +--- +

[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22746 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22746: [SPARK-24499][SQL][DOC] Split the page of sql-pro...

2018-10-17 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22746#discussion_r226011057 --- Diff: docs/_data/menu-sql.yaml --- @@ -0,0 +1,79 @@ +- text: Getting Started + url: sql-getting-started.html + subitems: +- te

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22466 **[Test build #4381 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4381/testReport)** for PR 22466 at commit [`d290998`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22756 cc @holdenk @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97495/ Test PASSed. ---

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22756 **[Test build #97495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97495/testReport)** for PR 22756 at commit [`4761989`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-10-17 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22575#discussion_r225998489 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StreamTableDDLCommandSuite.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-10-17 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22575#discussion_r225997731 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -631,6 +631,33 @@ object SQLConf { .intConf

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4063/

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22288 **[Test build #97499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97499/testReport)** for PR 22288 at commit [`69c156b`](https://github.com/apache/spark/commit/69

[GitHub] spark pull request #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new...

2018-10-17 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22288#discussion_r225998426 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -415,9 +420,65 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-17 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22466 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22757 **[Test build #97498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97498/testReport)** for PR 22757 at commit [`47b8906`](https://github.com/apache/spark/commit/47

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22757 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4062/

[GitHub] spark issue #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor sig...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22732 At this point I think you both know more than I do about this, so go ahead. To the limits of my understanding it sounds reasonable. ---

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22721 what's the impact to end users? wrong statistics? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22757 CC @Fokko - unfortunately the build didn't catch this one because it didn't know enough to trigger Kinesis tests. --- - To unsubs

[GitHub] spark pull request #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 i...

2018-10-17 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22757 [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kinesis ## What changes were proposed in this pull request? Also update Kinesis SDK's Jackson to match Spark's ## How was this pat

[GitHub] spark issue #22725: [SPARK-25753][[CORE][FOLLOW-UP]fix reading small files v...

2018-10-17 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22725 +1 Looks good, thanks @10110346 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #21990: [SPARK-25003][PYSPARK] Use SessionExtensions in Pyspark

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21990 **[Test build #97497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97497/testReport)** for PR 21990 at commit [`3629c78`](https://github.com/apache/spark/commit/36

[GitHub] spark pull request #21990: [SPARK-25003][PYSPARK] Use SessionExtensions in P...

2018-10-17 Thread RussellSpitzer
Github user RussellSpitzer commented on a diff in the pull request: https://github.com/apache/spark/pull/21990#discussion_r225992993 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -1136,4 +1121,27 @@ object SparkSession extends Logging {

[GitHub] spark pull request #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-10-17 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22575#discussion_r225992780 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -63,7 +63,9 @@ private[kafka010] class

[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22751 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22503: [SPARK-25493][SQL] Use auto-detection for CRLF in CSV da...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22503 **[Test build #97496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97496/testReport)** for PR 22503 at commit [`040047b`](https://github.com/apache/spark/commit/04

[GitHub] spark issue #22503: [SPARK-25493][SQL] Use auto-detection for CRLF in CSV da...

2018-10-17 Thread justinuang
Github user justinuang commented on the issue: https://github.com/apache/spark/pull/22503 done! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark issue #22751: [SPARK-20327][yarn] Follow up: fix resource request test...

2018-10-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22751 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark pull request #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF construc...

2018-10-17 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22732#discussion_r225986215 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala --- @@ -179,7 +179,8 @@ class DynamicPartitionDa

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4061/

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20999 It seems like Hive can drop partitions directly with a partition expression: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/m

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22756 **[Test build #97495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97495/testReport)** for PR 22756 at commit [`4761989`](https://github.com/apache/spark/commit/47

[GitHub] spark pull request #22756: [SPARK-25758][ML] Deprecate computeCost on Bisect...

2018-10-17 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22756 [SPARK-25758][ML] Deprecate computeCost on BisectingKMeans ## What changes were proposed in this pull request? The PR proposes to deprecate the `computeCost` method on `BisectingKMeans` i

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22729 I think it's a legit failure. It touches a Kinesis test, and that has triggered what I assume is an existing problem in the Kinesis integration. It looks like it didn't like the fact that we updated

[GitHub] spark issue #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor sig...

2018-10-17 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/spark/pull/22732 @srowen What @cloud-fan described is a change introduced in #22259. We can fix it by keeping each call to `ScalaReflection.schemaFor` in their own `Try` blocks. As to `UserDefinedFunction`, a

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-17 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22721 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@sp

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22727 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftserver.sh:...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22727 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #22744: [SPARK-25741][WebUI] Long URLs are not rendered properly...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22744 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-10-17 Thread pgandhi999
Github user pgandhi999 commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r225964304 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,869 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-10-17 Thread pgandhi999
Github user pgandhi999 commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r225963998 --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala --- @@ -341,7 +341,9 @@ private class LiveExecutorStageSummary( metrics.

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #97494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97494/testReport)** for PR 21688 at commit [`7e486f1`](https://github.com/apache/spark/commit/7e

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-17 Thread onursatici
Github user onursatici commented on the issue: https://github.com/apache/spark/pull/22146 @ifilonenko I would like to get this merged as well, I think the only blocker for that is for us to decide how to specify the spark container in the pod template. @erikerlandson @mccheah Cu

[GitHub] spark issue #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor sig...

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22732 That's a good point, but that was already an issue right? it isn't introduced by this change at least? --- - To unsubscribe, e-m

[GitHub] spark pull request #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF construc...

2018-10-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22732#discussion_r225952267 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -39,29 +40,29 @@ import org.apache.spark.sql.types.

[GitHub] spark issue #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor sig...

2018-10-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22732 After more thoughts, there is one case we don't handle well. For UDFs like `(a: Any, i: Int) => xxx`, previously we can still get the int type info at runtime, and add null check for it. Now we ca

[GitHub] spark issue #20859: [SPARK-23702][SS] Forbid watermarks on both sides of sta...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20859 **[Test build #97493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97493/testReport)** for PR 20859 at commit [`b32b6a6`](https://github.com/apache/spark/commit/b3

[GitHub] spark pull request #22708: [SPARK-21402][SQL] Fix java array of structs dese...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22708 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22708 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97492/ Test PASSed. ---

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22219 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22219 **[Test build #97492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97492/testReport)** for PR 22219 at commit [`9158edc`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-17 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22746 This is cool +1 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark pull request #22746: [SPARK-24499][SQL][DOC] Split the page of sql-pro...

2018-10-17 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22746#discussion_r225921716 --- Diff: docs/sql-reference.md --- @@ -0,0 +1,641 @@ +--- +layout: global +title: Reference +displayTitle: Reference +--- +

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97491/ Test PASSed. ---

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22708 **[Test build #97491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97491/testReport)** for PR 22708 at commit [`46e942d`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-17 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r225908701 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -449,7 +450,7 @@ private[history] class FsHistoryProvider

[GitHub] spark issue #22753: [SPARK-25754][DOC] Change CDN for MathJax

2018-10-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22753 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22753 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97488/ Test PASSed. ---

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22708 **[Test build #97488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97488/testReport)** for PR 22708 at commit [`811e45a`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97487/ Test FAILed. ---

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22729 **[Test build #97487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97487/testReport)** for PR 22729 at commit [`0860d27`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22754: [MINOR][CORE]The disk write buffer size must be greater ...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22754 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97484/ Test PASSed. ---

[GitHub] spark issue #22754: [MINOR][CORE]The disk write buffer size must be greater ...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22754 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22754: [MINOR][CORE]The disk write buffer size must be greater ...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22754 **[Test build #97484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97484/testReport)** for PR 22754 at commit [`dfc4b65`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22750: [SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeR...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22750 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22750: [SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeR...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22750 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97486/ Test PASSed. ---

[GitHub] spark issue #22750: [SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeR...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22750 **[Test build #97486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97486/testReport)** for PR 22750 at commit [`318762c`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh s...

2018-10-17 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22748#discussion_r225867655 --- Diff: bin/docker-image-tool.sh --- @@ -78,20 +91,38 @@ function build { docker build $NOCACHEARG "${BUILD_ARGS[@]}" \ -t $(image_ref spark

[GitHub] spark pull request #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh s...

2018-10-17 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22748#discussion_r225867566 --- Diff: bin/docker-image-tool.sh --- @@ -44,28 +44,41 @@ function image_ref { function build { local BUILD_ARGS local IMG_PATH + loc

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22219 **[Test build #97492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97492/testReport)** for PR 22219 at commit [`9158edc`](https://github.com/apache/spark/commit/91

[GitHub] spark issue #22749: [WIP][SPARK-25746][SQL] Refactoring ExpressionEncoder to...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22749 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22749: [WIP][SPARK-25746][SQL] Refactoring ExpressionEncoder to...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22749 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97485/ Test FAILed. ---

[GitHub] spark issue #22749: [WIP][SPARK-25746][SQL] Refactoring ExpressionEncoder to...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22749 **[Test build #97485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97485/testReport)** for PR 22749 at commit [`25a6162`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh script

2018-10-17 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22748 > There seems to be overlapping logic between this PR and #22681 Yes sorry, I was having issues with the script while working on something unrelated and hadn't realised your integration tests

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 Looks good otherwise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviou...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20503#discussion_r225846867 --- Diff: python/pyspark/sql/types.py --- @@ -1581,7 +1581,7 @@ def __repr__(self): return "Row(%s)" % ", ".join("%s=%r" % (k, v)

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-17 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r225846631 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala --- @@ -64,4 +64,11 @@ private[spark] object config { .bytesConf

[GitHub] spark pull request #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviou...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20503#discussion_r225846669 --- Diff: python/pyspark/sql/types.py --- @@ -1581,7 +1581,7 @@ def __repr__(self): return "Row(%s)" % ", ".join("%s=%r" % (k, v)

[GitHub] spark pull request #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviou...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20503#discussion_r225846584 --- Diff: python/pyspark/sql/types.py --- @@ -1581,7 +1581,7 @@ def __repr__(self): return "Row(%s)" % ", ".join("%s=%r" % (k, v)

[GitHub] spark pull request #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviou...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20503#discussion_r225846381 --- Diff: python/pyspark/sql/tests.py --- @@ -234,6 +234,10 @@ def test_empty_row(self): row = Row() self.assertEqual(len(row),

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-17 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r225845782 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -449,7 +450,7 @@ private[history] class FsHistoryProvider

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-17 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20999 any more comments @cloud-fan @maropu @viirya ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviou...

2018-10-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20503#discussion_r225844655 --- Diff: python/pyspark/sql/tests.py --- @@ -234,6 +234,10 @@ def test_empty_row(self): row = Row() self.assertEqual(len(row),

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22708 **[Test build #97491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97491/testReport)** for PR 22708 at commit [`46e942d`](https://github.com/apache/spark/commit/46

[GitHub] spark pull request #22708: [SPARK-21402][SQL] Fix java array of structs dese...

2018-10-17 Thread vofque
Github user vofque commented on a diff in the pull request: https://github.com/apache/spark/pull/22708#discussion_r225840666 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanWithMapSuite.java --- @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22708 **[Test build #97490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97490/testReport)** for PR 22708 at commit [`b1f74ac`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97490/ Test FAILed. ---

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22708 **[Test build #97490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97490/testReport)** for PR 22708 at commit [`b1f74ac`](https://github.com/apache/spark/commit/b1

[GitHub] spark pull request #22708: [SPARK-21402][SQL] Fix java array of structs dese...

2018-10-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22708#discussion_r225834919 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanWithMapSuite.java --- @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark issue #22708: [SPARK-21402][SQL] Fix java array of structs deserializa...

2018-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22708 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

<    1   2   3   4   >