[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...

2018-10-29 Thread mt40
Github user mt40 commented on a diff in the pull request: https://github.com/apache/spark/pull/22309#discussion_r228863565 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -373,6 +383,32 @@ object ScalaReflection extends

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22873 @viirya I think we can remove it as it is used nowhere. The point is: even if we remove it, we will remove it only on 3.0, so for 2.4 we should anyway fix this IMO. ---

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22873 Are we considering to remove it? If no, as `save` now calls `SaveLoadV2_0`, it seems good to update this variable. --- - To

[GitHub] spark issue #22874: [SPARK-25865][WIP][CORE] Add GC information to ExecutorM...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22874 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22873 cc @cloud-fan @huaxingao @mengxr @WeichenXu123 @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22874: [WIP][SPARK-25865][CORE] Add GC information to ExecutorM...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22874 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22874: [SPARK-25865][WIP][CORE] Add GC information to ExecutorM...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22874 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22874: [WIP][SPARK-25865][CORE] Add GC information to Ex...

2018-10-29 Thread LantaoJin
GitHub user LantaoJin opened a pull request: https://github.com/apache/spark/pull/22874 [WIP][SPARK-25865][CORE] Add GC information to ExecutorMetrics ## What changes were proposed in this pull request? This PR is opened on top of the PR for #22612 since it import an

[GitHub] spark pull request #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22873 [SPARK-25866][ML] Update KMeans formatVersion ## What changes were proposed in this pull request? When we added the `distanceMeasure`, we didn't update the `formatVersion` for `KMeans`.

[GitHub] spark pull request #22868: [SPARK-25833][SQL][DOCS] Update migration guide f...

2018-10-29 Thread seancxmao
Github user seancxmao commented on a diff in the pull request: https://github.com/apache/spark/pull/22868#discussion_r228845332 --- Diff: docs/sql-migration-guide-hive-compatibility.md --- @@ -51,6 +51,9 @@ Spark SQL supports the vast majority of Hive features, such as: *

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-29 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r228844982 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -298,30 +312,40 @@ class KryoDeserializationStream( } }

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22830 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks ...

2018-10-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22844#discussion_r228841276 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala --- @@ -16,32 +16,33 @@ */ package

[GitHub] spark issue #22856: [SPARK-25856][SQL][MINOR] Remove AverageLike and CountLi...

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22856 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22830: [SPARK-25838][ML] Remove formatVersion from Savea...

2018-10-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22830#discussion_r228839435 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -163,8 +163,6 @@ class LogisticRegressionModel

[GitHub] spark issue #15599: [SPARK-18022][SQL] java.lang.NullPointerException instea...

2018-10-29 Thread shatestest
Github user shatestest commented on the issue: https://github.com/apache/spark/pull/15599 @uzadude sir I am getting same error in spark-sql 2.3.1 version

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98193/testReport)** for PR 22844 at commit

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22830 this was introduced by @jkbradley in https://github.com/apache/spark/commit/975bcef467b35586e5224171071355409f451d2d. --- - To

[GitHub] spark pull request #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks ...

2018-10-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22844#discussion_r228832524 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala --- @@ -16,32 +16,30 @@ */ package

[GitHub] spark pull request #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks ...

2018-10-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22844#discussion_r228832419 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala --- @@ -16,32 +16,30 @@ */ package

[GitHub] spark pull request #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks t...

2018-10-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22845#discussion_r228831997 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmarks.scala --- @@ -16,30 +16,30 @@ */ package

[GitHub] spark pull request #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks t...

2018-10-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22845#discussion_r228831306 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmarks.scala --- @@ -16,30 +16,30 @@ */ package

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-29 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r228830146 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98192/testReport)** for PR 22844 at commit

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98189/ Test FAILed. ---

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98189/testReport)** for PR 22845 at commit

[GitHub] spark pull request #22514: [SPARK-25271][SQL] Hive ctas commands should use ...

2018-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22514#discussion_r228825355 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala --- @@ -45,6 +46,11 @@ case class

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22870 **[Test build #98191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98191/testReport)** for PR 22870 at commit

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22870 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22817: [SPARK-25816][SQL] Fix attribute resolution in nested ex...

2018-10-29 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22817 Thanks @dongjoon-hyun , @gatorsmile, @cloud-fan , @hvanhovell for the review. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21732: [SPARK-24762][SQL] Enable Option of Product encod...

2018-10-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21732#discussion_r228820434 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala --- @@ -362,4 +362,38 @@ class ScalaReflectionSuite extends

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98190/testReport)** for PR 22847 at commit

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-29 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22847 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98188/ Test FAILed. ---

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98188/testReport)** for PR 22872 at commit

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98189/testReport)** for PR 22845 at commit

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98188/testReport)** for PR 22872 at commit

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-29 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22861 Current implementation misses main args, but some suite would need it anyway. Let's can discuss #22872. --- - To

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98187/testReport)** for PR 22872 at commit

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22872 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22872 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22872 @gengliangwang @dongjoon-hyun @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22514: [SPARK-25271][SQL] Hive ctas commands should use ...

2018-10-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22514#discussion_r228817044 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala --- @@ -45,6 +46,11 @@ case class

[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98185/testReport)** for PR 22872 at commit

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22721 **[Test build #98186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98186/testReport)** for PR 22721 at commit

[GitHub] spark pull request #22872: [SPARK-25864][SQL][TEST] Make main args accessibl...

2018-10-29 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/22872 [SPARK-25864][SQL][TEST] Make main args accessible for BenchmarkBase's subclass ## What changes were proposed in this pull request? Set main args correctly in BenchmarkBase, to make it

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22721 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98184/ Test FAILed. ---

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98179/ Test FAILed. ---

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22530 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98183/ Test FAILed. ---

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98181/ Test FAILed. ---

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22530 **[Test build #98183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98183/testReport)** for PR 22530 at commit

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98182/ Test FAILed. ---

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22721 **[Test build #98181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98181/testReport)** for PR 22721 at commit

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22870 **[Test build #98184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98184/testReport)** for PR 22870 at commit

[GitHub] spark pull request #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migrat...

2018-10-29 Thread seancxmao
Github user seancxmao closed the pull request at: https://github.com/apache/spark/pull/22851 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98179/testReport)** for PR 22830 at commit

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98182/testReport)** for PR 22847 at commit

[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22530 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-29 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22851 Closing this. Thank you @dongjoon-hyun @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22514: [SPARK-25271][SQL] Hive ctas commands should use ...

2018-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22514#discussion_r228816243 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala --- @@ -45,6 +46,11 @@ case class

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22870 **[Test build #98184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98184/testReport)** for PR 22870 at commit

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22514: [SPARK-25271][SQL] Hive ctas commands should use ...

2018-10-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22514#discussion_r228813738 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala --- @@ -45,6 +46,11 @@ case class

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22870 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22871: [SPARK-25179][PYTHON][DOCS] Document BinaryType support ...

2018-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22871 Thanks, @dongjoon-hyun and @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98180/ Test FAILed. ---

[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22870 **[Test build #98180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98180/testReport)** for PR 22870 at commit

[GitHub] spark issue #22813: [SPARK-25818][CORE] WorkDirCleanup should only remove th...

2018-10-29 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/22813 @dongjoon-hyun Yes, you can think so. So I want to solve this problem on the spark platform to reduce the risk of some misoperations of operation and maintenance engineer. `WorkDirCleanUp

[GitHub] spark issue #22813: [SPARK-25818][CORE] WorkDirCleanup should only remove th...

2018-10-29 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/22813 As far as I know, when a spark program is submitted to the cluster, a directory will be created under `SPARK_WORK_DIR`. The directory name consists of application, timestamp, and five-digit

[GitHub] spark pull request #22871: [SPARK-25179][PYTHON][DOCS] Document BinaryType s...

2018-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22871 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

<    1   2   3   4   5   6