Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228863565
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -373,6 +383,32 @@ object ScalaReflection extends
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22873
@viirya I think we can remove it as it is used nowhere. The point is: even
if we remove it, we will remove it only on 3.0, so for 2.4 we should anyway fix
this IMO.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22873
Are we considering to remove it? If no, as `save` now calls `SaveLoadV2_0`,
it seems good to update this variable.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22874
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22873
cc @cloud-fan @huaxingao @mengxr @WeichenXu123 @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22874
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22874
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user LantaoJin opened a pull request:
https://github.com/apache/spark/pull/22874
[WIP][SPARK-25865][CORE] Add GC information to ExecutorMetrics
## What changes were proposed in this pull request?
This PR is opened on top of the PR for #22612 since it import an
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/22873
[SPARK-25866][ML] Update KMeans formatVersion
## What changes were proposed in this pull request?
When we added the `distanceMeasure`, we didn't update the `formatVersion`
for `KMeans`.
Github user seancxmao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22868#discussion_r228845332
--- Diff: docs/sql-migration-guide-hive-compatibility.md ---
@@ -51,6 +51,9 @@ Spark SQL supports the vast majority of Hive features,
such as:
*
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22855#discussion_r228844982
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -298,30 +312,40 @@ class KryoDeserializationStream(
}
}
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22830
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22844#discussion_r228841276
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
@@ -16,32 +16,33 @@
*/
package
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22856
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22830#discussion_r228839435
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -163,8 +163,6 @@ class LogisticRegressionModel
Github user shatestest commented on the issue:
https://github.com/apache/spark/pull/15599
@uzadude sir I am getting same error in spark-sql 2.3.1 version
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22844
**[Test build #98193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98193/testReport)**
for PR 22844 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22830
this was introduced by @jkbradley in
https://github.com/apache/spark/commit/975bcef467b35586e5224171071355409f451d2d.
---
-
To
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22844#discussion_r228832524
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
@@ -16,32 +16,30 @@
*/
package
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22844#discussion_r228832419
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
@@ -16,32 +16,30 @@
*/
package
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22845#discussion_r228831997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmarks.scala
---
@@ -16,30 +16,30 @@
*/
package
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22845#discussion_r228831306
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmarks.scala
---
@@ -16,30 +16,30 @@
*/
package
Github user LantaoJin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r228830146
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -394,9 +394,15 @@ private[spark] object JsonProtocol {
/**
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22844
**[Test build #98192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98192/testReport)**
for PR 22844 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98189/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22845
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22845
**[Test build #98189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98189/testReport)**
for PR 22845 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228825355
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -45,6 +46,11 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22870
**[Test build #98191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98191/testReport)**
for PR 22870 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22870
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user peter-toth commented on the issue:
https://github.com/apache/spark/pull/22817
Thanks @dongjoon-hyun , @gatorsmile, @cloud-fan , @hvanhovell for the
review.
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21732#discussion_r228820434
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -362,4 +362,38 @@ class ScalaReflectionSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98190/testReport)**
for PR 22847 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22847
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98188/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22872
**[Test build #98188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98188/testReport)**
for PR 22872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22845
**[Test build #98189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98189/testReport)**
for PR 22845 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22872
**[Test build #98188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98188/testReport)**
for PR 22872 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22861
Current implementation misses main args, but some suite would need it
anyway.
Let's can discuss #22872.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22872
**[Test build #98187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98187/testReport)**
for PR 22872 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22872
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22872
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22872
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22872
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22872
@gengliangwang @dongjoon-hyun @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228817044
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -45,6 +46,11 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22872
**[Test build #98185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98185/testReport)**
for PR 22872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22721
**[Test build #98186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98186/testReport)**
for PR 22721 at commit
GitHub user yucai opened a pull request:
https://github.com/apache/spark/pull/22872
[SPARK-25864][SQL][TEST] Make main args accessible for BenchmarkBase's
subclass
## What changes were proposed in this pull request?
Set main args correctly in BenchmarkBase, to make it
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22721
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98184/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98179/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22530
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98183/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22721
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98181/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22530
**[Test build #98183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98183/testReport)**
for PR 22530 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98182/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22721
**[Test build #98181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98181/testReport)**
for PR 22721 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22870
**[Test build #98184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98184/testReport)**
for PR 22870 at commit
Github user seancxmao closed the pull request at:
https://github.com/apache/spark/pull/22851
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22830
**[Test build #98179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98179/testReport)**
for PR 22830 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98182/testReport)**
for PR 22847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22530
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22851
Closing this. Thank you @dongjoon-hyun @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228816243
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -45,6 +46,11 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22870
**[Test build #98184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98184/testReport)**
for PR 22870 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228813738
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -45,6 +46,11 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22870
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22871
Thanks, @dongjoon-hyun and @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22870
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98180/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22870
**[Test build #98180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98180/testReport)**
for PR 22870 at commit
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/22813
@dongjoon-hyun Yes, you can think so. So I want to solve this problem on
the spark platform to reduce the risk of some misoperations of operation and
maintenance engineer. `WorkDirCleanUp
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/22813
As far as I know, when a spark program is submitted to the cluster, a
directory will be created under `SPARK_WORK_DIR`. The directory name consists
of application, timestamp, and five-digit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22871
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
501 - 585 of 585 matches
Mail list logo