Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22962#discussion_r232448083
--- Diff: python/pyspark/taskcontext.py ---
@@ -144,10 +144,19 @@ def __init__(self):
"""Construct a BarrierTaskContext, use get instead"""
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232447827
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -50,20 +50,11 @@ class Pul
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232447937
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -0,0 +1,171 @@
+/*
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22962#discussion_r232447967
--- Diff: python/pyspark/taskcontext.py ---
@@ -144,10 +144,19 @@ def __init__(self):
"""Construct a BarrierTaskContext, use get instead"""
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22962
@xuanyuanking, mind explaining how and why it happens rather then what
happens in PR description?
---
-
To unsubscribe, e-ma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22955
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4910/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22955
**[Test build #98676 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98676/testReport)**
for PR 22955 at commit
[`38b1555`](https://github.com/apache/spark/commit/38
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22962#discussion_r232447862
--- Diff: python/pyspark/tests.py ---
@@ -614,6 +614,18 @@ def context_barrier(x):
times =
rdd.barrier().mapPartitions(f).map(context_barri
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22955
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r232447655
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
Array("lo
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21161
I think it has fixed by
[SPARK-21479](https://issues.apache.org/jira/browse/SPARK-21479).
---
-
To unsubscribe, e-mail: reviews-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22932
double checked. A late LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22994
I agree with this change. The current script is a total mess - I will try
to help take a look when the tests pass. BTW, it would be awesome if PR
description contains what this PR tries to fix l
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r232447366
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
Array("lo
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22963
I also agree with @srowen's
(https://github.com/apache/spark/pull/22963#issuecomment-437133365)
---
-
To unsubscribe, e-mail
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22893
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22938#discussion_r232446781
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -15,6 +15,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 3.0, the `from_json` f
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22938#discussion_r232446534
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -550,15 +550,33 @@ case class JsonToStructs(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r232446160
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
Array("logi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r232445980
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
Array("logi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #98675 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98675/testReport)**
for PR 22899 at commit
[`3a32007`](https://github.com/apache/spark/commit/3a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4909/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22899
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98674/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #98674 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98674/testReport)**
for PR 22899 at commit
[`3a32007`](https://github.com/apache/spark/commit/3
201 - 228 of 228 matches
Mail list logo
