[GitHub] spark pull request #23031: [SPARK-26060][SQL] Track SparkConf entries and ma...

2018-11-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23031#discussion_r234314374 --- Diff: docs/sql-migration-guide-upgrade.md --- @@ -17,6 +17,8 @@ displayTitle: Spark SQL Upgrading Guide - The `ADD JAR` command previously re

[GitHub] spark pull request #23059: [SPARK-26091][SQL] Upgrade to 2.3.4 for Hive Meta...

2018-11-16 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/23059 [SPARK-26091][SQL] Upgrade to 2.3.4 for Hive Metastore Client 2.3 ## What changes were proposed in this pull request? Hive 2.3.4 is released on [Nov. 7th](https://issues.apache.org/j

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22952 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22952 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22952 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98919/ Test PASSed. ---

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22952 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98917/ Test PASSed. ---

[GitHub] spark pull request #23038: [SPARK-25451][CORE][WEBUI]Aggregated metrics tabl...

2018-11-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23038#discussion_r234311257 --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala --- @@ -376,6 +376,8 @@ private class LiveStage extends LiveEntity { val e

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22952 **[Test build #98917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98917/testReport)** for PR 22952 at commit [`3f6b5fb`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22952: [SPARK-20568][SS] Provide option to clean up completed f...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22952 **[Test build #98919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98919/testReport)** for PR 22952 at commit [`ca26b41`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #23058: [SPARK-25905][CORE] When getting a remote block, avoid f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23058 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23058: [SPARK-25905][CORE] When getting a remote block, avoid f...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23058 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5083/

[GitHub] spark issue #23058: [SPARK-25905][CORE] When getting a remote block, avoid f...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23058 **[Test build #98923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98923/testReport)** for PR 23058 at commit [`2516ec6`](https://github.com/apache/spark/commit/25

[GitHub] spark pull request #23058: [SPARK-25905][CORE] When getting a remote block, ...

2018-11-16 Thread wypoon
GitHub user wypoon opened a pull request: https://github.com/apache/spark/pull/23058 [SPARK-25905][CORE] When getting a remote block, avoid forcing a conversion to a ChunkedByteBuffer ## What changes were proposed in this pull request? In `BlockManager`, `getRemoteValues` g

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-16 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23049 I'm not sure this is actually helping much or making things less confusing. If `spark-env.sh` doesn't exist, your message will tell people to modify a file that doesn't exist. If it'

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r234304621 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -598,13 +597,25 @@ private[yarn] class YarnAllocator

[GitHub] spark pull request #23039: [SPARK-26066][SQL] Move truncatedString to sql/ca...

2018-11-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/23039#discussion_r234303428 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/UtilsSuite.scala --- @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-16 Thread adoron
Github user adoron commented on the issue: https://github.com/apache/spark/pull/23043 @cloud-fan that's what I thought as well at first, but the flow doesn't go through that code - running `Seq(0.0d, 0.0d, -0.0d).toDF("i").groupBy("i").count().collect()` and adding a breakpoint.

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23039 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98915/ Test PASSed. ---

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23039 **[Test build #98915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98915/testReport)** for PR 23039 at commit [`7180c2e`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegratio...

2018-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23041 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-16 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/23041 Thanks. Merging to master and 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-16 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r234286173 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala --- @@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN, OUT](

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5082/

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23045 **[Test build #98922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98922/testReport)** for PR 23045 at commit [`d231ff5`](https://github.com/apache/spark/commit/d2

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 Looking at `UnsafeRow.putFloat`, it normalizes the value of `Float.NaN`. I think we should do the same there for `-0.0`, and other related places (check how we handle Float.NaN). --- -

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23043 They do, FWIW: ``` scala> java.lang.Double.doubleToLongBits(0.0) res1: Long = 0 scala> java.lang.Double.doubleToLongBits(-0.0) res2: Long = -9223372036854775808 ``` ---

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 Before rushing to a fix that replaces -0.0 to 0.0, I'd like to know how this bug happens. One possible reason might be, 0.0 and -0.0 have different binary format. Spark use unsafe API to

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23052 I think now it should be good timing to match the behaviours. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2018-11-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18784 Go for it. On Fri, Nov 16, 2018 at 6:08 AM Stavros Kontopoulos < notificati...@github.com> wrote: > @imaxxs @rxin I > think

[GitHub] spark pull request #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/te...

2018-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23056 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py ...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23056 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py ...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23056 @BryanCutler, let me merge this. Let's do the ML one and then clean up both comments throughout ML and MLlib at once. --- -

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23052 related another try https://github.com/apache/spark/pull/13252 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23052 One try to add some tests for reading/writing empty dataframes was here https://github.com/apache/spark/pull/13253 fyi --- -

[GitHub] spark pull request #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_...

2018-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22937 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23052 Which should be ... this https://github.com/apache/spark/pull/12855 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22937 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22937 If there are no further comments from Mesos experts and you're confident in the change; it seems reasonable to me. --- - To unsub

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22598 **[Test build #98921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98921/testReport)** for PR 22598 at commit [`2a0cdb7`](https://github.com/apache/spark/commit/2a

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-16 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 Hi @dongjoon-hyun anything I can do to help move this along? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-16 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/22598 retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-11-16 Thread jianpan
Github user jianpan commented on the issue: https://github.com/apache/spark/pull/21632 Is there an ETA when this will be merged to master? Allowing sample weights is an important enhancements. Thanks. --- - To unsu

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98920/testReport)** for PR 23057 at commit [`a71b1c6`](https://github.com/apache/spark/commit/a7

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5081/

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/23057 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22952: [SPARK-20568][SS] Rename files which are completed in pr...

2018-11-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/22952 @zsxwing @dongjoon-hyun @steveloughran Thanks all for the valuable feedback! I applied review comments. While I covered the new feature with new UTs, I'm yet to test this manually w

[GitHub] spark issue #22952: [SPARK-20568][SS] Rename files which are completed in pr...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22952 **[Test build #98919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98919/testReport)** for PR 22952 at commit [`ca26b41`](https://github.com/apache/spark/commit/ca

[GitHub] spark issue #22952: [SPARK-20568][SS] Rename files which are completed in pr...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22952 **[Test build #98918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98918/testReport)** for PR 22952 at commit [`33c5681`](https://github.com/apache/spark/commit/33

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98914/ Test FAILed. ---

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98914/testReport)** for PR 23057 at commit [`a71b1c6`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98916/ Test PASSed. ---

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23030 **[Test build #98916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98916/testReport)** for PR 23030 at commit [`66b3e7f`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #22952: [SPARK-20568][SS] Rename files which are completed in pr...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22952 **[Test build #98917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98917/testReport)** for PR 22952 at commit [`3f6b5fb`](https://github.com/apache/spark/commit/3f

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5080/

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23030 **[Test build #98916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98916/testReport)** for PR 23030 at commit [`66b3e7f`](https://github.com/apache/spark/commit/66

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/23057 Thanks @mgaido91. I will review this tomorrow. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional c

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-16 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r234233444 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -735,18 +744,8 @@ private[yarn] class YarnAllocator

[GitHub] spark pull request #23013: [SPARK-25023] More detailed security guidance for...

2018-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23013 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r234232203 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -735,18 +744,8 @@ private[yarn] class YarnAllocator(

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23013 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #18784: [SPARK-21559][Mesos] remove mesos fine-grained mode

2018-11-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/18784 @imaxxs @rxin I think its a good time to remove this, I will update the PR if you are all ok. --- - To unsubscribe, e-mail: revie

[GitHub] spark issue #23017: [SPARK-26015][K8S] Set a default UID for Spark on K8S Im...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23017 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23017: [SPARK-26015][K8S] Set a default UID for Spark on K8S Im...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23017 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98911/ Test PASSed. ---

[GitHub] spark pull request #23052: [SPARK-26081][SQL] Prevent empty files for empty ...

2018-11-16 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/23052#discussion_r234211079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala --- @@ -174,13 +174,18 @@ private[csv] class CsvOutput

[GitHub] spark issue #23017: [SPARK-26015][K8S] Set a default UID for Spark on K8S Im...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23017 **[Test build #98911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98911/testReport)** for PR 23017 at commit [`8f4fd19`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23039 **[Test build #98915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98915/testReport)** for PR 23039 at commit [`7180c2e`](https://github.com/apache/spark/commit/71

[GitHub] spark issue #22979: [SPARK-25977][SQL] Parsing decimals from CSV using local...

2018-11-16 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22979 @HyukjinKwon Could you take a look at this one more time, please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-16 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23052 > Similar changes were proposed in Parquet few years ago (by me) and reverted. What was the main reason to revert it? If it is possible could you give me a link to your PR. --- -

[GitHub] spark pull request #22779: [SPARK-25786][CORE]If the ByteBuffer.hasArray is ...

2018-11-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22779#discussion_r234204540 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -497,6 +498,17 @@ class KryoSerializerAutoResetDisabledSuite extend

[GitHub] spark pull request #23039: [SPARK-26066][SQL] Move truncatedString to sql/ca...

2018-11-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23039#discussion_r234202827 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1594,6 +1594,13 @@ object SQLConf { "WHERE, which does

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-16 Thread nrchakradhar
Github user nrchakradhar commented on the issue: https://github.com/apache/spark/pull/23013 The description is very useful and concise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22598 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22598 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98912/ Test FAILed. ---

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22598 **[Test build #98912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98912/testReport)** for PR 22598 at commit [`2a0cdb7`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98914/testReport)** for PR 23057 at commit [`a71b1c6`](https://github.com/apache/spark/commit/a7

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5079/

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98913/ Test FAILed. ---

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98913/testReport)** for PR 23057 at commit [`2af656a`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98913/testReport)** for PR 23057 at commit [`2af656a`](https://github.com/apache/spark/commit/2a

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98908/ Test PASSed. ---

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5078/

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23049 **[Test build #98908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98908/testReport)** for PR 23049 at commit [`3269862`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-16 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/23057 [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries ## What changes were proposed in this pull request? When there is a self-join as result of a IN subquery, the join condition

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/23057 cc @cloud-fan @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98909/ Test PASSed. ---

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22138 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22138 **[Test build #98909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98909/testReport)** for PR 22138 at commit [`fd4ff83`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py ...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98906/ Test PASSed. ---

[GitHub] spark issue #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py ...

2018-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23056 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23056: [SPARK-26034][PYTHON][TESTS] Break large mllib/tests.py ...

2018-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23056 **[Test build #98906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98906/testReport)** for PR 23056 at commit [`2759521`](https://github.com/apache/spark/commit/2

<    1   2   3   4   5   >