Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23262
**[Test build #99903 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99903/testReport)**
for PR 23262 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99901/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23271
**[Test build #99901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99901/testReport)**
for PR 23271 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23251
cc @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23262
LGTM, can you update the PR title and description?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23270
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99898/
Test FAILed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240180713
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -416,7 +416,12 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23270
**[Test build #99898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99898/testReport)**
for PR 23270 at commit
Github user eatoncys commented on the issue:
https://github.com/apache/spark/pull/23262
@HyukjinKwon Ok, removed it, thanks for review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23272
have you seen any bug report caused by this dead lock?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240178993
--- Diff:
core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java ---
@@ -38,12 +38,14 @@ public long spill(long size, MemoryConsumer trigger)
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22764
kindly ping @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23273
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99909/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23273
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23273
**[Test build #99909 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99909/testReport)**
for PR 23273 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23262
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99899/
Test FAILed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23262
Let's remove. No point of keeping unused method. The code will remain in
the commit anyway. Also, there's no quite good point of keeping few lines
method that's called only at one place.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23262
**[Test build #99899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99899/testReport)**
for PR 23262 at commit
Github user eatoncys commented on the issue:
https://github.com/apache/spark/pull/23262
@HyukjinKwon @mgaido91 Thanks for review. @cloud-fan @kiszk Would you like
to give some suggestions: remove the object `RDDConversions` , or leave it
there?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22707
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99905/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22707
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22707
**[Test build #99905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99905/testReport)**
for PR 22707 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23156
@gaborgsomogyi No problem :) When you get some other times please take a
look at my other PRs as well.
---
-
To
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/23156
BTW, coming back to your clean up PR but it takes some time to switch
context :)
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99904/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23268
**[Test build #99904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99904/testReport)**
for PR 23268 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/23156
Ah, ok. This solution was agreed with him on
https://github.com/apache/spark/pull/20936.
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240170574
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -255,11 +255,18 @@ private MapIterator(int numRecords, Location loc,
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23156
I think @jose-torres previously led the feature.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23057
@cloud-fan @gatorsmile may you please take a look at this? Thanks.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23259
+1 for SQL 2011. I downloaded the standard but I couldn't find any section
dedicated to, In postgres doc, though, they are stating that they are not
following the standard strictly:
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/23156
I thought this part is not affected. Who leads it? Asking it because
haven't seen progress anywhere.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23269
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23269
**[Test build #99908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99908/testReport)**
for PR 23269 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23269
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99908/
Test FAILed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23202
Similar discussion is going on at
https://github.com/apache/spark/pull/23201#discussion_r240156871. Let me keep
tracking them. Sorry for late response, @MaxGekk
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/23156
I'd rather not jumping in something regarding continuous mode unless the
overall design (including aggregation and join) of continuous mode is cleared
and stabilized.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23201#discussion_r240156871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
---
@@ -121,7 +122,26 @@ private[sql] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23201#discussion_r240153595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
---
@@ -121,7 +122,26 @@ private[sql] class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23262
LGTM otheriwse
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240151214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -17,51 +17,39 @@
package
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/23268
@HyukjinKwon I've updated the desc.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user seancxmao commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r240148392
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23132
> mind fixing PR description accordingly?
@HyukjinKwon fixed
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r240146706
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240146031
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -255,11 +255,18 @@ private MapIterator(int numRecords, Location
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240144674
--- Diff:
core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
---
@@ -667,4 +668,53 @@ public void testPeakMemoryUsed()
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23273
**[Test build #99909 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99909/testReport)**
for PR 23273 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23273
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23273
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user seancxmao opened a pull request:
https://github.com/apache/spark/pull/23273
[SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation
rule
## What changes were proposed in this pull request?
There are some comments issues left when
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23269
**[Test build #99908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99908/testReport)**
for PR 23269 at commit
Github user aditanase commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r240141774
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23269
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23269
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23269
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240141142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -17,51 +17,39 @@
package
Github user fjh100456 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r240139057
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -227,18 +227,22 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21109
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99907/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21109
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21109
**[Test build #99907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99907/testReport)**
for PR 21109 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21109
**[Test build #99907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99907/testReport)**
for PR 21109 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240134191
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -17,51 +17,39 @@
package
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240135694
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -17,51 +17,39 @@
package
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22957
**[Test build #99906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99906/testReport)**
for PR 22957 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22957
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22683
Looks okay to me too. UI change requires screenshots of UI tho strictly.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23268
Let's fix PR description as well. You can leave the comments above resolved.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23249#discussion_r240123260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -262,6 +261,15 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22707
**[Test build #99905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99905/testReport)**
for PR 22707 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22707
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22707
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maomaoChibei commented on a diff in the pull request:
https://github.com/apache/spark/pull/23268#discussion_r240126376
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -53,19 +53,12 @@ private[hive] object HiveShim {
* This
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/23268
@HyukjinKwon Please re-review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23268
**[Test build #99904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99904/testReport)**
for PR 23268 at commit
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/23268
I've revert the refactor commit.
I'm wondering if I need to create a issue for a unit test only PR.
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23269
hmm, I think the PR title is too long...Maybe just `Revert hash join
metrics that causes performance degradation`?
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23272
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23269
@viirya ok I will update. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23262
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23271
cc @rxin and @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23262
**[Test build #99903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99903/testReport)**
for PR 23262 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23271#discussion_r240115920
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -58,8 +58,21 @@ object Row {
* Merge multiple rows into a single
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23228
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23228
**[Test build #99902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99902/testReport)**
for PR 23228 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23272
**[Test build #99900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99900/testReport)**
for PR 23272 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23271
**[Test build #99901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99901/testReport)**
for PR 23271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23272
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23272
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23271
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
701 - 800 of 826 matches
Mail list logo
