[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446490616 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446490616 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446490610 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446490610 Merged build finished. Test PASSed.

[GitHub] SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446490498 **[Test build #19 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] sadhen commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
sadhen commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446490065 OK, I will polish it later. This is an automated message from the Apache Gi

[GitHub] AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446488548 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446488546 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446488546 Merged build finished. Test FAILed. This is

[GitHub] SparkQA removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446475933 **[Test build #17 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446488548 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] SparkQA commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
SparkQA commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446488365 **[Test build #17 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17/testR

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446486859 Test FAILed. Refer to this link for build results (access rights to

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446486855 Merged build finished. Test FAILed. --

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446486855 Merged build finished. Test FAILed. --

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446486859 Test FAILed. Refer to this link for build results (access rights to CI serve

[GitHub] SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446442398 **[Test build #11 has started](https://amplab.cs.berkeley.edu/jenkins/jo

[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446486573 **[Test build #11 has finished](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] kiszk commented on issue #23294: [SPARK-26265][Core][Followup] Put freePage into a finally block

2018-12-11 Thread GitBox
kiszk commented on issue #23294: [SPARK-26265][Core][Followup] Put freePage into a finally block URL: https://github.com/apache/spark/pull/23294#issuecomment-446485354 LGTM, thanks This is an automated message from the Apache

[GitHub] felixcheung commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events

2018-12-11 Thread GitBox
felixcheung commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events URL: https://github.com/apache/spark/pull/23263#issuecomment-446483977 my 2c - it does seem useful, though sounds like mostly for Atlas for now. if you can think of a less intrusive way to do this it might be ea

[GitHub] felixcheung commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events

2018-12-11 Thread GitBox
felixcheung commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events URL: https://github.com/apache/spark/pull/23263#issuecomment-446484055 (oops sorry - too easy to close) This is an automated message from the Apache

[GitHub] HyukjinKwon opened a new pull request #23263: [SPARK-23674][ML] Adds Spark ML Events

2018-12-11 Thread GitBox
HyukjinKwon opened a new pull request #23263: [SPARK-23674][ML] Adds Spark ML Events URL: https://github.com/apache/spark/pull/23263 ## What changes were proposed in this pull request? This PR proposes to add ML events so that other developers can track and add some actions for them

[GitHub] felixcheung closed pull request #23263: [SPARK-23674][ML] Adds Spark ML Events

2018-12-11 Thread GitBox
felixcheung closed pull request #23263: [SPARK-23674][ML] Adds Spark ML Events URL: https://github.com/apache/spark/pull/23263 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] felixcheung commented on a change in pull request #23292: [SPARK-19827][R][FOLLOWUP] spark.ml R API for PIC

2018-12-11 Thread GitBox
felixcheung commented on a change in pull request #23292: [SPARK-19827][R][FOLLOWUP] spark.ml R API for PIC URL: https://github.com/apache/spark/pull/23292#discussion_r240898609 ## File path: R/pkg/R/mllib_fpm.R ## @@ -183,8 +183,8 @@ setMethod("write.ml", signature(object

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446481380 Test FAILed. Refer to this link for build results (access rights to CI server need

[GitHub] SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446481366 **[Test build #18 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBui

[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446481376 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446481376 Merged build finished. Test FAILed.

[GitHub] SparkQA removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480621 **[Test build #18 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReq

[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446481380 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480632 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480632 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480626 Merged build finished. Test PASSed.

[GitHub] cloud-fan commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
cloud-fan commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480647 It's a little weird to have table without schema. I leave `schema` in `Table` with comment sayin

[GitHub] SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
SparkQA commented on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480621 **[Test build #18 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23266: [SPARK-26313][SQL] move read related methods from Table to read related mix-in traits URL: https://github.com/apache/spark/pull/23266#issuecomment-446480626 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446477915 Test FAILed. Refer to this link for build results (access rights to

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240894917 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileS

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446477908 Merged build finished. Test FAILed. --

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240894769 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileS

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446477915 Test FAILed. Refer to this link for build results (access rights to CI serve

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446477908 Merged build finished. Test FAILed. --

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240894769 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileS

[GitHub] SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446435549 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/jo

[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446477611 **[Test build #10 has finished](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240894533 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileS

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240894261 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/strea

[GitHub] gatorsmile commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
gatorsmile commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446477152 > The semicolon (;) terminates an SQL command. It cannot appear anywhere within a command, except within a string constant or quoted id

[GitHub] AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446476895 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446476895 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446476891 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446476891 Merged build finished. Test PASSed. This is

[GitHub] gatorsmile commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
gatorsmile commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446476683 Let us first update the PR description to explain the problem we want to resolve. Regarding comments, our SQL parser follows PostgreSQL

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240893378 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/strea

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240893237 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/strea

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240893299 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileS

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240893237 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/strea

[GitHub] SparkQA commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

2018-12-11 Thread GitBox
SparkQA commented on issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML URL: https://github.com/apache/spark/pull/23144#issuecomment-446475933 **[Test build #17 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17/testRe

[GitHub] HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2018-12-11 Thread GitBox
HeartSaVioR commented on a change in pull request #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#discussion_r240893073 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/strea

[GitHub] HeartSaVioR edited a comment on issue #23169: [SPARK-26103][SQL] Limit the length of debug strings for query plans

2018-12-11 Thread GitBox
HeartSaVioR edited a comment on issue #23169: [SPARK-26103][SQL] Limit the length of debug strings for query plans URL: https://github.com/apache/spark/pull/23169#issuecomment-446475026 @DaveDeCaprio I'm not sure only adding doc in SQLConf is enough for end users to be aware when troub

[GitHub] HeartSaVioR commented on issue #23169: [SPARK-26103][SQL] Limit the length of debug strings for query plans

2018-12-11 Thread GitBox
HeartSaVioR commented on issue #23169: [SPARK-26103][SQL] Limit the length of debug strings for query plans URL: https://github.com/apache/spark/pull/23169#issuecomment-446475026 @DaveDeCaprio I'm not sure only adding doc in SQLConf is enough for end users to be aware when troubleshoot

[GitHub] AmplabJenkins removed a comment on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296#issuecomment-446472926 Can one of the admins verify this patch? -

[GitHub] AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296#issuecomment-446473122 Can one of the admins verify this patch? -

[GitHub] AmplabJenkins removed a comment on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296#issuecomment-446472860 Can one of the admins verify this patch? -

[GitHub] AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296#issuecomment-446472926 Can one of the admins verify this patch? -

[GitHub] AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296#issuecomment-446472860 Can one of the admins verify this patch? -

[GitHub] lcqzte10192193 opened a new pull request #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize

2018-12-11 Thread GitBox
lcqzte10192193 opened a new pull request #23296: [mllib]MergeAggregate serialize and deserialize function use Bytebuffer to optimize URL: https://github.com/apache/spark/pull/23296 ## What changes were proposed in this pull request? MergeAggregate serialize and deserialize function can u

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446470421 Test FAILed. Refer to this link for build results (access rights to

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446470417 Merged build finished. Test FAILed. --

[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446470417 Merged build finished. Test FAILed. --

[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446470421 Test FAILed. Refer to this link for build results (access rights to CI serve

[GitHub] SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446429391 **[Test build #8 has started](https://amplab.cs.berkeley.edu/jenkins/job

[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown

2018-12-11 Thread GitBox
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-446469994 **[Test build #8 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] SparkQA commented on issue #23273: [MINOR][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-11 Thread GitBox
SparkQA commented on issue #23273: [MINOR][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446468234 **[Test build #16 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16/testReport)** for

[GitHub] benmccann commented on issue #20974: [SPARK-23862][SQL] Spark ExpressionEncoder should support java enum type in scala

2018-12-11 Thread GitBox
benmccann commented on issue #20974: [SPARK-23862][SQL] Spark ExpressionEncoder should support java enum type in scala URL: https://github.com/apache/spark/pull/20974#issuecomment-446467737 @gatorsmile @cloud-fan would you be able to give this PR a look or suggest a more appropriate review

[GitHub] AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446467464 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446467466 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446467466 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] AmplabJenkins removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446467310 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446467464 Merged build finished. Test PASSed. This is an au

[GitHub] SparkQA commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-11 Thread GitBox
SparkQA commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446467343 **[Test build #15 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15/testReport)

[GitHub] AmplabJenkins commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446467310 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] AmplabJenkins removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446467307 Merged build finished. Test FAILed. This is an automated me

[GitHub] AmplabJenkins commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446467307 Merged build finished. Test FAILed. This is an automated message fr

[GitHub] SparkQA commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
SparkQA commented on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446467127 **[Test build #9 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)** for PR 23276 at

[GitHub] SparkQA removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way

2018-12-11 Thread GitBox
SparkQA removed a comment on issue #23276: [SPARK-26321][SQL] Split a SQL in correct way URL: https://github.com/apache/spark/pull/23276#issuecomment-446433577 **[Test build #9 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)** for PR 2

[GitHub] seancxmao commented on a change in pull request #23273: [MINOR][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-11 Thread GitBox
seancxmao commented on a change in pull request #23273: [MINOR][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#discussion_r240886207 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala

[GitHub] cloud-fan commented on issue #23294: [SPARK-26265][Core][Followup] Put freePage into a finally block

2018-12-11 Thread GitBox
cloud-fan commented on issue #23294: [SPARK-26265][Core][Followup] Put freePage into a finally block URL: https://github.com/apache/spark/pull/23294#issuecomment-446467008 I think this can be merged to 2.4 without conflict. I'll ping you if it doesn't. Thanks!

[GitHub] rvesse commented on a change in pull request #22904: [SPARK-25887][K8S] Configurable K8S context support

2018-12-11 Thread GitBox
rvesse commented on a change in pull request #22904: [SPARK-25887][K8S] Configurable K8S context support URL: https://github.com/apache/spark/pull/22904#discussion_r240886000 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesC

[GitHub] AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446463272 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446463271 Merged build finished. Test PASSed. This is an

[GitHub] AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446463271 Merged build finished. Test PASSed. This is an automat

[GitHub] AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446463272 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] SparkQA commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
SparkQA commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446463245 **[Test build #14 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14/testReport)** f

[GitHub] gatorsmile commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
gatorsmile commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446462519 LGTM pending Jenkins. This is an automated message from

[GitHub] gatorsmile commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page

2018-12-11 Thread GitBox
gatorsmile commented on issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job page URL: https://github.com/apache/spark/pull/23068#issuecomment-446462497 retest this please This is an automated message from the

[GitHub] AmplabJenkins removed a comment on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax URL: https://github.com/apache/spark/pull/23295#issuecomment-446460866 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] AmplabJenkins removed a comment on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax

2018-12-11 Thread GitBox
AmplabJenkins removed a comment on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax URL: https://github.com/apache/spark/pull/23295#issuecomment-446460865 Merged build finished. Test PASSed.

[GitHub] SparkQA commented on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax

2018-12-11 Thread GitBox
SparkQA commented on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax URL: https://github.com/apache/spark/pull/23295#issuecomment-446460982 **[Test build #13 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13/testR

[GitHub] AmplabJenkins commented on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax

2018-12-11 Thread GitBox
AmplabJenkins commented on issue #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax URL: https://github.com/apache/spark/pull/23295#issuecomment-446460865 Merged build finished. Test PASSed. This is

  1   2   3   4   5   6   7   8   9   10   >