[GitHub] [spark] AmplabJenkins removed a comment on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368#issuecomment-482920865 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368#issuecomment-482920895 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368#issuecomment-482920714 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368#issuecomment-482920865 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368#issuecomment-482920714 Can one of the admins verify this patch? --

[GitHub] [spark] shivusondur opened a new pull request #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places

2019-04-13 Thread GitBox
shivusondur opened a new pull request #24368: [MINOR][CORE] Added Constant instead of referring string literal used from many places URL: https://github.com/apache/spark/pull/24368 ## What changes were proposed in this pull request? Added Constant instead of referring the same String

[GitHub] [spark] AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482916858 Merged build finished. Test PASSed. This is an autom

[GitHub] [spark] AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482916861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482916861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482916858 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
SparkQA commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482916752 **[Test build #104568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104568/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
SparkQA removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897670 **[Test build #104568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104568/testRe

[GitHub] [spark] TisonKun commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
TisonKun commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482916307 Thanks for your reviews @HyukjinKwon @srowen . Now I can see it is too minor to be an individual pr. Closing... --

[GitHub] [spark] SparkQA commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
SparkQA commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913653 **[Test build #104569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104569/testReport)** for PR 2404

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913575 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913571 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913571 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913575 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenk

[GitHub] [spark] wangyum commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
wangyum commented on issue #24044: [WIP][test-hadoop2.7] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482913220 retest this please This is an automated message from the Apache Git Se

[GitHub] [spark] pengbo commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit…

2019-04-13 Thread GitBox
pengbo commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit… URL: https://github.com/apache/spark/pull/24286#discussion_r27513 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/log

[GitHub] [spark] pengbo commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit…

2019-04-13 Thread GitBox
pengbo commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit… URL: https://github.com/apache/spark/pull/24286#discussion_r27513 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/log

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
HyukjinKwon commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#discussion_r275137603 ## File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ## @@ -19,6

[GitHub] [spark] srowen commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit…

2019-04-13 Thread GitBox
srowen commented on a change in pull request #24286: [SPARK-27351][SQL] Wrong outputRows estimation after AggregateEstimation wit… URL: https://github.com/apache/spark/pull/24286#discussion_r275136453 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/log

[GitHub] [spark] srowen commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
srowen commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#discussion_r275135820 ## File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ## @@ -58,7 +59,

[GitHub] [spark] srowen commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
srowen commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#discussion_r275135814 ## File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ## @@ -19,6 +19,

[GitHub] [spark] SparkQA commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
SparkQA commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897670 **[Test build #104568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104568/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897578 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897578 Merged build finished. Test PASSed. This is an autom

[GitHub] [spark] AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berke

[GitHub] [spark] zsxwing commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

2019-04-13 Thread GitBox
zsxwing commented on issue #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter URL: https://github.com/apache/spark/pull/24365#issuecomment-482897373 test this please This is an automated message from the Apa

[GitHub] [spark] AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482894250 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482894250 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482894251 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482894251 Test PASSed. Refer to this link for build results (access rights to CI server needed

[GitHub] [spark] SparkQA removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
SparkQA removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846388 **[Test build #104567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] SparkQA commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
SparkQA commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482894141 **[Test build #104567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] srowen commented on a change in pull request #24362: [SPARK-27454][ML][SQL] Spark image datasource fail when encounter some illegal images

2019-04-13 Thread GitBox
srowen commented on a change in pull request #24362: [SPARK-27454][ML][SQL] Spark image datasource fail when encounter some illegal images URL: https://github.com/apache/spark/pull/24362#discussion_r275134105 ## File path: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.s

[GitHub] [spark] srowen closed pull request #24360: [MINOR][TEST] Speed up slow tests in QuantileDiscretizerSuite

2019-04-13 Thread GitBox
srowen closed pull request #24360: [MINOR][TEST] Speed up slow tests in QuantileDiscretizerSuite URL: https://github.com/apache/spark/pull/24360 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] AmplabJenkins removed a comment on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367#issuecomment-482893446 Can one of the admins verify this patch? T

[GitHub] [spark] AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367#issuecomment-482893706 Can one of the admins verify this patch? This is a

[GitHub] [spark] AmplabJenkins removed a comment on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367#issuecomment-482893678 Can one of the admins verify this patch? T

[GitHub] [spark] AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367#issuecomment-482893678 Can one of the admins verify this patch? This is a

[GitHub] [spark] srowen commented on issue #24360: [MINOR][TEST] Speed up slow tests in QuantileDiscretizerSuite

2019-04-13 Thread GitBox
srowen commented on issue #24360: [MINOR][TEST] Speed up slow tests in QuantileDiscretizerSuite URL: https://github.com/apache/spark/pull/24360#issuecomment-482893589 Merged to master This is an automated message from the Apa

[GitHub] [spark] AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367#issuecomment-482893446 Can one of the admins verify this patch? This is a

[GitHub] [spark] mazeboard commented on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard commented on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482893414 we created a new PR (https://github.com/apache/spark/pull/24367) for the modification of the bean encoder (Jav

[GitHub] [spark] mazeboard opened a new pull request #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects

2019-04-13 Thread GitBox
mazeboard opened a new pull request #24367: [SPARK-27457][SQL] modify bean encoder to support avro objects URL: https://github.com/apache/spark/pull/24367 ## What changes were proposed in this pull request? Currently we modified JavaTypeInference to be able to create encoders for Avro o

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two

[GitHub] [spark] mazeboard commented on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard commented on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482883525 Currently we modified JavaTypeInference to be able to create encoders for Avro objects; we have now two soluti

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482880658 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.e

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482880658 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenki

[GitHub] [spark] SparkQA removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
SparkQA removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826428 **[Test build #104566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104566/testReport)** for

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482880655 Merged build finished. Test FAILed. This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482880655 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
SparkQA commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482880488 **[Test build #104566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104566/testReport)** for PR 240

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties

2019-04-13 Thread GitBox
mazeboard edited a comment on issue #24299: [SPARK-27388][SQL] expression encoder for objects defined by properties URL: https://github.com/apache/spark/pull/24299#issuecomment-482167159 I would like to give an example to explain why the PR addition must be in ScalaReflection The

[GitHub] [spark] shaneknapp commented on issue #24266: [SPARK-25079][python] update python3 executable to 3.6.x

2019-04-13 Thread GitBox
shaneknapp commented on issue #24266: [SPARK-25079][python] update python3 executable to 3.6.x URL: https://github.com/apache/spark/pull/24266#issuecomment-482863645 ok, i think this is ready to be merge/deployed next week. i'll send out an email to dev@ and get this scheduled. O

[GitHub] [spark] felixcheung commented on a change in pull request #24058: [SPARK-27128][SQL] Migrate JSON to File Data Source V2

2019-04-13 Thread GitBox
felixcheung commented on a change in pull request #24058: [SPARK-27128][SQL] Migrate JSON to File Data Source V2 URL: https://github.com/apache/spark/pull/24058#discussion_r275127885 ## File path: R/pkg/tests/fulltests/test_sparkSQL.R ## @@ -3657,8 +3657,7 @@ test_that("Ca

[GitHub] [spark] felixcheung commented on issue #24353: [SPARK-27446][R] Use existing spark conf if available.

2019-04-13 Thread GitBox
felixcheung commented on issue #24353: [SPARK-27446][R] Use existing spark conf if available. URL: https://github.com/apache/spark/pull/24353#issuecomment-482860357 ok thats fine. This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
SparkQA commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846388 **[Test build #104567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReque

[GitHub] [spark] AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846087 Test PASSed. Refer to this link for build results (access rights to CI server needed

[GitHub] [spark] AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846077 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846077 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24342: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision URL: https://github.com/apache/spark/pull/24342#issuecomment-482846087 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] SparkQA commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
SparkQA commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826428 **[Test build #104566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104566/testReport)** for PR 2404

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826125 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826122 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826122 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24044: [WIP][test-hadoop3.2] Test Hadoop 3.2 on jenkins URL: https://github.com/apache/spark/pull/24044#issuecomment-482826125 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenk

[GitHub] [spark] TisonKun commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
TisonKun commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#discussion_r275119749 ## File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ## @@ -19,6 +1

[GitHub] [spark] cloud-fan edited a comment on issue #24129: [SPARK-27190][SQL] add table capability for streaming

2019-04-13 Thread GitBox
cloud-fan edited a comment on issue #24129: [SPARK-27190][SQL] add table capability for streaming URL: https://github.com/apache/spark/pull/24129#issuecomment-482792336 > The check you linked to is done after the plan is analyzed The whole process is, the logical plan is first analyz

[GitHub] [spark] HyukjinKwon closed pull request #24361: [MINOR][DOCS] Fix some broken links in docs

2019-04-13 Thread GitBox
HyukjinKwon closed pull request #24361: [MINOR][DOCS] Fix some broken links in docs URL: https://github.com/apache/spark/pull/24361 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
HyukjinKwon commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482809305 It's virtually same before/after and I wouldn't fix the styles alone in a PR but rather help review other PRs. -

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
HyukjinKwon commented on a change in pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#discussion_r275118068 ## File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala ## @@ -19,6

[GitHub] [spark] HyukjinKwon commented on issue #24361: [MINOR][DOCS] Fix some broken links in docs

2019-04-13 Thread GitBox
HyukjinKwon commented on issue #24361: [MINOR][DOCS] Fix some broken links in docs URL: https://github.com/apache/spark/pull/24361#issuecomment-482809084 Merged to master. This is an automated message from the Apache Git Serv

[GitHub] [spark] HyukjinKwon removed a comment on issue #24353: [SPARK-27446][R] Use existing spark conf if available.

2019-04-13 Thread GitBox
HyukjinKwon removed a comment on issue #24353: [SPARK-27446][R] Use existing spark conf if available. URL: https://github.com/apache/spark/pull/24353#issuecomment-482808813 BTW, I believe this is consistent with some other places as well. ---

[GitHub] [spark] HyukjinKwon commented on issue #24353: [SPARK-27446][R] Use existing spark conf if available.

2019-04-13 Thread GitBox
HyukjinKwon commented on issue #24353: [SPARK-27446][R] Use existing spark conf if available. URL: https://github.com/apache/spark/pull/24353#issuecomment-482808813 BTW, I believe this is consistent with some other places as well. ---

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24362: [SPARK-27454][ML][SQL] Spark image datasource fail when encounter some illegal images

2019-04-13 Thread GitBox
HyukjinKwon commented on a change in pull request #24362: [SPARK-27454][ML][SQL] Spark image datasource fail when encounter some illegal images URL: https://github.com/apache/spark/pull/24362#discussion_r275117268 ## File path: mllib/src/main/scala/org/apache/spark/ml/image/ImageSc

[GitHub] [spark] AmplabJenkins removed a comment on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482794285 Can one of the admins verify this patch? This is an automa

[GitHub] [spark] AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482794417 Can one of the admins verify this patch? This is an automated mess

[GitHub] [spark] AmplabJenkins removed a comment on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482794251 Can one of the admins verify this patch? This is an automa

[GitHub] [spark] AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482794285 Can one of the admins verify this patch? This is an automated mess

[GitHub] [spark] AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366#issuecomment-482794251 Can one of the admins verify this patch? This is an automated mess

[GitHub] [spark] TisonKun opened a new pull request #24366: [MINOR] Fix import in NettyStreamManager.scala

2019-04-13 Thread GitBox
TisonKun opened a new pull request #24366: [MINOR] Fix import in NettyStreamManager.scala URL: https://github.com/apache/spark/pull/24366 ## What changes were proposed in this pull request? Fix import in NettyStreamManager.scala ## How was this patch tested? straight f

[GitHub] [spark] cloud-fan commented on issue #24129: [SPARK-27190][SQL] add table capability for streaming

2019-04-13 Thread GitBox
cloud-fan commented on issue #24129: [SPARK-27190][SQL] add table capability for streaming URL: https://github.com/apache/spark/pull/24129#issuecomment-482792336 > The check you linked to is done after the plan is analyzed The whole process is, the logical plan is first analyzed by t

[GitHub] [spark] gengliangwang commented on issue #24058: [SPARK-27128][SQL] Migrate JSON to File Data Source V2

2019-04-13 Thread GitBox
gengliangwang commented on issue #24058: [SPARK-27128][SQL] Migrate JSON to File Data Source V2 URL: https://github.com/apache/spark/pull/24058#issuecomment-482784385 This is ready. Please help review it. @cloud-fan @dongjoon-hyun @HyukjinKwon -

[GitHub] [spark] AmplabJenkins removed a comment on issue #24364: [SPARK-27452][BUILD] Update zstd-jni to 1.3.8-7

2019-04-13 Thread GitBox
AmplabJenkins removed a comment on issue #24364: [SPARK-27452][BUILD] Update zstd-jni to 1.3.8-7 URL: https://github.com/apache/spark/pull/24364#issuecomment-482783404 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] AmplabJenkins commented on issue #24364: [SPARK-27452][BUILD] Update zstd-jni to 1.3.8-7

2019-04-13 Thread GitBox
AmplabJenkins commented on issue #24364: [SPARK-27452][BUILD] Update zstd-jni to 1.3.8-7 URL: https://github.com/apache/spark/pull/24364#issuecomment-482783404 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkin

  1   2   >