[GitHub] [spark] AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860440 Merged build finished. Test PASSed. This is an automated me

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794944 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@ -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860445 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] [spark] AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860440 Merged build finished. Test PASSed. This is an automated message fr

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794622 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@ -

[GitHub] [spark] AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860445 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] SparkQA removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838459 **[Test build #107290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107290/testReport)** for PR

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794352 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@ -

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794292 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@ -

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300794352 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ## @@ -

[GitHub] [spark] SparkQA commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
SparkQA commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508860107 **[Test build #107290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107290/testReport)** for PR 25021 a

[GitHub] [spark] Tagar commented on issue #25032: Add root degree to PolynomialExpansion

2019-07-05 Thread GitBox
Tagar commented on issue #25032: Add root degree to PolynomialExpansion URL: https://github.com/apache/spark/pull/25032#issuecomment-508857876 We use `sqrt` for engineered features quite often, for some of the variables with a larger scale of values. Haven't seen our DS folks use anythin

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300790364 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300789916 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300788642 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300788424 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300788160 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300787294 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300786525 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300786324 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala #

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300785760 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable URL: https://github.com/apache/spark/pull/24832#discussion_r300785218 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508844217 **[Test build #107292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107292/testReport

[GitHub] [spark] peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r300777950 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ###

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508843824 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508843824 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508843819 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-508843819 Merged build finished. Test PASSed. This

[GitHub] [spark] peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r30045 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubsti

[GitHub] [spark] AmplabJenkins removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508840075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508840070 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508840070 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508840075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] SparkQA removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508800061 **[Test build #107286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107286/testReport)

[GitHub] [spark] SparkQA commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW`

2019-07-05 Thread GitBox
SparkQA commented on issue #25061: [SPARK-28262][SQL] Support `DROP GLOBAL TEMPORARY VIEW` URL: https://github.com/apache/spark/pull/25061#issuecomment-508839781 **[Test build #107286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107286/testReport)** for

[GitHub] [spark] peter-toth commented on issue #24949: [SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases

2019-07-05 Thread GitBox
peter-toth commented on issue #24949: [SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases URL: https://github.com/apache/spark/pull/24949#issuecomment-508838752 Thanks for the review @dongjoon-hyun, @HyukjinKwon, @gatorsmile! ---

[GitHub] [spark] SparkQA commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
SparkQA commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838463 **[Test build #107289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBui

[GitHub] [spark] SparkQA commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
SparkQA commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838459 **[Test build #107290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107290/testReport)** for PR 25021 at

[GitHub] [spark] SparkQA commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
SparkQA commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838460 **[Test build #107291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107291/testReport)** for PR

[GitHub] [spark] AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838037 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838082 Merged build finished. Test PASSed. This is an auto

[GitHub] [spark] AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838045 Test PASSed. Refer to this link for build results (access rights to CI server nee

[GitHub] [spark] AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838087 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berk

[GitHub] [spark] AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838074 Merged build finished. Test PASSed. This is an automated me

[GitHub] [spark] AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins

[GitHub] [spark] AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838037 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508838045 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838087 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu

[GitHub] [spark] AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation.

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24937: [SPARK-28139][SQL] Add v2 ALTER TABLE implementation. URL: https://github.com/apache/spark/pull/24937#issuecomment-508838082 Merged build finished. Test PASSed. This is an automated me

[GitHub] [spark] AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508838074 Merged build finished. Test PASSed. This is an automated message fr

[GitHub] [spark] dongjoon-hyun closed pull request #24949: [SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases

2019-07-05 Thread GitBox
dongjoon-hyun closed pull request #24949: [SPARK-28002][SQL][FOLLOWUP] Fix duplicate CTE error message and add more test cases URL: https://github.com/apache/spark/pull/24949 This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508837774 Thank you for update, @Tonix517 . -

[GitHub] [spark] Tonix517 commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-05 Thread GitBox
Tonix517 commented on issue #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#issuecomment-508837422 retest this please This is an a

[GitHub] [spark] dongjoon-hyun commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508837495 Gentle ping, @JoshRosen . It would be really great if we can get a confirmation for you. --

[GitHub] [spark] dongjoon-hyun commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13 URL: https://github.com/apache/spark/pull/25021#issuecomment-508837304 Retest this please. This is an automated message from the Apache Gi

[GitHub] [spark] SparkQA commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
SparkQA commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835508 **[Test build #107288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107288/testReport)** for PR 24768 at com

[GitHub] [spark] rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#discussion_r300768695 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala ## @@ -17,54

[GitHub] [spark] AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835142 Merged build finished. Test PASSed. This is an automated messag

[GitHub] [spark] AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835142 Merged build finished. Test PASSed. This is an automated message from t

[GitHub] [spark] rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#discussion_r300768382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UpdateAttributeNullability.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-508835148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//jo

[GitHub] [spark] rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#discussion_r300768382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UpdateAttributeNullability.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#discussion_r300768353 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala ## @@ -17,54

[GitHub] [spark] rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

2019-07-05 Thread GitBox
rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#discussion_r300765447 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala ## @@ -17,54

[GitHub] [spark] dongjoon-hyun commented on issue #24851: [SPARK-27303][GRAPH] Add PropertyGraph construction API

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #24851: [SPARK-27303][GRAPH] Add PropertyGraph construction API URL: https://github.com/apache/spark/pull/24851#issuecomment-508831262 Thank you for updating, @s1ck . This is an automated mess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r300764407 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaS

[GitHub] [spark] AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508830620 Test PASSed. Refer to this link for build results (acces

[GitHub] [spark] AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508830619 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508830620 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508830619 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508804074 **[Test build #107287 has started](https://amplab.cs.berkeley.ed

[GitHub] [spark] SparkQA commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-05 Thread GitBox
SparkQA commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508830252 **[Test build #107287 has finished](https://amplab.cs.berkeley.edu/jenkin

[GitHub] [spark] AmplabJenkins removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508824321 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508824314 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508824314 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508824321 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] SparkQA removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508795819 **[Test build #107285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] SparkQA commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-05 Thread GitBox
SparkQA commented on issue #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#issuecomment-508823899 **[Test build #107285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r300753985 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESub

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r300753650 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r300752978 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -147,6 +147,8 @@ licen

[GitHub] [spark] asfgit closed pull request #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
asfgit closed pull request #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060 This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] mengxr commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
mengxr commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060#issuecomment-508817975 Merged into master. I didn't backport the change to branch-2.4 due to number of lines of edit. -

[GitHub] [spark] dongjoon-hyun commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508817921 Hi, @WangGuangxin . We don't need to put `[MINOR]` if you have a JIRA ID. --

[GitHub] [spark] mengxr commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
mengxr commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060#issuecomment-508817529 LGTM. Confirm that `@pandas_udf` is now correctly rendered in API doc. I didn't spot any regression. ---

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#discussion_r300750094 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql ## @@ -0,0 +1,362 @@ +-- +-- P

[GitHub] [spark] dongjoon-hyun closed pull request #24755: [SPARK-27898][SQL] Support 4 date operators(date + integer, integer + date, date - integer and date - date)

2019-07-05 Thread GitBox
dongjoon-hyun closed pull request #24755: [SPARK-27898][SQL] Support 4 date operators(date + integer, integer + date, date - integer and date - date) URL: https://github.com/apache/spark/pull/24755 This is an automated messa

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on a change in pull request #24850: [SPARK-28020][SQL][TEST] Port date.sql URL: https://github.com/apache/spark/pull/24850#discussion_r300749936 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql ## @@ -0,0 +1,364 @@ +-- +-- P

[GitHub] [spark] rxin commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
rxin commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060#issuecomment-508815524 seems fine This is an automated message from t

[GitHub] [spark] srowen commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation

2019-07-05 Thread GitBox
srowen commented on issue #25060: [SPARK-28206][PYTHON] Remove the legacy Epydoc in PySpark API documentation URL: https://github.com/apache/spark/pull/25060#issuecomment-508815367 I had never seen this. Looks good if it simplifies and improves docs. ---

[GitHub] [spark] rxin commented on issue #25022: [SPARK-24695][SQL]: To expose Calendar interval type, so that same can be returned from the UDF.

2019-07-05 Thread GitBox
rxin commented on issue #25022: [SPARK-24695][SQL]: To expose Calendar interval type, so that same can be returned from the UDF. URL: https://github.com/apache/spark/pull/25022#issuecomment-508815192 I'm OK exposing it, but we need to mark that this API is not stable and will be broken in

[GitHub] [spark] AmplabJenkins removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508808163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508808160 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508808160 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
AmplabJenkins commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508808163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] SparkQA removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
SparkQA removed a comment on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508751500 **[Test build #107283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1072

[GitHub] [spark] SparkQA commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL

2019-07-05 Thread GitBox
SparkQA commented on issue #25059: [SPARK-28257][SQL][MINOR]Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#issuecomment-508807781 **[Test build #107283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107283/test

[GitHub] [spark] AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-05 Thread GitBox
AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-508807132 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenki

<    1   2   3   4   5   6   7   >