[GitHub] [spark] sandeep-katta commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found

2019-08-10 Thread GitBox
sandeep-katta commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-520202315 > What's a behaviour in the other systems, e.g., hive and presto? Could you check that?

[GitHub] [spark] maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found

2019-08-10 Thread GitBox
maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-520202258 What's a behaviour in the other systems, e.g., hive and presto? Could you check that? --

[GitHub] [spark] sandeep-katta commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found

2019-08-10 Thread GitBox
sandeep-katta commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-520202213 current flow is as below Once the resource is loaded, spark checks for given classNa

[GitHub] [spark] dilipbiswal commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found

2019-08-10 Thread GitBox
dilipbiswal commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-520201922 @maropu > Is that workflow is common? Actually i don't know. Just thought i shoul

[GitHub] [spark] Udbhav30 commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2019-08-10 Thread GitBox
Udbhav30 commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory URL: https://github.com/apache/spark/pull/25398#discussion_r312723036 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSql

[GitHub] [spark] Udbhav30 commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2019-08-10 Thread GitBox
Udbhav30 commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory URL: https://github.com/apache/spark/pull/25398#discussion_r312722943 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuit

[GitHub] [spark] ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak

2019-08-10 Thread GitBox
ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak URL: https://github.com/apache/spark/pull/23083#discussion_r312722564 ## File path: core/src/main/scala/org/apache/spark/util/CompletionIterator.scala ##

[GitHub] [spark] ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak

2019-08-10 Thread GitBox
ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak URL: https://github.com/apache/spark/pull/23083#discussion_r312722564 ## File path: core/src/main/scala/org/apache/spark/util/CompletionIterator.scala ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520199200 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520199201 Test PASSed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] [spark] AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520199201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520199200 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
SparkQA removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191442 **[Test build #108926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] SparkQA commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
SparkQA commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520199131 **[Test build #108926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108926/t

[GitHub] [spark] maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found

2019-08-10 Thread GitBox
maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-520198192 Is that workflow is common? As another option, we might be able to just output warning messages f

[GitHub] [spark] maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory URL: https://github.com/apache/spark/pull/25398#discussion_r312721534 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlPa

[GitHub] [spark] ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak

2019-08-10 Thread GitBox
ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak URL: https://github.com/apache/spark/pull/23083#discussion_r312721558 ## File path: core/src/main/scala/org/apache/spark/util/CompletionIterator.scala ##

[GitHub] [spark] ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak

2019-08-10 Thread GitBox
ChenjunZou commented on a change in pull request #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator field leak URL: https://github.com/apache/spark/pull/23083#discussion_r312721558 ## File path: core/src/main/scala/org/apache/spark/util/CompletionIterator.scala ##

[GitHub] [spark] maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory URL: https://github.com/apache/spark/pull/25398#discussion_r312721545 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.

[GitHub] [spark] maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory URL: https://github.com/apache/spark/pull/25398#discussion_r312721534 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlPa

[GitHub] [spark] maropu commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
maropu commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312721331 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ## @@ -0,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719909 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#discussion_r312719611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/Looku

[GitHub] [spark] AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191657 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191655 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191655 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
SparkQA commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191442 **[Test build #108926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108926/te

[GitHub] [spark] dongjoon-hyun commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25372: [SPARK-28640][SQL] Only give warning when session catalog is not defined URL: https://github.com/apache/spark/pull/25372#issuecomment-520191311 Retest this please. This is an automated

[GitHub] [spark] dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520191238 cc @srowen , @gatorsmile , @cloud-fan since this PR removed the test coverage for old HMS at

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719397 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719349 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719343 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719253 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719228 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520190431 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520190430 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520190431 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520190430 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
SparkQA removed a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184868 **[Test build #108925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] SparkQA commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
SparkQA commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520190374 **[Test build #108925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719033 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719019 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312719006 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718876 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718876 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718876 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718876 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718772 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718668 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3]

2019-08-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #24829: [SPARK-27988][SQL][TEST] Port AGGREGATES.sql [Part 3] URL: https://github.com/apache/spark/pull/24829#discussion_r312718647 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/aggregates_part3.sql ##

[GitHub] [spark] dongjoon-hyun closed pull request #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun closed pull request #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405 This is an automated message from the Apache Git

[GitHub] [spark] wangyum commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
wangyum commented on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520188470 Thank you @dongjoon-hyun This is

[GitHub] [spark] dongjoon-hyun closed pull request #25395: [SPARK-28675][SQL] Remove maskCredentials and use redactOptions

2019-08-10 Thread GitBox
dongjoon-hyun closed pull request #25395: [SPARK-28675][SQL] Remove maskCredentials and use redactOptions URL: https://github.com/apache/spark/pull/25395 This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520188249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/j

[GitHub] [spark] AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520188249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//

[GitHub] [spark] AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520188246 Merged build finished. Test FAILed. This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520188246 Merged build finished. Test FAILed. This is an automated message fro

[GitHub] [spark] SparkQA commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
SparkQA commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520188209 **[Test build #108924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108924/testReport)** for PR 25404 at

[GitHub] [spark] SparkQA removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
SparkQA removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184451 **[Test build #108924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108924/testReport)** for PR

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520185862 @wangyum . As you mentioned [here](https://github.com/apache/spark/pull/25405#issuecom

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520185862 @wangyum . As you mentioned, this PR doesn't make them pass on JDK11. In that case,

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25405: [SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520185862 @wangyum . As you mentioned, this PR doesn't make them pass on JDK11. In that case,

[GitHub] [spark] dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520185862 @wangyum . As you mentioned, this PR doesn't make them pass in JDK11. In tha

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520185011 The failures seems relevant, @wangyum . Could you check the failures? - `[info] *** 212 TESTS FAILED ***` ``` [info] -

[GitHub] [spark] maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#discussion_r312717142 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrec

[GitHub] [spark] dongjoon-hyun commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520185011 The failure seems relevant, @wangyum . Could you check the failures?

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520185011 The failures seems relevant, @wangyum . Could you check the failures?

[GitHub] [spark] maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#discussion_r312702648 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrec

[GitHub] [spark] SparkQA commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
SparkQA commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184868 **[Test build #108925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184776 Merged build finished. Test PASSed. This is an automated mes

[GitHub] [spark] AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184775 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184774 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184774 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184776 Merged build finished. Test PASSed. This is an automated message fro

[GitHub] [spark] AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184775 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] [spark] AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25405: [SPARK-28685][SQL][TEST][test-hadoop3.2] VersionsSuite and HiveClientSuites support test on JDK 11 URL: https://github.com/apache/spark/pull/25405#issuecomment-520184659 Retest this please. --

[GitHub] [spark] SparkQA commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
SparkQA commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184451 **[Test build #108924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108924/testReport)** for PR 25404 at

[GitHub] [spark] dongjoon-hyun commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

2019-08-10 Thread GitBox
dongjoon-hyun commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9 URL: https://github.com/apache/spark/pull/25404#issuecomment-520184408 Retest this please. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520184344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520184344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520184342 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520184342 Merged build finished. Test PASSed. Th

[GitHub] [spark] SparkQA removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
SparkQA removed a comment on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520172776 **[Test build #108923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108923/

[GitHub] [spark] SparkQA commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-10 Thread GitBox
SparkQA commented on issue #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#issuecomment-520184244 **[Test build #108923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108923/testRep

[GitHub] [spark] maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#discussion_r312716579 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrec

[GitHub] [spark] maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#discussion_r312716579 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrec

[GitHub] [spark] maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-10 Thread GitBox
maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#discussion_r312716579 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrec

[GitHub] [spark] AmplabJenkins commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-08-10 Thread GitBox
AmplabJenkins commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-520182897 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-08-10 Thread GitBox
AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-520182900 Test PASSed. Refer to this link for build results (access rights to CI

  1   2   3   4   >