[GitHub] [spark] AmplabJenkins removed a comment on issue #25433: [SPARK-28715][SQL] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25433: [SPARK-28715][SQL] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520881501 Can one of the admins verify this patch? --

[GitHub] [spark] dongjoon-hyun commented on issue #25433: [SPARK-28715][SQL] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
dongjoon-hyun commented on issue #25433: [SPARK-28715][SQL] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520889229 ok to test This is an auto

[GitHub] [spark] AmplabJenkins removed a comment on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans URL: https://github.com/apache/spark/pull/25434#issuecomment-520887338 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans URL: https://github.com/apache/spark/pull/25434#issuecomment-520888278 Can one of the admins verify this patch?

[GitHub] [spark] HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520888168 Thanks @viirya and sorry for late response. I was stuck in some works for last some days. ---

[GitHub] [spark] HyukjinKwon closed pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon closed pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352 This is an automated message from the Apache Git S

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+

2019-08-13 Thread GitBox
dongjoon-hyun edited a comment on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ URL: https://github.com/apache/spark/pull/25429#issuecomment-520886671 @wangyum . Did I miss something you did? I downloaded and rebased to the

[GitHub] [spark] AmplabJenkins commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans URL: https://github.com/apache/spark/pull/25434#issuecomment-520887338 Can one of the admins verify this patch?

[GitHub] [spark] hvanhovell commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans

2019-08-13 Thread GitBox
hvanhovell commented on issue #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans URL: https://github.com/apache/spark/pull/25434#issuecomment-520887258 ok to test -

[GitHub] [spark] dbaliafroozeh opened a new pull request #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans

2019-08-13 Thread GitBox
dbaliafroozeh opened a new pull request #25434: [SPARK-28716] Add id to Exchange and Subquery's stringArgs method for easier identifying their reuses in query plans URL: https://github.com/apache/spark/pull/25434 ## What changes were proposed in this pull request? Add id to Exchange

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon commented on a change in pull request #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#discussion_r313466840 ## File path: python/pyspark/sql/tests/test_pandas_udf_grouped_agg.p

[GitHub] [spark] dongjoon-hyun commented on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+

2019-08-13 Thread GitBox
dongjoon-hyun commented on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ URL: https://github.com/apache/spark/pull/25429#issuecomment-520886779 cc @dbtsai Thi

[GitHub] [spark] dongjoon-hyun commented on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+

2019-08-13 Thread GitBox
dongjoon-hyun commented on issue #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ URL: https://github.com/apache/spark/pull/25429#issuecomment-520886671 @wangyum . Did I miss something you did? I downloaded and rebased to the master.

[GitHub] [spark] HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520885844 FYI, the tests already passed. ---

[GitHub] [spark] HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520885379 Merged to master. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520884093 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520884083 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520884093 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520884083 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+

2019-08-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ URL: https://github.com/apache/spark/pull/25429#discussion_r313460910 ## File path: sql/hive/src/main/scala/org/apache/spark/

[GitHub] [spark] SparkQA commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
SparkQA commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520881657 **[Test build #109042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109042/testReport)** for P

[GitHub] [spark] AmplabJenkins removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520880558 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520881501 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520880315 Can one of the admins verify this patch? ---

[GitHub] [spark] Fokko commented on a change in pull request #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
Fokko commented on a change in pull request #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#discussion_r313459174 ## File path: pom.xml ## @@ -2777,7 +2777,7 @@ com.puppycrawl.tools

[GitHub] [spark] LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-13 Thread GitBox
LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r313459043 ## File path: resource-managers/yarn/src/main/scala/org/apache/

[GitHub] [spark] AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520880558 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520880315 Can one of the admins verify this patch? ---

[GitHub] [spark] hvanhovell removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
hvanhovell removed a comment on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520878854 ok to test This is an auto

[GitHub] [spark] hvanhovell commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
hvanhovell commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520878983 ok to test This is an automated me

[GitHub] [spark] hvanhovell commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
hvanhovell commented on issue #25433: [SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433#issuecomment-520878854 ok to test This is an automated me

[GitHub] [spark] dbaliafroozeh opened a new pull request #25433: SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan

2019-08-13 Thread GitBox
dbaliafroozeh opened a new pull request #25433: SPARK-28715] Introduce collectInPlanAndSubqueries and subqueriesAll in QueryPlan URL: https://github.com/apache/spark/pull/25433 ## What changes were proposed in this pull request? Introduces the collectInPlanAndSubqueries and subquerie

[GitHub] [spark] SparkQA commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
SparkQA commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520878270 **[Test build #109041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109041/testReport)** for P

[GitHub] [spark] dongjoon-hyun commented on issue #25431: [SPARK-28711][DOCS] Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
dongjoon-hyun commented on issue #25431: [SPARK-28711][DOCS] Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520878282 Hi, @sandeep-katta . Could you include https://github.com/apache/spark/pull/25431#issuecomment-520818

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520877289 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520877278 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520877289 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
dongjoon-hyun commented on a change in pull request #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#discussion_r313454310 ## File path: pom.xml ## @@ -2777,7 +2777,7 @@ com.puppycrawl.t

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520877278 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520874673 Can one of the admins verify this patch? This is a

[GitHub] [spark] dongjoon-hyun commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
dongjoon-hyun commented on issue #25432: [SPARK-28713][BUILD] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520876425 ok to test This is an automated message from the Apache Gi

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520874673 Can one of the admins verify this patch? This is an automated mes

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520873715 Can one of the admins verify this patch? This is an autom

[GitHub] [spark] AmplabJenkins removed a comment on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520873352 Can one of the admins verify this patch? This is an autom

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520873715 Can one of the admins verify this patch? This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25432: [SPARK-28713] Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432#issuecomment-520873352 Can one of the admins verify this patch? This is an automated mes

[GitHub] [spark] peter-toth commented on a change in pull request #25121: [SPARK-28356][SQL] Do not reduce the number of partitions for repartition in adaptive execution

2019-08-13 Thread GitBox
peter-toth commented on a change in pull request #25121: [SPARK-28356][SQL] Do not reduce the number of partitions for repartition in adaptive execution URL: https://github.com/apache/spark/pull/25121#discussion_r313447177 ## File path: sql/core/src/main/scala/org/apache/spark/sql/

[GitHub] [spark] Fokko opened a new pull request #25432: SPARK-28713: Bump checkstyle from 8.14 to 8.18

2019-08-13 Thread GitBox
Fokko opened a new pull request #25432: SPARK-28713: Bump checkstyle from 8.14 to 8.18 URL: https://github.com/apache/spark/pull/25432 ## What changes were proposed in this pull request? Fixes a vulnerability from the GitHub Security Advisory Database: _Moderate severity vulne

[GitHub] [spark] SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
SparkQA commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520871170 **[Test build #109040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520870152 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520870143 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520870152 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520870143 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause

2019-08-13 Thread GitBox
HyukjinKwon commented on issue #25352: [SPARK-28422][SQL][Python] GROUPED_AGG pandas_udf should work without group by clause URL: https://github.com/apache/spark/pull/25352#issuecomment-520868534 retest this please This is an

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313441345 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.sc

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313441345 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.sc

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313441345 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.sc

[GitHub] [spark] srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds

2019-08-13 Thread GitBox
srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-520864890 If I'm right, it's just a few more lines of change here. The K8S script change would take a little more wor

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313434824 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313435039 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313435262 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313435635 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313435885 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313434699 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25424: [SPARK-28543][DOCS][WebUI] Document Spark Jobs page URL: https://github.com/apache/spark/pull/25424#discussion_r313435974 ## File path: docs/web-ui.md ## @@ -35,6 +35,64 @@ progress of all jobs and the overall event time

[GitHub] [spark] srowen commented on a change in pull request #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25429: [SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ URL: https://github.com/apache/spark/pull/25429#discussion_r313433441 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hiv

[GitHub] [spark] srowen commented on a change in pull request #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
srowen commented on a change in pull request #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#discussion_r313428819 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -23,6 +23,9

[GitHub] [spark] wangyum commented on a change in pull request #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
wangyum commented on a change in pull request #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#discussion_r313412063 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/h

[GitHub] [spark] AmplabJenkins removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520835250 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
SparkQA removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520791125 **[Test build #109036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] AmplabJenkins commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520835259 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520835250 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520835259 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] SparkQA commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-13 Thread GitBox
SparkQA commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-520834540 **[Test build #109036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-13 Thread GitBox
eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r313395656 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSui

[GitHub] [spark] cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-13 Thread GitBox
cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-520833907 I think we have too many string related methods in `TreeNode`, which makes it pretty hard to extend. Maybe it's time to introdu

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-13 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r313390577 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ## @@ -64,6 +

[GitHub] [spark] gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-08-13 Thread GitBox
gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-520830078 To make a small extract about the discussion in the Kafka dev channel the proposal where tends to be agreement

[GitHub] [spark] sujith71955 commented on issue #23899: [SPARK-26969][SQL] Using ODBC client not able to see the query data when column datatype is decimal

2019-08-13 Thread GitBox
sujith71955 commented on issue #23899: [SPARK-26969][SQL] Using ODBC client not able to see the query data when column datatype is decimal URL: https://github.com/apache/spark/pull/23899#issuecomment-520827942 Thanks all for the guidance. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520827185 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520827194 Test PASSed. Refer to this link for build results (access rig

[GitHub] [spark] AmplabJenkins commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520827185 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520827194 Test PASSed. Refer to this link for build results (access rights to C

[GitHub] [spark] SparkQA commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
SparkQA commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520827064 **[Test build #109039 has finished](https://amplab.cs.berkeley.edu/jenkins/job

[GitHub] [spark] SparkQA removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
SparkQA removed a comment on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520818568 **[Test build #109039 has started](https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-13 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r313385107 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@

[GitHub] [spark] sujith71955 commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-08-13 Thread GitBox
sujith71955 commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-520823648 gentle ping @dongjoon-hyun @maropu --

[GitHub] [spark] cloud-fan closed pull request #25419: [SPARK-28698][SQL] Support user-specified output schema in `to_avro`

2019-08-13 Thread GitBox
cloud-fan closed pull request #25419: [SPARK-28698][SQL] Support user-specified output schema in `to_avro` URL: https://github.com/apache/spark/pull/25419 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] cloud-fan commented on issue #25419: [SPARK-28698][SQL] Support user-specified output schema in `to_avro`

2019-08-13 Thread GitBox
cloud-fan commented on issue #25419: [SPARK-28698][SQL] Support user-specified output schema in `to_avro` URL: https://github.com/apache/spark/pull/25419#issuecomment-520821779 thanks, merging to master! This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520820100 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520820100 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520820300 Can one of the admins verify this patch? ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520818441 Can one of the admins verify this patch? --

[GitHub] [spark] sandeep-katta commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
sandeep-katta commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520818708 After upgrading to SPARK 3.0 Thrift Server is failed to start as there is a mismatch in the sche

[GitHub] [spark] AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
AmplabJenkins commented on issue #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431#issuecomment-520818441 Can one of the admins verify this patch? ---

[GitHub] [spark] SparkQA commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
SparkQA commented on issue #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#issuecomment-520818568 **[Test build #109039 has started](https://amplab.cs.berkeley.edu/jenkins/job/

[GitHub] [spark] sandeep-katta opened a new pull request #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade

2019-08-13 Thread GitBox
sandeep-katta opened a new pull request #25431: [SPARK-28711][Documentation]Update migration guide to add note about Hive upgrade URL: https://github.com/apache/spark/pull/25431 ## What changes were proposed in this pull request? Add note about updating `SCHEMA_VERSION` of Hive in t

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust

2019-08-13 Thread GitBox
gaborgsomogyi commented on a change in pull request #25418: [SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust URL: https://github.com/apache/spark/pull/25418#discussion_r313372987 ## File path: external/kafka-0-10-sql/src/mai

[GitHub] [spark] cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#issuecomment-520816943 LGTM except https://github.com/apache/spark/pull/25115#discussion_r313371566 --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25408: [SPARK-28687][SQL] Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`

2019-08-13 Thread GitBox
AmplabJenkins removed a comment on issue #25408: [SPARK-28687][SQL] Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()` URL: https://github.com/apache/spark/pull/25408#issuecomment-520816618 Test PASSed. Refer to this link for build results (access rights to CI s

<    4   5   6   7   8   9   10   11   12   >