[GitHub] [spark] srowen commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
srowen commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#discussion_r316836981 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server

2019-08-22 Thread GitBox
dongjoon-hyun commented on issue #25373: [SPARK-28527][SQL][TEST] Re-run all the tests in SQLQueryTestSuite via Thrift Server URL: https://github.com/apache/spark/pull/25373#issuecomment-524032556 Ur, @wangyum . AFAIK, `Apache Maven` is the official primary `Apache Spark` project build

[GitHub] [spark] AmplabJenkins removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-524032216 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-524032226 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-523939972 **[Test build #109578 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-524032226 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-524032216 Merged build finished. Test PASSed.

[GitHub] [spark] srowen commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
srowen commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#discussion_r316835723 ## File path:

[GitHub] [spark] SparkQA commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations

2019-08-22 Thread GitBox
SparkQA commented on issue #25503: [SPARK-28702][SQL] Display useful error message (instead of NPE) for invalid Dataset operations URL: https://github.com/apache/spark/pull/25503#issuecomment-524031558 **[Test build #109578 has

[GitHub] [spark] dongjoon-hyun commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
dongjoon-hyun commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-524029729 Thank you so much, @srowen . This looks good to me. The only concern is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-524028940 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-524028937 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-524028940 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-524028937 Merged build finished. Test PASSed. This

[GitHub] [spark] zsxwing edited a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-22 Thread GitBox
zsxwing edited a comment on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-524028670 @eyalzit could you open a PR for 2.4? I can help if you don't have time. I did a quick check. There are just some minor

[GitHub] [spark] zsxwing commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer

2019-08-22 Thread GitBox
zsxwing commented on issue #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#issuecomment-524028670 @eyalzit could you open a PR for 2.4? I can help if you don't have time. I did a quick check. There is just some minor import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#discussion_r316831108 ## File path:

[GitHub] [spark] SparkQA commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
SparkQA commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-524028359 **[Test build #109588 has

[GitHub] [spark] SparkQA removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-523966704 **[Test build #109588 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#discussion_r316828437 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-524023761 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-524023755 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-524023761 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-524023755 Merged build finished. Test PASSed.

[GitHub] [spark] vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#discussion_r316824964 ## File path:

[GitHub] [spark] SparkQA commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
SparkQA commented on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-524022857 **[Test build #109586 has

[GitHub] [spark] SparkQA removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#issuecomment-523960042 **[Test build #109586 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#discussion_r316824245 ## File path:

[GitHub] [spark] dilipbiswal commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316820130 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala ## @@

[GitHub] [spark] MaxGekk commented on a change in pull request #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates

2019-08-22 Thread GitBox
MaxGekk commented on a change in pull request #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates URL: https://github.com/apache/spark/pull/25410#discussion_r316817684 ## File path:

[GitHub] [spark] dilipbiswal commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316817014 ## File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out ## @@ -0,0 +1,714 @@ +--

[GitHub] [spark] brkyvz commented on issue #25363: [SPARK-28628][SQL][WIP] Implement SupportsNamespaces in V2SessionCatalog

2019-08-22 Thread GitBox
brkyvz commented on issue #25363: [SPARK-28628][SQL][WIP] Implement SupportsNamespaces in V2SessionCatalog URL: https://github.com/apache/spark/pull/25363#issuecomment-524013000 The implementation is solid. Looking forward to the tests

[GitHub] [spark] rdblue commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
rdblue commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-524011892 @cloud-fan, I commented above, but just to be clear I think that the file source v2 read path also needs to be disabled

[GitHub] [spark] AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-524010766 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-524010777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-524010766 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-524010777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-22 Thread GitBox
SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-524008480 **[Test build #109591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109591/testReport)** for PR 25354 at

[GitHub] [spark] AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-524006925 Test FAILed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-524006919 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523996055 **[Test build #109590 has

[GitHub] [spark] AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-524006919 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-524006925 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
SparkQA commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-524006829 **[Test build #109590 has

[GitHub] [spark] vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#discussion_r316801882 ## File path:

[GitHub] [spark] MaxGekk commented on a change in pull request #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates

2019-08-22 Thread GitBox
MaxGekk commented on a change in pull request #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates URL: https://github.com/apache/spark/pull/25410#discussion_r316801765 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/timestamp.sql ##

[GitHub] [spark] vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#discussion_r316800906 ## File path:

[GitHub] [spark] MaxGekk commented on issue #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates

2019-08-22 Thread GitBox
MaxGekk commented on issue #25410: [SPARK-28690][SQL] Add `date_part` function for timestamps/dates URL: https://github.com/apache/spark/pull/25410#issuecomment-524002797 @dongjoon-hyun @maropu When I set `spark.sql.parser.ansi.enabled` to `false` there:

[GitHub] [spark] rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-22 Thread GitBox
rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r316799338 ## File path:

[GitHub] [spark] srowen commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-22 Thread GitBox
srowen commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-524000750 I would not enforce it only in IJ... do it or don't, I say. I think if we bite the bullet and make this

[GitHub] [spark] srowen commented on a change in pull request #25552: [SPARK-28849][CORE] Add a number to control transferTo calls to avoid infinite loop in some occasional cases

2019-08-22 Thread GitBox
srowen commented on a change in pull request #25552: [SPARK-28849][CORE] Add a number to control transferTo calls to avoid infinite loop in some occasional cases URL: https://github.com/apache/spark/pull/25552#discussion_r316797268 ## File path:

[GitHub] [spark] shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-22 Thread GitBox
shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#discussion_r316788688 ## File path:

[GitHub] [spark] sarutak commented on a change in pull request #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
sarutak commented on a change in pull request #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#discussion_r316795899 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523998300 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523998307 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523998307 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523998300 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523996660 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523996671 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523996671 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523996660 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523939927 **[Test build #109577 has

[GitHub] [spark] SparkQA commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
SparkQA commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523996055 **[Test build #109590 has

[GitHub] [spark] SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523996053 **[Test build #109589 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523995250 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523995244 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

2019-08-22 Thread GitBox
SparkQA commented on issue #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on URL: https://github.com/apache/spark/pull/25551#issuecomment-523995855 **[Test build #109577 has

[GitHub] [spark] AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523995244 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523995250 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] sarutak commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
sarutak commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523993834 Let's retry test on Jenkins and confirm whether the failure is caused by flaky

[GitHub] [spark] sarutak commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics

2019-08-22 Thread GitBox
sarutak commented on issue #24651: [SPARK-27420][DSTREAMS][Kinesis] KinesisInputDStream should expose a way to configure CloudWatch metrics URL: https://github.com/apache/spark/pull/24651#issuecomment-523993889 retest this please.

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-22 Thread GitBox
imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r316789183 ## File path:

[GitHub] [spark] shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-22 Thread GitBox
shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#discussion_r316788688 ## File path:

[GitHub] [spark] shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-22 Thread GitBox
shahidki31 commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#discussion_r316788688 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523979850 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523979844 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523979850 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523979844 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
SparkQA commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523979138 **[Test build #109575 has

[GitHub] [spark] SparkQA removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523888949 **[Test build #109575 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523974173 Test FAILed. Refer to this link for build results (access rights

[GitHub] [spark] SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-52397 **[Test build #109587 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523974161 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523974147 **[Test build #109587 has

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523974161 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523974173 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523973437 Test FAILed. Refer to this link for build results (access rights

[GitHub] [spark] SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523926765 **[Test build #109576 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523973430 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523973430 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
AmplabJenkins commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523973437 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523972915 **[Test build #109576 has

[GitHub] [spark] rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-22 Thread GitBox
rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523969454 > Once we make ANSI policy the default, then v1 and v2 can still have the same default policy From this

[GitHub] [spark] vanzin commented on issue #25341: [SPARK-28607][CORE][SHUFFLE] Don't store partition lengths twice.

2019-08-22 Thread GitBox
vanzin commented on issue #25341: [SPARK-28607][CORE][SHUFFLE] Don't store partition lengths twice. URL: https://github.com/apache/spark/pull/25341#issuecomment-523967896 Don't know. Need time to review and I've been busy.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-523965867 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
AmplabJenkins removed a comment on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-523965849 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python

2019-08-22 Thread GitBox
SparkQA commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python URL: https://github.com/apache/spark/pull/25545#issuecomment-523966704 **[Test build #109588 has

[GitHub] [spark] tgravescs commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
tgravescs commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-523966592 those changes LGTM, I only skimmed mostly and looked for ones I'm familiar with.

[GitHub] [spark] SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations

2019-08-22 Thread GitBox
SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-52397 **[Test build #109587 has

[GitHub] [spark] rdblue commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
rdblue commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r316757980 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ##

<    1   2   3   4   5   6   7   8   9   10   >