[GitHub] [spark] srowen commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0

2019-11-02 Thread GitBox
srowen commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0 URL: https://github.com/apache/spark/pull/26333#issuecomment-549054629 Understood, and I expect it's fine to merge this to 2.4 as well. While I'm also at Databricks, we all wear our ASF project 'hat'

[GitHub] [spark] etspaceman commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0

2019-11-02 Thread GitBox
etspaceman commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0 URL: https://github.com/apache/spark/pull/26333#issuecomment-549053630 This one is quite urgent for our team at Disney Streaming Services. We are going through a massive Kinesis scale-up and the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549053091 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549053087 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549053091 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041422 **[Test build #113130 has

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549053087 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549052949 **[Test build #113130 has

[GitHub] [spark] AmplabJenkins commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052846 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052846 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052850 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052850 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] SparkQA commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
SparkQA commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052695 **[Test build #113131 has

[GitHub] [spark] imback82 commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

2019-11-02 Thread GitBox
imback82 commented on issue #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#issuecomment-549052593 retest this please

[GitHub] [spark] srowen commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0

2019-11-02 Thread GitBox
srowen commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0 URL: https://github.com/apache/spark/pull/26333#issuecomment-549052434 I usually leave it open for a day or two if it's not urgent, esp at the weekend, just to see if anyone has further comments. It's

[GitHub] [spark] etspaceman commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0

2019-11-02 Thread GitBox
etspaceman commented on issue #26333: [SPARK-29677][DStreams] amazon-kinesis-client 1.12.0 URL: https://github.com/apache/spark/pull/26333#issuecomment-549051241 Anything else required before this is merged? This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549050186 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549050182 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549050182 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549050186 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039144 **[Test build #113129 has

[GitHub] [spark] SparkQA commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
SparkQA commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549050047 **[Test build #113129 has

[GitHub] [spark] srowen commented on a change in pull request #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write, Blacklisted, Logs, Threaddump columns

2019-11-02 Thread GitBox
srowen commented on a change in pull request #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump columns URL: https://github.com/apache/spark/pull/26263#discussion_r341813155 ## File path:

[GitHub] [spark] srowen commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

2019-11-02 Thread GitBox
srowen commented on issue #25344: [WIP][SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-549048294 Is this superseded by https://github.com/apache/spark/pull/26301 ?

[GitHub] [spark] srowen commented on a change in pull request #25632: [SPARK-28809][DOC][SQL]Document SHOW TABLE in SQL Reference

2019-11-02 Thread GitBox
srowen commented on a change in pull request #25632: [SPARK-28809][DOC][SQL]Document SHOW TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25632#discussion_r341812608 ## File path: docs/sql-ref-syntax-aux-show-table.md ## @@ -18,5 +18,153 @@ license: |

[GitHub] [spark] srowen commented on issue #26362: Turns `pre-built package` into a link to pre-built packages

2019-11-02 Thread GitBox
srowen commented on issue #26362: Turns `pre-built package` into a link to pre-built packages URL: https://github.com/apache/spark/pull/26362#issuecomment-549046673 This is OK, but please clean up the PR description and title per https://spark.apache.org/contributing.html Any other

[GitHub] [spark] SparkQA commented on issue #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils

2019-11-02 Thread GitBox
SparkQA commented on issue #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils URL: https://github.com/apache/spark/pull/26301#issuecomment-549046388 **[Test build #4913 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils URL: https://github.com/apache/spark/pull/26301#issuecomment-547708636 Can one of the admins verify this patch?

[GitHub] [spark] srowen commented on a change in pull request #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils

2019-11-02 Thread GitBox
srowen commented on a change in pull request #26301: [WIP] [SPARK-29644] [SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils URL: https://github.com/apache/spark/pull/26301#discussion_r341812085 ## File path:

[GitHub] [spark] srowen commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-11-02 Thread GitBox
srowen commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-549046017 I agree that compatibility is a minor issue here. But it also sounds like this change allows things to work that did not

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549045694 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549045691 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549045691 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549045694 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035169 **[Test build #113128 has

[GitHub] [spark] SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549045564 **[Test build #113128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113128/testReport)** for

[GitHub] [spark] cloud-fan closed pull request #26285: [SPARK-29623][SQL] do not allow multiple unit TO unit statements in interval literal syntax

2019-11-02 Thread GitBox
cloud-fan closed pull request #26285: [SPARK-29623][SQL] do not allow multiple unit TO unit statements in interval literal syntax URL: https://github.com/apache/spark/pull/26285 This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on issue #26285: [SPARK-29623][SQL] do not allow multiple unit TO unit statements in interval literal syntax

2019-11-02 Thread GitBox
cloud-fan commented on issue #26285: [SPARK-29623][SQL] do not allow multiple unit TO unit statements in interval literal syntax URL: https://github.com/apache/spark/pull/26285#issuecomment-549044500 thanks for the review, merging to master!

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041540 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041542 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041542 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041540 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549041422 **[Test build #113130 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549040724 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549040723 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549040724 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549040723 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025909 **[Test build #113126 has

[GitHub] [spark] SparkQA commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
SparkQA commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549040619 **[Test build #113126 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549039445 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549039443 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549039445 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549039443 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032681 **[Test build #113127 has

[GitHub] [spark] SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549039387 **[Test build #113127 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039264 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039261 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039264 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039261 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
SparkQA commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549039144 **[Test build #113129 has

[GitHub] [spark] MaxGekk commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
MaxGekk commented on issue #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368#issuecomment-549038881 @cloud-fan @hvanhovell Please, take a look at this. If it makes sense for you, we could discuss alternative

[GitHub] [spark] MaxGekk opened a new pull request #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes

2019-11-02 Thread GitBox
MaxGekk opened a new pull request #26368: [SPARK-29723][SQL] Get date and time parts of an interval as java classes URL: https://github.com/apache/spark/pull/26368 ### What changes were proposed in this pull request? I propose 2 new methods for `CalendarInterval`: - `period()`

[GitHub] [spark] AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549037872 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549037870 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549037872 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549037870 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549023191 **[Test build #113125 has

[GitHub] [spark] SparkQA commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
SparkQA commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549037786 **[Test build #113125 has

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035319 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035319 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035320 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035320 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549035169 **[Test build #113128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113128/testReport)** for

[GitHub] [spark] MaxGekk commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
MaxGekk commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549034769 jenkins, retest this, please This is an automated message from

[GitHub] [spark] peter-toth commented on issue #26044: [SPARK-29375][SQL] Exchange reuse across all subquery levels

2019-11-02 Thread GitBox
peter-toth commented on issue #26044: [SPARK-29375][SQL] Exchange reuse across all subquery levels URL: https://github.com/apache/spark/pull/26044#issuecomment-549034118 @cloud-fan @dongjoon-hyun @gatorsmile @maropu @maryannxue @mgaido91 @viirya any feedback/comment is gladly welcome

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032766 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032768 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032768 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032766 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
SparkQA commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032681 **[Test build #113127 has

[GitHub] [spark] MaxGekk commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
MaxGekk commented on issue #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367#issuecomment-549032490 ping @cloud-fan @dongjoon-hyun This is an automated

[GitHub] [spark] MaxGekk opened a new pull request #26367: [SPARK-29671][SQL] Simplify string representation of intervals

2019-11-02 Thread GitBox
MaxGekk opened a new pull request #26367: [SPARK-29671][SQL] Simplify string representation of intervals URL: https://github.com/apache/spark/pull/26367 ### What changes were proposed in this pull request? In the PR, I propose to changed `CalendarInterval.toString`: - to skip the

[GitHub] [spark] cxzl25 commented on issue #26323: [SPARK-29657][CORE] Iterator spill supporting radix sort with null prefix

2019-11-02 Thread GitBox
cxzl25 commented on issue #26323: [SPARK-29657][CORE] Iterator spill supporting radix sort with null prefix URL: https://github.com/apache/spark/pull/26323#issuecomment-549031424 @JoshRosen @davies Can you look at this pr when you are free? Thank you.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549030383 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549030382 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549030383 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549030382 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
SparkQA commented on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549030298 **[Test build #113124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113124/testReport)** for

[GitHub] [spark] SparkQA removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting

2019-11-02 Thread GitBox
SparkQA removed a comment on issue #26256: [SPARK-29605][SQL] Optimize string to interval casting URL: https://github.com/apache/spark/pull/26256#issuecomment-549020901 **[Test build #113124 has

[GitHub] [spark] MaxGekk commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default

2019-11-02 Thread GitBox
MaxGekk commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r341805513 ## File path:

[GitHub] [spark] MaxGekk commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default

2019-11-02 Thread GitBox
MaxGekk commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r341805513 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025979 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025981 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025981 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] yaooqinn commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
yaooqinn commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025953 cc @ueshin @gatorsmile @cloud-fan @HyukjinKwon @dongjoon-hyun, thanks in advance.

[GitHub] [spark] AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
AmplabJenkins commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025979 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
SparkQA commented on issue #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366#issuecomment-549025909 **[Test build #113126 has

[GitHub] [spark] yaooqinn commented on a change in pull request #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-02 Thread GitBox
yaooqinn commented on a change in pull request #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#discussion_r341804338 ## File path:

[GitHub] [spark] yaooqinn opened a new pull request #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions

2019-11-02 Thread GitBox
yaooqinn opened a new pull request #26366: [SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions URL: https://github.com/apache/spark/pull/26366 ### What changes were proposed in this pull request? Support non-reversed keywords to be used in high

[GitHub] [spark] AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`

2019-11-02 Thread GitBox
AmplabJenkins removed a comment on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549023309 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   >