[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344115266 ## File path: mllib/src/main/scala/org/apache/spark/ml/regression/FMRegress

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344109298 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344024509 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551568884 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344114969 ## File path: mllib/src/main/scala/org/apache/spark/ml/regression/FMRegress

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344024143 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551568849 Merged build finished. Test FAILed. T

[GitHub] [spark] SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551567947 **[Test build #113453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11345

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344103733 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344109884 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344112132 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344115165 ## File path: mllib/src/main/scala/org/apache/spark/ml/regression/FMRegress

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344112686 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344108759 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344111904 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344107245 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-08 Thread GitBox
zhengruifeng commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344023746 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMCla

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-551548087 Can one of the admins verify this patch? Thi

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-551549935 Can one of the admins verify this patch? This is an

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-551548087 Can one of the admins verify this patch? This is an

[GitHub] [spark] AngersZhuuuu commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-08 Thread GitBox
AngersZh commented on issue #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-551548633 @cloud-fan Use this change in https://github.com/apache/spark/pull/26431 make result right as PostgresSQL But I

[GitHub] [spark] AngersZhuuuu opened a new pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-08 Thread GitBox
AngersZh opened a new pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437 ### What changes were proposed in this pull request? When use `EXISTS` in Join's `ON` condition, some join type such as FULL O

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-08 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r344110822 ## File path: core/src/test/scala/org/apache/spark/deploy/

[GitHub] [spark] Ngone51 commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
Ngone51 commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#discussion_r344112213 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMast

[GitHub] [spark] zhengruifeng closed pull request #26398: [SPARK-29756][ML] CountVectorizer forget to unpersist intermediate rdd

2019-11-08 Thread GitBox
zhengruifeng closed pull request #26398: [SPARK-29756][ML] CountVectorizer forget to unpersist intermediate rdd URL: https://github.com/apache/spark/pull/26398 This is an automated message from the Apache Git Service. To res

[GitHub] [spark] AmplabJenkins commented on issue #26436: [MINOR]FsHistoryProvider import cleanup

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26436: [MINOR]FsHistoryProvider import cleanup URL: https://github.com/apache/spark/pull/26436#issuecomment-551538301 Can one of the admins verify this patch? This is an automated message from

[GitHub] [spark] gaborgsomogyi commented on issue #26436: [MINOR]FsHistoryProvider import cleanup

2019-11-08 Thread GitBox
gaborgsomogyi commented on issue #26436: [MINOR]FsHistoryProvider import cleanup URL: https://github.com/apache/spark/pull/26436#issuecomment-551536810 cc @vanzin @srowen @HeartSaVioR This is an automated message from the Apa

[GitHub] [spark] SparkQA commented on issue #26436: [MINOR]FsHistoryProvider import cleanup

2019-11-08 Thread GitBox
SparkQA commented on issue #26436: [MINOR]FsHistoryProvider import cleanup URL: https://github.com/apache/spark/pull/26436#issuecomment-551536768 **[Test build #113456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113456/testReport)** for PR 26436 at commi

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-08 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r344109687 ## File path: core/src/main/scala/org/apache/spark/deploy/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551532735 Test PASSed. Refer to this link for build results (access rights to CI server needed)

[GitHub] [spark] gaborgsomogyi opened a new pull request #26436: [MINOR]FsHistoryProvider import cleanup

2019-11-08 Thread GitBox
gaborgsomogyi opened a new pull request #26436: [MINOR]FsHistoryProvider import cleanup URL: https://github.com/apache/spark/pull/26436 ### What changes were proposed in this pull request? As it has been discussed in https://github.com/apache/spark/pull/26397#discussion_r343726691 `FsH

[GitHub] [spark] AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551532697 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551532697 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551532735 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] SparkQA removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
SparkQA removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551426559 **[Test build #113446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReques

[GitHub] [spark] SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551530128 **[Test build #113446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilde

[GitHub] [spark] iRakson commented on issue #26315: [SPARK-29152] Executor Plugin shutdown when dynamic allocation is ena…

2019-11-08 Thread GitBox
iRakson commented on issue #26315: [SPARK-29152] Executor Plugin shutdown when dynamic allocation is ena… URL: https://github.com/apache/spark/pull/26315#issuecomment-551510270 > All the previous comments are still outstanding. plugin Shutdown method has been removed. executorShutdow

[GitHub] [spark] AmplabJenkins removed a comment on issue #26435: Allow calling non-aggregate SQL functions with column name

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26435: Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#issuecomment-551501316 Can one of the admins verify this patch? This

[GitHub] [spark] AmplabJenkins commented on issue #26435: Allow calling non-aggregate SQL functions with column name

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26435: Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#issuecomment-551503137 Can one of the admins verify this patch? This is an au

[GitHub] [spark] AmplabJenkins commented on issue #26435: Allow calling non-aggregate SQL functions with column name

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26435: Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#issuecomment-551501316 Can one of the admins verify this patch? This is an au

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344095845 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/c

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344095811 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/c

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344097331 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/c

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344099249 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344096448 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/c

[GitHub] [spark] MaxHaertwig opened a new pull request #26435: Allow calling non-aggregate SQL functions with column name

2019-11-08 Thread GitBox
MaxHaertwig opened a new pull request #26435: Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435 ### What changes were proposed in this pull request? I added functions that can be called with the column name for the func

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344098788 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344096376 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/c

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344098840 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] HeartSaVioR commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-08 Thread GitBox
HeartSaVioR commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r344096886 ## File path: core/src/main/scala/org/apache/spark/deploy/hi

[GitHub] [spark] AmplabJenkins removed a comment on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#issuecomment-551480180 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#issuecomment-551480155 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#issuecomment-551480155 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#issuecomment-551480180 Test PASSed. Refer to this link for build results (access rights to CI server needed)

[GitHub] [spark] SparkQA commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
SparkQA commented on issue #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#issuecomment-551478479 **[Test build #113455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReques

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092308 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execu

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092267 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/c

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092239 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/c

[GitHub] [spark] LantaoJin commented on a change in pull request #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-08 Thread GitBox
LantaoJin commented on a change in pull request #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#discussion_r344092091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ##

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092124 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/c

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092158 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/c

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344092198 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/c

[GitHub] [spark] cloud-fan commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#discussion_r344091241 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMa

[GitHub] [spark] AngersZhuuuu commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition

2019-11-08 Thread GitBox
AngersZh commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition URL: https://github.com/apache/spark/pull/26431#issuecomment-551450466 > I think we need to update `PlanSubqueries` to fai if it hit subqueries that it can't pla

[GitHub] [spark] AmplabJenkins removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551447730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551447725 Merged build finished. Test PASSed. This i

[GitHub] [spark] AmplabJenkins commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551447725 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551447730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] cloud-fan commented on a change in pull request #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#discussion_r344064290 ## File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql ## @@ -0,0 +

[GitHub] [spark] SparkQA commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
SparkQA commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551447181 **[Test build #113454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113454/testReport)*

[GitHub] [spark] cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551446907 retest this please This is an automated message from t

[GitHub] [spark] cloud-fan commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition

2019-11-08 Thread GitBox
cloud-fan commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition URL: https://github.com/apache/spark/pull/26431#issuecomment-551446298 I think we need to update `PlanSubqueries` to fai if it hit subqueries that it can't plan. @A

[GitHub] [spark] maropu commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-08 Thread GitBox
maropu commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551445578 retest this please This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551445078 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551445062 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551445078 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551445062 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-08 Thread GitBox
SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-551444576 **[Test build #113453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113453

[GitHub] [spark] maropu commented on a change in pull request #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-08 Thread GitBox
maropu commented on a change in pull request #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#discussion_r344055080 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala #

[GitHub] [spark] beliefer commented on a change in pull request #26420: [SPARK-27986] Support ANSI SQL filter predicate for aggregate expression.

2019-11-08 Thread GitBox
beliefer commented on a change in pull request #26420: [SPARK-27986] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#discussion_r344054409 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/Hash

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-08 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r344054288 ## File path: core/src/main/scala/org/apache/spark/deploy/

[GitHub] [spark] gaborgsomogyi commented on issue #23956: [SPARK-27042][SS] Close cached Kafka producer in case of task retry

2019-11-08 Thread GitBox
gaborgsomogyi commented on issue #23956: [SPARK-27042][SS] Close cached Kafka producer in case of task retry URL: https://github.com/apache/spark/pull/23956#issuecomment-551442420 https://github.com/apache/spark/pull/25853 merged which allows to invalidate producers (and not close when in

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344045675 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execut

[GitHub] [spark] AngersZhuuuu commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition

2019-11-08 Thread GitBox
AngersZh commented on issue #26431: [SPARK-29769][SQL] Support "exists/not exists" condition as all type Join's on cpndition URL: https://github.com/apache/spark/pull/26431#issuecomment-551440104 > So the direct cause is that we can't plan the subquery. What's the problem in the planne

[GitHub] [spark] xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344043241 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551439423 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551439423 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551439417 Merged build finished. Test PASSed. This is a

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344042674 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551439417 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344042369 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] SparkQA commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
SparkQA commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551438951 **[Test build #113452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113452/testReport)**

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344040821 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] yaooqinn commented on a change in pull request #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-08 Thread GitBox
yaooqinn commented on a change in pull request #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#discussion_r344040810 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ## @@ -192,4 +19

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344039131 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan

2019-11-08 Thread GitBox
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan URL: https://github.com/apache/spark/pull/26167#discussion_r344038513 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/ca

[GitHub] [spark] yaooqinn opened a new pull request #26279: [SPARK-28382][SQL] Add array function - unnest

2019-11-08 Thread GitBox
yaooqinn opened a new pull request #26279: [SPARK-28382][SQL] Add array function - unnest URL: https://github.com/apache/spark/pull/26279 ### What changes were proposed in this pull request? Function | Return Type | Description | Example | Result -- | -- | -- | -- | --

[GitHub] [spark] AbhishekNew commented on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write, Blacklisted, Logs, Threaddump columns

2019-11-08 Thread GitBox
AbhishekNew commented on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump columns URL: https://github.com/apache/spark/pull/26263#issuecomment-551435321 Display tooltip at center is standard. Looks good to me. ---

[GitHub] [spark] yaooqinn commented on issue #26279: [SPARK-28382][SQL] Add array function - unnest

2019-11-08 Thread GitBox
yaooqinn commented on issue #26279: [SPARK-28382][SQL] Add array function - unnest URL: https://github.com/apache/spark/pull/26279#issuecomment-551435541 > ```sql > postgres=# select unnest(array[array[1, 2], array[3, 4]]); > unnest > > 1 > 2 >

[GitHub] [spark] yaooqinn closed pull request #26279: [SPARK-28382][SQL] Add array function - unnest

2019-11-08 Thread GitBox
yaooqinn closed pull request #26279: [SPARK-28382][SQL] Add array function - unnest URL: https://github.com/apache/spark/pull/26279 This is an automated message from the Apache Git Service. To respond to the message, please

<    3   4   5   6   7   8   9   >