[GitHub] [spark] maropu commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-02 Thread GitBox
maropu commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#discussion_r352902281 ## File path: docs/sql-migration-guide.md ## @@ -25

[GitHub] [spark] AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-560812862 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-560565474 **[Test build #114737 has started](https://amplab.cs.berkeley.edu/jenkins/job/Sp

[GitHub] [spark] SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system

2019-12-02 Thread GitBox
SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-560808573 **[Test build #114737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPull

[GitHub] [spark] maropu commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-02 Thread GitBox
maropu commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r352899754 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis

[GitHub] [spark] HeartSaVioR commented on issue #26709: [SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType correctly

2019-12-02 Thread GitBox
HeartSaVioR commented on issue #26709: [SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType correctly URL: https://github.com/apache/spark/pull/26709#issuecomment-560791418 Thanks all for reviewing and merging!

[GitHub] [spark] HeartSaVioR commented on issue #26732: [MINOR][SS] Add implementation note on overriding serialize/deserialize in HDFSMetadataLog methods' scaladoc

2019-12-02 Thread GitBox
HeartSaVioR commented on issue #26732: [MINOR][SS] Add implementation note on overriding serialize/deserialize in HDFSMetadataLog methods' scaladoc URL: https://github.com/apache/spark/pull/26732#issuecomment-560790803 Thanks all for reviewing and merging! -

[GitHub] [spark] maropu commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
maropu commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560778189 cc: @cloud-fan @dongjoon-hyun --

[GitHub] [spark] maropu commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-12-02 Thread GitBox
maropu commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-560768225 Yea, I also think we need to add a flag to cover the issue. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560736240 Test FAILed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560736194 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535360 **[Test build #114736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1147

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560736240 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560736194 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560734440 **[Test build #114736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114736/test

[GitHub] [spark] AmplabJenkins removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-560713045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-560712991 Build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-560712991 Build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-560713045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] SparkQA commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
SparkQA commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-560709548 **[Test build #114738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114738/testReport)

[GitHub] [spark] hvanhovell commented on a change in pull request #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-02 Thread GitBox
hvanhovell commented on a change in pull request #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#discussion_r352881909 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CollectMetricsExec.sca

[GitHub] [spark] mccheah commented on issue #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
mccheah commented on issue #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-560665325 @dongjoon-hyun can you take a look? This is an automated message

[GitHub] [spark] mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#discussion_r352868164 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ## @@ -

[GitHub] [spark] mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#discussion_r352868340 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ## @@ -

[GitHub] [spark] mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
mccheah commented on a change in pull request #26738: [SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#discussion_r352867265 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ## @@ -

[GitHub] [spark] hvanhovell commented on a change in pull request #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan

2019-12-02 Thread GitBox
hvanhovell commented on a change in pull request #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#discussion_r352848870 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@

[GitHub] [spark] hvanhovell commented on a change in pull request #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan

2019-12-02 Thread GitBox
hvanhovell commented on a change in pull request #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#discussion_r352848870 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@

[GitHub] [spark] hvanhovell commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan

2019-12-02 Thread GitBox
hvanhovell commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-560584746 Retriggered the linting job, lets see what comes up. This is an aut

[GitHub] [spark] AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560572236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560572236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560572227 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560572227 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560512427 **[Test build #114734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1147

[GitHub] [spark] SparkQA commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks

2019-12-02 Thread GitBox
SparkQA commented on issue #26614: [SPARK-29976][CORE] Trigger speculation for stages with too few tasks URL: https://github.com/apache/spark/pull/26614#issuecomment-560571509 **[Test build #114734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114734/test

[GitHub] [spark] SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system

2019-12-02 Thread GitBox
SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-560565474 **[Test build #114737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560555851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560555841 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560555841 Merged build finished. Test PASSed. This is a

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560555851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] [spark] hvanhovell closed pull request #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries

2019-12-02 Thread GitBox
hvanhovell closed pull request #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries URL: https://github.com/apache/spark/pull/26705 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] hvanhovell commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries

2019-12-02 Thread GitBox
hvanhovell commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries URL: https://github.com/apache/spark/pull/26705#issuecomment-560555678 Merging to master This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560528948 **[Test build #114735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114735/testRep

[GitHub] [spark] SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560555468 **[Test build #114735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114735/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table URL: https://github.com/apache/spark/pull/26740#issuecomment-560553849 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table URL: https://github.com/apache/spark/pull/26740#issuecomment-560554339 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table URL: https://github.com/apache/spark/pull/26740#issuecomment-560553849 Can one of the admins verify this patch?

[GitHub] [spark] AndrewKL opened a new pull request #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table

2019-12-02 Thread GitBox
AndrewKL opened a new pull request #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table URL: https://github.com/apache/spark/pull/26740 https://issues.apache.org/jira/browse/SPARK-30053?page=com.atlassian.jira.plugin.system.issuetabpanels%3Ac

[GitHub] [spark] srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352780059 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7 +

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535896 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535896 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #26738: [WIP][SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26738: [WIP][SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-560456369 Can one of the admins verify this patch? This

[GitHub] [spark] mccheah commented on issue #26738: [WIP][SPARK-30082] Do not replace Zeros when replacing NaNs

2019-12-02 Thread GitBox
mccheah commented on issue #26738: [WIP][SPARK-30082] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-560535450 Ok to test This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560535360 **[Test build #114736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114736/testR

[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-12-02 Thread GitBox
Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r352771008 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ###

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560529567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560529559 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560529567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560529559 Merged build finished. Test PASSed. This is a

[GitHub] [spark] SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-560528948 **[Test build #114735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114735/testReport)**

[GitHub] [spark] huaxingao commented on a change in pull request #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
huaxingao commented on a change in pull request #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#discussion_r352764710 ## File path: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ## @@

[GitHub] [spark] Fokko closed pull request #26737: [SPARK-30103][SQL] Consolidate Schema merge logic

2019-12-02 Thread GitBox
Fokko closed pull request #26737: [SPARK-30103][SQL] Consolidate Schema merge logic URL: https://github.com/apache/spark/pull/26737 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] Fokko commented on issue #26737: [SPARK-30103][SQL] Consolidate Schema merge logic

2019-12-02 Thread GitBox
Fokko commented on issue #26737: [SPARK-30103][SQL] Consolidate Schema merge logic URL: https://github.com/apache/spark/pull/26737#issuecomment-560526443 I found the difference, the `.merge()` will actually take the union of the schema's, while the `TypeCoercion.findTightestCommonType()` w

[GitHub] [spark] huaxingao opened a new pull request #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-02 Thread GitBox
huaxingao opened a new pull request #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739 ### What changes were proposed in this pull request? add weight support in KMeans ### Why are the changes needed? KMeans should su

[GitHub] [spark] zsxwing commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink

2019-12-02 Thread GitBox
zsxwing commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#discussion_r352759721 ## File path: sql/core/src/main/scala/

[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352757120 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7

[GitHub] [spark] rdblue commented on a change in pull request #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-12-02 Thread GitBox
rdblue commented on a change in pull request #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#discussion_r352756387 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connecto

[GitHub] [spark] tgravescs commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
tgravescs commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560515037 so just want to confirm with @squito and @jiangxb1987 , It looks like what is implemented now is the number of un

[GitHub] [spark] AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560513058 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560513052 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560513052 Merged build finished. Test PASSed. This i

[GitHub] [spark] AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560513058 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] SparkQA commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
SparkQA commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560512427 **[Test build #114734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114734/testReport)*

[GitHub] [spark] srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352746869 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7 +

[GitHub] [spark] tgravescs commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation

2019-12-02 Thread GitBox
tgravescs commented on issue #26614: [SPARK-29976][CORE] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-560510257 test this please This is an automated message from the

[GitHub] [spark] zsxwing commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-12-02 Thread GitBox
zsxwing commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-560508633 Yep. As reverting this can cause another behavior change, we should avoid doing this i

[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352740785 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7

[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352740785 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7

[GitHub] [spark] AmplabJenkins commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560498295 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab

[GitHub] [spark] AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560498295 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560498289 Merged build finished. Test PASSed. This i

[GitHub] [spark] AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560498289 Merged build finished. Test PASSed. ---

[GitHub] [spark] SparkQA removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560399962 **[Test build #114732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114

[GitHub] [spark] SparkQA commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
SparkQA commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560497625 **[Test build #114732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114732/tes

[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560490323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560490318 Merged build finished. Test PASSed. Th

[GitHub] [spark] AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560490323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560490318 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560385470 **[Test build #114730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114730/

[GitHub] [spark] SparkQA commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-02 Thread GitBox
SparkQA commented on issue #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#issuecomment-560489615 **[Test build #114730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114730/testRep

[GitHub] [spark] srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-12-02 Thread GitBox
srowen commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r352718162 ## File path: streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala ## @@ -162,7 +

[GitHub] [spark] SparkQA removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
SparkQA removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560388295 **[Test build #114731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] AmplabJenkins removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560484669 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560484656 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560484669 Test PASSed. Refer to this link for build results (access rights to CI server needed

[GitHub] [spark] AmplabJenkins commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
AmplabJenkins commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560484656 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset

2019-12-02 Thread GitBox
SparkQA commented on issue #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset URL: https://github.com/apache/spark/pull/26681#issuecomment-560483992 **[Test build #114731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560471137 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-02 Thread GitBox
AmplabJenkins removed a comment on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-560471145 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

<    1   2   3   4   5   6   7   8   >