[GitHub] [spark] XuQianJin-Stars edited a comment on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls

2019-12-15 Thread GitBox
XuQianJin-Stars edited a comment on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-565938938 > Can you please investigate how other systems like Kafka, Hadoop handle this problem? Adding

[GitHub] [spark] ulysses-you commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT

2019-12-15 Thread GitBox
ulysses-you commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT URL: https://github.com/apache/spark/pull/26831#discussion_r358089369 ## File path:

[GitHub] [spark] ulysses-you commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT

2019-12-15 Thread GitBox
ulysses-you commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT URL: https://github.com/apache/spark/pull/26831#discussion_r358089369 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565938983 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565938993 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938572 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565938983 Merged build finished. Test PASSed. This is an

[GitHub] [spark] HyukjinKwon commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
HyukjinKwon commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938890 Merged to master and branch-2.4. This is an automated message

[GitHub] [spark] XuQianJin-Stars commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls

2019-12-15 Thread GitBox
XuQianJin-Stars commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-565938938 > Can you please investigate how other systems like Kafka, Hadoop handle this problem? Adding

[GitHub] [spark] AmplabJenkins commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565938993 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938566 Merged build finished. Test PASSed. This is an

[GitHub] [spark] HyukjinKwon closed pull request #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
HyukjinKwon closed pull request #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
SparkQA removed a comment on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565904733 **[Test build #115375 has

[GitHub] [spark] AmplabJenkins commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938566 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938572 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
SparkQA commented on issue #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#issuecomment-565938379 **[Test build #115375 has

[GitHub] [spark] SparkQA removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
SparkQA removed a comment on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565889436 **[Test build #115372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115372/testReport)**

[GitHub] [spark] SparkQA commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function

2019-12-15 Thread GitBox
SparkQA commented on issue #26896: [MINOR][DOCS] Fix documentation for slide function URL: https://github.com/apache/spark/pull/26896#issuecomment-565938021 **[Test build #115372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115372/testReport)** for PR

[GitHub] [spark] cloud-fan edited a comment on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier

2019-12-15 Thread GitBox
cloud-fan edited a comment on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier URL: https://github.com/apache/spark/pull/26897#issuecomment-565926586 If something is only being tested but not nothing else, it's dead code. I checked the removed

[GitHub] [spark] cloud-fan edited a comment on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier

2019-12-15 Thread GitBox
cloud-fan edited a comment on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier URL: https://github.com/apache/spark/pull/26897#issuecomment-565926586 If something is only being tested not nothing else, it's dead code. I checked the removed tests

[GitHub] [spark] HyukjinKwon edited a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-15 Thread GitBox
HyukjinKwon edited a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-565935837 Sorry, @cloud-fan, I just checked the cc. > The result is unexpected. In ResolveAlias,

[GitHub] [spark] HyukjinKwon commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-15 Thread GitBox
HyukjinKwon commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-565935837 Sorry, @cloud-fan, I just checked the cc. > The result is unexpected. In ResolveAlias, we only

[GitHub] [spark] cloud-fan commented on a change in pull request #26894: [SPARK-30094][SQL] Apply current namespace for the single-part table name

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26894: [SPARK-30094][SQL] Apply current namespace for the single-part table name URL: https://github.com/apache/spark/pull/26894#discussion_r358079795 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
viirya commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#discussion_r358077265 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#issuecomment-565931705 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#issuecomment-565931713 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] amanomer commented on issue #26808: [SPARK-30184][SQL] Implement a helper method for aliasing functions

2019-12-15 Thread GitBox
amanomer commented on issue #26808: [SPARK-30184][SQL] Implement a helper method for aliasing functions URL: https://github.com/apache/spark/pull/26808#issuecomment-565931668 Tests have passed. Kindly review. @cloud-fan

[GitHub] [spark] AmplabJenkins commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#issuecomment-565931713 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#issuecomment-565931705 Merged build finished. Test PASSed.

[GitHub] [spark] amanomer commented on a change in pull request #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType

2019-12-15 Thread GitBox
amanomer commented on a change in pull request #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType URL: https://github.com/apache/spark/pull/26811#discussion_r358076319 ## File path:

[GitHub] [spark] amanomer removed a comment on issue #26808: [SPARK-30184][SQL] Implement a helper method for aliasing functions

2019-12-15 Thread GitBox
amanomer removed a comment on issue #26808: [SPARK-30184][SQL] Implement a helper method for aliasing functions URL: https://github.com/apache/spark/pull/26808#issuecomment-565785795 Tests have passed. Kindly review cc @maropu @cloud-fan

[GitHub] [spark] amanomer commented on a change in pull request #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType

2019-12-15 Thread GitBox
amanomer commented on a change in pull request #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType URL: https://github.com/apache/spark/pull/26811#discussion_r358076174 ## File path:

[GitHub] [spark] SparkQA commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
SparkQA commented on issue #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#issuecomment-565931326 **[Test build #115380 has

[GitHub] [spark] sarutak commented on a change in pull request #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
sarutak commented on a change in pull request #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#discussion_r358075772 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala

[GitHub] [spark] viirya commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
viirya commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#discussion_r358075604 ## File path: python/pyspark/ml/classification.py

[GitHub] [spark] sarutak commented on a change in pull request #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs

2019-12-15 Thread GitBox
sarutak commented on a change in pull request #26703: [SPARK-29997][WEBUI][FOLLOWUP] Refactor code for job description of empty jobs URL: https://github.com/apache/spark/pull/26703#discussion_r358075572 ## File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala

[GitHub] [spark] jerryshao commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls

2019-12-15 Thread GitBox
jerryshao commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-565930482 Can you please investigate how other systems like Kafka, Hadoop handle this problem? Adding parameter

[GitHub] [spark] AmplabJenkins removed a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565929821 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565929813 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565929813 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565929821 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
SparkQA commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565929533 **[Test build #115379 has

[GitHub] [spark] JkSelf commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
JkSelf commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565928572 @cloud-fan Ok, I will fix the failed tests firstly. Thanks.

[GitHub] [spark] JkSelf opened a new pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
JkSelf opened a new pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813 ### What changes were proposed in this pull request? Enable adaptive query execution default ### Why are the changes

[GitHub] [spark] cloud-fan edited a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
cloud-fan edited a comment on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565927319 It's arguable that if we should turn on AQE by default in 3.0 or not. But I think it's worthwhile to try

[GitHub] [spark] shahidki31 commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab

2019-12-15 Thread GitBox
shahidki31 commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab URL: https://github.com/apache/spark/pull/26756#discussion_r358072287 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

2019-12-15 Thread GitBox
cloud-fan commented on issue #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default URL: https://github.com/apache/spark/pull/26813#issuecomment-565927319 It's arguable that if we should turn on AQE by default in 3.0 or not. But I think it's worthwhile to try turn it

[GitHub] [spark] cloud-fan commented on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier

2019-12-15 Thread GitBox
cloud-fan commented on issue #26897: [SPARK-30104][SQL][FOLLOWUP] Remove LookupCatalog.AsTemporaryViewIdentifier URL: https://github.com/apache/spark/pull/26897#issuecomment-565926586 If something is only used in tests, it's dead code. I checked the removed tests and they solely test

[GitHub] [spark] viirya commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
viirya commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#issuecomment-565926605 Looks good.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#issuecomment-565926110 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#issuecomment-565926119 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#issuecomment-565926110 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#issuecomment-565926119 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] yaooqinn commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types

2019-12-15 Thread GitBox
yaooqinn commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types URL: https://github.com/apache/spark/pull/26699#discussion_r358071270 ## File path:

[GitHub] [spark] SparkQA commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
SparkQA commented on issue #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#issuecomment-565925834 **[Test build #115378 has

[GitHub] [spark] cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types URL: https://github.com/apache/spark/pull/26699#discussion_r358070749 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
HyukjinKwon commented on a change in pull request #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903#discussion_r358070696 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

[GitHub] [spark] HyukjinKwon opened a new pull request #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String)

2019-12-15 Thread GitBox
HyukjinKwon opened a new pull request #26903: [SPARK-30200][DOCS][FOLLOW-UP] Add documentation for explain(mode: String) URL: https://github.com/apache/spark/pull/26903 ### What changes were proposed in this pull request? This PR adds the documentation of the new `mode` added to

[GitHub] [spark] cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types URL: https://github.com/apache/spark/pull/26699#discussion_r358070565 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26699: [SPARK-30066][SQL] Support columnar execution on interval types URL: https://github.com/apache/spark/pull/26699#discussion_r358070365 ## File path:

[GitHub] [spark] iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab

2019-12-15 Thread GitBox
iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab URL: https://github.com/apache/spark/pull/26756#discussion_r358069951 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
cloud-fan commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565924368 > In fact, we only need to reserve -1 when doing min max statistics in SQLMetrics.stringValue

[GitHub] [spark] iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab

2019-12-15 Thread GitBox
iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab URL: https://github.com/apache/spark/pull/26756#discussion_r358069458 ## File path:

[GitHub] [spark] iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab

2019-12-15 Thread GitBox
iRakson commented on a change in pull request #26756: [SPARK-30119][WebUI]Support Pagination for Batch Tables in Streaming Tab URL: https://github.com/apache/spark/pull/26756#discussion_r358068966 ## File path:

[GitHub] [spark] wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565921324 Merged to master. This is an

[GitHub] [spark] wangyum closed pull request #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
wangyum closed pull request #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902 This is an automated message from the Apache Git

[GitHub] [spark] wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565921177 I'm merging it and will be releasing v3.0.0-preview2 soon.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
HyukjinKwon commented on a change in pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#discussion_r358065239 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565919210 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565919203 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565919203 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565919210 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
SparkQA commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565918944 **[Test build #115377 has

[GitHub] [spark] cloud-fan commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
cloud-fan commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565918538 ok to test This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-565813077 Can one of the admins verify this patch?

[GitHub] [spark] cloud-fan commented on issue #26887: [SPARK-30259][SQL] Fix CREATE TABLE behavior when session catalog is specified explicitly

2019-12-15 Thread GitBox
cloud-fan commented on issue #26887: [SPARK-30259][SQL] Fix CREATE TABLE behavior when session catalog is specified explicitly URL: https://github.com/apache/spark/pull/26887#issuecomment-565918083 good catch! late LGTM This

[GitHub] [spark] gatorsmile commented on a change in pull request #23943: [SPARK-27034][SQL] Nested schema pruning for ORC

2019-12-15 Thread GitBox
gatorsmile commented on a change in pull request #23943: [SPARK-27034][SQL] Nested schema pruning for ORC URL: https://github.com/apache/spark/pull/23943#discussion_r358063793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565917516 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565917522 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] cloud-fan commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26831: [SPARK-30201][SQL] HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT URL: https://github.com/apache/spark/pull/26831#discussion_r358063675 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565917522 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565917516 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#discussion_r358063371 ## File path:

[GitHub] [spark] SparkQA commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
SparkQA commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565917197 **[Test build #115376 has

[GitHub] [spark] huaxingao commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
huaxingao commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#discussion_r358063126 ## File path:

[GitHub] [spark] wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
wangyum commented on issue #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902#issuecomment-565916254 cc @dongjoon-hyun @HyukjinKwon

[GitHub] [spark] wangyum opened a new pull request #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh`

2019-12-15 Thread GitBox
wangyum opened a new pull request #26902: Revert "[SPARK-30056][INFRA] Skip building test artifacts in `dev/make-distribution.sh` URL: https://github.com/apache/spark/pull/26902 #15267 # What changes were proposed in this pull request? This reverts commit 7c0ce285. ### Why

[GitHub] [spark] huaxingao commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
huaxingao commented on a change in pull request #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#discussion_r358061923 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565914120 Test FAILed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565914113 Merged build finished. Test FAILed.

[GitHub] [spark] cloud-fan commented on a change in pull request #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2019-12-15 Thread GitBox
cloud-fan commented on a change in pull request #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#discussion_r358060612 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
SparkQA removed a comment on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565895997 **[Test build #115374 has

[GitHub] [spark] AmplabJenkins commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565914113 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565914120 Test FAILed. Refer to this link for build results (access rights to

[GitHub] [spark] HyukjinKwon closed pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
HyukjinKwon closed pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898 This is an automated message

[GitHub] [spark] SparkQA commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams

2019-12-15 Thread GitBox
SparkQA commented on issue #26838: [SPARK-30144][ML][PySpark] Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams URL: https://github.com/apache/spark/pull/26838#issuecomment-565913975 **[Test build #115374 has

[GitHub] [spark] HyukjinKwon commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
HyukjinKwon commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#issuecomment-565913928 Thanks guys. Merged to master.

[GitHub] [spark] AmplabJenkins commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#issuecomment-565913851 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
AmplabJenkins commented on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#issuecomment-565913855 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

2019-12-15 Thread GitBox
AmplabJenkins removed a comment on issue #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes URL: https://github.com/apache/spark/pull/26898#issuecomment-565913855 Test PASSed. Refer to this link for build results (access

  1   2   3   4   5   >