[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359200277 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ResourcesSuite.scala ##

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359199567 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ResourcesSuite.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status URL: https://github.com/apache/spark/pull/26934#issuecomment-566919977 Can one of the admins verify this patch? ---

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359198977 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ResourcesSuite.scala ##

[GitHub] [spark] AngersZhuuuu commented on issue #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status

2019-12-17 Thread GitBox
AngersZh commented on issue #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status URL: https://github.com/apache/spark/pull/26934#issuecomment-566919665 @juliuszsompolski @wangyum This

[GitHub] [spark] AngersZhuuuu opened a new pull request #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status

2019-12-17 Thread GitBox
AngersZh opened a new pull request #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status URL: https://github.com/apache/spark/pull/26934 ### What changes were proposed in this pull request? Since we have add a close status for each statement, h

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359198761 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ResourcesSuite.scala ##

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359198588 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359198707 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ResourcesSuite.scala ##

[GitHub] [spark] maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#discussion_r359198300 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915417 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] SparkQA removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566914862 **[Test build #115492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115492/testRe

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915410 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915209 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915400 **[Test build #115492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115492/testReport)**

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915417 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915410 Merged build finished. Test FAILed. This is an autom

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915204 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915204 Merged build finished. Test PASSed. This is an autom

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566915209 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berke

[GitHub] [spark] SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566914862 **[Test build #115492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115492/testReport)**

[GitHub] [spark] wangshuo128 commented on a change in pull request #26924: [SPARK-30285][CORE]Fix deadlock between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError

2019-12-17 Thread GitBox
wangshuo128 commented on a change in pull request #26924: [SPARK-30285][CORE]Fix deadlock between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError URL: https://github.com/apache/spark/pull/26924#discussion_r359193483 ## File path: core/src/main/scala/org/apache/spark/

[GitHub] [spark] SparkQA commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
SparkQA commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#issuecomment-566912642 **[Test build #115491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115491/testReport)** for PR 26512 at comm

[GitHub] [spark] AmplabJenkins commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#issuecomment-566905786 Merged build finished. Test PASSed. This is an automated message from th

[GitHub] [spark] AmplabJenkins removed a comment on issue #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#issuecomment-566905812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenk

[GitHub] [spark] AmplabJenkins commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#issuecomment-566905812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job

[GitHub] [spark] AmplabJenkins removed a comment on issue #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#issuecomment-566905786 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] jalpan-randeri commented on a change in pull request #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
jalpan-randeri commented on a change in pull request #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#discussion_r359189091 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1525,7

[GitHub] [spark] jalpan-randeri commented on a change in pull request #26512: [SPARK-29493][SQL] Arrow MapType support

2019-12-17 Thread GitBox
jalpan-randeri commented on a change in pull request #26512: [SPARK-29493][SQL] Arrow MapType support URL: https://github.com/apache/spark/pull/26512#discussion_r35914 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -217,7 +217,7 @@ For detailed usage, please

[GitHub] [spark] maropu commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#discussion_r359188374 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Ana

[GitHub] [spark] maropu commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566900211 I checked the hive behaivour; hive uses not `int` but `bigint` for grouping IDs, so hive supports less than 64

[GitHub] [spark] HyukjinKwon commented on issue #22316: [SPARK-25048][SQL] Pivoting by multiple columns in Scala/Java

2019-12-17 Thread GitBox
HyukjinKwon commented on issue #22316: [SPARK-25048][SQL] Pivoting by multiple columns in Scala/Java URL: https://github.com/apache/spark/pull/22316#issuecomment-566888624 You can try: ```python df.groupby(...).pivot(..., values=[F.struct(F.lit("..."))._jc]) ``` for now.

[GitHub] [spark] viirya commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
viirya commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#discussion_r359170592 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Ana

[GitHub] [spark] HyukjinKwon edited a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
HyukjinKwon edited a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566886930 Merged to master. This is an automated message f

[GitHub] [spark] HyukjinKwon commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
HyukjinKwon commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566886930 Merged to master and branch-2.4. This is an automated m

[GitHub] [spark] AmplabJenkins commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933#issuecomment-566886144 Can one of the admins verify this patch? This

[GitHub] [spark] AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-566886284 Merged build finished. Test PASSed. Th

[GitHub] [spark] AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-566886284 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933#issuecomment-566885779 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-566886292 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-566886292 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] SparkQA commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-17 Thread GitBox
SparkQA commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-566885900 **[Test build #115490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115490/

[GitHub] [spark] AmplabJenkins commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933#issuecomment-566885779 Can one of the admins verify this patch? This

[GitHub] [spark] iRakson edited a comment on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
iRakson edited a comment on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933#issuecomment-566884491 cc @cloud-fan #26518 This is an automated m

[GitHub] [spark] iRakson commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
iRakson commented on issue #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933#issuecomment-566884491 cc @cloud-fan This is an automated message from th

[GitHub] [spark] iRakson opened a new pull request #26933: Throw Exception when invalid string is cast to decimal in ANSI mode

2019-12-17 Thread GitBox
iRakson opened a new pull request #26933: Throw Exception when invalid string is cast to decimal in ANSI mode URL: https://github.com/apache/spark/pull/26933 ### What changes were proposed in this pull request? If spark.sql.ansi.enabled is set, Throw analysis exception when ca

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r358961919 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV

[GitHub] [spark] imback82 commented on a change in pull request #26921: [SPARK-30282][SQL] UnresolvedV2Relation should be resolved to temp view first

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26921: [SPARK-30282][SQL] UnresolvedV2Relation should be resolved to temp view first URL: https://github.com/apache/spark/pull/26921#discussion_r359164909 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysi

[GitHub] [spark] imback82 commented on issue #26921: [SPARK-30282][SQL] UnresolvedV2Relation should be resolved to temp view first

2019-12-17 Thread GitBox
imback82 commented on issue #26921: [SPARK-30282][SQL] UnresolvedV2Relation should be resolved to temp view first URL: https://github.com/apache/spark/pull/26921#issuecomment-566881435 cc: @cloud-fan This is an automated mes

[GitHub] [spark] maropu edited a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu edited a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566880237 > Should we just use string type for grouping id? A consistent type of grouping id sounds more reliable

[GitHub] [spark] maropu edited a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu edited a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566880237 > Should we just use string type for grouping id? A consistent type of grouping id sounds more reliable

[GitHub] [spark] maropu commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566880237 > Should we just use string type for grouping id? A consistent type of grouping id sounds more reliable

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r359157149 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r358960206 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r358961919 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r359162122 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis

[GitHub] [spark] imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace

2019-12-17 Thread GitBox
imback82 commented on a change in pull request #26923: [SPARK-30284][SQL] CREATE VIEW should keep the current catalog and namespace URL: https://github.com/apache/spark/pull/26923#discussion_r358962641 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/vie

[GitHub] [spark] AmplabJenkins commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566877443 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566877439 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566877439 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566877443 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] SparkQA removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566831365 **[Test build #115481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115481/tes

[GitHub] [spark] AmplabJenkins commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566877001 Merged build finished. Test PASSed. Th

[GitHub] [spark] AmplabJenkins removed a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566877001 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566877008 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566877008 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] SparkQA commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE

2019-12-17 Thread GitBox
SparkQA commented on issue #26931: [SPARK-30291] catch the exception when doing materialize in AQE URL: https://github.com/apache/spark/pull/26931#issuecomment-566877035 **[Test build #115481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115481/testReport

[GitHub] [spark] AmplabJenkins removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566876646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] SparkQA commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
SparkQA commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566876665 **[Test build #115489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115489/

[GitHub] [spark] viirya commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
viirya commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566876700 Do other systems (Hive, Presto...) have similar issue? ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566876634 Merged build finished. Test PASSed. This is a

[GitHub] [spark] AmplabJenkins commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566876646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] [spark] amanomer commented on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType

2019-12-17 Thread GitBox
amanomer commented on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType URL: https://github.com/apache/spark/pull/26811#issuecomment-566876474 @cloud-fan find the comment below https://issues.apache.org/jira/browse/SPARK-29600?focusedCom

[GitHub] [spark] AmplabJenkins commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566876634 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] SparkQA removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566831392 **[Test build #115482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115482/testRep

[GitHub] [spark] viirya commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
viirya commented on issue #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#issuecomment-566876398 Should we just use string type for grouping id? A consistent type of grouping id sounds more reliable. cc @clo

[GitHub] [spark] SparkQA commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc

2019-12-17 Thread GitBox
SparkQA commented on issue #26922: [MINOR][SQL][DOC] Fix some format issues in Dataset API Doc URL: https://github.com/apache/spark/pull/26922#issuecomment-566876277 **[Test build #115482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115482/testReport)**

[GitHub] [spark] amanomer removed a comment on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType

2019-12-17 Thread GitBox
amanomer removed a comment on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType URL: https://github.com/apache/spark/pull/26811#issuecomment-59319 Thanks all. This is an a

[GitHub] [spark] amanomer removed a comment on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType

2019-12-17 Thread GitBox
amanomer removed a comment on issue #26811: [SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType URL: https://github.com/apache/spark/pull/26811#issuecomment-58130 Sure I will do. This is

[GitHub] [spark] maropu commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID

2019-12-17 Thread GitBox
maropu commented on a change in pull request #26918: [SPARK-30279][SQL] Support 32 or more grouping attributes for GROUPING_ID URL: https://github.com/apache/spark/pull/26918#discussion_r359158750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Ana

[GitHub] [spark] AmplabJenkins commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566868919 Test PASSed. Refer to this link for build results (access rights to CI server needed

[GitHub] [spark] AmplabJenkins commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566868912 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566868919 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566868912 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566868470 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566868473 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] SparkQA commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
SparkQA commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566868538 **[Test build #115478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] AmplabJenkins commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566868470 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566868473 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.e

[GitHub] [spark] SparkQA removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#issuecomment-566820169 **[Test build #115478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-566835810 Can you please review the test suite cc @maropu @cloud-fan @HyukjinKwon ---

[GitHub] [spark] SparkQA removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566856194 **[Test build #115486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115486/testReport

[GitHub] [spark] SparkQA commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures

2019-12-17 Thread GitBox
SparkQA commented on issue #26803: [SPARK-30178][ML] RobustScaler support large numFeatures URL: https://github.com/apache/spark/pull/26803#issuecomment-566868260 **[Test build #115486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115486/testReport)** fo

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866941 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866938 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
SparkQA removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866591 **[Test build #115488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115488/testRe

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866903 Merged build finished. Test PASSed. This is an autom

[GitHub] [spark] AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866941 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
AmplabJenkins removed a comment on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866911 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extended to be case insensitive

2019-12-17 Thread GitBox
SparkQA commented on issue #26927: [SPARK-29505][SQL] desc extendedto be case insensitive URL: https://github.com/apache/spark/pull/26927#issuecomment-566866929 **[Test build #115488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115488/testReport)**

  1   2   3   4   5   6   7   8   9   10   >