[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373940062 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functio

[GitHub] [spark] cloud-fan commented on issue #21888: [SPARK-24253][SQL][WIP] Implement DeleteFrom for v2 tables

2020-02-02 Thread GitBox
cloud-fan commented on issue #21888: [SPARK-24253][SQL][WIP] Implement DeleteFrom for v2 tables URL: https://github.com/apache/spark/pull/21888#issuecomment-581261506 This is done by https://github.com/apache/spark/pull/25115, closing this PR ---

[GitHub] [spark] cloud-fan closed pull request #21888: [SPARK-24253][SQL][WIP] Implement DeleteFrom for v2 tables

2020-02-02 Thread GitBox
cloud-fan closed pull request #21888: [SPARK-24253][SQL][WIP] Implement DeleteFrom for v2 tables URL: https://github.com/apache/spark/pull/21888 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#issuecomment-581262355 In general, this seems to be a follow-up of SPARK-23792 (at 2.4.0). Since it's too old JIRA,

[GitHub] [spark] MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373942625 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scal

[GitHub] [spark] MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373942941 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scal

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373944831 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functio

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373944890 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functio

[GitHub] [spark] dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#issuecomment-581267606 @MaxGekk . Every committer's suggestion is his/her own criteria for his/her acceptance. I am

[GitHub] [spark] dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
dongjoon-hyun commented on issue #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#issuecomment-581268053 Anyway, thank you always for you active contribution. Apache Spark community really needs th

[GitHub] [spark] AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581247012 Test FAILed. Refer to this link fo

[GitHub] [spark] fuwhu commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
fuwhu commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581273963 retest this please.

[GitHub] [spark] cloud-fan edited a comment on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-02 Thread GitBox
cloud-fan edited a comment on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581274289 shall we further generalize it? Currently we un-cache tables in several commands like DROP TABLE,

[GitHub] [spark] cloud-fan commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-02 Thread GitBox
cloud-fan commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581274289 shall we further generalize it? Currently we un-cache tables in several commands like DROP TABLE, TRUNCAT

[GitHub] [spark] cloud-fan commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
cloud-fan commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581274793 retest this please -

[GitHub] [spark] cloud-fan commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
cloud-fan commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581275046 ok to test This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-569861845 Can one of the admins verify this patch? -

[GitHub] [spark] SparkQA commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
SparkQA commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581275585 **[Test build #117764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275525 Merged build finished. Test FAILed.

[GitHub] [spark] cloud-fan commented on a change in pull request #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
cloud-fan commented on a change in pull request #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#discussion_r373952868 ## File path: sql/core/src/main/scala/org/apache/spark/sql/e

[GitHub] [spark] cloud-fan commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
cloud-fan commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581275571 retest this please This

[GitHub] [spark] AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275530 Test FAILed. Refer to this link for build

[GitHub] [spark] AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275525 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581245265 Test FAILed. Refer to this link for build results (access rights to CI serv

[GitHub] [spark] AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275972 Test PASSed. Refer to this link fo

[GitHub] [spark] AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581276005 Test PASSed. Refer to this link for build results (access rights to CI serv

[GitHub] [spark] AmplabJenkins commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581276027 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581276023 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275972 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581276023 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275959 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581276005 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#issuecomment-581276027 Test PASSed. Refer to this link for build results (access rights to CI s

[GitHub] [spark] AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581275995 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581275995 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27232: [SPARK-30525][SQL]HiveTableScanExec do not need to prune partitions again after pushing down to SessionCatalog for partition pruning URL: https://github.com/apache/spark/pull/27232#issuecomment-581275959 Merged build finished. Test PASSed.

[GitHub] [spark] viirya commented on a change in pull request #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table

2020-02-02 Thread GitBox
viirya commented on a change in pull request #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#discussion_r373953950 ## File path: sql/core/src/main/scala/org/apache/spark/sql/exec

[GitHub] [spark] zsxwing commented on issue #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf

2020-02-02 Thread GitBox
zsxwing commented on issue #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf URL: https://github.com/apache/spark/pull/27425#issuecomment-581276861 Thanks! Merging to master and branch-3.0. -

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373954840 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions

[GitHub] [spark] asfgit closed pull request #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf

2020-02-02 Thread GitBox
asfgit closed pull request #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf URL: https://github.com/apache/spark/pull/27425 This is an automated message from the Apache Git Service

[GitHub] [spark] AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581277885 Test FAILed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins commented on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581277877 Merged build finished. Test FAILed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false

2020-02-02 Thread GitBox
AmplabJenkins removed a comment on issue #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false URL: https://github.com/apache/spark/pull/27306#issuecomment-581277877 Merged build finished. Test FAILed. -

[GitHub] [spark] peter-toth commented on issue #24553: [SPARK-27604][SQL] Enhance constant propagation

2020-02-02 Thread GitBox
peter-toth commented on issue #24553: [SPARK-27604][SQL] Enhance constant propagation URL: https://github.com/apache/spark/pull/24553#issuecomment-581278212 @cloud-fan, @dongjoon-hyun, @maropu I improved `ConstantPropagation` a bit in this PR. Do you think you could review it? ---

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373954840 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373954840 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
HyukjinKwon commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373957826 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions

[GitHub] [spark] xuanyuanking commented on issue #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf

2020-02-02 Thread GitBox
xuanyuanking commented on issue #27425: [SPARK-29543][SS][FOLLOWUP] Move `spark.sql.streaming.ui.*` configs to StaticSQLConf URL: https://github.com/apache/spark/pull/27425#issuecomment-581280423 Thanks for the review! This i

[GitHub] [spark] MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox
MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp` URL: https://github.com/apache/spark/pull/27438#discussion_r373960161 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scal

<    1   2   3   4   5