[GitHub] [spark] HeartSaVioR commented on issue #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore URL: https://github.com/apache/spark/pull/26935#issuecomment-613854725 retest this, please

[GitHub] [spark] HeartSaVioR commented on issue #27557: [SPARK-30804][SS] Measure and log elapsed time for "compact" operation in CompactibleFileStreamLog

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #27557: [SPARK-30804][SS] Measure and log elapsed time for "compact" operation in CompactibleFileStreamLog URL: https://github.com/apache/spark/pull/27557#issuecomment-613854671 retest this, please -

[GitHub] [spark] HeartSaVioR commented on issue #24173: [SPARK-27237][SS] Introduce State schema validation among query restart

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #24173: [SPARK-27237][SS] Introduce State schema validation among query restart URL: https://github.com/apache/spark/pull/24173#issuecomment-613854819 retest this, please This is an automated me

[GitHub] [spark] gatorsmile commented on issue #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-14 Thread GitBox
gatorsmile commented on issue #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check. URL: https://github.com/apache/spark/pull/28194#issuecomment-613854769 discussed this with @beliefer offline. Let us generate a MD file as the golden file. We can build a MD table to

[GitHub] [spark] HeartSaVioR commented on issue #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files URL: https://github.com/apache/spark/pull/27620#issuecomment-613853337 retest this, please --

[GitHub] [spark] HeartSaVioR commented on issue #27664: [SPARK-30915][SS] FileStreamSink: Avoid reading the metadata log file when finding the latest batch ID

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #27664: [SPARK-30915][SS] FileStreamSink: Avoid reading the metadata log file when finding the latest batch ID URL: https://github.com/apache/spark/pull/27664#issuecomment-613852939 retest this, please -

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408618027 ## File path: sql/core/src/m

[GitHub] [spark] turboFei commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-14 Thread GitBox
turboFei commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task URL: https://github.com/apache/spark/pull/26339#issuecomment-613851498 Thanks, I will try my best to complete the test case

[GitHub] [spark] HeartSaVioR commented on issue #28156: [SPARK-31388][SQL][TESTS] org.apache.spark.sql.hive.thriftserver.CliSuite doesn't match results correctly

2020-04-14 Thread GitBox
HeartSaVioR commented on issue #28156: [SPARK-31388][SQL][TESTS] org.apache.spark.sql.hive.thriftserver.CliSuite doesn't match results correctly URL: https://github.com/apache/spark/pull/28156#issuecomment-613851650 I've observed high possibility of failing CliSuite on PR builder and this i

[GitHub] [spark] MaxGekk commented on issue #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
MaxGekk commented on issue #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212#issuecomment-613851002 > ... we should also investigate if 2.4 has a correctness issue Here is the JIRA ticket for investigation: SPARK-31449 -

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408616120 ## File path: core/src/main/java/o

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408615862 ## File path: common/unsafe/src/m

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408614500 ## File path: sql/core/src/main/j

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408613304 ## File path: common/unsafe/

[GitHub] [spark] AmplabJenkins removed a comment on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613847267 Test PASSed. Refer to this link for build results (access rights to CI server n

[GitHub] [spark] AmplabJenkins removed a comment on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613847262 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613847262 Merged build finished. Test PASSed. -

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408612502 ## File path: common/unsafe/src/m

[GitHub] [spark] AmplabJenkins commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613847267 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
SparkQA commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613846729 **[Test build #121300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408612355 ## File path: core/src/main/j

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28034: [SPARK-31268][CORE]Initial Task Executor Metrics with latestMetrics

2020-04-14 Thread GitBox
AngersZh commented on a change in pull request #28034: [SPARK-31268][CORE]Initial Task Executor Metrics with latestMetrics URL: https://github.com/apache/spark/pull/28034#discussion_r408612064 ## File path: core/src/main/scala/org/apache/spark/executor/ExecutorMetricsPoller.sca

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408611757 ## File path: core/src/main/java/o

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408611724 ## File path: common/unsafe/

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408610853 ## File path: sql/core/src/m

[GitHub] [spark] cloud-fan commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
cloud-fan commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613844433 retest this please This is a

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408609783 ## File path: common/unsafe/src/m

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408609505 ## File path: sql/catalyst/s

[GitHub] [spark] AmplabJenkins commented on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression URL: https://github.com/apache/spark/pull/28222#issuecomment-613843597 Can one of the admins verify this patch? This is an autom

[GitHub] [spark] AmplabJenkins removed a comment on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression URL: https://github.com/apache/spark/pull/28222#issuecomment-613841466 Can one of the admins verify this patch? This is

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408608737 ## File path: core/src/main/j

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408608737 ## File path: core/src/main/j

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
jiangxb1987 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408608316 ## File path: common/unsafe/

[GitHub] [spark] AmplabJenkins removed a comment on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221#issuecomment-613841631 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221#issuecomment-613841637 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] kiszk commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

2020-04-14 Thread GitBox
kiszk commented on issue #28083: [SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec URL: https://github.com/apache/spark/pull/28083#issuecomment-613841712 Looks good to me This is an auto

[GitHub] [spark] AmplabJenkins commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221#issuecomment-613841631 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221#issuecomment-613841637 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins commented on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression URL: https://github.com/apache/spark/pull/28222#issuecomment-613841466 Can one of the admins verify this patch? This is an autom

[GitHub] [spark] sathyaprakashg opened a new pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-14 Thread GitBox
sathyaprakashg opened a new pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression URL: https://github.com/apache/spark/pull/28222 ### What changes were proposed in this pull request? ExtractIntervalPart change `ExtractIntervalPart` expression get the interv

[GitHub] [spark] SparkQA commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
SparkQA commented on issue #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221#issuecomment-613841147 **[Test build #121299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] cloud-fan closed pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
cloud-fan closed pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on issue #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
cloud-fan commented on issue #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212#issuecomment-613839785 The PR itself looks good but we should also investigate if 2.4 has a correctness issue. Thanks, merging to master/3.0! --

[GitHub] [spark] ueshin opened a new pull request #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution.

2020-04-14 Thread GitBox
ueshin opened a new pull request #28221: [SPARK-31441][PYSPARK][SQL][2.4] Support duplicated column names for toPandas with arrow execution. URL: https://github.com/apache/spark/pull/28221 ### What changes were proposed in this pull request? This is to backport #28210. This PR

[GitHub] [spark] AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613818640 Test PASSed. Refer to this link for build results (

[GitHub] [spark] AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613818640 Test PASSed. Refer to this link for build r

[GitHub] [spark] AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613818634 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613818634 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
SparkQA removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613773713 **[Test build #121297 has started](https://amplab.c

[GitHub] [spark] SparkQA commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
SparkQA commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613818040 **[Test build #121297 has finished](https://amplab.cs.berke

[GitHub] [spark] HyukjinKwon closed pull request #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
HyukjinKwon closed pull request #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219 This is an automated message from the Apache Git Ser

[GitHub] [spark] HyukjinKwon commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
HyukjinKwon commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613816629 cc @ueshin This is an automate

[GitHub] [spark] HyukjinKwon commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
HyukjinKwon commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613816140 Thanks @viirya. Merged to branch-2.4. --

[GitHub] [spark] nucflash commented on issue #25193: [SPARK-28439][PYTHON][SQL] Add support for count: Column in array_repeat

2020-04-14 Thread GitBox
nucflash commented on issue #25193: [SPARK-28439][PYTHON][SQL] Add support for count: Column in array_repeat URL: https://github.com/apache/spark/pull/25193#issuecomment-613812867 If the column passed as count is not `int`, `array_repeat` will choke. In the line ``` _to_java_column(

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun edited a comment on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is diffe

[GitHub] [spark] dongjoon-hyun commented on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

2020-04-14 Thread GitBox
dongjoon-hyun commented on issue #27695: [SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers URL: https://github.com/apache/spark/pull/27695#issuecomment-613799273 @onursatici . I'm still not sure about this approach. - First, K8s environment is different fr

[GitHub] [spark] Ngone51 commented on a change in pull request #27724: [SPARK-30973][SQL] ScriptTransformationExec should wait for the termination …

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #27724: [SPARK-30973][SQL] ScriptTransformationExec should wait for the termination … URL: https://github.com/apache/spark/pull/27724#discussion_r408560803 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/Script

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613794530 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613794536 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613794530 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613794451 **[Test build #121298 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuild

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613794536 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] SparkQA removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
SparkQA removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785358 **[Test build #121298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReque

[GitHub] [spark] cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212#discussion_r408551341 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala #

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785716 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785716 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785705 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785705 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613785358 **[Test build #121298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilde

[GitHub] [spark] cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212#discussion_r408549259 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala #

[GitHub] [spark] cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate

2020-04-14 Thread GitBox
cloud-fan commented on a change in pull request #28212: [SPARK-31443][SQL] Fix perf regression of toJavaDate URL: https://github.com/apache/spark/pull/28212#discussion_r408549259 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala #

[GitHub] [spark] SparkQA commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
SparkQA commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613773713 **[Test build #121297 has started](https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613772069 Test PASSed. Refer to this link for build r

[GitHub] [spark] AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613772065 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613772069 Test PASSed. Refer to this link for build results (

[GitHub] [spark] AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#issuecomment-613772065 Merged build finished. Test PASSed. -

[GitHub] [spark] Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset

2020-04-14 Thread GitBox
Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect UnsafeAlignedOffset URL: https://github.com/apache/spark/pull/28195#discussion_r408534911 ## File path: sql/hive/src/test/s

[GitHub] [spark] huaxingao commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
huaxingao commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613766440 cc @maropu This is an automated message from

[GitHub] [spark] manuzhang commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-14 Thread GitBox
manuzhang commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task URL: https://github.com/apache/spark/pull/26339#issuecomment-613765840 @turboFei I'm ok with the original design. Plea

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613763778 Test FAILed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613763775 Merged build finished. Test FAILed. -

[GitHub] [spark] SparkQA removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
SparkQA removed a comment on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613757856 **[Test build #121295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReque

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613763775 Merged build finished. Test FAILed. --

[GitHub] [spark] SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
SparkQA commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613763701 **[Test build #121295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuild

[GitHub] [spark] AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28219: [SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names URL: https://github.com/apache/spark/pull/28219#issuecomment-613763778 Test FAILed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613762829 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613762833 Test PASSed. Refer to this link for build results (access rights to CI server needed): https

[GitHub] [spark] SparkQA commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
SparkQA commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613762740 **[Test build #121296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121296/te

[GitHub] [spark] AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613762833 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] SparkQA removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
SparkQA removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613760143 **[Test build #121296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12

[GitHub] [spark] AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613762829 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613760429 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins commented on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613760432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613760432 Test PASSed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] [spark] AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section

2020-04-14 Thread GitBox
AmplabJenkins removed a comment on issue #28220: [SPARK-31390][SQL][DOCS] Document Window Function in SQL Syntax Section URL: https://github.com/apache/spark/pull/28220#issuecomment-613760429 Merged build finished. Test PASSed. --

  1   2   3   4   5   6   7   >