[GitHub] [spark] maropu commented on a change in pull request #28104: [SPARK-31331][SQL][DOCS] Document Spark integration with Hive UDFs/UDAFs/UDTFs

2020-04-19 Thread GitBox
maropu commented on a change in pull request #28104: URL: https://github.com/apache/spark/pull/28104#discussion_r411105164 ## File path: docs/sql-ref-functions-udf-hive.md ## @@ -19,4 +19,90 @@ license: | limitations under the License. --- -Integration with Hive

[GitHub] [spark] Ngone51 commented on a change in pull request #28254: [SPARK-31478][CORE]Call `StopExecutor` before killing executors

2020-04-19 Thread GitBox
Ngone51 commented on a change in pull request #28254: URL: https://github.com/apache/spark/pull/28254#discussion_r40015 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -769,6 +769,8 @@ class

[GitHub] [spark] maropu commented on a change in pull request #28251: [SPARK-31476][SQL] Add an ExpressionInfo entry for EXTRACT

2020-04-19 Thread GitBox
maropu commented on a change in pull request #28251: URL: https://github.com/apache/spark/pull/28251#discussion_r411109456 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -423,6 +423,7 @@ object FunctionRegistry {

[GitHub] [spark] AmplabJenkins commented on issue #27944: [SPARK-31180][ML] Implement PowerTransform

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #27944: URL: https://github.com/apache/spark/pull/27944#issuecomment-616325425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on issue #27944: [SPARK-31180][ML] Implement PowerTransform

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #27944: URL: https://github.com/apache/spark/pull/27944#issuecomment-616325425 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] iRakson commented on a change in pull request #28254: [SPARK-31478][CORE]Call `StopExecutor` before killing executors

2020-04-19 Thread GitBox
iRakson commented on a change in pull request #28254: URL: https://github.com/apache/spark/pull/28254#discussion_r411109001 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -769,6 +769,8 @@ class

[GitHub] [spark] SparkQA commented on issue #27944: [SPARK-31180][ML] Implement PowerTransform

2020-04-19 Thread GitBox
SparkQA commented on issue #27944: URL: https://github.com/apache/spark/pull/27944#issuecomment-616325119 **[Test build #121504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121504/testReport)** for PR 27944 at commit

[GitHub] [spark] cloud-fan commented on issue #28266: [SPARK-31256][SQL] DataFrameNaFunctions.drop should work for nested columns

2020-04-19 Thread GitBox
cloud-fan commented on issue #28266: URL: https://github.com/apache/spark/pull/28266#issuecomment-616322205 @dongjoon-hyun yes This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] maropu commented on a change in pull request #28104: [SPARK-31331][SQL][DOCS] Document Spark integration with Hive UDFs/UDAFs/UDTFs

2020-04-19 Thread GitBox
maropu commented on a change in pull request #28104: URL: https://github.com/apache/spark/pull/28104#discussion_r411105164 ## File path: docs/sql-ref-functions-udf-hive.md ## @@ -19,4 +19,90 @@ license: | limitations under the License. --- -Integration with Hive

[GitHub] [spark] cloud-fan commented on issue #28197: [SPARK-31431][SQL] Add CalendarInterval encoder support

2020-04-19 Thread GitBox
cloud-fan commented on issue #28197: URL: https://github.com/apache/spark/pull/28197#issuecomment-616320345 I'd say `CalendarInterval` should be treated the same as `Decimal`. They are semi-public, and are already supported partially (inside case class). It's arguable if we want to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28104: [SPARK-31331][SQL][DOCS] Document Spark integration with Hive UDFs/UDAFs/UDTFs

2020-04-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28104: URL: https://github.com/apache/spark/pull/28104#discussion_r411103361 ## File path: docs/sql-ref-functions-udf-hive.md ## @@ -19,4 +19,90 @@ license: | limitations under the License. --- -Integration with Hive

[GitHub] [spark] AmplabJenkins removed a comment on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616319622 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
SparkQA removed a comment on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616293948 **[Test build #121496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121496/testReport)** for PR 28268 at commit

[GitHub] [spark] AmplabJenkins commented on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616319622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] cloud-fan commented on a change in pull request #28226: [SPARK-31452][SQL] Do not create partition spec for 0-size partitions in AQE

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28226: URL: https://github.com/apache/spark/pull/28226#discussion_r411102045 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala ## @@ -88,9 +88,11 @@ case class

[GitHub] [spark] SparkQA commented on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
SparkQA commented on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616319130 **[Test build #121496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121496/testReport)** for PR 28268 at commit

[GitHub] [spark] AmplabJenkins commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616318720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28104: [SPARK-31331][SQL][DOCS] Document Spark integration with Hive UDFs/UDAFs/UDTFs

2020-04-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28104: URL: https://github.com/apache/spark/pull/28104#discussion_r411101626 ## File path: docs/sql-ref-functions-udf-hive.md ## @@ -19,4 +19,90 @@ license: | limitations under the License. --- -Integration with Hive

[GitHub] [spark] AmplabJenkins removed a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616318720 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411101432 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] SparkQA commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
SparkQA commented on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616318288 **[Test build #121503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121503/testReport)** for PR 26339 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411100904 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411100552 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411099766 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411099482 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] dongjoon-hyun commented on issue #28148: [SPARK-31381][SPARK-29245][SQL] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
dongjoon-hyun commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616316299 Finally! Thank you, @wangyum . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] maropu commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
maropu commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411099259 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,505 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to the

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411098844 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] dongjoon-hyun commented on issue #28266: [SPARK-31256][SQL] DataFrameNaFunctions.drop should work for nested columns

2020-04-19 Thread GitBox
dongjoon-hyun commented on issue #28266: URL: https://github.com/apache/spark/pull/28266#issuecomment-616314632 So, SPARK-31256 made a regression at 2.4.5 and this recovers it? This is an automated message from the Apache

[GitHub] [spark] viirya commented on a change in pull request #27728: [SPARK-25556][SPARK-17636][SPARK-31026][SPARK-31060][SQL][test-hive1.2] Nested Column Predicate Pushdown for Parquet

2020-04-19 Thread GitBox
viirya commented on a change in pull request #27728: URL: https://github.com/apache/spark/pull/27728#discussion_r411096547 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -652,10 +652,19 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411096138 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,505 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411095492 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] viirya commented on issue #28197: [SPARK-31431][SQL] Add CalendarInterval encoder support

2020-04-19 Thread GitBox
viirya commented on issue #28197: URL: https://github.com/apache/spark/pull/28197#issuecomment-616311588 Do we expect users to read data and represent as CalendarInterval in Dataset? Seems to me CalendarInterval is only for usage in Spark row. Although not the same, it sounds similar to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411095121 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411095492 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411095121 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411095121 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,506 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] huaxingao commented on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
huaxingao commented on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616309537 @cloud-fan I addressed all the comments. Could you please check one more time? Thanks! This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616306537 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616306537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
SparkQA commented on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616306215 **[Test build #121502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121502/testReport)** for PR 28269 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28250: [SPARK-31475][SQL] Broadcast stage in AQE did not timeout

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28250: URL: https://github.com/apache/spark/pull/28250#discussion_r411089336 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala ## @@ -398,4 +399,22 @@ class BroadcastJoinSuite

[GitHub] [spark] AmplabJenkins removed a comment on issue #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28265: URL: https://github.com/apache/spark/pull/28265#issuecomment-616304410 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on issue #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28265: URL: https://github.com/apache/spark/pull/28265#issuecomment-616304410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on issue #28270: [SPARK-31494][ML] flatten the result dataframe of ANOVATest

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28270: URL: https://github.com/apache/spark/pull/28270#issuecomment-616302400 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on issue #28270: [SPARK-31494][ML] flatten the result dataframe of ANOVATest

2020-04-19 Thread GitBox
SparkQA commented on issue #28270: URL: https://github.com/apache/spark/pull/28270#issuecomment-616304123 **[Test build #121500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121500/testReport)** for PR 28270 at commit

[GitHub] [spark] SparkQA commented on issue #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
SparkQA commented on issue #28265: URL: https://github.com/apache/spark/pull/28265#issuecomment-616304143 **[Test build #121501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121501/testReport)** for PR 28265 at commit

[GitHub] [spark] AmplabJenkins removed a comment on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616304127 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616304127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] cloud-fan commented on issue #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
cloud-fan commented on issue #28265: URL: https://github.com/apache/spark/pull/28265#issuecomment-616304084 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] SparkQA removed a comment on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
SparkQA removed a comment on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616300097 **[Test build #121499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121499/testReport)** for PR 28237 at commit

[GitHub] [spark] SparkQA commented on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
SparkQA commented on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616303982 **[Test build #121499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121499/testReport)** for PR 28237 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28251: [SPARK-31476][SQL] Add an ExpressionInfo entry for EXTRACT

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28251: URL: https://github.com/apache/spark/pull/28251#discussion_r411087296 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -423,6 +423,7 @@ object FunctionRegistry

[GitHub] [spark] gatorsmile commented on a change in pull request #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
gatorsmile commented on a change in pull request #28265: URL: https://github.com/apache/spark/pull/28265#discussion_r411086764 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala ## @@ -163,9 +163,9 @@ class SparkSessionBuilderSuite

[GitHub] [spark] gatorsmile commented on issue #28265: [SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration

2020-04-19 Thread GitBox
gatorsmile commented on issue #28265: URL: https://github.com/apache/spark/pull/28265#issuecomment-616303005 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gatorsmile commented on a change in pull request #24979: [SPARK-28179][SQL] Avoid hard-coded config: spark.sql.globalTempDatabase

2020-04-19 Thread GitBox
gatorsmile commented on a change in pull request #24979: URL: https://github.com/apache/spark/pull/24979#discussion_r411086592 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -158,7 +158,7 @@ private[sql] class SharedState( //

[GitHub] [spark] gatorsmile commented on a change in pull request #24979: [SPARK-28179][SQL] Avoid hard-coded config: spark.sql.globalTempDatabase

2020-04-19 Thread GitBox
gatorsmile commented on a change in pull request #24979: URL: https://github.com/apache/spark/pull/24979#discussion_r411086416 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -158,7 +158,7 @@ private[sql] class SharedState( //

[GitHub] [spark] SparkQA removed a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
SparkQA removed a comment on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616267769 **[Test build #121493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121493/testReport)** for PR 26339 at commit

[GitHub] [spark] AmplabJenkins commented on issue #28270: [SPARK-31494][ML] flatten the result dataframe of ANOVATest

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28270: URL: https://github.com/apache/spark/pull/28270#issuecomment-616302400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616302130 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins removed a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616302135 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121493/

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411086116 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2215,7 +2219,11 @@ case class

[GitHub] [spark] AmplabJenkins commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616302130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] zhengruifeng opened a new pull request #28270: [SPARK-31494][ML] flatten the result dataframe of ANOVATest

2020-04-19 Thread GitBox
zhengruifeng opened a new pull request #28270: URL: https://github.com/apache/spark/pull/28270 ### What changes were proposed in this pull request? add a new method `def test(dataset: DataFrame, featuresCol: String, labelCol: String, flatten: Boolean): DataFrame` ### Why are

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411085917 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2215,7 +2219,11 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411085824 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2179,7 +2178,11 @@ object

[GitHub] [spark] SparkQA commented on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-19 Thread GitBox
SparkQA commented on issue #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-616301796 **[Test build #121493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121493/testReport)** for PR 26339 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411085373 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2130,38 +2129,38 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411085051 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2130,38 +2129,38 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616300361 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28248: [SPARK-31474][SQL] Consistency between dayofweek/dow in extract exprsession and dayofweek function

2020-04-19 Thread GitBox
cloud-fan commented on a change in pull request #28248: URL: https://github.com/apache/spark/pull/28248#discussion_r411084360 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2089,8 +2089,7 @@ object DatePart

[GitHub] [spark] AmplabJenkins commented on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616300361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on issue #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
SparkQA commented on issue #28237: URL: https://github.com/apache/spark/pull/28237#issuecomment-616300097 **[Test build #121499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121499/testReport)** for PR 28237 at commit

[GitHub] [spark] huaxingao commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
huaxingao commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411082047 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,505 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] huaxingao commented on a change in pull request #28237: [SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

2020-04-19 Thread GitBox
huaxingao commented on a change in pull request #28237: URL: https://github.com/apache/spark/pull/28237#discussion_r411081987 ## File path: docs/sql-ref-literals.md ## @@ -0,0 +1,505 @@ +--- +layout: global +title: Literals +displayTitle: Literals +license: | + Licensed to

[GitHub] [spark] AmplabJenkins removed a comment on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616296943 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on issue #28148: [SPARK-31381][SPARK-29245][SQL] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616296974 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on issue #28148: [SPARK-31381][SPARK-29245][SQL] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616296974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616296943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on issue #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
SparkQA commented on issue #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-616296734 **[Test build #121497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121497/testReport)** for PR 28269 at commit

[GitHub] [spark] SparkQA commented on issue #28148: [SPARK-31381][SPARK-29245][SQL] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
SparkQA commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616296735 **[Test build #121498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121498/testReport)** for PR 28148 at commit

[GitHub] [spark] wangyum commented on issue #28148: [SPARK-31381][SPARK-29245][SQL] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
wangyum commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616295772 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] ulysses-you commented on a change in pull request #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
ulysses-you commented on a change in pull request #28269: URL: https://github.com/apache/spark/pull/28269#discussion_r411078284 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala ## @@ -109,7 +109,7 @@ object

[GitHub] [spark] ulysses-you opened a new pull request #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-19 Thread GitBox
ulysses-you opened a new pull request #28269: URL: https://github.com/apache/spark/pull/28269 ### What changes were proposed in this pull request? To respect `OptimizeIn`. Use `In` or `InSet` according partition size. ### Why are the changes needed? Better

[GitHub] [spark] AmplabJenkins commented on issue #28148: [WIP][SPARK-31381][SPARK-29245][SQL][test-hadoop3.2][test-java11] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616294803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on issue #28148: [WIP][SPARK-31381][SPARK-29245][SQL][test-hadoop3.2][test-java11] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616294803 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on issue #28148: [WIP][SPARK-31381][SPARK-29245][SQL][test-hadoop3.2][test-java11] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
SparkQA removed a comment on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616255932 **[Test build #121491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121491/testReport)** for PR 28148 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #28226: [SPARK-31452][SQL] Do not create partition spec for 0-size partitions in AQE

2020-04-19 Thread GitBox
Ngone51 commented on a change in pull request #28226: URL: https://github.com/apache/spark/pull/28226#discussion_r411076696 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala ## @@ -88,9 +88,11 @@ case class

[GitHub] [spark] SparkQA commented on issue #28148: [WIP][SPARK-31381][SPARK-29245][SQL][test-hadoop3.2][test-java11] Upgrade built-in Hive 2.3.6 to 2.3.7

2020-04-19 Thread GitBox
SparkQA commented on issue #28148: URL: https://github.com/apache/spark/pull/28148#issuecomment-616294353 **[Test build #121491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121491/testReport)** for PR 28148 at commit

[GitHub] [spark] AmplabJenkins removed a comment on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
AmplabJenkins removed a comment on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616294101 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616294101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on issue #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
SparkQA commented on issue #28268: URL: https://github.com/apache/spark/pull/28268#issuecomment-616293948 **[Test build #121496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121496/testReport)** for PR 28268 at commit

[GitHub] [spark] zhengruifeng opened a new pull request #28268: [SPARK-31492][ML] flatten the result dataframe of FValueTest

2020-04-19 Thread GitBox
zhengruifeng opened a new pull request #28268: URL: https://github.com/apache/spark/pull/28268 ### What changes were proposed in this pull request? add a new method `def test(dataset: DataFrame, featuresCol: String, labelCol: String, flatten: Boolean): DataFrame` ### Why are the

[GitHub] [spark] yaooqinn edited a comment on issue #28197: [SPARK-31431][SQL] Add CalendarInterval encoder support

2020-04-19 Thread GitBox
yaooqinn edited a comment on issue #28197: URL: https://github.com/apache/spark/pull/28197#issuecomment-616291295 Hi,@viirya, thanks for the details. take your commit as an example https://github.com/apache/spark/commit/48e44b24a7663142176102ac4c6bf4242f103804,

[GitHub] [spark] yaooqinn commented on issue #28197: [SPARK-31431][SQL] Add CalendarInterval encoder support

2020-04-19 Thread GitBox
yaooqinn commented on issue #28197: URL: https://github.com/apache/spark/pull/28197#issuecomment-616291295 Hi, take your commit as an example https://github.com/apache/spark/commit/48e44b24a7663142176102ac4c6bf4242f103804, `Seq(Set(interval)).toDF()`, do intervals work as domain objects

[GitHub] [spark] uncleGen commented on issue #27694: [SPARK-30946][SS] Serde entry with UnsafeRow on FileStream(Source/Sink)Log with LZ4 compression

2020-04-19 Thread GitBox
uncleGen commented on issue #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-616289728 Suppose there is a streaming job pipeline, and these streaming job comes from different end-users or department, if middle end-user upgrade their spark and use

[GitHub] [spark] Ngone51 commented on a change in pull request #28254: [SPARK-31478][CORE]Call `StopExecutor` before killing executors

2020-04-19 Thread GitBox
Ngone51 commented on a change in pull request #28254: URL: https://github.com/apache/spark/pull/28254#discussion_r411069475 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -769,6 +769,8 @@ class

[GitHub] [spark] zhengruifeng commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments

2020-04-19 Thread GitBox
zhengruifeng commented on issue #28202: URL: https://github.com/apache/spark/pull/28202#issuecomment-616288772 I think it is not worth too much, and will close it. This is an automated message from the Apache Git Service. To

[GitHub] [spark] gatorsmile commented on a change in pull request #27728: [SPARK-25556][SPARK-17636][SPARK-31026][SPARK-31060][SQL][test-hive1.2] Nested Column Predicate Pushdown for Parquet

2020-04-19 Thread GitBox
gatorsmile commented on a change in pull request #27728: URL: https://github.com/apache/spark/pull/27728#discussion_r411068064 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -652,10 +652,19 @@ object

[GitHub] [spark] AmplabJenkins commented on issue #28260: [SPARK-31487][CORE] Move slots check of barrier job from DAGScheduler to TaskSchedulerImpl

2020-04-19 Thread GitBox
AmplabJenkins commented on issue #28260: URL: https://github.com/apache/spark/pull/28260#issuecomment-616286093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   3   4   5   >