[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644503270 @liucht-inspur Could you reflect my last comment? This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440555618 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start

[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
liucht-inspur commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644497872 cc @sarutak and @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440554399 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644497141 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on a change in pull request #28746: URL: https://github.com/apache/spark/pull/28746#discussion_r440554399 ## File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ## @@ -63,23 +65,34 @@ class LocalSparkCluster( /* Start

[GitHub] [spark] AmplabJenkins commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644497141 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
SparkQA commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644496861 **[Test build #124084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124084/testReport)** for PR 28746 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644405360 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-644495908 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
yaooqinn commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644490708 Thanks, @dongjoon-hyun, and sorry for the inconvenience. I will keep working on this. This is an automated

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440547026 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488817 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440547026 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488817 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440546771 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488405 **[Test build #124083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124083/testReport)** for PR 28635 at commit

[GitHub] [spark] zhli1142015 commented on pull request #28769: [SPARK-31929][WEBUI] Close leveldbiterator when leveldb.close

2020-06-15 Thread GitBox
zhli1142015 commented on pull request #28769: URL: https://github.com/apache/spark/pull/28769#issuecomment-644488465 Kindly ping, @srowen , @gengliangwang , do you have any other comments? Is this ok to merge? This is an

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-15 Thread GitBox
dongjoon-hyun edited a comment on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644485683 Sorry, @yaooqinn and @cloud-fan . As I mentioned on @yaooqinn's followup PR , it seems that we need to revert this again. -

[GitHub] [spark] vanzin commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
vanzin commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644487378 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644486208 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440544556 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644486208 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-62574 **[Test build #124078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124078/testReport)** for PR 28412 at commit

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440544007 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] dongjoon-hyun commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644485683 Sorry, @yaooqinn and @cloud-fan . As I mentioned on @yaooqinn , it seems that we need to revert this again. -

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644485557 **[Test build #124078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124078/testReport)** for PR 28412 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
dongjoon-hyun commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644485307 Sorry, @yaooqinn and @cloud-fan . It seems that we had better revert the patch first because it's too flaky. -

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440543326 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644482579 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644482579 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644429902 **[Test build #124077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124077/testReport)** for PR 28412 at commit

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644481897 **[Test build #124077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124077/testReport)** for PR 28412 at commit

[GitHub] [spark] beliefer commented on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

2020-06-15 Thread GitBox
beliefer commented on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644481669 @jiangxb1987 @Ngone51 Thanks for your help! This is an automated message from the Apache Git Service. To

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440539782 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,22 @@ class HiveDDLSuite } }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478729 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478729 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-15 Thread GitBox
imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r440536834 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,112 @@ +/* + *

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644478474 **[Test build #124082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124082/testReport)** for PR 28710 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477975 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477975 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644373853 **[Test build #124074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124074/testReport)** for PR 28828 at commit

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-644477261 **[Test build #124074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124074/testReport)** for PR 28828 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644476807 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644476807 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
SparkQA commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644476504 **[Test build #124081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124081/testReport)** for PR 28810 at commit

[GitHub] [spark] maropu commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
maropu commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644474897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644475032 Let's also follow the new GitHub PR template - https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE

[GitHub] [spark] xuanyuanking edited a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
xuanyuanking edited a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-643916110 cc @maropu @gatorsmile @HeartSaVioR @dongjoon-hyun A new regression bug SPARK-31990 was found when investigating the test failure

[GitHub] [spark] holdenk commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644468103 I've updated the description @gatorsmile, let me know if there is any particular points you would like clarified.

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440526114 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,93 @@ class WholeStageCodegenSuite

[GitHub] [spark] maropu commented on pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-644466372 Could you show us performance gains by enabling this codegen? This is an automated message from the Apache Git

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440525221 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] maropu commented on a change in pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440525322 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644463707 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644463707 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644407813 **[Test build #124076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124076/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644463033 **[Test build #124076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124076/testReport)** for PR 28708 at commit

[GitHub] [spark] maropu commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
maropu commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644461527 Btw, could you brush up the PR description for better commit logs? what's the proposal of this PR, what's a behaivor change before/after this PR, brabrabra... I feel the curren

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644461275 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644461275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644460954 **[Test build #124080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124080/testReport)** for PR 28833 at commit

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440519426 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644459506 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644459506 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644402021 **[Test build #124075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124075/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644458813 **[Test build #124075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124075/testReport)** for PR 28708 at commit

[GitHub] [spark] github-actions[bot] commented on pull request #27845: [GRAPHX][MINOR] Shortest paths on weighted edges

2020-06-15 Thread GitBox
github-actions[bot] commented on pull request #27845: URL: https://github.com/apache/spark/pull/27845#issuecomment-644458186 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #22163: [SPARK-25166][CORE]Reduce the number of write operations for shuffle write.

2020-06-15 Thread GitBox
github-actions[bot] commented on pull request #22163: URL: https://github.com/apache/spark/pull/22163#issuecomment-644458199 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] gatorsmile commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
gatorsmile commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644454930 @holdenk The PR description is not clear. The current PR description does not have the first section in the template "What changes were proposed in this pull request?" .

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644450568 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644450563 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644450563 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644259675 **[Test build #124069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644450238 **[Test build #124069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-69106 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-69106 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-68725 **[Test build #124079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124079/testReport)** for PR 28784 at commit

[GitHub] [spark] maropu commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
maropu commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-67040 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
maropu commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r440501541 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -839,6 +839,17 @@ object SQLConf {

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-62574 **[Test build #124078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124078/testReport)** for PR 28412 at commit

[GitHub] [spark] agrawaldevesh commented on a change in pull request #28817: [WIP][SPARK-31197][CORE] Exit the executor once all tasks and migrations are finished built on top of on top of spark20629

2020-06-15 Thread GitBox
agrawaldevesh commented on a change in pull request #28817: URL: https://github.com/apache/spark/pull/28817#discussion_r440500977 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -258,26 +262,60 @@ private[spark] class

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-60678 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-60678 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-60315 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] baohe-zhang commented on a change in pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
baohe-zhang commented on a change in pull request #28412: URL: https://github.com/apache/spark/pull/28412#discussion_r440499121 ## File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-60315 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644266765 **[Test build #124072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124072/testReport)** for PR 28593 at commit

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644439550 **[Test build #124072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124072/testReport)** for PR 28593 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644432286 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644432278 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644429050 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644432241 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28695/

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644432278 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-644429042 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644430543 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644430538 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644430543 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644430538 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] baohe-zhang commented on a change in pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
baohe-zhang commented on a change in pull request #28412: URL: https://github.com/apache/spark/pull/28412#discussion_r440490267 ## File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

<    1   2   3   4   5   6   7   8   >