[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644276586 **[Test build #124056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124056/testReport)** for PR 28833 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644273994 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644256162 **[Test build #124068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644273985 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644273985 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644273778 **[Test build #124068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644268766 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644268757 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644248826 **[Test build #124067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644268757 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644268510 **[Test build #124067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

AmplabJenkins removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-644268016 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644267202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

AmplabJenkins commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-644268016 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644267202 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644266765 **[Test build #124072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124072/testReport)** for PR 28593 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

SparkQA removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-644163493 **[Test build #124058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124058/testReport)** for PR 28619 at commit

[GitHub] [spark] SparkQA commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

SparkQA commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-644266505 **[Test build #124058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124058/testReport)** for PR 28619 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

AmplabJenkins removed a comment on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644263709 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

AmplabJenkins commented on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644263709 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

SparkQA commented on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644263214 **[Test build #124071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124071/testReport)** for PR 28641 at commit

[GitHub] [spark] viirya commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

viirya commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r440327523 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -839,6 +839,17 @@ object SQLConf {

[GitHub] [spark] jiangxb1987 commented on pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

jiangxb1987 commented on pull request #28641: URL: https://github.com/apache/spark/pull/28641#issuecomment-644262390 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644260249 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644260249 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644260135 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644260135 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] karuppayya commented on pull request #28715: [SPARK-31897][SQL]Enable codegen for GenerateExec

karuppayya commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-644260009 @cloud-fan @maropu I have fixed the tests. Can you please take a look again. Thanks This is an automated

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644259687 **[Test build #124070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124070/testReport)** for PR 28593 at commit

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644259675 **[Test build #124069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124069/testReport)** for PR 28835 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644259220 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644259220 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] GuoPhilipse commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

GuoPhilipse commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440323745 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -201,14 +201,16 @@ class HiveQuerySuite extends

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644237920 **[Test build #124064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644258791 **[Test build #124064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit

[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

yaooqinn commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644257906 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644256667 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644256667 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644256162 **[Test build #124068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124068/testReport)** for PR 28835 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440318937 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -552,28 +554,32 @@ class HiveQuerySuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440318782 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -552,28 +554,32 @@ class HiveQuerySuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440317372 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -552,28 +554,32 @@ class HiveQuerySuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440316503 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -201,14 +201,16 @@ class HiveQuerySuite extends

[GitHub] [spark] GuoPhilipse commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

GuoPhilipse commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440313281 ## File path: sql/hive/src/test/resources/golden/timestamp cast #3-0-732ed232ac592c5e7f7c913a88874fd2 ## @@ -1 +0,0 @@ -1.2 Review comment:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644249420 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644249420 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644248826 **[Test build #124067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124067/testReport)** for PR 28835 at commit

[GitHub] [spark] GuoPhilipse commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

GuoPhilipse commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440311658 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -180,7 +180,7 @@ class HiveQuerySuite extends

[GitHub] [spark] GuoPhilipse commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

GuoPhilipse commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440311100 ## File path: sql/hive/src/test/resources/golden/timestamp cast #3-0-89ef5480d0dd001cec4642de58f8632f ## @@ -0,0 +1 @@ +1.0 Review comment:

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644245610 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644245610 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-644245311 **[Test build #124066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124066/testReport)** for PR 28593 at commit

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644241625 **[Test build #124065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124065/testReport)** for PR 28710 at commit

[GitHub] [spark] maropu commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

maropu commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440300111 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,22 @@ class HiveDDLSuite } } +

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644238429 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644238429 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644234589 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644237920 **[Test build #124064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124064/testReport)** for PR 28835 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

dongjoon-hyun commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644235466 Thank you for investigating this, @yaooqinn . cc @cloud-fan This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644234589 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn opened a new pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

yaooqinn opened a new pull request #28835: URL: https://github.com/apache/spark/pull/28835 ### What changes were proposed in this pull request? fix flaky test ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440294042 ## File path: sql/hive/src/test/resources/golden/timestamp cast #3-0-89ef5480d0dd001cec4642de58f8632f ## @@ -0,0 +1 @@ +1.0 Review comment:

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun edited a comment on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644232213 The followings is the failure on `master` branch in addition to the PR Builder failures. -

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r440293436 ## File path: sql/hive/src/test/resources/golden/timestamp cast #3-0-732ed232ac592c5e7f7c913a88874fd2 ## @@ -1 +0,0 @@ -1.2 Review comment:

[GitHub] [spark] dongjoon-hyun commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644232213 The followings is the failure on `master` branch in addition to the PR Builder failures. -

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r44021 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -180,7 +180,7 @@ class HiveQuerySuite extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

AmplabJenkins removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-644227014 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

AmplabJenkins commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-644227014 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

SparkQA commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-644226300 **[Test build #124062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124062/testReport)** for PR 27690 at commit

[GitHub] [spark] SparkQA commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

SparkQA commented on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-644226261 **[Test build #124063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124063/testReport)** for PR 28816 at commit

[GitHub] [spark] maropu commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

maropu commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-644223909 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

AmplabJenkins commented on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-644222863 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

AmplabJenkins removed a comment on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-644222849 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

AmplabJenkins commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644219054 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

AmplabJenkins removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644219054 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

SparkQA commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644217416 **[Test build #124051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124051/testReport)** for PR 28781 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

SparkQA removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644040894 **[Test build #124051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124051/testReport)** for PR 28781 at commit

[GitHub] [spark] maropu commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

maropu commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-644216754 Ah, the cause of the conflict is that I didn't merge https://github.com/apache/spark/pull/28802 into branch-3.0. Since #28802 is just for test improvements, I've cherry-picked

[GitHub] [spark] huaxingao commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

huaxingao commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-644214995 Thanks! @srowen @zhengruifeng This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] zsxwing commented on a change in pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

zsxwing commented on a change in pull request #28828: URL: https://github.com/apache/spark/pull/28828#discussion_r440272044 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ## @@ -43,7 +43,7 @@ class StateOperatorProgress private[sql](

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

AmplabJenkins removed a comment on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644214555 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

AmplabJenkins commented on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644214555 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

SparkQA commented on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644214042 **[Test build #124061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124061/testReport)** for PR 28824 at commit

[GitHub] [spark] huaxingao commented on pull request #28704: [SPARK-31777][ML][PySpark] Add user-specified fold column to CrossValidator

huaxingao commented on pull request #28704: URL: https://github.com/apache/spark/pull/28704#issuecomment-644213530 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on a change in pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

viirya commented on a change in pull request #28826: URL: https://github.com/apache/spark/pull/28826#discussion_r440265563 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SchemaPruning.scala ## @@ -120,7 +120,8 @@ object SchemaPruning {

[GitHub] [spark] emnajaoua removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

emnajaoua removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-644206076 Hi everyone, Thank you for the effort of developing this important feature. I am interested to know whether it will be soon deployed. We currently need it to

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun edited a comment on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644206443 The failures occurs on Maven, too. Please see https://github.com/apache/spark/pull/28797#issuecomment-644185984 .

[GitHub] [spark] dongjoon-hyun commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644206443 The failures are Maven, too. Please see https://github.com/apache/spark/pull/28797#issuecomment-644185984 .

[GitHub] [spark] emnajaoua commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

emnajaoua commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-644206076 Hi everyone, Thank you for the effort of developing this important feature. I am interested to know whether it will be soon deployed. We currently need it to write a

[GitHub] [spark] yaooqinn commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

yaooqinn commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644205659 The test failures are all by SBT? If so, should I send a followup to use dedicated JVMs for them first？ @dongjoon-hyun

[GitHub] [spark] maropu commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

maropu commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-644205711 Thanks! Merged to master. Note that, since this fix conflicts with branch-3.0, I'll open another PR for that.

[GitHub] [spark] maropu closed pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

maropu closed pull request #28807: URL: https://github.com/apache/spark/pull/28807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] yaooqinn commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

yaooqinn commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644203656 It seems to hit the derby metastore constraints that fail the connection to metastore This is an

[GitHub] [spark] dongjoon-hyun commented on pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun commented on pull request #28797: URL: https://github.com/apache/spark/pull/28797#issuecomment-644202674 For a record, this fails sometime (not always), but the failures seems to occur frequently on `branch-3.0`.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

AmplabJenkins removed a comment on pull request #28809: URL: https://github.com/apache/spark/pull/28809#issuecomment-644202188 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

AmplabJenkins commented on pull request #28809: URL: https://github.com/apache/spark/pull/28809#issuecomment-644202188 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

maropu commented on a change in pull request #28826: URL: https://github.com/apache/spark/pull/28826#discussion_r440256983 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SchemaPruning.scala ## @@ -120,7 +120,8 @@ object SchemaPruning {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28797: [SPARK-31926][SQL][TEST-HIVE1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

dongjoon-hyun commented on a change in pull request #28797: URL: https://github.com/apache/spark/pull/28797#discussion_r440255926 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala ## @@ -69,23 +79,35 @@ trait

[GitHub] [spark] maropu edited a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

maropu edited a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-644200898 Basically, I think we need the two types of tests: end-2-end (coarse-grained) tests and fine-grained tests. For the former tests, how about adding some tests in

[GitHub] [spark] SparkQA commented on pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

SparkQA commented on pull request #28809: URL: https://github.com/apache/spark/pull/28809#issuecomment-644201601 **[Test build #124060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124060/testReport)** for PR 28809 at commit

<    1   2   3   4   5   6   7   8   >