[GitHub] [spark] AmplabJenkins commented on pull request #29075: [SPARK-32284][SQL] Avoid expanding too many CNF predicates in partition pruning

AmplabJenkins commented on pull request #29075: URL: https://github.com/apache/spark/pull/29075#issuecomment-657393340 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

SparkQA commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657393233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] gatorsmile commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

gatorsmile commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r453468999 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -199,7 +199,7 @@ abstract class SparkStrategies

[GitHub] [spark] AmplabJenkins commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

AmplabJenkins commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657393309 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

AmplabJenkins commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-657393278 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

AmplabJenkins commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657393265 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29075: [SPARK-32284][SQL] Avoid expanding too many CNF predicates in partition pruning

SparkQA commented on pull request #29075: URL: https://github.com/apache/spark/pull/29075#issuecomment-657393239 **[Test build #125746 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125746/testReport)** for PR 29075 at commit

[GitHub] [spark] SparkQA commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

SparkQA commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-657393237 **[Test build #125751 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125751/testReport)** for PR 28363 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

HyukjinKwon commented on a change in pull request #28957: URL: https://github.com/apache/spark/pull/28957#discussion_r453468016 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -180,7 +173,7 @@ def create_array(s, t): if len(s) == 0 and

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

HyukjinKwon commented on a change in pull request #28957: URL: https://github.com/apache/spark/pull/28957#discussion_r453467521 ## File path: python/pyspark/sql/pandas/serializers.py ## @@ -180,7 +173,7 @@ def create_array(s, t): if len(s) == 0 and

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657391382 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

AmplabJenkins commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657391378 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

SparkQA removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657346056 **[Test build #125749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125749/testReport)** for PR 29064 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657391378 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

SparkQA commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657391155 **[Test build #125749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125749/testReport)** for PR 29064 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before reading DataFrame and before/after writing DataFrame over JDBC

AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-657389372 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28953: [SPARK-32013][SQL] Support query execution before reading DataFrame and before/after writing DataFrame over JDBC

AmplabJenkins commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-657389372 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before reading DataFrame and before/after writing DataFrame over JDBC

SparkQA removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-657311315 **[Test build #125741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125741/testReport)** for PR 28953 at commit

[GitHub] [spark] SparkQA commented on pull request #28953: [SPARK-32013][SQL] Support query execution before reading DataFrame and before/after writing DataFrame over JDBC

SparkQA commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-657388961 **[Test build #125741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125741/testReport)** for PR 28953 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

dongjoon-hyun commented on a change in pull request #28957: URL: https://github.com/apache/spark/pull/28957#discussion_r453462469 ## File path: dev/lint-python ## @@ -168,7 +168,15 @@ function sphinx_test { # Check that the documentation builds acceptably, skip check if

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28957: [SPARK-32138] Drop Python 2.7, 3.4 and 3.5

dongjoon-hyun commented on a change in pull request #28957: URL: https://github.com/apache/spark/pull/28957#discussion_r453462469 ## File path: dev/lint-python ## @@ -168,7 +168,15 @@ function sphinx_test { # Check that the documentation builds acceptably, skip check if

[GitHub] [spark] cloud-fan commented on a change in pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE

cloud-fan commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r453462372 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -240,6 +240,10 @@ statement | MSCK REPAIR TABLE

[GitHub] [spark] cloud-fan commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

cloud-fan commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453460284 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a

[GitHub] [spark] cloud-fan commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

cloud-fan commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453460284 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2048,19 +2088,34 @@ class Dataset[T] private[sql]( // Builds a

[GitHub] [spark] cloud-fan commented on a change in pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

cloud-fan commented on a change in pull request #28996: URL: https://github.com/apache/spark/pull/28996#discussion_r453459502 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2030,7 +2030,25 @@ class Dataset[T] private[sql]( * @group typedrel

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

AmplabJenkins removed a comment on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-657384480 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] weixiuli commented on pull request #28994: [SPARK-32170][CORE] Improve the speculation for the inefficient tasks by the task metrics.

weixiuli commented on pull request #28994: URL: https://github.com/apache/spark/pull/28994#issuecomment-657384538 @maropu @cloud-fan @gatorsmile @mridulm @dongjoon-hyun Could you help check this PR? Thanks. This is an

[GitHub] [spark] AmplabJenkins commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

AmplabJenkins commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-657384480 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

SparkQA removed a comment on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-657340452 **[Test build #125748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125748/testReport)** for PR 27694 at commit

[GitHub] [spark] SparkQA commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

SparkQA commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-657384095 **[Test build #125748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125748/testReport)** for PR 27694 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29061: [SPARK-32258][SQL] NormalizeFloatingNumbers directly normalizes IF/CaseWhen/Coalesce child expressions

cloud-fan commented on a change in pull request #29061: URL: https://github.com/apache/spark/pull/29061#discussion_r453458611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala ## @@ -116,6 +116,15 @@ object

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

dongjoon-hyun edited a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-657383898 Hi, @ulysses-you . We already choose the plan. This is a step to forbid that gracefully. For `create view v1 as select null as col`, we can add an

[GitHub] [spark] dongjoon-hyun commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

dongjoon-hyun commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-657383898 Hi, @ulysses-you . We already choose the plan. This is a step to forbid that gracefully. For `create view v1 as select null as col`, we can add an `AnalysisException`

[GitHub] [spark] ulysses-you commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

ulysses-you commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-657382943 @cloud-fan doesn't work. We should choose a plan that forbid or support. This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29083: debug SPARK-32250

AmplabJenkins removed a comment on pull request #29083: URL: https://github.com/apache/spark/pull/29083#issuecomment-657382195 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29083: debug SPARK-32250

AmplabJenkins commented on pull request #29083: URL: https://github.com/apache/spark/pull/29083#issuecomment-657382195 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29083: debug SPARK-32250

SparkQA removed a comment on pull request #29083: URL: https://github.com/apache/spark/pull/29083#issuecomment-657338632 **[Test build #125747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125747/testReport)** for PR 29083 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29083: debug SPARK-32250

AmplabJenkins removed a comment on pull request #29083: URL: https://github.com/apache/spark/pull/29083#issuecomment-657338935 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #29083: debug SPARK-32250

SparkQA commented on pull request #29083: URL: https://github.com/apache/spark/pull/29083#issuecomment-657381725 **[Test build #125747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125747/testReport)** for PR 29083 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #24990: [SPARK-28191][SS] New data source - state - reader part

AmplabJenkins removed a comment on pull request #24990: URL: https://github.com/apache/spark/pull/24990#issuecomment-657381054 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #24990: [SPARK-28191][SS] New data source - state - reader part

SparkQA removed a comment on pull request #24990: URL: https://github.com/apache/spark/pull/24990#issuecomment-657302246 **[Test build #125740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125740/testReport)** for PR 24990 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #24990: [SPARK-28191][SS] New data source - state - reader part

AmplabJenkins commented on pull request #24990: URL: https://github.com/apache/spark/pull/24990#issuecomment-657381054 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #24990: [SPARK-28191][SS] New data source - state - reader part

SparkQA commented on pull request #24990: URL: https://github.com/apache/spark/pull/24990#issuecomment-657380687 **[Test build #125740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125740/testReport)** for PR 24990 at commit

[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

SaurabhChawla100 commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r453453601 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala ## @@ -80,10 +80,10 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

AmplabJenkins removed a comment on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657379354 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

AmplabJenkins commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657379354 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

SparkQA commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657378974 **[Test build #125752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125752/testReport)** for PR 29045 at commit

[GitHub] [spark] beliefer commented on a change in pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

beliefer commented on a change in pull request #27428: URL: https://github.com/apache/spark/pull/27428#discussion_r453452526 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -118,7 +118,75 @@ import

[GitHub] [spark] Ngone51 commented on pull request #28850: [SPARK-32015][Core]Remote inheritable thread local variables after spark context is stopped

Ngone51 commented on pull request #28850: URL: https://github.com/apache/spark/pull/28850#issuecomment-657375831 yea, I think I have to agree with @srowen . The approach is not perfect as I thought previously, sorry for the misleading @wankunde Soft reference could probably work in

<    2   3   4   5   6   7