[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456758817 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apac

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660439022 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660439022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660406621 **[Test build #126084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126084/testReport)** for PR 29135 at commit [`2253499`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660438898 **[Test build #126084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126084/testReport)** for PR 29135 at commit [`2253499`](https://github.co

[GitHub] [spark] gengliangwang commented on pull request #29133: [SPARK-32253][INFRA] Show errors only for the sbt tests of github actions

2020-07-17 Thread GitBox
gengliangwang commented on pull request #29133: URL: https://github.com/apache/spark/pull/29133#issuecomment-660438805 @viirya I have updated the PR description. This is an automated message from the Apache Git Service. To re

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456758182 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -87,17 +171,55 @@ trait BaseScriptTransforma

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456757751 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apac

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-660437685 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-660437683 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-660437683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-660404676 **[Test build #126083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126083/testReport)** for PR 29101 at commit [`d37c21c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-17 Thread GitBox
SparkQA commented on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-660437542 **[Test build #126083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126083/testReport)** for PR 29101 at commit [`d37c21c`](https://github.co

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29104: [SPARK-32290][SQL] NotInSubquery SingleColumn Optimize

2020-07-17 Thread GitBox
agrawaldevesh commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r456756939 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NotInSubqueryHashJoinTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] zero323 commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

2020-07-17 Thread GitBox
zero323 commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r456756157 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema, options=

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660435578 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660435573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660435573 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660403653 **[Test build #126082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126082/testReport)** for PR 29135 at commit [`7127744`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660435353 **[Test build #126082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126082/testReport)** for PR 29135 at commit [`7127744`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660433006 **[Test build #126096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126096/testReport)** for PR 29014 at commit [`4a18813`](https://github.com

[GitHub] [spark] agrawaldevesh commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-17 Thread GitBox
agrawaldevesh commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-660432463 @holdenk ... It would be great for you to review this PR. This PR stems from your suggestion of plumbing a "isWorkerLost" to the executor decommission message, as you sugg

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660432238 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660432238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660431827 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660420607 **[Test build #126090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126090/testReport)** for PR 29085 at commit [`5c049b5`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660431825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660431825 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660431781 **[Test build #126090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126090/testReport)** for PR 29085 at commit [`5c049b5`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-660429662 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-660429662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-17 Thread GitBox
SparkQA commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-660429520 **[Test build #126095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126095/testReport)** for PR 29079 at commit [`d620940`](https://github.com

[GitHub] [spark] viirya commented on pull request #29133: [SPARK-32253][INFRA] Show errors only for the sbt tests of github actions

2020-07-17 Thread GitBox
viirya commented on pull request #29133: URL: https://github.com/apache/spark/pull/29133#issuecomment-660429568 I saw the screenshot of after this change. Can we also add one screenshot of before this change too? This is an

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751726 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -56,10 +65,85 @@ trait BaseScriptTrans

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751726 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -56,10 +65,85 @@ trait BaseScriptTrans

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751726 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -56,10 +65,85 @@ trait BaseScriptTrans

[GitHub] [spark] c21 commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-17 Thread GitBox
c21 commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-660428967 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751690 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SparkScriptTransformationSuite.scala ## @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751677 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala ## @@ -172,19 +237,17 @@ case class Hiv

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660428786 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660428786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r456751646 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala ## @@ -0,0 +1,296 @@ +/* + * Licensed to th

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660428628 **[Test build #126094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126094/testReport)** for PR 29085 at commit [`6811721`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660427858 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660427858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
SparkQA commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660427670 **[Test build #126093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126093/testReport)** for PR 29107 at commit [`c23898e`](https://github.com

[GitHub] [spark] viirya commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
viirya commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660426922 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] AmplabJenkins commented on pull request #29130: [SPARK-32330][SQL] Preserve shuffled hash join build side partitioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29130: URL: https://github.com/apache/spark/pull/29130#issuecomment-660425624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29130: [SPARK-32330][SQL] Preserve shuffled hash join build side partitioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29130: URL: https://github.com/apache/spark/pull/29130#issuecomment-660425624 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29130: [SPARK-32330][SQL] Preserve shuffled hash join build side partitioning

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29130: URL: https://github.com/apache/spark/pull/29130#issuecomment-660389881 **[Test build #126081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126081/testReport)** for PR 29130 at commit [`f9479b6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29130: [SPARK-32330][SQL] Preserve shuffled hash join build side partitioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #29130: URL: https://github.com/apache/spark/pull/29130#issuecomment-660425484 **[Test build #126081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126081/testReport)** for PR 29130 at commit [`f9479b6`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660425265 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660425265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660425094 **[Test build #126092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126092/testReport)** for PR 29085 at commit [`04684a8`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660424078 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660424076 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660424076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660410501 **[Test build #126085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126085/testReport)** for PR 29014 at commit [`9f41504`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-660423931 **[Test build #126085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126085/testReport)** for PR 29014 at commit [`9f41504`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660423538 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660423535 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660423535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660381500 **[Test build #126077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126077/testReport)** for PR 29107 at commit [`c23898e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
SparkQA commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-660423434 **[Test build #126077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126077/testReport)** for PR 29107 at commit [`c23898e`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660422979 **[Test build #126091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126091/testReport)** for PR 28676 at commit [`9caeecd`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AngersZh commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660422452 > As @cloud-fan [suggested above](https://github.com/apache/spark/pull/29085#discussion_r454299734), you need to move the two tests into `sql/core`; could you check my PR f

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660422415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660422415 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
imback82 commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660422348 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] StefanXiepj commented on pull request #29144: [SPARK-15118][SQL] Spark SQLConf should support loading hive properties in hive-site.xml

2020-07-17 Thread GitBox
StefanXiepj commented on pull request #29144: URL: https://github.com/apache/spark/pull/29144#issuecomment-660421270 > #24489 has addressed your major concern. For the other conf, we can discuss it case by case. In general, we are not respecting Hive conf. @gatorsmile This pr will b

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660420722 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660420722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] gatorsmile commented on pull request #29144: [SPARK-15118][SQL] Spark SQLConf should support loading hive properties in hive-site.xml

2020-07-17 Thread GitBox
gatorsmile commented on pull request #29144: URL: https://github.com/apache/spark/pull/29144#issuecomment-660420728 https://github.com/apache/spark/pull/24489 has addressed your major concern. For the other conf, we can discuss it case by case. In general, we are not respecting Hive conf.

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-17 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-660420607 **[Test build #126090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126090/testReport)** for PR 29085 at commit [`5c049b5`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660419631 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
SparkQA removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660415855 **[Test build #126087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126087/testReport)** for PR 28676 at commit [`9caeecd`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660419628 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660419768 **[Test build #126089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126089/testReport)** for PR 29135 at commit [`ba7c3a4`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660419628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660419604 **[Test build #126087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126087/testReport)** for PR 28676 at commit [`9caeecd`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29150: [SPARK-32353][TEST] Update docker/spark-test and clean up unused stuff

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29150: URL: https://github.com/apache/spark/pull/29150#issuecomment-660280141 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660418988 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660418988 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
SparkQA commented on pull request #29135: URL: https://github.com/apache/spark/pull/29135#issuecomment-660418864 **[Test build #126088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126088/testReport)** for PR 29135 at commit [`7159582`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456742673 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456742634 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660415996 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660415996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660415855 **[Test build #126087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126087/testReport)** for PR 28676 at commit [`9caeecd`](https://github.com

[GitHub] [spark] imback82 commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-17 Thread GitBox
imback82 commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-660415514 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
maropu commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456741460 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] holdenk commented on pull request #29151: [SPARK-29909][BUILD] Use python3 in build scripts

2020-07-17 Thread GitBox
holdenk commented on pull request #29151: URL: https://github.com/apache/spark/pull/29151#issuecomment-660413587 The pip packaging failure is interesting. Let me know if you want me to take a deeper look at our packaging tests. On Fri, Jul 17, 2020 at 7:00 PM UCB AMPLab wrote:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29143: [SPARK-32344][SQL] Unevaluable expr is set to FIRST/LAST ignoreNullsExpr in distinct aggregates

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29143: URL: https://github.com/apache/spark/pull/29143#issuecomment-660413372 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29143: [SPARK-32344][SQL] Unevaluable expr is set to FIRST/LAST ignoreNullsExpr in distinct aggregates

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #29143: URL: https://github.com/apache/spark/pull/29143#issuecomment-660413372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29143: [SPARK-32344][SQL] Unevaluable expr is set to FIRST/LAST ignoreNullsExpr in distinct aggregates

2020-07-17 Thread GitBox
SparkQA commented on pull request #29143: URL: https://github.com/apache/spark/pull/29143#issuecomment-660413170 **[Test build #126086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126086/testReport)** for PR 29143 at commit [`66bf522`](https://github.com

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-17 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r456736612 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1767,8 +1767,13 @@ private[spark] class DAGScheduler(

[GitHub] [spark] maropu commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-17 Thread GitBox
maropu commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456740147 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3676,3 +3678,63 @@ object UpdateOuterReferences ext

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-17 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-660412892 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] StefanXiepj commented on pull request #29144: [SPARK-15118][SQL] Spark SQLConf should support loading hive properties in hive-site.xml

2020-07-17 Thread GitBox
StefanXiepj commented on pull request #29144: URL: https://github.com/apache/spark/pull/29144#issuecomment-660412941 hi @maropu , Could you please take a look at this and give some advice? Thx. Jeff.r This i

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-17 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-660412892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

  1   2   3   4   5   6   7   8   >