[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661275603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661275603 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661275615 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] imback82 opened a new pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
imback82 opened a new pull request #29167: URL: https://github.com/apache/spark/pull/29167 ### What changes were proposed in this pull request? Currently, you can specify properties when creating a temporary view. However, the specified properties are not used and can be misl

[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661279371 **[Test build #126196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661280057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661280057 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
imback82 commented on a change in pull request #29167: URL: https://github.com/apache/spark/pull/29167#discussion_r457632275 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3515,6 +3515,13 @@ class AstBuilder(conf: SQLConf

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661293904 **[Test build #126185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126185/testReport)** for PR 29067 at commit [`f0c7cfe`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661101653 **[Test build #126185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126185/testReport)** for PR 29067 at commit [`f0c7cfe`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661294364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661294364 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661294369 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] MaxGekk opened a new pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
MaxGekk opened a new pull request #29168: URL: https://github.com/apache/spark/pull/29168 ### What changes were proposed in this pull request? This PR implements basic functionalities of the `TableCatalog` interface, so that end-users can use the JDBC as a catalog. ### Why are the

[GitHub] [spark] SparkQA commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
SparkQA commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661305415 **[Test build #126197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126197/testReport)** for PR 29168 at commit [`43c35fc`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661306022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661306022 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] viirya opened a new pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
viirya opened a new pull request #29169: URL: https://github.com/apache/spark/pull/29169 ### What changes were proposed in this pull request? Currently, the readability in the logs of GitHub Actions are not really good. This proposes to add a step in GitHub Actions to sho

[GitHub] [spark] AmplabJenkins commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661309622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] mukulmurthy commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-20 Thread GitBox
mukulmurthy commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-661311103 I just linked the JIRA to SPARK-29358 so it's easier to track the lineage. Is there already another follow up ticket to make this work for nested structs? -

[GitHub] [spark] SparkQA commented on pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

2020-07-20 Thread GitBox
SparkQA commented on pull request #29166: URL: https://github.com/apache/spark/pull/29166#issuecomment-661311652 **[Test build #126186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126186/testReport)** for PR 29166 at commit [`eaf936c`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29166: URL: https://github.com/apache/spark/pull/29166#issuecomment-661312157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29166: URL: https://github.com/apache/spark/pull/29166#issuecomment-661120468 **[Test build #126186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126186/testReport)** for PR 29166 at commit [`eaf936c`](https://gi

[GitHub] [spark] MaxGekk commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
MaxGekk commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661312035 @dongjoon-hyun I am looking forward to review comments from you. This is an automated message from the Apache Gi

[GitHub] [spark] SparkQA commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
SparkQA commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661312692 **[Test build #126199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126199/testReport)** for PR 29145 at commit [`74f8f1b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661312597 **[Test build #126198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126198/testReport)** for PR 29169 at commit [`730b133`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29166: URL: https://github.com/apache/spark/pull/29166#issuecomment-661312157 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29166: URL: https://github.com/apache/spark/pull/29166#issuecomment-661312160 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661309622 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661313084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661313073 **[Test build #126198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126198/testReport)** for PR 29169 at commit [`730b133`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661313218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661312597 **[Test build #126198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126198/testReport)** for PR 29169 at commit [`730b133`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661313084 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661313218 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661313100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] huaxingao commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
huaxingao commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661315749 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661316285 **[Test build #126200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126200/testReport)** for PR 29169 at commit [`ba22a2e`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661316322 **[Test build #126201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126201/testReport)** for PR 29159 at commit [`16abf9c`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661316985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661316964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661316985 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661316964 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29161: [SPARK-32365][SQL]Fix IndexOutOfBoundsException in regexp_extract

2020-07-20 Thread GitBox
SparkQA commented on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661318293 **[Test build #126188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126188/testReport)** for PR 29161 at commit [`fd0d54c`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29161: [SPARK-32365][SQL]Fix IndexOutOfBoundsException in regexp_extract

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661125180 **[Test build #126188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126188/testReport)** for PR 29161 at commit [`fd0d54c`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29161: [SPARK-32365][SQL]Fix IndexOutOfBoundsException in regexp_extract

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661318966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29161: [SPARK-32365][SQL]Fix IndexOutOfBoundsException in regexp_extract

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661318966 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29161: [SPARK-32365][SQL]Fix IndexOutOfBoundsException in regexp_extract

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661318972 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661319868 **[Test build #126196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661279371 **[Test build #126196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661320048 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661320048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661320057 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] dongjoon-hyun closed pull request #29164: [SPARK-32367][K8S][TESTS] Correct the spelling of parameter in KubernetesTestComponents

2020-07-20 Thread GitBox
dongjoon-hyun closed pull request #29164: URL: https://github.com/apache/spark/pull/29164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661326940 Oh. Looks nice, @viirya . This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661326940 Oh. The idea looks nice, @viirya . This is an automated message from the Apache Git Service. To res

[GitHub] [spark] dongjoon-hyun commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661327190 cc @gengliangwang and @HyukjinKwon This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] dongjoon-hyun closed pull request #29165: [SPARK-32368][SQL] pathGlobFilter, recursiveFileLookup and basePath should respect case insensitivity

2020-07-20 Thread GitBox
dongjoon-hyun closed pull request #29165: URL: https://github.com/apache/spark/pull/29165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661329833 Could you fix the UT failure? ``` org.apache.spark.sql.hive.execution.HiveSQLViewSuite.correctly parse CREATE TEMPORARY VIEW statement ``` --

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29167: URL: https://github.com/apache/spark/pull/29167#discussion_r457688329 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2003,6 +2002,17 @@ class DDLParserSuite

[GitHub] [spark] viirya commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-07-20 Thread GitBox
viirya commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-661331128 Thanks @maropu @HyukjinKwon. Overall looks okay to me, I don't have a chance to test this though. This is an aut

[GitHub] [spark] viirya commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-20 Thread GitBox
viirya commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-661331758 > I just linked the JIRA to [SPARK-29358](https://issues.apache.org/jira/browse/SPARK-29358) so it's easier to track the lineage. > > Is there already another follow up ti

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457690165 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object RegExpEx

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457690531 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object RegExpEx

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457690897 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object RegExpEx

[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661334281 **[Test build #126202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit [`8b35497`](https://github.com

[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
imback82 commented on a change in pull request #29167: URL: https://github.com/apache/spark/pull/29167#discussion_r457692814 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2003,6 +2002,17 @@ class DDLParserSuite exten

[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661334714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661335028 **[Test build #126187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126187/testReport)** for PR 29067 at commit [`46f4021`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661334714 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661120578 **[Test build #126187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126187/testReport)** for PR 29067 at commit [`46f4021`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661335997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661335997 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29142: URL: https://github.com/apache/spark/pull/29142#issuecomment-661336084 Could you close this PR, @ulysses-you ? This is an automated message from the Apache Git Service. To respo

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29142: URL: https://github.com/apache/spark/pull/29142#issuecomment-661336084 Could you close this PR please, @ulysses-you ? Or, could you let me know what I missed in your proposal? --

[GitHub] [spark] dongjoon-hyun commented on pull request #29117: [SPARK-32363][PYTHON][BUILD] Fix flakiness in pip package testing in Jenkins

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-661337728 It seems that the last two runs fail consecutively. - https://github.com/apache/spark/pull/29117#issuecomment-661091482 - https://github.com/apache/spark/pull/29117#is

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29117: [SPARK-32363][PYTHON][BUILD] Fix flakiness in pip package testing in Jenkins

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-661337728 It seems that the last run failed https://github.com/apache/spark/pull/29117#issuecomment-661233612 ? Do we have another root cause of flakiness?

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29117: [SPARK-32363][PYTHON][BUILD] Fix flakiness in pip package testing in Jenkins

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-661337728 It seems that the last two runs failed consecutively. - https://github.com/apache/spark/pull/29117#issuecomment-661091482 - https://github.com/apache/spark/pull

[GitHub] [spark] SparkQA removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661316322 **[Test build #126201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126201/testReport)** for PR 29159 at commit [`16abf9c`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661338154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29117: [SPARK-32363][PYTHON][BUILD] Fix flakiness in pip package testing in Jenkins

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-661337728 It seems that the last run failed https://github.com/apache/spark/pull/29117#issuecomment-661233612 ? -

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661337831 **[Test build #126201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126201/testReport)** for PR 29159 at commit [`16abf9c`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661338154 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] viirya commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
viirya commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661339022 Hmm, does it mean the specified properties are not used by Spark currently? If users possibly already use it? Th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661338164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661340246 **[Test build #126191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126191/testReport)** for PR 29067 at commit [`10b0ce1`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661160094 **[Test build #126191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126191/testReport)** for PR 29067 at commit [`10b0ce1`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661340978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661340978 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] viirya commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
viirya commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661341830 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] viirya commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
viirya commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661342229 For backport PR, can you add [3.0] to the PR title? This is an automated message from the Apache Git Service. To

[GitHub] [spark] holdenk commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-20 Thread GitBox
holdenk commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r457697698 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -871,7 +871,7 @@ private[deploy] class Master( logInfo("Telli

[GitHub] [spark] holdenk commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
holdenk commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457701747 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionInfo.scala ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] holdenk commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
holdenk commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457702764 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1767,8 +1767,13 @@ private[spark] class DAGScheduler(

[GitHub] [spark] viirya commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
viirya commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661343714 Is this just a backport of #29112? Looks it it is bigger change than #29112? This is an automated message from th

[GitHub] [spark] dongjoon-hyun commented on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-661344352 @hvanhovell . The following is complete wrong because the above optimization was one of the recommendations for many Hortonworks customers to save their HDFS usage. I knew

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-661344352 @hvanhovell . The following is complete wrong because the above optimization was one of the recommendations for many Hortonworks customers to save their HDFS usage.

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661344542 **[Test build #126203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126203/testReport)** for PR 29159 at commit [`16abf9c`](https://github.com

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29089: [SPARK-32276][SQL] Remove redundant sorts before repartition nodes

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29089: URL: https://github.com/apache/spark/pull/29089#issuecomment-661344352 @hvanhovell . The following is complete wrong because the above optimization was one of the recommendations for many Hortonworks customers to save their HDFS usage.

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark] ML params default value parity

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-661345145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

<    1   2   3   4   5   6   7   8   9   >