[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29199: [SPARK-32105][SQL][FOLLOWUP] Refactor current ScriptTransformationExec

2020-07-22 Thread GitBox
AngersZh commented on a change in pull request #29199: URL: https://github.com/apache/spark/pull/29199#discussion_r459249013 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ## @@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {

[GitHub] [spark] maropu commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP] Refactor current ScriptTransformationExec

2020-07-22 Thread GitBox
maropu commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662848753 Anyone could check this? @cloud-fan @viirya @wangyum This is an automated message from the Apache Git Service. T

[GitHub] [spark] maropu commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP] Refactor current ScriptTransformationExec

2020-07-22 Thread GitBox
maropu commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662848103 Could you file a new JIRA? This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] AmplabJenkins commented on pull request #29200: [SPARK-32251][SQL][TESTS][FOLLOWUP] improve SQL keyword test

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29200: URL: https://github.com/apache/spark/pull/29200#issuecomment-662848235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] maropu commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
maropu commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662847749 FYI: This PR comes from the comment: https://github.com/apache/spark/pull/29085#issuecomment-662794540 This is a

[GitHub] [spark] maropu commented on a change in pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
maropu commented on a change in pull request #29199: URL: https://github.com/apache/spark/pull/29199#discussion_r459246806 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ## @@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {

[GitHub] [spark] cloud-fan commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap and documentation

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459246674 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [SPARK-32389][TESTS] Add all hive.execution suite in the parallel test group

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662845868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan opened a new pull request #29200: [SPARK-32251][SQL][TESTS] improve SQL keyword test

2020-07-22 Thread GitBox
cloud-fan opened a new pull request #29200: URL: https://github.com/apache/spark/pull/29200 ### What changes were proposed in this pull request? Improve the `SQLKeywordSuite` so that: 1. it checks keywords under default mode as well 2. it checks if there are typos in the

[GitHub] [spark] cloud-fan commented on pull request #29200: [SPARK-32251][SQL][TESTS] improve SQL keyword test

2020-07-22 Thread GitBox
cloud-fan commented on pull request #29200: URL: https://github.com/apache/spark/pull/29200#issuecomment-662846486 cc @maropu This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [SPARK-32389][TESTS] Add all hive.execution suite in the parallel test group

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662845868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
HyukjinKwon commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662844528 I double checked. I believe it should be ready for a look and possibly good to go. This is an automated mes

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
HyukjinKwon commented on a change in pull request #29188: URL: https://github.com/apache/spark/pull/29188#discussion_r459243054 ## File path: python/pyspark/sql/functions.py ## @@ -1196,6 +1196,8 @@ def to_date(col, format=None): By default, it follows casting rules to :c

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662843483 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662843476 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
SparkQA commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662843769 **[Test build #126390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126390/testReport)** for PR 29188 at commit [`8a6d316`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662843479 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662843479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662843476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662842636 **[Test build #126376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126376/testReport)** for PR 29085 at commit [`03d3409`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662798740 **[Test build #126376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126376/testReport)** for PR 29085 at commit [`03d3409`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662842137 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662842130 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662842130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap and documentation

2020-07-22 Thread GitBox
SparkQA commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662842211 **[Test build #126389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126389/testReport)** for PR 29191 at commit [`81ac6c6`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662788394 **[Test build #126372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126372/testReport)** for PR 29085 at commit [`be80c27`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662841807 **[Test build #126372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126372/testReport)** for PR 29085 at commit [`be80c27`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29198: [SPARK-32401][SQL] Migrate function related commands to new resolution framework

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29198: URL: https://github.com/apache/spark/pull/29198#issuecomment-662840603 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
SparkQA commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662840761 **[Test build #126388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126388/testReport)** for PR 29107 at commit [`2a9e1e4`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #29198: [SPARK-32401][SQL] Migrate function related commands to new resolution framework

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29198: URL: https://github.com/apache/spark/pull/29198#issuecomment-662810236 **[Test build #126377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126377/testReport)** for PR 29198 at commit [`38756fc`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29198: [SPARK-32401][SQL] Migrate function related commands to new resolution framework

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29198: URL: https://github.com/apache/spark/pull/29198#issuecomment-662840600 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29198: [SPARK-32401][SQL] Migrate function related commands to new resolution framework

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29198: URL: https://github.com/apache/spark/pull/29198#issuecomment-662840600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29198: [SPARK-32401][SQL] Migrate function related commands to new resolution framework

2020-07-22 Thread GitBox
SparkQA commented on pull request #29198: URL: https://github.com/apache/spark/pull/29198#issuecomment-662840371 **[Test build #126377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126377/testReport)** for PR 29198 at commit [`38756fc`](https://github.co

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-07-22 Thread GitBox
dongjoon-hyun edited a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-662839954 By default (=if you don't use `--exclude-tags r`), the test coverage is unchanged in the community so far.

[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-662839954 By default (=if you don't use `--exclude-tags r`), the test coverage is the same in the community. This i

[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-662839474 Hi, @ifilonenko and @shaneknapp . This is designed to run K8s test more selectively like the other test tags (e.g. `ExtendedYarnTest`). ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap and documentation

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662837360 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap and documentation

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662837360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662837130 The PR description is updated accordingly. This is an automated message from the Apache Git Service. To re

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459232335 ## File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala ## @@ -1718,4 +1720,23 @@ class JDBCSuite extends QueryTest jdb

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459231589 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662831333 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662831354 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662831354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29107: URL: https://github.com/apache/spark/pull/29107#issuecomment-662831333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
SparkQA commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662831076 **[Test build #126387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126387/testReport)** for PR 29190 at commit [`fa41817`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
cloud-fan commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662829893 I agree `host` is better as it's general to any deployment model. I think we should only use `worker` when it refers to the standalone worker. Maybe we can start following thi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662829543 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459225681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] AmplabJenkins commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662829543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459225681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459225681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] SparkQA commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
SparkQA commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662829231 **[Test build #126386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126386/testReport)** for PR 29191 at commit [`3e55841`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459225681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459225681 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] agrawaldevesh commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
agrawaldevesh commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662828785 > Merged, thanks everyone. > > I don't know if we have a good principle around naming host v. worker with the deprecation. Thanks @holdenk for championing and

[GitHub] [spark] cloud-fan commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459223512 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
agrawaldevesh commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459223391 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class Broadcast

[GitHub] [spark] cloud-fan commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459223066 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662825995 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662825993 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662825995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662825993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
SparkQA commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662825656 **[Test build #126384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126384/testReport)** for PR 29191 at commit [`e64e7ad`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-662825676 **[Test build #126385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126385/testReport)** for PR 29014 at commit [`7203980`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
HyukjinKwon commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662824703 Looks good This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662824244 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662824244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
SparkQA commented on pull request #29191: URL: https://github.com/apache/spark/pull/29191#issuecomment-662824010 **[Test build #126383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126383/testReport)** for PR 29191 at commit [`e5ddea4`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29196: [SPARK-32398][TESTS][CORE][STREAMING][SQL][ML] Update to scalatest 3.2.0 for Scala 2.13.3+

2020-07-22 Thread GitBox
HyukjinKwon commented on pull request #29196: URL: https://github.com/apache/spark/pull/29196#issuecomment-662824076 Yeah, we still should address https://github.com/apache/spark/pull/29196#discussion_r459209060 but the changes here look good.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459219673 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -288,7 +288,7 @@ final class DataFrameWriter[T] private[sql](

[GitHub] [spark] SparkQA commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
SparkQA commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662822321 **[Test build #126382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126382/testReport)** for PR 29199 at commit [`9b1f28a`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
dongjoon-hyun commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459218262 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -288,7 +288,7 @@ final class DataFrameWriter[T] private[sql](

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662820990 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662820990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
SparkQA commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662820692 **[Test build #126381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126381/testReport)** for PR 29199 at commit [`a007fa1`](https://github.com

[GitHub] [spark] kujon commented on pull request #29192: [SPARK-32393][SQL] Fix postgres bpchar array support

2020-07-22 Thread GitBox
kujon commented on pull request #29192: URL: https://github.com/apache/spark/pull/29192#issuecomment-662819772 > Could you add tests in PostgresIntegrationSuite then check if the test can pass on your local env? (Note: our testing framework, Jenkins, does not run it). will do!

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29196: [SPARK-32398][TESTS][CORE][STREAMING][SQL][ML] Update to scalatest 3.2.0 for Scala 2.13.3+

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29196: URL: https://github.com/apache/spark/pull/29196#issuecomment-662819514 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662819301 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29196: [SPARK-32398][TESTS][CORE][STREAMING][SQL][ML] Update to scalatest 3.2.0 for Scala 2.13.3+

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29196: URL: https://github.com/apache/spark/pull/29196#issuecomment-662819514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662819334 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662819301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-662819369 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AngersZhuuuu commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AngersZh commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662819271 FYI @maropu This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] AmplabJenkins commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662819334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29196: [SPARK-32398][TESTS][CORE][STREAMING][SQL][ML] Update to scalatest 3.2.0 for Scala 2.13.3+

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29196: URL: https://github.com/apache/spark/pull/29196#issuecomment-662785553 **[Test build #126371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126371/testReport)** for PR 29196 at commit [`9c12088`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-662819369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29196: [SPARK-32398][TESTS][CORE][STREAMING][SQL][ML] Update to scalatest 3.2.0 for Scala 2.13.3+

2020-07-22 Thread GitBox
SparkQA commented on pull request #29196: URL: https://github.com/apache/spark/pull/29196#issuecomment-662819159 **[Test build #126371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126371/testReport)** for PR 29196 at commit [`9c12088`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
SparkQA commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662819020 **[Test build #126379 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126379/testReport)** for PR 29186 at commit [`b654ebd`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-22 Thread GitBox
SparkQA commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-662819073 **[Test build #126380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126380/testReport)** for PR 29167 at commit [`477b696`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #29166: [SPARK-32280][SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict pl

2020-07-22 Thread GitBox
viirya commented on a change in pull request #29166: URL: https://github.com/apache/spark/pull/29166#discussion_r459214912 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1237,20 +1250,79 @@ class Analyzer( if (conf

[GitHub] [spark] SparkQA commented on pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
SparkQA commented on pull request #29199: URL: https://github.com/apache/spark/pull/29199#issuecomment-662818996 **[Test build #126378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126378/testReport)** for PR 29199 at commit [`8364f1f`](https://github.com

[GitHub] [spark] AngersZhuuuu opened a new pull request #29199: [SPARK-32105][SQL][FOLLOWUP]Refactor current ScriptTransformationExec…

2020-07-22 Thread GitBox
AngersZh opened a new pull request #29199: URL: https://github.com/apache/spark/pull/29199 # What changes were proposed in this pull request? - Extract common Script IOSchema `ScriptTransformationIOSchema` - avoid repeated judgement extract process output row method `createOut

[GitHub] [spark] xuanyuanking commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
xuanyuanking commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662818538 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HyukjinKwon closed pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
HyukjinKwon closed pull request #29195: URL: https://github.com/apache/spark/pull/29195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459213960 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -288,7 +288,7 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] [spark] cloud-fan commented on a change in pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29191: URL: https://github.com/apache/spark/pull/29191#discussion_r459213858 ## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala ## @@ -52,6 +52,8 @@ class CaseInsensitiveMa

[GitHub] [spark] HyukjinKwon commented on pull request #29195: [SPARK-32338][SQL][PYSPARK][FOLLOW-UP] Update slice to accept Column for start and length.

2020-07-22 Thread GitBox
HyukjinKwon commented on pull request #29195: URL: https://github.com/apache/spark/pull/29195#issuecomment-662817669 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-22 Thread GitBox
imback82 commented on a change in pull request #29167: URL: https://github.com/apache/spark/pull/29167#discussion_r459212899 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -266,6 +266,16 @@ abstract class SQLViewSuite extends Quer

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

2020-07-22 Thread GitBox
cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r459212692 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -271,7 +281,7 @@ case class Uni

  1   2   3   4   5   6   7   8   9   10   >