[GitHub] [spark] AmplabJenkins removed a comment on pull request #29260: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29260: URL: https://github.com/apache/spark/pull/29260#issuecomment-664347826 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #29260: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29260: URL: https://github.com/apache/spark/pull/29260#issuecomment-664347826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] WinkerDu opened a new pull request #29260: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
WinkerDu opened a new pull request #29260: URL: https://github.com/apache/spark/pull/29260 ### What changes were proposed in this pull request? When using dynamic partition overwrite, each task has its working dir under staging dir like `stagingDir/.spark-staging-{jobId}`, ea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29243: [SPARK-32444][SQL] Infer filters from DPP

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29243: URL: https://github.com/apache/spark/pull/29243#issuecomment-664341924 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29243: [SPARK-32444][SQL] Infer filters from DPP

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29243: URL: https://github.com/apache/spark/pull/29243#issuecomment-664341924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-664341339 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-664341327 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-664341327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29243: [SPARK-32444][SQL] Infer filters from DPP

2020-07-27 Thread GitBox
SparkQA commented on pull request #29243: URL: https://github.com/apache/spark/pull/29243#issuecomment-664341321 **[Test build #126641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126641/testReport)** for PR 29243 at commit [`bcc81be`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-664212994 **[Test build #126634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126634/testReport)** for PR 29014 at commit [`c5edd23`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-27 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-664340538 **[Test build #126634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126634/testReport)** for PR 29014 at commit [`c5edd23`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664338595 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-664338651 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664338595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-664338651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-27 Thread GitBox
SparkQA commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-664338026 **[Test build #126640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126640/testReport)** for PR 28968 at commit [`a78fd43`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
SparkQA commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664337984 **[Test build #126639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126639/testReport)** for PR 29000 at commit [`e3dc26b`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-27 Thread GitBox
HyukjinKwon commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-664337380 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-664334637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-664334632 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-664175993 **[Test build #126626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126626/testReport)** for PR 28841 at commit [`11e1109`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-664334632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-07-27 Thread GitBox
SparkQA commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-664334191 **[Test build #126626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126626/testReport)** for PR 28841 at commit [`11e1109`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-664332877 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon closed pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
HyukjinKwon closed pull request #29229: URL: https://github.com/apache/spark/pull/29229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-664332877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
HyukjinKwon commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-664332698 Merged to master. Thanks @dongjoon-hyun and @viirya This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-664179480 **[Test build #126627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126627/testReport)** for PR 29188 at commit [`d6d0117`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-27 Thread GitBox
SparkQA commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-664331962 **[Test build #126627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126627/testReport)** for PR 29188 at commit [`d6d0117`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664329566 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664329566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664247382 **[Test build #126638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126638/testReport)** for PR 29257 at commit [`b2dad7c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
SparkQA commented on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664329191 **[Test build #126638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126638/testReport)** for PR 29257 at commit [`b2dad7c`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29259: [SPARK-29918][SQL][FOLLOWUP][TEST] Fix endianness issues in tests in RecordBinaryComparatorSuite

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29259: URL: https://github.com/apache/spark/pull/29259#issuecomment-664314873 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29259: [SPARK-29918][SQL][FOLLOWUP][TEST] Fix endianness issues in tests in RecordBinaryComparatorSuite

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29259: URL: https://github.com/apache/spark/pull/29259#issuecomment-664313746 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #29259: [SPARK-29918][SQL][FOLLOWUP][TEST] Fix endianness issues in tests in RecordBinaryComparatorSuite

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29259: URL: https://github.com/apache/spark/pull/29259#issuecomment-664313746 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460805760 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSparkSe

[GitHub] [spark] mundaym opened a new pull request #29259: [SPARK-29918][SQL][FOLLOWUP][TEST] Fix endianness issues in tests in RecordBinaryComparatorSuite

2020-07-27 Thread GitBox
mundaym opened a new pull request #29259: URL: https://github.com/apache/spark/pull/29259 ### What changes were proposed in this pull request? PR #26548 means that RecordBinaryComparator now uses big endian byte order for long comparisons. However, this means that some of the consta

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29255: [SPARK-32455][ML] LogisticRegressionModel prediction optimization

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29255: URL: https://github.com/apache/spark/pull/29255#issuecomment-664307630 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29255: [SPARK-32455][ML] LogisticRegressionModel prediction optimization

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29255: URL: https://github.com/apache/spark/pull/29255#issuecomment-664217047 **[Test build #126635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126635/testReport)** for PR 29255 at commit [`5860f81`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29255: [SPARK-32455][ML] LogisticRegressionModel prediction optimization

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29255: URL: https://github.com/apache/spark/pull/29255#issuecomment-664307630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29255: [SPARK-32455][ML] LogisticRegressionModel prediction optimization

2020-07-27 Thread GitBox
SparkQA commented on pull request #29255: URL: https://github.com/apache/spark/pull/29255#issuecomment-664306088 **[Test build #126635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126635/testReport)** for PR 29255 at commit [`5860f81`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29258: [SPARK-32458][SQL][TESTS] Fix incorrectly sized row value reads.

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29258: URL: https://github.com/apache/spark/pull/29258#issuecomment-664302394 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #29258: [SPARK-32458][SQL][TESTS] Fix incorrectly sized row value reads.

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29258: URL: https://github.com/apache/spark/pull/29258#issuecomment-664304397 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #29258: [SPARK-32458][SQL][TESTS] Fix incorrectly sized row value reads.

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29258: URL: https://github.com/apache/spark/pull/29258#issuecomment-664302394 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] mundaym opened a new pull request #29258: [SPARK-32458][SQL][TESTS] Fix incorrectly sized row value reads.

2020-07-27 Thread GitBox
mundaym opened a new pull request #29258: URL: https://github.com/apache/spark/pull/29258 ### What changes were proposed in this pull request? Updates to tests to use correctly sized `getInt` or `getLong` calls. ### Why are the changes needed? The reads were incorrectly sized (i

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-664290163 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-664175950 **[Test build #126625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126625/testReport)** for PR 29229 at commit [`d6ac35d`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-664290163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-27 Thread GitBox
SparkQA commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-664286909 **[Test build #126625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126625/testReport)** for PR 29229 at commit [`d6ac35d`](https://github.co

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460795351 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache So

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664275587 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664275569 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664275569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664186752 **[Test build #126629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126629/testReport)** for PR 29000 at commit [`5865f51`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-07-27 Thread GitBox
SparkQA commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-664273902 **[Test build #126629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126629/testReport)** for PR 29000 at commit [`5865f51`](https://github.co

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r46016 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache So

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776658 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ## @@ -1646,4 +1647,96 @@ class SubquerySuite extends QueryTest with Sha

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776658 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ## @@ -1646,4 +1647,96 @@ class SubquerySuite extends QueryTest with Sha

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776654 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala ## @@ -70,15 +70,15 @@ class DebuggingSuite extends Share

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776317 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala ## @@ -70,15 +70,15 @@ class DebuggingSuite extends Share

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460775483 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala ## @@ -70,15 +70,15 @@ class DebuggingSuite extends Sha

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460775092 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664244178 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460774691 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSparkSe

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460774691 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSparkSe

[GitHub] [spark] SparkQA commented on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
SparkQA commented on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664247382 **[Test build #126638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126638/testReport)** for PR 29257 at commit [`b2dad7c`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460774615 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460773562 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSpark

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460773428 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSparkSe

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460772792 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -903,15 +926,65 @@ private[joins] object LongHashed

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460772732 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with SharedSpark

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29241: URL: https://github.com/apache/spark/pull/29241#discussion_r460682607 ## File path: core/src/main/scala/org/apache/spark/TestUtils.scala ## @@ -236,7 +236,11 @@ private[spark] object TestUtils { * Test if a command i

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460772228 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -311,6 +314,15 @@ private[joins] object UnsafeHashe

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29204: [SPARK-32412][SQL] Unify error handling for spark thrift server operations

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29204: URL: https://github.com/apache/spark/pull/29204#issuecomment-664244632 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460771904 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -903,15 +926,65 @@ private[joins] object LongHash

[GitHub] [spark] AmplabJenkins commented on pull request #29204: [SPARK-32412][SQL] Unify error handling for spark thrift server operations

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29204: URL: https://github.com/apache/spark/pull/29204#issuecomment-664244632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29204: [SPARK-32412][SQL] Unify error handling for spark thrift server operations

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29204: URL: https://github.com/apache/spark/pull/29204#issuecomment-664212962 **[Test build #126633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126633/testReport)** for PR 29204 at commit [`5011314`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29204: [SPARK-32412][SQL] Unify error handling for spark thrift server operations

2020-07-27 Thread GitBox
SparkQA commented on pull request #29204: URL: https://github.com/apache/spark/pull/29204#issuecomment-664244271 **[Test build #126633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126633/testReport)** for PR 29204 at commit [`5011314`](https://github.co

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29241: URL: https://github.com/apache/spark/pull/29241#discussion_r460689868 ## File path: core/src/main/scala/org/apache/spark/TestUtils.scala ## @@ -236,7 +236,11 @@ private[spark] object TestUtils { * Test if a command i

[GitHub] [spark] AmplabJenkins commented on pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29257: URL: https://github.com/apache/spark/pull/29257#issuecomment-664244178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460768470 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +490,43 @@ case class BroadcastHash

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460770609 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -311,6 +314,15 @@ private[joins] object UnsafeHas

[GitHub] [spark] zhengruifeng opened a new pull request #29257: [SPARK-32457][ML] logParam thresholds in DT/GBT/FM/LR/MLP

2020-07-27 Thread GitBox
zhengruifeng opened a new pull request #29257: URL: https://github.com/apache/spark/pull/29257 ### What changes were proposed in this pull request? logParam `thresholds` in DT/GBT/FM/LR/MLP ### Why are the changes needed? param `thresholds` is logged in NB/RF, but not in oth

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460770684 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -889,7 +903,16 @@ private[joins] object LongHashe

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460768470 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +490,43 @@ case class BroadcastHash

[GitHub] [spark] cloud-fan commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
cloud-fan commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460767934 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +490,43 @@ case class BroadcastHash

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29256: [SPARK-32456][SS] Give better error message for union streams in append mode that don't have a watermark

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29256: URL: https://github.com/apache/spark/pull/29256#issuecomment-664240371 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29241: URL: https://github.com/apache/spark/pull/29241#issuecomment-664239449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins commented on pull request #29256: [SPARK-32456][SS] Give better error message for union streams in append mode that don't have a watermark

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29256: URL: https://github.com/apache/spark/pull/29256#issuecomment-664240371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29256: [SPARK-32456][SS] Give better error message for union streams in append mode that don't have a watermark

2020-07-27 Thread GitBox
SparkQA commented on pull request #29256: URL: https://github.com/apache/spark/pull/29256#issuecomment-664239733 **[Test build #126637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126637/testReport)** for PR 29256 at commit [`66e1f52`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29241: URL: https://github.com/apache/spark/pull/29241#issuecomment-664239439 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29241: URL: https://github.com/apache/spark/pull/29241#issuecomment-664239439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] xuanyuanking opened a new pull request #29256: [SPARK-32456][SS] Give better error message for union streams in append mode that don't have a watermark

2020-07-27 Thread GitBox
xuanyuanking opened a new pull request #29256: URL: https://github.com/apache/spark/pull/29256 ### What changes were proposed in this pull request? Check the Distinct nodes by assuming it as Aggregate in `UnsupportOperationChecker` for streaming. ### Why are the changes needed?

[GitHub] [spark] SparkQA commented on pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
SparkQA commented on pull request #29241: URL: https://github.com/apache/spark/pull/29241#issuecomment-664238519 **[Test build #126623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126623/testReport)** for PR 29241 at commit [`d239ede`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29241: [SPARK-32443][CORE] Use POSIX-compatible `command -v` in testCommandAvailable

2020-07-27 Thread GitBox
SparkQA removed a comment on pull request #29241: URL: https://github.com/apache/spark/pull/29241#issuecomment-664166354 **[Test build #126623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126623/testReport)** for PR 29241 at commit [`d239ede`](https://gi

[GitHub] [spark] leanken commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-664237007 @cloud-fan updated. with your suggestion, hashedRelation code diff is smaller and making more sense. This is an

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-664236317 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
AmplabJenkins commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-664236317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460762568 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +967,29 @@ private[joins] object LongHashed

  1   2   3   >