[GitHub] [spark] MaxGekk commented on pull request #29317: [SPARK-32510][SQL] Check duplicate nested columns in read from JDBC datasource

2020-07-31 Thread GitBox
MaxGekk commented on pull request #29317: URL: https://github.com/apache/spark/pull/29317#issuecomment-667091282 @cloud-fan @HyukjinKwon @maropu Please, review this PR. This is an automated message from the Apache Git Service

[GitHub] [spark] MaxGekk commented on a change in pull request #29317: [SPARK-32510][SQL] Check duplicate nested columns in read from JDBC datasource

2020-07-31 Thread GitBox
MaxGekk commented on a change in pull request #29317: URL: https://github.com/apache/spark/pull/29317#discussion_r463576239 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -819,8 +819,10 @@ object JdbcUtils extends Lo

[GitHub] [spark] AmplabJenkins commented on pull request #29278: [SPARK-32160][CORE][PYSPARK] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29278: URL: https://github.com/apache/spark/pull/29278#issuecomment-667089695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
SparkQA commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667089902 **[Test build #126885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126885/testReport)** for PR 29294 at commit [`4531bad`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29318: [SPARK-32509][SQL] Ignore unused DPP True Filter in Canonicalization

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29318: URL: https://github.com/apache/spark/pull/29318#issuecomment-667088534 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
SparkQA commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667088326 **[Test build #126884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126884/testReport)** for PR 28617 at commit [`f6848ed`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-667088060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29318: [SPARK-32509][SQL] Ignore unused DPP True Filter in Canonicalization

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29318: URL: https://github.com/apache/spark/pull/29318#issuecomment-667088115 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on pull request #29278: [SPARK-32160][CORE][PYSPARK] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
SparkQA commented on pull request #29278: URL: https://github.com/apache/spark/pull/29278#issuecomment-667087591 **[Test build #126869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126869/testReport)** for PR 29278 at commit [`0ea7ea9`](https://github.co

[GitHub] [spark] prakharjain09 opened a new pull request #29318: [SPARK-32509][SQL] Ignore unused DPP True Filter in Canonicalization

2020-07-31 Thread GitBox
prakharjain09 opened a new pull request #29318: URL: https://github.com/apache/spark/pull/29318 ### What changes were proposed in this pull request? This PR fixes issues relate to Canonicalization of FileSourceScanExec when it contains unused DPP Filter. ### Why are the changes ne

[GitHub] [spark] SparkQA removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-666973312 **[Test build #126870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126870/testReport)** for PR 28939 at commit [`ae52b78`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-07-31 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-667086377 **[Test build #126870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126870/testReport)** for PR 28939 at commit [`ae52b78`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-667085443 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
SparkQA commented on pull request #29315: URL: https://github.com/apache/spark/pull/29315#issuecomment-667085637 **[Test build #126883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126883/testReport)** for PR 29315 at commit [`376989d`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-667085440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-667085440 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-666973362 **[Test build #126871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126871/testReport)** for PR 28781 at commit [`aa7a682`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667083647 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083728 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
SparkQA commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667083911 **[Test build #126882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126882/testReport)** for PR 29269 at commit [`cb82167`](https://github.com

[GitHub] [spark] stczwd edited a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
stczwd edited a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083355 @cloud-fan Thanks for paying attention on this PR. This can be changed to `WIP` if we still have some conflicts. > What is the reason to extend `TableCatalog` instea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667083639 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-666968732 **[Test build #126866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126866/testReport)** for PR 29291 at commit [`9939ea7`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-07-31 Thread GitBox
SparkQA commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-667083791 **[Test build #126881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126881/testReport)** for PR 28527 at commit [`b471a0e`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-666966221 **[Test build #126856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126856/testReport)** for PR 28617 at commit [`f6848ed`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-07-31 Thread GitBox
SparkQA commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-667083841 **[Test build #126871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126871/testReport)** for PR 28781 at commit [`aa7a682`](https://github.co

[GitHub] [spark] stczwd edited a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
stczwd edited a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083355 @cloud-fan Thanks for paying attention on this PR. This can be changed to `WIP` if we still have some conflicts. > What is the reason to extend `TableCatalog` instea

[GitHub] [spark] SparkQA commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
SparkQA commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083004 **[Test build #126856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126856/testReport)** for PR 28617 at commit [`f6848ed`](https://github.co

[GitHub] [spark] stczwd commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-07-31 Thread GitBox
stczwd commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667083355 @cloud-fan This can be changed to `WIP` if we still have some conflicts. > What is the reason to extend `TableCatalog` instead of `Table`? I think it would be better to sup

[GitHub] [spark] SparkQA commented on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
SparkQA commented on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667083146 **[Test build #126866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126866/testReport)** for PR 29291 at commit [`9939ea7`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667083639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29315: URL: https://github.com/apache/spark/pull/29315#issuecomment-667029157 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667081136 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
SparkQA commented on pull request #29315: URL: https://github.com/apache/spark/pull/29315#issuecomment-667081276 **[Test build #126880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126880/testReport)** for PR 29315 at commit [`a358345`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667081136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-666968115 **[Test build #126857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126857/testReport)** for PR 29291 at commit [`fbb051b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
SparkQA commented on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667080197 **[Test build #126857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126857/testReport)** for PR 29291 at commit [`fbb051b`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29317: [WIP][SQL] Check duplicate nested columns in read from JDBC datasource

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29317: URL: https://github.com/apache/spark/pull/29317#issuecomment-667079962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29279: [SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29279: URL: https://github.com/apache/spark/pull/29279#issuecomment-667077280 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29271: [SPARK-32467][UI]Avoid encoding URL twice on https redirect

2020-07-31 Thread GitBox
SparkQA commented on pull request #29271: URL: https://github.com/apache/spark/pull/29271#issuecomment-667077427 **[Test build #126879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126879/testReport)** for PR 29271 at commit [`ef6cb87`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29279: [SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29279: URL: https://github.com/apache/spark/pull/29279#issuecomment-667077280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29279: [SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #29279: URL: https://github.com/apache/spark/pull/29279#issuecomment-666998475 **[Test build #126873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126873/testReport)** for PR 29279 at commit [`ad847b1`](https://gi

[GitHub] [spark] MaxGekk opened a new pull request #29317: [WIP][SQL] Check duplicate nested columns in read from JDBC datasource

2020-07-31 Thread GitBox
MaxGekk opened a new pull request #29317: URL: https://github.com/apache/spark/pull/29317 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [spark] SparkQA commented on pull request #29279: [SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name

2020-07-31 Thread GitBox
SparkQA commented on pull request #29279: URL: https://github.com/apache/spark/pull/29279#issuecomment-667076426 **[Test build #126873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126873/testReport)** for PR 29279 at commit [`ad847b1`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667071083 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thri

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29303: URL: https://github.com/apache/spark/pull/29303#issuecomment-667071115 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29303: [SPARK-32492][SQL] Fulfill missing column meta information COLUMN_SIZE /DECIMAL_DIGITS/NUM_PREC_RADIX/ORDINAL_POSITION for thriftserver

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29303: URL: https://github.com/apache/spark/pull/29303#issuecomment-667071115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667071083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
HyukjinKwon commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667070572 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667068237 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29291: URL: https://github.com/apache/spark/pull/29291#issuecomment-667068237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-667064939 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] beliefer commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
beliefer commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463549738 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-filter.sql ## @@ -36,8 +36,11 @@ SELECT COUNT(id) FILTER (WHERE hiredate = date "2001

[GitHub] [spark] AmplabJenkins commented on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-667067517 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667065327 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29299: [SPARK-32490][BUILD] Upgrade netty-all to 4.1.51.Final

2020-07-31 Thread GitBox
SparkQA commented on pull request #29299: URL: https://github.com/apache/spark/pull/29299#issuecomment-667065717 **[Test build #126878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126878/testReport)** for PR 29299 at commit [`06a2b0d`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667065320 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667065320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29316: URL: https://github.com/apache/spark/pull/29316#issuecomment-667064939 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] cxzl25 opened a new pull request #29316: [SPARK-32508][SQL] Disallow empty part col values in partition spec before static partition writing

2020-07-31 Thread GitBox
cxzl25 opened a new pull request #29316: URL: https://github.com/apache/spark/pull/29316 ### What changes were proposed in this pull request? Write to static partition, check in advance that the partition field is empty. ### Why are the changes needed? When writing to the curre

[GitHub] [spark] SparkQA removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-666968597 **[Test build #126864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126864/testReport)** for PR 28617 at commit [`f6848ed`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
SparkQA commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667064344 **[Test build #126864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126864/testReport)** for PR 28617 at commit [`f6848ed`](https://github.co

[GitHub] [spark] beliefer commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-31 Thread GitBox
beliefer commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463545124 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -118,6 +118,49 @@ import org.apa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667050003 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667050003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
HyukjinKwon commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667046854 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667045125 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667045116 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667045116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29310: [SPARK-32332][SQL][3.0] Support columnar exchanges

2020-07-31 Thread GitBox
SparkQA commented on pull request #29310: URL: https://github.com/apache/spark/pull/29310#issuecomment-667045390 **[Test build #126877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126877/testReport)** for PR 29310 at commit [`7aaa0cf`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-666968292 **[Test build #126861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126861/testReport)** for PR 29294 at commit [`4531bad`](https://gi

[GitHub] [spark] cloud-fan commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
cloud-fan commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667044527 Can we turn it into a WIP PR and add more changes to show how we can leverage the API to implement the partition related commands? I'm really curious about the process to reso

[GitHub] [spark] SparkQA commented on pull request #29294: [SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors.

2020-07-31 Thread GitBox
SparkQA commented on pull request #29294: URL: https://github.com/apache/spark/pull/29294#issuecomment-667044209 **[Test build #126861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126861/testReport)** for PR 29294 at commit [`4531bad`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667043397 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667043397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667039757 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667039757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29315: URL: https://github.com/apache/spark/pull/29315#issuecomment-667039785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-07-31 Thread GitBox
cloud-fan commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667039792 add to whitelist This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] xuanyuanking commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
xuanyuanking commented on a change in pull request #29315: URL: https://github.com/apache/spark/pull/29315#discussion_r463517304 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1236,7 +1236,7 @@ object SQLConf { val STATE_STORE_F

[GitHub] [spark] xuanyuanking commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
xuanyuanking commented on a change in pull request #29315: URL: https://github.com/apache/spark/pull/29315#discussion_r463517078 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1236,9 +1236,9 @@ object SQLConf { val STATE_STORE_F

[GitHub] [spark] cloud-fan commented on a change in pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
cloud-fan commented on a change in pull request #29315: URL: https://github.com/apache/spark/pull/29315#discussion_r463515692 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1236,9 +1236,9 @@ object SQLConf { val STATE_STORE_FORM

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667036184 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667036184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667033397 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-31 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r463511408 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala ## @@ -322,6 +322,48 @@ class RegexpEx

[GitHub] [spark] xuanyuanking commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
xuanyuanking commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667033676 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667033387 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-666968428 **[Test build #126865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126865/testReport)** for PR 29269 at commit [`cb82167`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-07-31 Thread GitBox
SparkQA commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-667033617 **[Test build #126876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126876/testReport)** for PR 28527 at commit [`3fbe65a`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667033387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29269: [SPARK-31792][SS][DOC][FOLLOW-UP] Rephrase the description for some operations

2020-07-31 Thread GitBox
SparkQA commented on pull request #29269: URL: https://github.com/apache/spark/pull/29269#issuecomment-667033178 **[Test build #126865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126865/testReport)** for PR 29269 at commit [`cb82167`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667032038 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667032025 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-07-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-667029106 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] xuanyuanking commented on pull request #29315: [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc

2020-07-31 Thread GitBox
xuanyuanking commented on pull request #29315: URL: https://github.com/apache/spark/pull/29315#issuecomment-667032181 https://github.com/apache/spark/pull/28707/files#diff-238c6b2f820f62c556f204788d684584R150 I think the error message is clear, we don't use code name inside. --

[GitHub] [spark] AmplabJenkins commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-07-31 Thread GitBox
AmplabJenkins commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667032025 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

2020-07-31 Thread GitBox
SparkQA commented on pull request #29146: URL: https://github.com/apache/spark/pull/29146#issuecomment-667032219 **[Test build #126875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126875/testReport)** for PR 29146 at commit [`6d2221d`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-07-31 Thread GitBox
SparkQA removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-666968238 **[Test build #126860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126860/testReport)** for PR 27246 at commit [`2e91826`](https://gi

<    1   2   3   4   5   6   7   >