[GitHub] [spark] viirya commented on a change in pull request #29270: [SPARK-32466][TEST][SQL] Add PlanStabilitySuite to detect SparkPlan regression

2020-08-01 Thread GitBox
viirya commented on a change in pull request #29270: URL: https://github.com/apache/spark/pull/29270#discussion_r464038614 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-08-01 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-667634880 **[Test build #126933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126933/testReport)** for PR 29067 at commit [`3f2f527`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #29270: [SPARK-32466][TEST][SQL] Add PlanStabilitySuite to detect SparkPlan regression

2020-08-01 Thread GitBox
viirya commented on a change in pull request #29270: URL: https://github.com/apache/spark/pull/29270#discussion_r464037778 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29325: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29325: URL: https://github.com/apache/spark/pull/29325#issuecomment-667634350 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre and Hadoop to 3.2.1

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-667634339 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-667634347 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29325: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29325: URL: https://github.com/apache/spark/pull/29325#issuecomment-667634350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre and Hadoop to 3.2.1

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-667634339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-667634347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre and Hadoop to 3.2.1

2020-08-01 Thread GitBox
SparkQA commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-667634235 **[Test build #126931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126931/testReport)** for PR 29326 at commit [`68375f0`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-08-01 Thread GitBox
HyukjinKwon commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-667634213 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] viirya commented on pull request #29325: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2020-08-01 Thread GitBox
viirya commented on pull request #29325: URL: https://github.com/apache/spark/pull/29325#issuecomment-667634230 Hadoop 3.2.0 still uses older Guava 11.0.2. I'm not sure if we can just upgrade Guava without touching Hadoop dependency. I want to run the patch through jenkins (sbt and maven)

[GitHub] [spark] SparkQA commented on pull request #29325: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2020-08-01 Thread GitBox
SparkQA commented on pull request #29325: URL: https://github.com/apache/spark/pull/29325#issuecomment-667634236 **[Test build #126932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126932/testReport)** for PR 29325 at commit [`4888ca0`](https://github.com

[GitHub] [spark] viirya opened a new pull request #29325: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2020-08-01 Thread GitBox
viirya opened a new pull request #29325: URL: https://github.com/apache/spark/pull/29325 ### What changes were proposed in this pull request? This PR upgrades Guava to newer 27.0-jre. ### Why are the changes needed? Guava 14.0.1 is pretty old and is among

[GitHub] [spark] viirya opened a new pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre and Hadoop to 3.2.1

2020-08-01 Thread GitBox
viirya opened a new pull request #29326: URL: https://github.com/apache/spark/pull/29326 ### What changes were proposed in this pull request? This PR upgrades Guava to newer 27.0-jre and the dependency version of Hadoop 3.2 line to 3.2.1. ### Why are the changes ne

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667633114 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667633209 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667633209 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667611648 **[Test build #126925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126925/testReport)** for PR 29304 at commit [`1153513`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667633114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
SparkQA commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667632990 **[Test build #126925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126925/testReport)** for PR 29304 at commit [`1153513`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667611654 **[Test build #126926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126926/testReport)** for PR 28617 at commit [`825d2e9`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
SparkQA commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667632893 **[Test build #126926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126926/testReport)** for PR 28617 at commit [`825d2e9`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667632692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667632692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667632566 **[Test build #126930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126930/testReport)** for PR 29324 at commit [`3672250`](https://github.com

[GitHub] [spark] huaxingao commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667632334 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667631832 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667613368 **[Test build #126927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126927/testReport)** for PR 29324 at commit [`3672250`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667631830 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667631830 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667631743 **[Test build #126927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126927/testReport)** for PR 29324 at commit [`3672250`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667625921 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-667625572 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667623511 **[Test build #126928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126928/testReport)** for PR 29074 at commit [`268326b`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667625924 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
SparkQA commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667625907 **[Test build #126928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126928/testReport)** for PR 29074 at commit [`268326b`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667625921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-667625572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29317: [SPARK-32510][SQL] Check duplicate nested columns in read from JDBC datasource

2020-08-01 Thread GitBox
HyukjinKwon commented on a change in pull request #29317: URL: https://github.com/apache/spark/pull/29317#discussion_r464029936 ## File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JdbcNestedDataSourceSuite.scala ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache So

[GitHub] [spark] SparkQA commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-08-01 Thread GitBox
SparkQA commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-667625475 **[Test build #126929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126929/testReport)** for PR 28715 at commit [`d6f8459`](https://github.com

[GitHub] [spark] kiszk commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-08-01 Thread GitBox
kiszk commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-667625363 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] HyukjinKwon commented on pull request #29323: [SPARK-32513][SQL] Rename classes/files with the Jdbc prefix to JDBC

2020-08-01 Thread GitBox
HyukjinKwon commented on pull request #29323: URL: https://github.com/apache/spark/pull/29323#issuecomment-667625304 Same as @maropu. There's inconsistency in JSON vs Json, CSV vs Csv. Orc might have to be ORC too. The change itself looks fine as one time thing but not sure if we should do

[GitHub] [spark] kiszk commented on pull request #28953: [SPARK-32013][SQL] Support query execution before reading DataFrame and before/after writing DataFrame over JDBC

2020-08-01 Thread GitBox
kiszk commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-667625280 @moomindani now, the conflict happens. Could you please resolve it? This is an automated message from the Apache G

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667623614 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667623614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-08-01 Thread GitBox
SparkQA commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-667623511 **[Test build #126928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126928/testReport)** for PR 29074 at commit [`268326b`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667622963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667622960 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667622960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
SparkQA commented on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667622892 **[Test build #126924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126924/testReport)** for PR 27507 at commit [`2125bff`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667605206 **[Test build #126924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126924/testReport)** for PR 27507 at commit [`2125bff`](https://gi

[GitHub] [spark] huaxingao commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667614925 @MaxGekk Thank you very much for your review! I addressed all the comments. Could you please take one more look? Thanks! -

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464022034 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -908,4 +909,25 @@ object JdbcUtils extends

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464021800 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464020918 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667613507 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667613507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] huaxingao commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
huaxingao commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464020845 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializa

[GitHub] [spark] SparkQA commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667613368 **[Test build #126927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126927/testReport)** for PR 29324 at commit [`3672250`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667611753 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667611732 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667611753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667611732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
SparkQA commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667611654 **[Test build #126926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126926/testReport)** for PR 28617 at commit [`825d2e9`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
SparkQA commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667611648 **[Test build #126925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126925/testReport)** for PR 29304 at commit [`1153513`](https://github.com

[GitHub] [spark] leanken commented on pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
leanken commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667611425 @maropu thanks for reviewing during weekend, code updated. ^_^ This is an automated message from the Apache Git

[GitHub] [spark] leanken commented on a change in pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
leanken commented on a change in pull request #29304: URL: https://github.com/apache/spark/pull/29304#discussion_r464019324 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -327,11 +327,29 @@ private[joins] object UnsafeHash

[GitHub] [spark] stczwd commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
stczwd commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r464019294 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitions.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apach

[GitHub] [spark] leanken commented on a change in pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
leanken commented on a change in pull request #29304: URL: https://github.com/apache/spark/pull/29304#discussion_r464019310 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1183,42 @@ class JoinSuite extends QueryTest with SharedSparkSe

[GitHub] [spark] maropu commented on a change in pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
maropu commented on a change in pull request #29304: URL: https://github.com/apache/spark/pull/29304#discussion_r464017097 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -393,33 +395,42 @@ object PhysicalWindow { object

[GitHub] [spark] leanken commented on a change in pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

2020-08-01 Thread GitBox
leanken commented on a change in pull request #29304: URL: https://github.com/apache/spark/pull/29304#discussion_r464015628 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -393,33 +395,42 @@ object PhysicalWindow { objec

[GitHub] [spark] github-actions[bot] closed pull request #27286: [SPARK-30576] [SS] block streaming batch commit, until completed。

2020-08-01 Thread GitBox
github-actions[bot] closed pull request #27286: URL: https://github.com/apache/spark/pull/27286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [spark] github-actions[bot] commented on pull request #28278: "[SPARK-29274][SQL] Fix compare bigdecimal and string, string cast to…

2020-08-01 Thread GitBox
github-actions[bot] commented on pull request #28278: URL: https://github.com/apache/spark/pull/28278#issuecomment-667605574 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] github-actions[bot] commented on pull request #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-08-01 Thread GitBox
github-actions[bot] commented on pull request #27861: URL: https://github.com/apache/spark/pull/27861#issuecomment-667605577 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] github-actions[bot] closed pull request #28232: [SPARK-31459][SQL]fix insert overwrite directory target path is an existing file

2020-08-01 Thread GitBox
github-actions[bot] closed pull request #28232: URL: https://github.com/apache/spark/pull/28232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [spark] AmplabJenkins commented on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667605379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667605379 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
SparkQA commented on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667605206 **[Test build #126924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126924/testReport)** for PR 27507 at commit [`2125bff`](https://github.com

[GitHub] [spark] beliefer commented on pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-08-01 Thread GitBox
beliefer commented on pull request #27507: URL: https://github.com/apache/spark/pull/27507#issuecomment-667604702 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] srowen commented on a change in pull request #29320: [WIP][SPARK-32507][DOCS][PYTHON] Add main page for PySpark documentation

2020-08-01 Thread GitBox
srowen commented on a change in pull request #29320: URL: https://github.com/apache/spark/pull/29320#discussion_r464008257 ## File path: python/docs/source/index.rst ## @@ -21,8 +21,42 @@ PySpark Documentation = +PySpark is an interface for Apache Spark

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667593319 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667590612 **[Test build #126923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126923/testReport)** for PR 29324 at commit [`ce00d06`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667593316 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667593303 **[Test build #126923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126923/testReport)** for PR 29324 at commit [`ce00d06`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667593316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
SparkQA commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667590612 **[Test build #126923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126923/testReport)** for PR 29324 at commit [`ce00d06`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667590723 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #29324: URL: https://github.com/apache/spark/pull/29324#issuecomment-667590723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #28885: URL: https://github.com/apache/spark/pull/28885#issuecomment-667579885 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #28885: URL: https://github.com/apache/spark/pull/28885#issuecomment-667579885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #28885: URL: https://github.com/apache/spark/pull/28885#issuecomment-667551151 **[Test build #126921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126921/testReport)** for PR 28885 at commit [`5d5fd04`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-08-01 Thread GitBox
SparkQA commented on pull request #28885: URL: https://github.com/apache/spark/pull/28885#issuecomment-667579674 **[Test build #126921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126921/testReport)** for PR 28885 at commit [`5d5fd04`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-08-01 Thread GitBox
AmplabJenkins commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667579371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667579371 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-08-01 Thread GitBox
SparkQA removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667563903 **[Test build #126922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126922/testReport)** for PR 27246 at commit [`9d5bd99`](https://gi

[GitHub] [spark] SparkQA commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-08-01 Thread GitBox
SparkQA commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-667579154 **[Test build #126922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126922/testReport)** for PR 27246 at commit [`9d5bd99`](https://github.co

[GitHub] [spark] rdblue commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
rdblue commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-667578389 Looks good to me. When you've submitted a PR with an example implementation, please link to it here. Since Wenchen wants to see this in use, I'll let him commit this when h

[GitHub] [spark] rdblue commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-01 Thread GitBox
rdblue commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r463993532 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitions.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apach

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29318: [SPARK-32509][SQL] Ignore unused DPP True Filter in Canonicalization

2020-08-01 Thread GitBox
AmplabJenkins removed a comment on pull request #29318: URL: https://github.com/apache/spark/pull/29318#issuecomment-667566726 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >