[GitHub] [spark] SparkQA commented on pull request #29403: [SPARK-32585][SQL] Support scala enumeration in ScalaReflection

2020-08-11 Thread GitBox
SparkQA commented on pull request #29403: URL: https://github.com/apache/spark/pull/29403#issuecomment-671910092 **[Test build #127319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127319/testReport)** for PR 29403 at commit [`0f98bef`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29407: [SPARK-32588][TEST] Fix SizeEstimator initialization in tests.

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29407: URL: https://github.com/apache/spark/pull/29407#issuecomment-671909569 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #29407: [SPARK-32588][TEST] Fix SizeEstimator initialization in tests.

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29407: URL: https://github.com/apache/spark/pull/29407#issuecomment-671909043 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] mundaym opened a new pull request #29407: [SPARK-32588][TEST] Fix SizeEstimator initialization in tests.

2020-08-11 Thread GitBox
mundaym opened a new pull request #29407: URL: https://github.com/apache/spark/pull/29407 In order to produce consistent results from SizeEstimator the tests override some system properties that are used during SizeEstimator initialization. However there were several places where eithe

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671899586 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671899586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671776159 **[Test build #127315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127315/testReport)** for PR 29405 at commit [`40af8d4`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
SparkQA commented on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671898813 **[Test build #127315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127315/testReport)** for PR 29405 at commit [`40af8d4`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671897577 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671897577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671896522 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671772709 **[Test build #127313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127313/testReport)** for PR 29404 at commit [`b9af4f5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671896769 **[Test build #127313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127313/testReport)** for PR 29404 at commit [`b9af4f5`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671896522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671772755 **[Test build #127314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127314/testReport)** for PR 29401 at commit [`b9776bd`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
SparkQA commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671895763 **[Test build #127314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127314/testReport)** for PR 29401 at commit [`b9776bd`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671889886 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671889886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769327 **[Test build #127312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127312/testReport)** for PR 29369 at commit [`e4b4c5a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
SparkQA commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671889081 **[Test build #127312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127312/testReport)** for PR 29369 at commit [`e4b4c5a`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29366: URL: https://github.com/apache/spark/pull/29366#issuecomment-671886677 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29366: URL: https://github.com/apache/spark/pull/29366#issuecomment-671886677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-11 Thread GitBox
SparkQA commented on pull request #29366: URL: https://github.com/apache/spark/pull/29366#issuecomment-671886135 **[Test build #127322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127322/testReport)** for PR 29366 at commit [`3b7bfac`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-11 Thread GitBox
HyukjinKwon commented on pull request #29366: URL: https://github.com/apache/spark/pull/29366#issuecomment-671884145 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671869345 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] SparkQA removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671810372 **[Test build #127316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127316/testReport)** for PR 29404 at commit [`a8be9e1`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671869336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671869336 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671869140 **[Test build #127316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127316/testReport)** for PR 29404 at commit [`a8be9e1`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29406: [SPARK-32352][SQL] Partially push down support data filter if it mixed in partition filters

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29406: URL: https://github.com/apache/spark/pull/29406#issuecomment-671856888 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29406: [SPARK-32352][SQL] Partially push down support data filter if it mixed in partition filters

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29406: URL: https://github.com/apache/spark/pull/29406#issuecomment-671856888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29406: [SPARK-32352][SQL] Partially push down support data filter if it mixed in partition filters

2020-08-11 Thread GitBox
SparkQA commented on pull request #29406: URL: https://github.com/apache/spark/pull/29406#issuecomment-671856304 **[Test build #127321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127321/testReport)** for PR 29406 at commit [`5bb0fb9`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #29406: [SPARK-32352][SQL] Partially push down support data filter if it mixed in partition filters

2020-08-11 Thread GitBox
AngersZh commented on pull request #29406: URL: https://github.com/apache/spark/pull/29406#issuecomment-671855936 FYI @wangyum @gengliangwang @cloud-fan This is an automated message from the Apache Git Service. To respo

[GitHub] [spark] AngersZhuuuu opened a new pull request #29406: [SPARK-32352][SQL] Partially push down support data filter if it mixed in partition filters

2020-08-11 Thread GitBox
AngersZh opened a new pull request #29406: URL: https://github.com/apache/spark/pull/29406 ### What changes were proposed in this pull request? We support partially push partition filters since SPARK-28169. We can also support partially push down data filters if it mixed in partition

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671852821 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671852821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
SparkQA commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671852134 **[Test build #127320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127320/testReport)** for PR 29369 at commit [`690e326`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29403: [SPARK-32585][SQL] Support scala enumeration in ScalaReflection

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29403: URL: https://github.com/apache/spark/pull/29403#issuecomment-671845635 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29403: [SPARK-32585][SQL] Support scala enumeration in ScalaReflection

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29403: URL: https://github.com/apache/spark/pull/29403#issuecomment-671845635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29403: [SPARK-32585][SQL] Support scala enumeration in ScalaReflection

2020-08-11 Thread GitBox
SparkQA commented on pull request #29403: URL: https://github.com/apache/spark/pull/29403#issuecomment-671845010 **[Test build #127319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127319/testReport)** for PR 29403 at commit [`0f98bef`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671842205 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671842205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] SparkQA commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
SparkQA commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671841371 **[Test build #127318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127318/testReport)** for PR 29369 at commit [`a9d5042`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468417598 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -339,6 +341,28 @@ object EliminateDistinct exte

[GitHub] [spark] beliefer commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
beliefer commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468442998 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateAggregateFilterSuite.scala ## @@ -0,0 +1,79 @@ +/* + * Licens

[GitHub] [spark] beliefer commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
beliefer commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468442906 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -339,6 +341,28 @@ object EliminateDistinct exten

[GitHub] [spark] leoluan2009 commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver

2020-08-11 Thread GitBox
leoluan2009 commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-671830972 @maropu all build are ok now, can you take a look again? thanks This is an automated message from the Apac

[GitHub] [spark] cloud-fan commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r468438557 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitionManagement.java ## @@ -0,0 +1,113 @@ +/* + * Licensed

[GitHub] [spark] cloud-fan commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r468438174 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java ## @@ -0,0 +1,87 @@ +/* + * Lice

[GitHub] [spark] cloud-fan commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r468438262 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java ## @@ -0,0 +1,87 @@ +/* + * Lice

[GitHub] [spark] cloud-fan commented on a change in pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r468437580 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java ## @@ -0,0 +1,87 @@ +/* + * Lice

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671826576 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671826576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
SparkQA commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671825983 **[Test build #127317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127317/testReport)** for PR 29401 at commit [`0b121c1`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AngersZh commented on a change in pull request #29401: URL: https://github.com/apache/spark/pull/29401#discussion_r468431497 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ## @@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {

[GitHub] [spark] cloud-fan commented on a change in pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29401: URL: https://github.com/apache/spark/pull/29401#discussion_r468425101 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ## @@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {

[GitHub] [spark] cloud-fan commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468419399 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateAggregateFilterSuite.scala ## @@ -0,0 +1,79 @@ +/* + * Licen

[GitHub] [spark] cloud-fan commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468418298 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateAggregateFilterSuite.scala ## @@ -0,0 +1,79 @@ +/* + * Licen

[GitHub] [spark] cloud-fan commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468417598 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -339,6 +341,28 @@ object EliminateDistinct exte

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671810965 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671810965 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] AmplabJenkins commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671810974 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31935/

[GitHub] [spark] SparkQA commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671810372 **[Test build #127316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127316/testReport)** for PR 29404 at commit [`a8be9e1`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
cloud-fan commented on a change in pull request #29369: URL: https://github.com/apache/spark/pull/29369#discussion_r468416023 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -339,6 +341,28 @@ object EliminateDistinct exte

[GitHub] [spark] cloud-fan commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-11 Thread GitBox
cloud-fan commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-671804290 @c21 yea this is a hard problem. We can probably add a different iterator implementation in `BytesToBytesMap`, which iterates the `longArray` first, get the key address,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671776709 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671776709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
SparkQA commented on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671776159 **[Test build #127315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127315/testReport)** for PR 29405 at commit [`40af8d4`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AngersZh commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671775460 > Thanks for the work, @AngersZh . Could you please fill the description as @HyukjinKwon suggested in the jira. I think that helps for better traceability. Yea,

[GitHub] [spark] maropu commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
maropu commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671774152 Thanks for the work, @AngersZh . Could you please fill the description as @HyukjinKwon suggested in the jira. I think that helps for better traceability. --

[GitHub] [spark] wangyum commented on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
wangyum commented on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671774173 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671773225 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671773246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671773246 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671773225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
SparkQA commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671772755 **[Test build #127314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127314/testReport)** for PR 29401 at commit [`b9776bd`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
SparkQA commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671772709 **[Test build #127313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127313/testReport)** for PR 29404 at commit [`b9af4f5`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AngersZh commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671772263 FYI cc @maropu @cloud-fan This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [spark] AngersZhuuuu commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AngersZh commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671771989 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29396: [SPARK-32579][SQL] Implement JDBCScan/ScanBuilder/WriteBuilder

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29396: URL: https://github.com/apache/spark/pull/29396#issuecomment-671769374 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671769653 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671768987 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-671769021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671769647 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29396: [SPARK-32579][SQL] Implement JDBCScan/ScanBuilder/WriteBuilder

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29396: URL: https://github.com/apache/spark/pull/29396#issuecomment-671769368 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-671769326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] SparkQA removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671694575 **[Test build #127302 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127302/testReport)** for PR 29369 at commit [`e4b4c5a`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671690473 **[Test build #127299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127299/testReport)** for PR 29401 at commit [`b9776bd`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29403: [SPARK-32585][SQL] Support scala enumeration in ScalaReflection

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29403: URL: https://github.com/apache/spark/pull/29403#issuecomment-671769023 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins commented on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-671769225 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29369: [SPARK-32540][SQL] Eliminate the filter clause in aggregate

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29369: URL: https://github.com/apache/spark/pull/29369#issuecomment-671769426 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29401: [SPARK-32400][SQL] Improve test coverage of HiveScriptTransformationExec

2020-08-11 Thread GitBox
AmplabJenkins commented on pull request #29401: URL: https://github.com/apache/spark/pull/29401#issuecomment-671769647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29405: [SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29405: URL: https://github.com/apache/spark/pull/29405#issuecomment-671768982 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-11 Thread GitBox
AmplabJenkins removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-671769322 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29396: [SPARK-32579][SQL] Implement JDBCScan/ScanBuilder/WriteBuilder

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29396: URL: https://github.com/apache/spark/pull/29396#issuecomment-671715831 **[Test build #127305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127305/testReport)** for PR 29396 at commit [`3ef5414`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling

2020-08-11 Thread GitBox
SparkQA removed a comment on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-671721570 **[Test build #127306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127306/testReport)** for PR 29367 at commit [`a099152`](https://gi

<    1   2   3   4   5   6   7   >