[GitHub] [spark] AmplabJenkins removed a comment on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675225935 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224011 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675225935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
SparkQA commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675225662 **[Test build #127523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127523/testReport)** for PR 29454 at commit [`bd7ff11`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
HyukjinKwon commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224351 cc @Ngone51 and @tgravescs FYI. This is being tested at https://github.com/apache/spark/actions/runs/213000777 -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675224126 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675224126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224121 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224004 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675224121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
SparkQA commented on pull request #29454: URL: https://github.com/apache/spark/pull/29454#issuecomment-675223758 **[Test build #127521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127521/testReport)** for PR 29454 at commit [`0e18705`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
HyukjinKwon commented on a change in pull request #29454: URL: https://github.com/apache/spark/pull/29454#discussion_r471888420 ## File path: .github/workflows/master.yml ## @@ -183,6 +183,12 @@ jobs: with: name: test-results-${{ matrix.modules }}-${{ matrix.com

[GitHub] [spark] SparkQA commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
SparkQA commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675223805 **[Test build #127522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127522/testReport)** for PR 29452 at commit [`97ad7fe`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
HyukjinKwon commented on a change in pull request #29454: URL: https://github.com/apache/spark/pull/29454#discussion_r471888420 ## File path: .github/workflows/master.yml ## @@ -183,6 +183,12 @@ jobs: with: name: test-results-${{ matrix.modules }}-${{ matrix.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675223505 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon opened a new pull request #29454: [SPARK-32645][INFRA] Upload unit-tests.log as an artifact

2020-08-17 Thread GitBox
HyukjinKwon opened a new pull request #29454: URL: https://github.com/apache/spark/pull/29454 ### What changes were proposed in this pull request? This PR proposes to upload `target/unit-tests.log` into the artifact so it will be able to download here: ![Screen Shot 2020-08-18 at

[GitHub] [spark] AmplabJenkins commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675223505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
SparkQA commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675222962 **[Test build #127518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127518/testReport)** for PR 29452 at commit [`61ac7b8`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
SparkQA removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675184177 **[Test build #127518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127518/testReport)** for PR 29452 at commit [`61ac7b8`](https://gi

[GitHub] [spark] agrawaldevesh commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
agrawaldevesh commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675222880 cc: @holdenk and @prakharjain09 ... This PR simply does some state cleanup/consolidation without making any semantic changes. I would be grateful for your review. I have a

[GitHub] [spark] gengliangwang commented on pull request #29450: [3.0][SQL] Revert SPARK-32018

2020-08-17 Thread GitBox
gengliangwang commented on pull request #29450: URL: https://github.com/apache/spark/pull/29450#issuecomment-675222779 @maropu This is a long-standing issue in Spark. I think we can mention the latest behavior in the migration guide and release note of 3.1.0. -

[GitHub] [spark] Ngone51 commented on pull request #29418: [SPARK-32600][CORE] Unify task name in some logs between driver and executor

2020-08-17 Thread GitBox
Ngone51 commented on pull request #29418: URL: https://github.com/apache/spark/pull/29418#issuecomment-675222013 @jiangxb1987 @tgravescs please help review, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [spark] Ngone51 edited a comment on pull request #29413: [SPARK-32597][CORE] Tune Event Drop in Async Event Queue

2020-08-17 Thread GitBox
Ngone51 edited a comment on pull request #29413: URL: https://github.com/apache/spark/pull/29413#issuecomment-675220711 > In that case, this 20% can be helpful. The problem is why you would like to set it to 20% in first place? Why not 10% or 30%? If one exactly know he/she would ex

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r471886440 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala ## @@ -97,18 +97,13 @@ class FileStreamSinkLog

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-17 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r471247988 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -295,7 +298,20 @@ class DAGSchedulerSuite extends SparkFunSuit

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r471885971 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala ## @@ -173,37 +177,64 @@ abstract class

[GitHub] [spark] Ngone51 commented on pull request #29413: [SPARK-32597][CORE] Tune Event Drop in Async Event Queue

2020-08-17 Thread GitBox
Ngone51 commented on pull request #29413: URL: https://github.com/apache/spark/pull/29413#issuecomment-675220711 > In that case, this 20% can be helpful. The problem is why you would like to set it to 20% in first place? Why not 10% or 30%? If one exactly know he/she would expect 20

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r471885284 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala ## @@ -173,37 +177,64 @@ abstract class

[GitHub] [spark] agrawaldevesh commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
agrawaldevesh commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675218449 @cloud-fan, incorporated your feedback. Thanks ! This is an automated message from the Apache Git Service.

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r471883048 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala ## @@ -173,37 +177,64 @@ abstract class

[GitHub] [spark] HeartSaVioR commented on a change in pull request #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #27620: URL: https://github.com/apache/spark/pull/27620#discussion_r471881844 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala ## @@ -311,6 +344,9 @@ object FileStreamSource

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29082: URL: https://github.com/apache/spark/pull/29082#issuecomment-675215274 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29082: URL: https://github.com/apache/spark/pull/29082#issuecomment-675215274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29082: [SPARK-32288][UI] Add exception summary for failed tasks in stage page

2020-08-17 Thread GitBox
SparkQA commented on pull request #29082: URL: https://github.com/apache/spark/pull/29082#issuecomment-675215033 **[Test build #127520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127520/testReport)** for PR 29082 at commit [`961eae1`](https://github.com

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-17 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r471247984 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -295,7 +298,20 @@ class DAGSchedulerSuite extends SparkFunSuit

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-17 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r471247988 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -295,7 +298,20 @@ class DAGSchedulerSuite extends SparkFunSuit

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-08-17 Thread GitBox
HeartSaVioR commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r471878410 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala ## @@ -106,10 +106,8 @@ abstract class

[GitHub] [spark] xuanyuanking commented on a change in pull request #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files

2020-08-17 Thread GitBox
xuanyuanking commented on a change in pull request #27620: URL: https://github.com/apache/spark/pull/27620#discussion_r471878372 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala ## @@ -311,6 +344,9 @@ object FileStreamSource

[GitHub] [spark] HyukjinKwon commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

2020-08-17 Thread GitBox
HyukjinKwon commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-675212876 @cloud-fan, I will port it back to other branches. I think it's doable. This is an automated message from th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675212104 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675212104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675173421 **[Test build #127516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127516/testReport)** for PR 29422 at commit [`df128e5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675211663 **[Test build #127516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127516/testReport)** for PR 29422 at commit [`df128e5`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675208709 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675208709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675208159 **[Test build #127515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127515/testReport)** for PR 29422 at commit [`e542aa1`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675168030 **[Test build #127515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127515/testReport)** for PR 29422 at commit [`e542aa1`](https://gi

[GitHub] [spark] wangyum commented on pull request #29439: [SPARK-32624][SQL] Use getCanonicalName to fix byte[] compile issue

2020-08-17 Thread GitBox
wangyum commented on pull request #29439: URL: https://github.com/apache/spark/pull/29439#issuecomment-675208120 Previously, we get java types by `CodeGenerator.javaType(dataType)`, such as: https://github.com/apache/spark/blob/ff39c9271ca04951b045c5d9fca2128a82d50b46/sql/catalyst/src/ma

[GitHub] [spark] HyukjinKwon commented on pull request #29449: [SPARK-32606][SPARK-32605][INFRA] Remove the forks of action-surefire-report and action-download-artifact in test_report.yml

2020-08-17 Thread GitBox
HyukjinKwon commented on pull request #29449: URL: https://github.com/apache/spark/pull/29449#issuecomment-675206792 Thank you guys! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-17 Thread GitBox
SparkQA commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-675204497 **[Test build #127519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127519/testReport)** for PR 29395 at commit [`daa205d`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-675203122 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-675203122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL] Add an optimizer rule to split an Expand into multiple Expands for aggregates

2020-08-17 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-675202769 @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] Ngone51 commented on pull request #29270: [SPARK-32466][TEST][SQL] Add PlanStabilitySuite to detect SparkPlan regression

2020-08-17 Thread GitBox
Ngone51 commented on pull request #29270: URL: https://github.com/apache/spark/pull/29270#issuecomment-675201798 thank you all!! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] Ngone51 commented on a change in pull request #29225: [SPARK-32287][TESTS] Flaky Test: ExecutorAllocationManagerSuite.add executors default profile

2020-08-17 Thread GitBox
Ngone51 commented on a change in pull request #29225: URL: https://github.com/apache/spark/pull/29225#discussion_r471865229 ## File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ## @@ -1603,7 +1603,7 @@ class ExecutorAllocationManagerSuite ext

[GitHub] [spark] itskals commented on pull request #29413: [SPARK-32597][CORE] Tune Event Drop in Async Event Queue

2020-08-17 Thread GitBox
itskals commented on pull request #29413: URL: https://github.com/apache/spark/pull/29413#issuecomment-675199584 > I don't understand this, how does it prevent the user from changing the conf? They either change the percentage to be 20% or the event queue size to 36000. Either way they

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29453: URL: https://github.com/apache/spark/pull/29453#issuecomment-675184700 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675184678 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29453: URL: https://github.com/apache/spark/pull/29453#issuecomment-675184700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675184678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] ulysses-you edited a comment on pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
ulysses-you edited a comment on pull request #29453: URL: https://github.com/apache/spark/pull/29453#issuecomment-675183486 cc @gatorsmile I have not changed some code for the [#comment](https://github.com/apache/spark/pull/28840#discussion_r471171963), please let me know if you wa

[GitHub] [spark] SparkQA commented on pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
SparkQA commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-675184177 **[Test build #127518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127518/testReport)** for PR 29452 at commit [`61ac7b8`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
SparkQA commented on pull request #29453: URL: https://github.com/apache/spark/pull/29453#issuecomment-675184148 **[Test build #127517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127517/testReport)** for PR 29453 at commit [`3633d89`](https://github.com

[GitHub] [spark] ulysses-you opened a new pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
ulysses-you opened a new pull request #29453: URL: https://github.com/apache/spark/pull/29453 ### What changes were proposed in this pull request? Address the [#comment](https://github.com/apache/spark/pull/28840#discussion_r471172006). ### Why are the changes needed?

[GitHub] [spark] ulysses-you commented on pull request #29453: [SPARK-31999][SQL][FOLLOWUP] fix nit and more test case

2020-08-17 Thread GitBox
ulysses-you commented on pull request #29453: URL: https://github.com/apache/spark/pull/29453#issuecomment-675183486 cc @gatorsmile This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675182282 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] agrawaldevesh opened a new pull request #29452: [SPARK-32643] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-17 Thread GitBox
agrawaldevesh opened a new pull request #29452: URL: https://github.com/apache/spark/pull/29452 ### What changes were proposed in this pull request? The decommissioning state is a bit fragment across two places in the TaskSchedulerImpl: https://github.com/apache/spark/pull/29014/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675182278 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675182278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675147172 **[Test build #127513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127513/testReport)** for PR 29422 at commit [`9a4cce6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675181917 **[Test build #127513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127513/testReport)** for PR 29422 at commit [`9a4cce6`](https://github.co

[GitHub] [spark] imback82 commented on a change in pull request #29437: [SPARK-32621][SQL] 'path' option can cause issues while inferring schema in CSV/JSON datasources

2020-08-17 Thread GitBox
imback82 commented on a change in pull request #29437: URL: https://github.com/apache/spark/pull/29437#discussion_r471831707 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileTable.scala ## @@ -34,13 +35,21 @@ import org.apache.spark.sql.u

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675173421 **[Test build #127516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127516/testReport)** for PR 29422 at commit [`df128e5`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675171978 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675171978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675168359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675168359 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29437: [SPARK-32621][SQL] 'path' option can cause issues while inferring schema in CSV/JSON datasources

2020-08-17 Thread GitBox
SparkQA commented on pull request #29437: URL: https://github.com/apache/spark/pull/29437#issuecomment-675168006 **[Test build #127514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127514/testReport)** for PR 29437 at commit [`b7f4ff6`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675168030 **[Test build #127515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127515/testReport)** for PR 29422 at commit [`e542aa1`](https://github.com

[GitHub] [spark] imback82 commented on a change in pull request #29437: [SPARK-32621][SQL] 'path' option can cause issues while inferring schema in CSV/JSON datasources

2020-08-17 Thread GitBox
imback82 commented on a change in pull request #29437: URL: https://github.com/apache/spark/pull/29437#discussion_r471830558 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala ## @@ -120,7 +120,7 @@ object TextInputJsonDa

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29437: [SPARK-32621][SQL] 'path' option can cause issues while inferring schema in CSV/JSON datasources

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29437: URL: https://github.com/apache/spark/pull/29437#issuecomment-675166306 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29437: [SPARK-32621][SQL] 'path' option can cause issues while inferring schema in CSV/JSON datasources

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29437: URL: https://github.com/apache/spark/pull/29437#issuecomment-675166306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] maropu commented on pull request #29450: [3.0][SQL] Revert SPARK-32018

2020-08-17 Thread GitBox
maropu commented on pull request #29450: URL: https://github.com/apache/spark/pull/29450#issuecomment-675157935 Is it worth describing the current behaviour https://github.com/apache/spark/pull/29448#issuecomment-674723823 as a known issue in the v3.0.1 release note?

[GitHub] [spark] sarutak commented on pull request #29442: [SPARK-32627][SQL][WEBUI] Add showSessionLink parameter to SqlStatsPagedTable class in ThriftServerPage

2020-08-17 Thread GitBox
sarutak commented on pull request #29442: URL: https://github.com/apache/spark/pull/29442#issuecomment-675152279 @tianhanhu Thank you for your contribution. We have a test suite for the ThriftServer's UI (org.apache.spark.sql.hive.thriftserver.UISeleniumSuite). So could you add a test

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675150747 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675150743 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
SparkQA removed a comment on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675147142 **[Test build #127512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127512/testReport)** for PR 29445 at commit [`e7d79be`](https://gi

[GitHub] [spark] sarutak commented on a change in pull request #29442: [SPARK-32627][SQL][WEBUI] Add showSessionLink parameter to SqlStatsPagedTable class in ThriftServerPage

2020-08-17 Thread GitBox
sarutak commented on a change in pull request #29442: URL: https://github.com/apache/spark/pull/29442#discussion_r471813284 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala ## @@ -206,18 +208,34 @@ private[ui]

[GitHub] [spark] AmplabJenkins commented on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675150743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
SparkQA commented on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675150627 **[Test build #127512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127512/testReport)** for PR 29445 at commit [`e7d79be`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675147500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
AmplabJenkins removed a comment on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675147513 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675147500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
AmplabJenkins commented on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675147513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29445: [WIP][SPARK-32092][ML][PySpark] Fix parameters not being copied in CrossValidatorModel.copy(), read() and write()

2020-08-17 Thread GitBox
SparkQA commented on pull request #29445: URL: https://github.com/apache/spark/pull/29445#issuecomment-675147142 **[Test build #127512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127512/testReport)** for PR 29445 at commit [`e7d79be`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29422: [SPARK-32613][CORE] Fix regressions in DecommissionWorkerSuite

2020-08-17 Thread GitBox
SparkQA commented on pull request #29422: URL: https://github.com/apache/spark/pull/29422#issuecomment-675147172 **[Test build #127513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127513/testReport)** for PR 29422 at commit [`9a4cce6`](https://github.com

[GitHub] [spark] fqaiser94 commented on a change in pull request #29322: [SPARK-32511][SQL] Add dropFields method to Column class

2020-08-17 Thread GitBox
fqaiser94 commented on a change in pull request #29322: URL: https://github.com/apache/spark/pull/29322#discussion_r471770146 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala ## @@ -453,60 +453,81 @@ class ComplexTypesSu

[GitHub] [spark] dongjoon-hyun commented on pull request #29426: [SPARK-32610][DOCS] Fix the link to metrics.dropwizard.io in monitoring.md to refer the proper version

2020-08-17 Thread GitBox
dongjoon-hyun commented on pull request #29426: URL: https://github.com/apache/spark/pull/29426#issuecomment-675096434 Thank you, @sarutak and @srowen . This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on pull request #29322: [SPARK-32511][SQL] Add dropFields method to Column class

2020-08-17 Thread GitBox
dongjoon-hyun commented on pull request #29322: URL: https://github.com/apache/spark/pull/29322#issuecomment-675095658 Hi, @cloud-fan . Could you update the Apache Jira issue, SPARK-32511, according to your revert, please? T

<    1   2   3   4   5   >