LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688661013
@cloud-fan @Ngone51 we can use https://github.com/apache/spark/pull/29660
This is an automated message fro
cloud-fan commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484691881
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExe
cloud-fan commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688658978
@LuciferYang do you have a branch that contains the compilation fix?
This is an automated message from the Apa
LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688653113
@Ngone51 need some simple fix on compilation for Scala 2.13 , `QueryPlan`
and `ShuffleBlockFetcherIterator`.
--
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484684202
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
dongjoon-hyun commented on a change in pull request #29665:
URL: https://github.com/apache/spark/pull/29665#discussion_r484683489
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##
@@ -889,4 +889,18 @@ class AdaptiveQu
dongjoon-hyun commented on pull request #29665:
URL: https://github.com/apache/spark/pull/29665#issuecomment-688650945
@manuzhang and @cloud-fan . If this is a kind of a correctness issue, could
you add a label to JIRA, please?
-
dongjoon-hyun commented on a change in pull request #29665:
URL: https://github.com/apache/spark/pull/29665#discussion_r484682143
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##
@@ -889,4 +889,18 @@ class AdaptiveQu
AmplabJenkins removed a comment on pull request #29065:
URL: https://github.com/apache/spark/pull/29065#issuecomment-688647916
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan closed pull request #29658:
URL: https://github.com/apache/spark/pull/29658
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
AmplabJenkins removed a comment on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688647888
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To r
AmplabJenkins commented on pull request #29065:
URL: https://github.com/apache/spark/pull/29065#issuecomment-688647916
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
AmplabJenkins commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688647888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
cloud-fan commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688647688
github action passes, thanks, merging to 3.0!
This is an automated message from the Apache Git Service.
To res
SparkQA commented on pull request #29065:
URL: https://github.com/apache/spark/pull/29065#issuecomment-688647269
**[Test build #128383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128383/testReport)**
for PR 29065 at commit
[`1a8cc9b`](https://github.com
SparkQA commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688647202
**[Test build #128382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128382/testReport)**
for PR 29658 at commit
[`edcd822`](https://github.com
dongjoon-hyun commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484679330
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,39 @@ class SQLExecutionSuite extend
yaooqinn commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688644885
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
dongjoon-hyun commented on pull request #29605:
URL: https://github.com/apache/spark/pull/29605#issuecomment-688644569
Thank you for the release preparation, @ScrapCodes .
This is an automated message from the Apache Git Serv
cloud-fan commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688638563
Interesting. So `AttributeSet` and `ExpressionSet` behave differently under
scala 2.12 and 2.13. @Ngone51 can you take a look?
--
cloud-fan commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484669025
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExe
maropu commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484669248
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
AmplabJenkins removed a comment on pull request #29660:
URL: https://github.com/apache/spark/pull/29660#issuecomment-688634013
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29660:
URL: https://github.com/apache/spark/pull/29660#issuecomment-688634013
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
SparkQA commented on pull request #29660:
URL: https://github.com/apache/spark/pull/29660#issuecomment-688633651
**[Test build #128381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128381/testReport)**
for PR 29660 at commit
[`454b53c`](https://github.com
LuciferYang commented on pull request #29660:
URL: https://github.com/apache/spark/pull/29660#issuecomment-688632207
Address 454b53c merge upstream master and resolve conflict file
This is an automated message from the Apache
zero323 commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-688630650
__Note__
In `pyspark-stubs` we use data driven test cases
([scenarios](https://github.com/zero323/pyspark-stubs/tree/master/test-data/unit)
and
[runner](https://github.
LuciferYang edited a comment on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688627206
So always need to re-generate golden files with Scala 2.13? Or we need to
use different golden files for different Scala verision, feels a little
unreasonable...
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484657207
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688627206
So always need to re-generate golden files with Scala 2.13? Or we need to
use different golden files for different Scala verision, feels a little
unreasonable...
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484657207
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
AmplabJenkins removed a comment on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688626498
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688626498
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
AmplabJenkins removed a comment on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688626020
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484657832
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
SparkQA commented on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688626087
**[Test build #128380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128380/testReport)**
for PR 29669 at commit
[`fb9489f`](https://github.com
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484657832
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
AmplabJenkins removed a comment on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688626014
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To r
AmplabJenkins commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688626014
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688625923
@cloud-fan Maybe I didn't describe it clearly, now I use the master of
spark-source to execute maven test with Scala 2.12
```
mvn clean test -pl sql/core -Dtest=no
SparkQA removed a comment on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688573747
**[Test build #128371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128371/testReport)**
for PR 29658 at commit
[`edcd822`](https://gi
wzhfy commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r484657207
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##
@@ -60,10 +63,12 @@ case class SubqueryBroadcastExec(
SparkQA commented on pull request #29658:
URL: https://github.com/apache/spark/pull/29658#issuecomment-688625549
**[Test build #128371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128371/testReport)**
for PR 29658 at commit
[`edcd822`](https://github.co
AmplabJenkins removed a comment on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688620349
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
cloud-fan commented on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688624276
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29586:
URL: https://github.com/apache/spark/pull/29586#issuecomment-688620505
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688620349
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To resp
AmplabJenkins removed a comment on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688620039
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
AmplabJenkins commented on pull request #29586:
URL: https://github.com/apache/spark/pull/29586#issuecomment-688620505
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
SparkQA commented on pull request #29586:
URL: https://github.com/apache/spark/pull/29586#issuecomment-688620214
**[Test build #128379 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128379/testReport)**
for PR 29586 at commit
[`7f112c9`](https://github.com
AmplabJenkins commented on pull request #29669:
URL: https://github.com/apache/spark/pull/29669#issuecomment-688620039
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To resp
cxzl25 commented on a change in pull request #29605:
URL: https://github.com/apache/spark/pull/29605#discussion_r484650666
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
##
@@ -341,6 +341,45 @@ class HashedRelationSuite ext
cxzl25 opened a new pull request #29669:
URL: https://github.com/apache/spark/pull/29669
### What changes were proposed in this pull request?
Before SPARK-31511 is fixed, `BytesToBytesMap` iterator() is not thread-safe
and may cause data inaccuracy.
We need to add a unit test.
cloud-fan commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688618849
This should have been merged before we have `PlanStabilitySuite`, as the
query plans in golden files were kind of random previously. That's why this PR
updates `PlanStabilityS
LuciferYang commented on pull request #29598:
URL: https://github.com/apache/spark/pull/29598#issuecomment-688615468
Sorry to leave a message in a completed issue. @cloud-fan @dbaliafroozeh
This patch seems to bring about some different behavior between use Scala 2.12
and Scala 2.13.
HyukjinKwon commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484646383
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,39 @@ class SQLExecutionSuite extends
HyukjinKwon edited a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688614177
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually
cloud-fan commented on pull request #29579:
URL: https://github.com/apache/spark/pull/29579#issuecomment-688614265
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the message
cloud-fan closed pull request #29579:
URL: https://github.com/apache/spark/pull/29579
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
HyukjinKwon edited a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688613392
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually
HyukjinKwon removed a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688613392
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually
HyukjinKwon commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688614177
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually directl
cloud-fan commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484645633
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,39 @@ class SQLExecutionSuite extends Sp
HyukjinKwon commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688613392
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually directl
HyukjinKwon edited a comment on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688613392
Just for a bit of more contexts, the commits are regularly digested and
shared into the dev mailing list after being summarized. The PRs introducing
APIs are usually
ScrapCodes commented on pull request #29605:
URL: https://github.com/apache/spark/pull/29605#issuecomment-688613221
Now, I can go ahead and tag the release. Good work. ( A long battle with CI)
This is an automated message fro
dongjoon-hyun commented on pull request #29067:
URL: https://github.com/apache/spark/pull/29067#issuecomment-688608918
Hi, @gatorsmile. Is your request just about revising this GitHub PR
description, right?
We cannot change commit logs.
-
KevinSmile edited a comment on pull request #29653:
URL: https://github.com/apache/spark/pull/29653#issuecomment-688562460
I think it only affects run-example in standalone-cluster mode.
As standalone-client mode and yarn-cluster/k8s-cluster/... mode have
different logics about how t
imback82 commented on a change in pull request #29655:
URL: https://github.com/apache/spark/pull/29655#discussion_r484636101
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/OptimizeSortMergeJoinWithPartialHashDistribution.scala
##
@@ -0,0 +1,115 @
dongjoon-hyun closed pull request #29647:
URL: https://github.com/apache/spark/pull/29647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on a change in pull request #29647:
URL: https://github.com/apache/spark/pull/29647#discussion_r484633284
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/SQLOrderingUtilSuite.scala
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the
HyukjinKwon commented on a change in pull request #29640:
URL: https://github.com/apache/spark/pull/29640#discussion_r484633037
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -0,0 +1,120 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
dongjoon-hyun commented on a change in pull request #29647:
URL: https://github.com/apache/spark/pull/29647#discussion_r484632927
##
File path: sql/core/src/test/resources/sql-tests/inputs/operators.sql
##
@@ -95,3 +95,9 @@ select width_bucket(5.35, 0.024, 10.06, null);
select
dongjoon-hyun commented on pull request #29605:
URL: https://github.com/apache/spark/pull/29605#issuecomment-688600014
Thank you, @cxzl25 and @cloud-fan .
This is an automated message from the Apache Git Service.
To respond t
viirya commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484632437
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,39 @@ class SQLExecutionSuite extends Spark
HyukjinKwon commented on a change in pull request #29640:
URL: https://github.com/apache/spark/pull/29640#discussion_r484632164
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -0,0 +1,120 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
viirya closed pull request #29645:
URL: https://github.com/apache/spark/pull/29645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
viirya commented on pull request #29645:
URL: https://github.com/apache/spark/pull/29645#issuecomment-688599032
Okay, I see. It also makes sense to me. This is a hard trade-off between
simplicity and flexibility. I will close this now. If we need this flexibility
in the future, we can revi
HyukjinKwon commented on a change in pull request #29640:
URL: https://github.com/apache/spark/pull/29640#discussion_r484631878
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -0,0 +1,120 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
SparkQA commented on pull request #29667:
URL: https://github.com/apache/spark/pull/29667#issuecomment-688598156
**[Test build #128378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128378/testReport)**
for PR 29667 at commit
[`b89eccc`](https://github.com
AmplabJenkins commented on pull request #29178:
URL: https://github.com/apache/spark/pull/29178#issuecomment-688598014
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To resp
HyukjinKwon commented on a change in pull request #29640:
URL: https://github.com/apache/spark/pull/29640#discussion_r484631009
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -0,0 +1,119 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
cloud-fan commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484630405
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,39 @@ class SQLExecutionSuite extends Sp
HyukjinKwon commented on a change in pull request #29640:
URL: https://github.com/apache/spark/pull/29640#discussion_r484630365
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -0,0 +1,120 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
AmplabJenkins removed a comment on pull request #29667:
URL: https://github.com/apache/spark/pull/29667#issuecomment-688596276
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on pull request #29645:
URL: https://github.com/apache/spark/pull/29645#issuecomment-688596465
I mean we should prefer "clear and simple semantic", otherwise people can
always ask to be more flexible and save more code, like supporting array of
array of struct.
--
AmplabJenkins commented on pull request #29667:
URL: https://github.com/apache/spark/pull/29667#issuecomment-688596276
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
cloud-fan commented on a change in pull request #29605:
URL: https://github.com/apache/spark/pull/29605#discussion_r484629408
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
##
@@ -341,6 +341,45 @@ class HashedRelationSuite
HyukjinKwon commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484629291
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,37 @@ class SQLExecutionSuite extends
cloud-fan closed pull request #29605:
URL: https://github.com/apache/spark/pull/29605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Ted-Jiang commented on pull request #29668:
URL: https://github.com/apache/spark/pull/29668#issuecomment-688595580
> @Ted-Jiang, can you double check and see if there are other typos in this
file while we're here?
Sureļ¼
--
cloud-fan commented on pull request #29605:
URL: https://github.com/apache/spark/pull/29605#issuecomment-688595687
jenkins is happy finally ...
Thanks, merging to 2.4!
This is an automated message from the Apache Git S
viirya commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484629064
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,37 @@ class SQLExecutionSuite extends Spark
HyukjinKwon commented on pull request #29666:
URL: https://github.com/apache/spark/pull/29666#issuecomment-688595293
Merged to master, branch-3.0 and branch-2.4.
This is an automated message from the Apache Git Service.
To re
HyukjinKwon closed pull request #29666:
URL: https://github.com/apache/spark/pull/29666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
viirya commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484628548
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,37 @@ class SQLExecutionSuite extends Spark
HyukjinKwon commented on pull request #29668:
URL: https://github.com/apache/spark/pull/29668#issuecomment-688594956
@Ted-Jiang, can you double check and see if there are other typos in this
file while we're here?
This is an
HyukjinKwon commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484625824
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,37 @@ class SQLExecutionSuite extends
HyukjinKwon commented on pull request #29667:
URL: https://github.com/apache/spark/pull/29667#issuecomment-688594453
The change itself looks good.
This is an automated message from the Apache Git Service.
To respond to the me
HyukjinKwon commented on a change in pull request #29667:
URL: https://github.com/apache/spark/pull/29667#discussion_r484627138
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##
@@ -119,6 +125,37 @@ class SQLExecutionSuite extends
1 - 100 of 494 matches
Mail list logo
