[GitHub] [spark] SparkQA commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693213988 **[Test build #128747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128747/testReport)** for PR 29765 at commit [`19ee398`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
SparkQA commented on pull request #29722: URL: https://github.com/apache/spark/pull/29722#issuecomment-693213903 **[Test build #128748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128748/testReport)** for PR 29722 at commit [`290d2c0`](https://github.com

[GitHub] [spark] KevinSmile commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
KevinSmile commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693211242 Seems that `DecommissionWorkerSuite` is unstable? This is an automated message from the Apache Git Service. T

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489203444 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala ## @@ -475,6 +476,23 @@ final class DataStreamReader private[s

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AngersZh commented on a change in pull request #29739: URL: https://github.com/apache/spark/pull/29739#discussion_r489202822 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -693,4 +694,29 @@ case class HiveTableRelation

[GitHub] [spark] viirya commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
viirya commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693209330 Oh, got it. I'm fixing it. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] cloud-fan commented on a change in pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29739: URL: https://github.com/apache/spark/pull/29739#discussion_r489199893 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -693,4 +694,29 @@ case class HiveTableRelation(

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489197789 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -174,7 +174,7 @@ case class CreateViewCommand( def v

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489195938 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( } } +

[GitHub] [spark] HyukjinKwon commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
HyukjinKwon commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693204275 I think .. Jenkins currently doesn't run PySpark documentation due to missing dependencies. I opened some JIRAs but looks like Shane is busy at this moment. GitHub Actions i

[GitHub] [spark] SparkQA commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-15 Thread GitBox
SparkQA commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693202858 **[Test build #128746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128746/testReport)** for PR 28841 at commit [`1c8384c`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
viirya commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489192414 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +848,9 @@ class Analyzer( */ object Re

[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693200669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693200669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-15 Thread GitBox
HyukjinKwon commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-693200082 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] viirya commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
viirya commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693199014 Not sure why GitHub Actions failed at Python linter? This is an automated message from the Apache Git Service. To

[GitHub] [spark] HeartSaVioR commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-15 Thread GitBox
HeartSaVioR commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-693198878 Looks OK except the cleanup of unnecessary workarounds for `consumer.poll` as a new commit. cc. @zsxwing ---

[GitHub] [spark] SparkQA commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-15 Thread GitBox
SparkQA commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693197739 **[Test build #128745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128745/testReport)** for PR 25965 at commit [`a885212`](https://github.com

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187406 ## File path: sql/core/src/test/resources/sql-tests/inputs/window.sql ## @@ -124,4 +144,26 @@ WINDOW w AS (PARTITION BY cate ORDER BY val); -- with filt

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693196447 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489187225 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Lead

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187346 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class CumeDist(

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489187271 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187186 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class CumeDist(

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-15 Thread GitBox
HeartSaVioR commented on a change in pull request #25965: URL: https://github.com/apache/spark/pull/25965#discussion_r489186932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala ## @@ -585,7 +585,8 @@ class MicroBatchExecu

[GitHub] [spark] AmplabJenkins commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693196447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186794 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] SparkQA removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693110435 **[Test build #128729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128729/testReport)** for PR 29765 at commit [`89c2eda`](https://gi

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186319 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Lead

[GitHub] [spark] SparkQA commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693195603 **[Test build #128729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128729/testReport)** for PR 29765 at commit [`89c2eda`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185564 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185786 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693194803 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693194803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193773 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128

[GitHub] [spark] SparkQA commented on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-15 Thread GitBox
SparkQA commented on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693193823 **[Test build #128730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128730/testReport)** for PR 29766 at commit [`80ac7d2`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29766: [SPARK-32704][SQL][TESTS][FOLLOW-UP] Check any physical rule instead of a specific rule in the test

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29766: URL: https://github.com/apache/spark/pull/29766#issuecomment-693112608 **[Test build #128730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128730/testReport)** for PR 29766 at commit [`80ac7d2`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #29761: [SPARK-32889][SQL] orc table column name supports special characters.

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29761: URL: https://github.com/apache/spark/pull/29761#discussion_r489184669 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala ## @@ -38,14 +38,19 @@ import org.apache.spark

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193767 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] cloud-fan closed pull request #29734: [SPARK-32861][SQL] GenerateExec should require column ordering

2020-09-15 Thread GitBox
cloud-fan closed pull request #29734: URL: https://github.com/apache/spark/pull/29734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] AmplabJenkins commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693146552 **[Test build #128738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128738/testReport)** for PR 29762 at commit [`df1a1c8`](https://gi

[GitHub] [spark] cloud-fan commented on pull request #29734: [SPARK-32861][SQL] GenerateExec should require column ordering

2020-09-15 Thread GitBox
cloud-fan commented on pull request #29734: URL: https://github.com/apache/spark/pull/29734#issuecomment-693193357 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] SparkQA commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-15 Thread GitBox
SparkQA commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693193153 **[Test build #128738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128738/testReport)** for PR 29762 at commit [`df1a1c8`](https://github.co

[GitHub] [spark] viirya commented on a change in pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-15 Thread GitBox
viirya commented on a change in pull request #25965: URL: https://github.com/apache/spark/pull/25965#discussion_r489180882 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala ## @@ -585,7 +585,8 @@ class MicroBatchExecution(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489183117 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class FindDataSource

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182868 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -475,6 +475,16 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( } }

[GitHub] [spark] cloud-fan commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489182003 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -923,6 +925,19 @@ class Analyzer( case u

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-15 Thread GitBox
HeartSaVioR commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489181522 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -182,28 +170,14 @@ private[kafka010]

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-15 Thread GitBox
HeartSaVioR commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489177227 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ## @@ -105,34 +109,16 @@ private[kafka010]

[GitHub] [spark] SparkQA commented on pull request #29731: [SPARK-32706][SQL] Improve cast string to decimal type

2020-09-15 Thread GitBox
SparkQA commented on pull request #29731: URL: https://github.com/apache/spark/pull/29731#issuecomment-693184148 **[Test build #128744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128744/testReport)** for PR 29731 at commit [`abf2f7e`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29731: [SPARK-32706][SQL] Improve cast string to decimal type

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29731: URL: https://github.com/apache/spark/pull/29731#issuecomment-693182177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29731: [SPARK-32706][SQL] Improve cast string to decimal type

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29731: URL: https://github.com/apache/spark/pull/29731#issuecomment-693182177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693179702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693179663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693179663 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693179702 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
SparkQA commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693179376 **[Test build #128743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128743/testReport)** for PR 29739 at commit [`883f547`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
SparkQA commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693179326 **[Test build #128742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128742/testReport)** for PR 29769 at commit [`e2b0c6b`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693154780 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] HyukjinKwon commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars

2020-09-15 Thread GitBox
HyukjinKwon commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693177918 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29586: [SPARK-32743][SQL] Add distinct info at UnresolvedFunction toString

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29586: URL: https://github.com/apache/spark/pull/29586#issuecomment-693177482 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29586: [SPARK-32743][SQL] Add distinct info at UnresolvedFunction toString

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29586: URL: https://github.com/apache/spark/pull/29586#issuecomment-693177482 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29586: [SPARK-32743][SQL] Add distinct info at UnresolvedFunction toString

2020-09-15 Thread GitBox
SparkQA commented on pull request #29586: URL: https://github.com/apache/spark/pull/29586#issuecomment-693176982 **[Test build #128741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128741/testReport)** for PR 29586 at commit [`95a3e02`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693175263 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693175253 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693175253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693119883 **[Test build #128731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128731/testReport)** for PR 29739 at commit [`936de37`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29739: [SPARK-32867][SQL] When explain, HiveTableRelation show limited message

2020-09-15 Thread GitBox
SparkQA commented on pull request #29739: URL: https://github.com/apache/spark/pull/29739#issuecomment-693174200 **[Test build #128731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128731/testReport)** for PR 29739 at commit [`936de37`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693173640 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693173640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693095626 **[Test build #128727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128727/testReport)** for PR 29765 at commit [`4c8ba2a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693172802 **[Test build #128727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128727/testReport)** for PR 29765 at commit [`4c8ba2a`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #29731: [SPARK-32706][SQL] Improve cast string to decimal type

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29731: URL: https://github.com/apache/spark/pull/29731#discussion_r489159909 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -646,7 +646,7 @@ abstract class CastBase extends U

[GitHub] [spark] AmplabJenkins commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693165708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693165708 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693059917 **[Test build #128725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128725/testReport)** for PR 29765 at commit [`3160705`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29765: [SPARK-32888][DOCS] Add user document about header flag and RDD as path for reading CSV

2020-09-15 Thread GitBox
SparkQA commented on pull request #29765: URL: https://github.com/apache/spark/pull/29765#issuecomment-693164712 **[Test build #128725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128725/testReport)** for PR 29765 at commit [`3160705`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29760: URL: https://github.com/apache/spark/pull/29760#issuecomment-693162725 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29760: URL: https://github.com/apache/spark/pull/29760#issuecomment-693162725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29760: URL: https://github.com/apache/spark/pull/29760#issuecomment-693128841 **[Test build #128732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128732/testReport)** for PR 29760 at commit [`ce5c81b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13

2020-09-15 Thread GitBox
SparkQA commented on pull request #29760: URL: https://github.com/apache/spark/pull/29760#issuecomment-693162213 **[Test build #128732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128732/testReport)** for PR 29760 at commit [`ce5c81b`](https://github.co

[GitHub] [spark] KevinSmile edited a comment on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
KevinSmile edited a comment on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693155804 cc @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] KevinSmile commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
KevinSmile commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693155804 @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AmplabJenkins commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693154780 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693154501 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29769: URL: https://github.com/apache/spark/pull/29769#issuecomment-693154501 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489145718 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class CumeDist(

[GitHub] [spark] KevinSmile edited a comment on pull request #29653: [SPARK-32804][Launcher] Fix run-example command builder bug

2020-09-15 Thread GitBox
KevinSmile edited a comment on pull request #29653: URL: https://github.com/apache/spark/pull/29653#issuecomment-693146867 Yes, I'm on it. @HyukjinKwon @koertkuipers Thanks again! followup fix at https://github.com/apache/spark/pull/29769

[GitHub] [spark] KevinSmile opened a new pull request #29769: [SPARK-32804][Launcher][FOLLOWUP] fix command builder test failure without jars

2020-09-15 Thread GitBox
KevinSmile opened a new pull request #29769: URL: https://github.com/apache/spark/pull/29769 ### What changes were proposed in this pull request? It's a followup of https://github.com/apache/spark/pull/29653. Tests in `SparkSubmitCommandBuilderSuite` may fail if you did

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489145248 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class CumeDist(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29768: [SPARK-32897][PYTHON] Don't show a deprecation warning at SparkSession.builder.getOrCreate

2020-09-15 Thread GitBox
AmplabJenkins removed a comment on pull request #29768: URL: https://github.com/apache/spark/pull/29768#issuecomment-693153408 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29768: [SPARK-32897][PYTHON] Don't show a deprecation warning at SparkSession.builder.getOrCreate

2020-09-15 Thread GitBox
SparkQA removed a comment on pull request #29768: URL: https://github.com/apache/spark/pull/29768#issuecomment-693146541 **[Test build #128737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128737/testReport)** for PR 29768 at commit [`8d1fcd1`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29768: [SPARK-32897][PYTHON] Don't show a deprecation warning at SparkSession.builder.getOrCreate

2020-09-15 Thread GitBox
AmplabJenkins commented on pull request #29768: URL: https://github.com/apache/spark/pull/29768#issuecomment-693153408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29768: [SPARK-32897][PYTHON] Don't show a deprecation warning at SparkSession.builder.getOrCreate

2020-09-15 Thread GitBox
SparkQA commented on pull request #29768: URL: https://github.com/apache/spark/pull/29768#issuecomment-693153206 **[Test build #128737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128737/testReport)** for PR 29768 at commit [`8d1fcd1`](https://github.co

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
HeartSaVioR commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489142317 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala ## @@ -815,3 +815,26 @@ class DataStreamR

[GitHub] [spark] HeartSaVioR commented on pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
HeartSaVioR commented on pull request #29756: URL: https://github.com/apache/spark/pull/29756#issuecomment-693152609 Btw to expand the tests you may also want to have the changes on InMemoryTable. Would it be good for you to go through my PR first and rebase, or let me extract the part to

[GitHub] [spark] HeartSaVioR commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
HeartSaVioR commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489141439 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala ## @@ -78,6 +78,22 @@ class Rate

[GitHub] [spark] LuciferYang commented on a change in pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13

2020-09-15 Thread GitBox
LuciferYang commented on a change in pull request #29760: URL: https://github.com/apache/spark/pull/29760#discussion_r489141885 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala ## @@ -129,7 +129,8 @@ class HiveSchemaInferenceSuite

  1   2   3   4   5   6   >