HyukjinKwon commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494055451
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,201 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
AmplabJenkins commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698129244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698128830
**[Test build #129067 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129067/testReport)**
for PR 29850 at commit
zero323 commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494054241
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,201 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698127658
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon closed pull request #29858:
URL: https://github.com/apache/spark/pull/29858
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhengruifeng commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698127269
Scala 2.13 building fail due to:
```
Error: ]
/home/runner/work/spark/spark/mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala:137:
type mismatch;
SparkQA commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698126272
**[Test build #129066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129066/testReport)**
for PR 29828 at commit
AmplabJenkins commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698125610
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698124622
**[Test build #129055 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)**
for PR 29858 at commit
viirya commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494050513
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the
AmplabJenkins commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698124422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698124440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698124056
**[Test build #129065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129065/testReport)**
for PR 29857 at commit
LuciferYang commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698123928
@dongjoon-hyun Address 4f5eac5 rebase master
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29806:
URL: https://github.com/apache/spark/pull/29806#issuecomment-698123737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29806:
URL: https://github.com/apache/spark/pull/29806#issuecomment-698123433
**[Test build #129063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129063/testReport)**
for PR 29806 at commit
AngersZh commented on a change in pull request #29054:
URL: https://github.com/apache/spark/pull/29054#discussion_r494048098
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##
@@ -69,7 +69,11 @@ private[sql] class
AmplabJenkins removed a comment on pull request #29843:
URL: https://github.com/apache/spark/pull/29843#issuecomment-698120109
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29843:
URL: https://github.com/apache/spark/pull/29843#issuecomment-698120109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29843:
URL: https://github.com/apache/spark/pull/29843#issuecomment-698119769
**[Test build #129064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129064/testReport)**
for PR 29843 at commit
AmplabJenkins commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698119068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698119068
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698119058
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33682/
HyukjinKwon edited a comment on pull request #29806:
URL: https://github.com/apache/spark/pull/29806#issuecomment-698110090
@zero323, @holdenk, @srowen, @viirya, @ueshin, would you mind taking a quick
look when you guys find some time?
HyukjinKwon edited a comment on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117279
@zero323 mind working on the below ones?
- writing the guidelines in the doc
- removing non-API type hints
I think these two are pretty important
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117104
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon closed pull request #29591:
URL: https://github.com/apache/spark/pull/29591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117279
@zero323 mind working on:
- writing the guidelines in the doc
- removing non-API type hints
?
I think these two are pretty important followups to be done soon ..
HyukjinKwon commented on a change in pull request #29858:
URL: https://github.com/apache/spark/pull/29858#discussion_r494042251
##
File path: python/pyspark/install.py
##
@@ -26,18 +26,13 @@
DEFAULT_HADOOP = "hadoop3.2"
DEFAULT_HIVE = "hive2.3"
SUPPORTED_HADOOP_VERSIONS =
HyukjinKwon commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698115525
Looks fine otherwise
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698114226
:)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuciferYang commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698114101
@dongjoon-hyun ok, I found https://github.com/apache/spark/pull/29859 fix
this today :)
This is an
SparkQA removed a comment on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698077548
**[Test build #129057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129057/testReport)**
for PR 29054 at commit
AmplabJenkins removed a comment on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698112244
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29806:
URL: https://github.com/apache/spark/pull/29806#issuecomment-698110509
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698112837
You need to rebase this branch .
This is an automated message from the Apache Git Service.
To respond to
HyukjinKwon commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494039482
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to
dongjoon-hyun commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698112690
@LuciferYang . I closed your #29861 because `master` branch is already
fixed two hours ago.
-
MLnick commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698112434
Scala 2.13 build seems to be failing? Why is that?
@zhengruifeng overall seems fine - what is the performance speedup that we
get from this optimization? Is it
SparkQA commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698112255
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33682/
dongjoon-hyun commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698112298
Please reopen this if the master branch is broken really.
This is an automated message from the Apache
AmplabJenkins commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698112244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuciferYang edited a comment on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698112073
dongjoon-hyun closed pull request #29861:
URL: https://github.com/apache/spark/pull/29861
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LuciferYang commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698112073
https://github.com/apache/spark/blob/0bc0e91e4015eb98bd2f4bf17da2ec7135b520a9/mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala#L36-L54
HyukjinKwon commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494038662
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to
SparkQA commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698111706
**[Test build #129057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129057/testReport)**
for PR 29054 at commit
dongjoon-hyun commented on a change in pull request #29861:
URL: https://github.com/apache/spark/pull/29861#discussion_r494038390
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
##
@@ -114,7
LuciferYang commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698111573
cc @srowen The remaining failed case is
```
RandomForestRegressorSuite:
- training with sample weights *** FAILED ***
0.756 was not greater than or equal
dongjoon-hyun commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698111394
`master` branch is already green, isn't it?
**
for PR 29806 at commit
HyukjinKwon commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494036508
##
File path: python/docs/source/user_guide/index.rst
##
@@ -24,4 +24,5 @@ User Guide
:maxdepth: 2
arrow_pandas
+python_packaging
HyukjinKwon commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494036068
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,201 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
HyukjinKwon commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494035189
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,220 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
LuciferYang commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698106409
also ping @HyukjinKwon
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins commented on pull request #29756:
URL: https://github.com/apache/spark/pull/29756#issuecomment-698101187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29756:
URL: https://github.com/apache/spark/pull/29756#issuecomment-698101187
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xuanyuanking commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r494027847
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##
@@ -260,19 +264,47 @@ class
SparkQA commented on pull request #29756:
URL: https://github.com/apache/spark/pull/29756#issuecomment-698100892
**[Test build #129062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129062/testReport)**
for PR 29756 at commit
SparkQA commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698100859
**[Test build #129061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129061/testReport)**
for PR 29861 at commit
xuanyuanking commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r494027734
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1020,16 +1039,35 @@ class Analyzer(
//
xuanyuanking commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r494027786
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##
@@ -731,3 +732,11 @@ case class
LuciferYang commented on pull request #29861:
URL: https://github.com/apache/spark/pull/29861#issuecomment-698100268
cc @dongjoon-hyun The change of SPARK-32971 blocking GitHub 2.13 build Action
This is an automated message
LuciferYang commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698100080
cc @dongjoon-hyun https://github.com/apache/spark/pull/29861 fix GitHub 2.13
build Action, related to k8s module, I will rebase this pr after it merged.
LuciferYang opened a new pull request #29861:
URL: https://github.com/apache/spark/pull/29861
### What changes were proposed in this pull request?
Manual call `toSeq` of
`MountVolumesFeatureStep.getAdditionalKubernetesResources` method because
`ArrayBuffer` not a `Seq` in Scala 2.13
AmplabJenkins removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093835
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093811
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33677/
AmplabJenkins removed a comment on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090510
**[Test build #129060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129060/testReport)**
for PR 29860 at commit
Ngone51 commented on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090163
cc @cloud-fan @maropu Please take a look, thanks!
This is an automated message from the Apache Git Service.
To
Ngone51 opened a new pull request #29860:
URL: https://github.com/apache/spark/pull/29860
### What changes were proposed in this pull request?
This PR proposes to add the caret hints, e.g., `^`, to the approved and
actual plans where they first become different.
AmplabJenkins removed a comment on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698089064
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698089064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-698088612
**[Test build #129059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129059/testReport)**
for PR 29828 at commit
AmplabJenkins removed a comment on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698087732
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698070226
**[Test build #129054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129054/testReport)**
for PR 29857 at commit
viirya commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494015049
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JsonSuite.scala
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache
AmplabJenkins commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698087732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698087474
**[Test build #129054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129054/testReport)**
for PR 29857 at commit
AmplabJenkins commented on pull request #29800:
URL: https://github.com/apache/spark/pull/29800#issuecomment-698087113
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698087229
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33677/
AmplabJenkins removed a comment on pull request #29800:
URL: https://github.com/apache/spark/pull/29800#issuecomment-698087113
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29800:
URL: https://github.com/apache/spark/pull/29800#issuecomment-698086807
**[Test build #129058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129058/testReport)**
for PR 29800 at commit
dongjoon-hyun closed pull request #29859:
URL: https://github.com/apache/spark/pull/29859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698084404
Scala 2.13 GA job passed. Thank you, @viirya and @HyukjinKwon .
Merged to master.
This is an automated
viirya commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494011718
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JsonSuite.scala
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache
dongjoon-hyun closed pull request #29853:
URL: https://github.com/apache/spark/pull/29853
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
maropu commented on a change in pull request #29828:
URL: https://github.com/apache/spark/pull/29828#discussion_r494010395
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JsonSuite.scala
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache
HyukjinKwon commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r494009107
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,220 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
Ngone51 commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698080541
> That being said I still have concerns this PR is not sufficiently tested,
can you add some more tests for the new flows you've introduced?
There's only one new flow
HyukjinKwon commented on pull request #29853:
URL: https://github.com/apache/spark/pull/29853#issuecomment-698080155
It would have been better if we keep [the PR
template](https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE)
though.
HyukjinKwon commented on pull request #29853:
URL: https://github.com/apache/spark/pull/29853#issuecomment-698079990
Yeah, that's a known flaky test.
This is an automated message from the Apache Git Service.
To respond to
AmplabJenkins removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698078601
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698075792
**[Test build #129056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129056/testReport)**
for PR 29859 at commit
1 - 100 of 705 matches
Mail list logo
