[GitHub] [spark] beliefer opened a new pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame

2020-10-12 Thread GitBox
beliefer opened a new pull request #30021: URL: https://github.com/apache/spark/pull/30021 ### What changes were proposed in this pull request? Except for Postgresql, other data sources (for example: vertica, oracle, redshift, mysql, presto) are not allowed to specify window frame for

[GitHub] [spark] AmplabJenkins commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707455162 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
SparkQA commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707455150 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34324/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707455162 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707454852 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707454852 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707436654 **[Test build #129718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129718/testReport)** for PR 30013 at commit

[GitHub] [spark] SparkQA commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
SparkQA commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707454565 **[Test build #129718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129718/testReport)** for PR 30013 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29983: URL: https://github.com/apache/spark/pull/29983#issuecomment-707452923 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707452475 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode/inline to benefit from predicate pushdown

2020-10-12 Thread GitBox
SparkQA commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-707453840 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34326/

[GitHub] [spark] AmplabJenkins commented on pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #29983: URL: https://github.com/apache/spark/pull/29983#issuecomment-707452923 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
SparkQA commented on pull request #29983: URL: https://github.com/apache/spark/pull/29983#issuecomment-707452911 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34323/

[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707452475 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707406757 **[Test build #129715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129715/testReport)** for PR 30020 at commit

[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707451736 **[Test build #129715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129715/testReport)** for PR 30020 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29831: [SPARK-32351][SQL] Show partially pushed down partition filters in explain()

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29831: URL: https://github.com/apache/spark/pull/29831#issuecomment-707450125 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30011: [WIP][SPARK-32281][SQL] Spark keep SORTED spec in metastore

2020-10-12 Thread GitBox
SparkQA commented on pull request #30011: URL: https://github.com/apache/spark/pull/30011#issuecomment-707450228 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34325/

[GitHub] [spark] AmplabJenkins commented on pull request #29831: [SPARK-32351][SQL] Show partially pushed down partition filters in explain()

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #29831: URL: https://github.com/apache/spark/pull/29831#issuecomment-707450125 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29831: [SPARK-32351][SQL] Show partially pushed down partition filters in explain()

2020-10-12 Thread GitBox
SparkQA commented on pull request #29831: URL: https://github.com/apache/spark/pull/29831#issuecomment-707449589 **[Test build #129709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129709/testReport)** for PR 29831 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29831: [SPARK-32351][SQL] Show partially pushed down partition filters in explain()

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #29831: URL: https://github.com/apache/spark/pull/29831#issuecomment-707366373 **[Test build #129709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129709/testReport)** for PR 29831 at commit

[GitHub] [spark] SparkQA commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
SparkQA commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707448692 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34324/

[GitHub] [spark] sunchao commented on pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
sunchao commented on pull request #29792: URL: https://github.com/apache/spark/pull/29792#issuecomment-707448379 Addressed comments. Please take another look @cloud-fan @maropu . Thanks! This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
SparkQA commented on pull request #29983: URL: https://github.com/apache/spark/pull/29983#issuecomment-707448016 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34323/

[GitHub] [spark] SparkQA commented on pull request #30011: [WIP][SPARK-32281][SQL] Spark keep SORTED spec in metastore

2020-10-12 Thread GitBox
SparkQA commented on pull request #30011: URL: https://github.com/apache/spark/pull/30011#issuecomment-707447488 **[Test build #129722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129722/testReport)** for PR 30011 at commit

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707445221 **[Test build #129721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129721/testReport)** for PR 30012 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #29982: [SPARK-33100][SQL] Ignore the content inside bracketed comment and ignore the comment without content

2020-10-12 Thread GitBox
yaooqinn commented on a change in pull request #29982: URL: https://github.com/apache/spark/pull/29982#discussion_r503630451 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala ## @@ -573,4 +573,14 @@ class CliSuite extends

[GitHub] [spark] yaooqinn commented on a change in pull request #29982: [SPARK-33100][SQL] Ignore the content inside bracketed comment and ignore the comment without content

2020-10-12 Thread GitBox
yaooqinn commented on a change in pull request #29982: URL: https://github.com/apache/spark/pull/29982#discussion_r503630325 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala ## @@ -573,4 +573,14 @@ class CliSuite extends

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
dongjoon-hyun edited a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707443174 Although I moved out `pyspark-streaming` from the following, it takes still ` 1h 35m 10s` at the last run (maybe sometimes). I'm looking at this. ``` -

[GitHub] [spark] SparkQA commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode/inline to benefit from predicate pushdown

2020-10-12 Thread GitBox
SparkQA commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-707443255 **[Test build #129720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129720/testReport)** for PR 29092 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
dongjoon-hyun commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707443174 Although I moved out `pyspark-streaming` from the following, it takes still ` 1h 35m 10s`. I'm looking at this. ``` -pyspark-core, pyspark-streaming,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707442177 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707442167 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707442167 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #29982: [SPARK-33100][SQL] Ignore the content inside bracketed comment and ignore the comment without content

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29982: URL: https://github.com/apache/spark/pull/29982#discussion_r503628406 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala ## @@ -519,15 +519,29 @@ private[hive]

[GitHub] [spark] SparkQA removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707376550 **[Test build #129712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129712/testReport)** for PR 30012 at commit

[GitHub] [spark] maropu commented on a change in pull request #29982: [SPARK-33100][SQL] Ignore the content inside bracketed comment and ignore the comment without content

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29982: URL: https://github.com/apache/spark/pull/29982#discussion_r503624175 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala ## @@ -519,15 +519,29 @@ private[hive]

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707441542 **[Test build #129712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129712/testReport)** for PR 30012 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707439648 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707439641 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707439641 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30011: [WIP][SPARK-32281][SQL] Spark keep SORTED spec in metastore

2020-10-12 Thread GitBox
SparkQA commented on pull request #30011: URL: https://github.com/apache/spark/pull/30011#issuecomment-707438957 **[Test build #129719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129719/testReport)** for PR 30011 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707374183 **[Test build #129711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129711/testReport)** for PR 30020 at commit

[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707438791 **[Test build #129711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129711/testReport)** for PR 30020 at commit

[GitHub] [spark] SparkQA commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
SparkQA commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707436654 **[Test build #129718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129718/testReport)** for PR 30013 at commit

[GitHub] [spark] zhengruifeng commented on a change in pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
zhengruifeng commented on a change in pull request #30013: URL: https://github.com/apache/spark/pull/30013#discussion_r503623615 ## File path: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala ## @@ -400,10 +400,9 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29792: URL: https://github.com/apache/spark/pull/29792#issuecomment-707434624 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707434267 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #29792: URL: https://github.com/apache/spark/pull/29792#issuecomment-707434624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707434529 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34322/

[GitHub] [spark] AmplabJenkins commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707434540 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707434264 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #29792: URL: https://github.com/apache/spark/pull/29792#issuecomment-707326402 **[Test build #129704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129704/testReport)** for PR 29792 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707434264 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-10-12 Thread GitBox
SparkQA commented on pull request #29792: URL: https://github.com/apache/spark/pull/29792#issuecomment-707434001 **[Test build #129704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129704/testReport)** for PR 29792 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707363680 **[Test build #129708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129708/testReport)** for PR 30012 at commit

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707433373 **[Test build #129708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129708/testReport)** for PR 30012 at commit

[GitHub] [spark] SparkQA commented on pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
SparkQA commented on pull request #29983: URL: https://github.com/apache/spark/pull/29983#issuecomment-707432512 **[Test build #129717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129717/testReport)** for PR 29983 at commit

[GitHub] [spark] zhengruifeng commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
zhengruifeng commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707432942 @huaxingao I find that in [suite `test("thresholds

[GitHub] [spark] leanken commented on a change in pull request #29983: [SPARK-13860][SQL] Change statistical aggregate function to return null instead of Double.NaN when divideByZero

2020-10-12 Thread GitBox
leanken commented on a change in pull request #29983: URL: https://github.com/apache/spark/pull/29983#discussion_r503618972 ## File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out ## @@ -141,17 +141,17 @@ struct +struct Review

[GitHub] [spark] zhengruifeng edited a comment on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
zhengruifeng edited a comment on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707430678 @huaxingao In #29255, if threshold is set in binary lor **Estimator**, then in the **Model**, the values of `_threshold` and `_rawThreshold` are wrong (they are

[GitHub] [spark] zhengruifeng edited a comment on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
zhengruifeng edited a comment on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707430678 @huaxingao In #29255, if threshold is set in binary lor **Estimator**, then in the **Model**, the values of `_threshold` and `_rawThreshold` are wrong (they are

[GitHub] [spark] zhengruifeng commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
zhengruifeng commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707430678 @huaxingao In #29255, if threshold is set in binary lor **Estimator**, then in the model, the values of `_threshold` and `_rawThreshold` are wrong (they are initialized by

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-707429378 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-707429378 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

2020-10-12 Thread GitBox
SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-707428786 **[Test build #129705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129705/testReport)** for PR 30018 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-707333076 **[Test build #129705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129705/testReport)** for PR 30018 at commit

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707428193 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34322/

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
HyukjinKwon commented on a change in pull request #30020: URL: https://github.com/apache/spark/pull/30020#discussion_r503615658 ## File path: dev/run-tests.py ## @@ -55,6 +55,10 @@ def determine_modules_for_files(filenames): for filename in filenames: if filename

[GitHub] [spark] huaxingao commented on pull request #30013: [SPARK-32455][ML][Follow-Up] LogisticRegressionModel prediction optimization - fix incorrect initialization

2020-10-12 Thread GitBox
huaxingao commented on pull request #30013: URL: https://github.com/apache/spark/pull/30013#issuecomment-707427214 In #29255, the values of `_threshold` and `_rawThreshold` are not correct if `threshold` is explicitly set, right? Does that mean the results for `predict` and `transform`

[GitHub] [spark] wangyum commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver

2020-10-12 Thread GitBox
wangyum commented on a change in pull request #29933: URL: https://github.com/apache/spark/pull/29933#discussion_r503614378 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -893,6 +893,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707425231 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707425227 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] zhengruifeng commented on pull request #30000: [SPARK-33111][ML] aft transform optimization

2020-10-12 Thread GitBox
zhengruifeng commented on pull request #3: URL: https://github.com/apache/spark/pull/3#issuecomment-707425415 Thank you for reviewing! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707425227 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707425213 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34321/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707424439 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
HyukjinKwon commented on a change in pull request #30012: URL: https://github.com/apache/spark/pull/30012#discussion_r503612756 ## File path: .github/workflows/build_and_test.yml ## @@ -42,9 +42,11 @@ jobs: mllib-local, mllib, yarn, mesos, kubernetes,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707424432 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707424432 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707357103 **[Test build #129707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129707/testReport)** for PR 30019 at commit

[GitHub] [spark] SparkQA commented on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
SparkQA commented on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707423910 **[Test build #129707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129707/testReport)** for PR 30019 at commit

[GitHub] [spark] sunchao commented on pull request #30019: [SPARK-32381][CORE][SQL][FOLLOWUP] Reply on listLocatedStatus from FileSystem implementations

2020-10-12 Thread GitBox
sunchao commented on pull request #30019: URL: https://github.com/apache/spark/pull/30019#issuecomment-707421105 Will do @dongjoon-hyun . Should I open a new PR or change title for this one? This is an automated message from

[GitHub] [spark] maropu commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r503609757 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -318,16 +320,49 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29843: [SPARK-29250][BUILD][test-maven][test-hadoop2.7] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-707420794 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29843: [SPARK-29250][BUILD][test-maven][test-hadoop2.7] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-707420786 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29843: [SPARK-29250][BUILD][test-maven][test-hadoop2.7] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-707369074 **[Test build #129710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129710/testReport)** for PR 29843 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29843: [SPARK-29250][BUILD][test-maven][test-hadoop2.7] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-707420786 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29843: [SPARK-29250][BUILD][test-maven][test-hadoop2.7] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-10-12 Thread GitBox
SparkQA commented on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-707420404 **[Test build #129710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129710/testReport)** for PR 29843 at commit

[GitHub] [spark] github-actions[bot] commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

2020-10-12 Thread GitBox
github-actions[bot] commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-707419504 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #28860: [SPARK-32002][SQL]Support ExtractValue from nested ArrayStruct

2020-10-12 Thread GitBox
github-actions[bot] commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-707419498 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29972: [SPARK-33081][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: update type and nullability of columns (DB2 dialect)

2020-10-12 Thread GitBox
AmplabJenkins removed a comment on pull request #29972: URL: https://github.com/apache/spark/pull/29972#issuecomment-707419405 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins

2020-10-12 Thread GitBox
SparkQA commented on pull request #30020: URL: https://github.com/apache/spark/pull/30020#issuecomment-707419385 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34321/

[GitHub] [spark] AmplabJenkins commented on pull request #29972: [SPARK-33081][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: update type and nullability of columns (DB2 dialect)

2020-10-12 Thread GitBox
AmplabJenkins commented on pull request #29972: URL: https://github.com/apache/spark/pull/29972#issuecomment-707419405 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29972: [SPARK-33081][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: update type and nullability of columns (DB2 dialect)

2020-10-12 Thread GitBox
SparkQA removed a comment on pull request #29972: URL: https://github.com/apache/spark/pull/29972#issuecomment-707351433 **[Test build #129706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129706/testReport)** for PR 29972 at commit

[GitHub] [spark] SparkQA commented on pull request #29972: [SPARK-33081][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: update type and nullability of columns (DB2 dialect)

2020-10-12 Thread GitBox
SparkQA commented on pull request #29972: URL: https://github.com/apache/spark/pull/29972#issuecomment-707418695 **[Test build #129706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129706/testReport)** for PR 29972 at commit

[GitHub] [spark] SparkQA commented on pull request #30012: [SPARK-XXX][INFRA] Rebalance GitHub Action jobs

2020-10-12 Thread GitBox
SparkQA commented on pull request #30012: URL: https://github.com/apache/spark/pull/30012#issuecomment-707417045 **[Test build #129716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129716/testReport)** for PR 30012 at commit

[GitHub] [spark] maropu commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r503604990 ## File path: sql/core/src/test/resources/sql-tests/results/regexp-functions.sql.out ## @@ -252,3 +252,53 @@ SELECT regexp_extract_all('a 2b 14m',

[GitHub] [spark] maropu commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r503604042 ## File path: sql/core/src/test/resources/sql-tests/inputs/regexp-functions.sql ## @@ -31,3 +31,11 @@ SELECT regexp_extract_all('1a 2b 14m',

[GitHub] [spark] maropu commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-10-12 Thread GitBox
maropu commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r503603525 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -2538,7 +2538,7 @@ object functions { * @since 1.5.0 */ def

<    1   2   3   4   5   6   7   8   9   >