[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506491449 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/BasicWriteJobStatsTrackerMetricSuite.scala ## @@ -0,0 +1,59 @@ +/* +

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

AmplabJenkins removed a comment on pull request #30056: URL: https://github.com/apache/spark/pull/30056#issuecomment-710083115 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506489291 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/BasicWriteJobStatsTrackerMetricSuite.scala ## @@ -0,0 +1,59 @@ +/* +

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506488151 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala ## @@ -0,0 +1,111 @@

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

AmplabJenkins commented on pull request #30056: URL: https://github.com/apache/spark/pull/30056#issuecomment-710083115 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

SparkQA commented on pull request #30056: URL: https://github.com/apache/spark/pull/30056#issuecomment-710083092 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34502/

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506487800 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala ## @@ -0,0 +1,111 @@

[GitHub] [spark] ulysses-you commented on pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

ulysses-you commented on pull request #30029: URL: https://github.com/apache/spark/pull/30029#issuecomment-710081710 @cloud-fan sure will do it tomorrow. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] SparkQA commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

SparkQA commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710079144 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34503/

[GitHub] [spark] cloud-fan commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

cloud-fan commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r506477673 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2067,6 +2067,13 @@ class Dataset[T] private[sql]( * //

[GitHub] [spark] akiyamaneko edited a comment on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

akiyamaneko edited a comment on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997845 @gengliangwang I have attached the screenshot, or you can visit this:

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710075408 **[Test build #129899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129899/testReport)** for PR 30018 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

cloud-fan commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r506473939 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,188 @@ package

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

SparkQA commented on pull request #30056: URL: https://github.com/apache/spark/pull/30056#issuecomment-710069516 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34502/

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506448136 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala ## @@ -0,0 +1,138 @@

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506448618 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala ## @@ -0,0 +1,138 @@

[GitHub] [spark] dossett commented on pull request #29231: [SPARK-32436][CORE] Initialize numNonEmptyBlocks in HighlyCompressedMapStatus.readExternal

dossett commented on pull request #29231: URL: https://github.com/apache/spark/pull/29231#issuecomment-710061815 Running on GCP's dataproc 2.0: ``` aniskodedossett@dossett-delta-w-0:~$ spark-sql --version Welcome to __ / __/__ ___ _/ /__

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506446756 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -76,7 +79,7 @@ class

[GitHub] [spark] SparkQA commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

SparkQA commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710060401 **[Test build #129898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129898/testReport)** for PR 30026 at commit

[GitHub] [spark] LuciferYang commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710056295 Address 73e2ea6 reorganize the benchmark file This is an automated message from the Apache Git Service. To

[GitHub] [spark] tanelk commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

tanelk commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710054486 > **[Test build #129895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129895/testReport)** for PR 30018 at commit

[GitHub] [spark] tgravescs commented on pull request #29906: [SPARK-32037][CORE] Rename blacklisting feature

tgravescs commented on pull request #29906: URL: https://github.com/apache/spark/pull/29906#issuecomment-710051232 Before the comment I think to that is what I had -just deprecated, so it would be fairly easy to revert to it. Also cc @Ngone51 since he was part of that discussion

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

AmplabJenkins removed a comment on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-710050202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

AmplabJenkins commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-710050202 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] tgravescs edited a comment on pull request #29906: [SPARK-32037][CORE] Rename blacklisting feature

tgravescs edited a comment on pull request #29906: URL: https://github.com/apache/spark/pull/29906#issuecomment-710049939 @srowen @mridulm see the discussion back : https://github.com/apache/spark/pull/29906#discussion_r499125900 I'm fine either way. More input would be great so

[GitHub] [spark] tgravescs commented on pull request #29906: [SPARK-32037][CORE] Rename blacklisting feature

tgravescs commented on pull request #29906: URL: https://github.com/apache/spark/pull/29906#issuecomment-710049939 @srowen @mridulm see the discussion back : https://github.com/apache/spark/pull/29906#discussion_r499125900 I'm fine either way. More input would be great so let me

[GitHub] [spark] SparkQA commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

SparkQA commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-710049061 **[Test build #129889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129889/testReport)** for PR 30023 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

SparkQA removed a comment on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709929939 **[Test build #129889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129889/testReport)** for PR 30023 at commit

[GitHub] [spark] SparkQA commented on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

SparkQA commented on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710048233 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34501/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

AmplabJenkins removed a comment on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710048301 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

AmplabJenkins commented on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710048301 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] tgravescs edited a comment on pull request #29977: [SPARK-33088][CORE] Enhance ExecutorPlugin API to include callbacks on task start and end events

tgravescs edited a comment on pull request #29977: URL: https://github.com/apache/spark/pull/29977#issuecomment-710047148 I added @fsamuel-bs as a contributor in jira and assigned it to him. thanks.. This is an automated

[GitHub] [spark] tgravescs commented on pull request #29977: [SPARK-33088][CORE] Enhance ExecutorPlugin API to include callbacks on task start and end events

tgravescs commented on pull request #29977: URL: https://github.com/apache/spark/pull/29977#issuecomment-710047148 I added @fsamuel-bs as a contributor in lira and assigned it to him. thanks.. This is an automated message

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

SparkQA commented on pull request #30056: URL: https://github.com/apache/spark/pull/30056#issuecomment-710045243 **[Test build #129897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129897/testReport)** for PR 30056 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

AmplabJenkins removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710039325 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

AmplabJenkins removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710039315 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

AmplabJenkins commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710039315 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710006244 **[Test build #129895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129895/testReport)** for PR 30018 at commit

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710038924 **[Test build #129895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129895/testReport)** for PR 30018 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

AmplabJenkins removed a comment on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710036785 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

SparkQA commented on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710037274 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34501/

[GitHub] [spark] AmplabJenkins commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

AmplabJenkins commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710036785 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710036771 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34500/

[GitHub] [spark] dossett commented on pull request #29231: [SPARK-32436][CORE] Initialize numNonEmptyBlocks in HighlyCompressedMapStatus.readExternal

dossett commented on pull request #29231: URL: https://github.com/apache/spark/pull/29231#issuecomment-710031660 Thank you @srowen, the environment I saw this on was running spark 3.0.1 and scala 2.12.12. If I can reproduce it today I can share a stack trace and other details if that

[GitHub] [spark] srowen commented on pull request #30034: [SPARK-33111][ML][Follow-Up] aft transform optimization - predictQuantiles

srowen commented on pull request #30034: URL: https://github.com/apache/spark/pull/30034#issuecomment-710029484 It seems OK ; out of curiosity does this help much? This is an automated message from the Apache Git Service. To

[GitHub] [spark] srowen commented on pull request #29231: [SPARK-32436][CORE] Initialize numNonEmptyBlocks in HighlyCompressedMapStatus.readExternal

srowen commented on pull request #29231: URL: https://github.com/apache/spark/pull/29231#issuecomment-710028325 This only seems to affect scala 2.13, regardless, and only 3.1.x supports scala 2.13, so no there isn't a need to put it in 3.0.x. The workaround doesn't require a scala fix if

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710024768 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34500/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins removed a comment on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-710019753 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-710019726 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34499/

[GitHub] [spark] AmplabJenkins commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-710019753 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

SparkQA commented on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710017515 **[Test build #129896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129896/testReport)** for PR 30067 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710014843 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] MaxGekk commented on pull request #29976: [SPARK-33094][SQL] Make ORC format propagate Hadoop config from DS options to underlying HDFS file system

MaxGekk commented on pull request #29976: URL: https://github.com/apache/spark/pull/29976#issuecomment-710015169 Here is the PR https://github.com/apache/spark/pull/30067 with common test. This is an automated message from

[GitHub] [spark] MaxGekk commented on pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

MaxGekk commented on pull request #30067: URL: https://github.com/apache/spark/pull/30067#issuecomment-710015456 @cloud-fan @HyukjinKwon Please, take a look at it when you have time. This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710014833 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710014809 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34498/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710014833 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] MaxGekk opened a new pull request #30067: [SPARK-33169][SQL][TESTS] Check propagation of datasource options to underlying file system for built-in file-based datasources

MaxGekk opened a new pull request #30067: URL: https://github.com/apache/spark/pull/30067 ### What changes were proposed in this pull request? 1. Add the common trait `CommonFileDataSourceSuite` with tests that can be executed for all built-in file-based datasources. 2. Add a test

[GitHub] [spark] dossett commented on pull request #29231: [SPARK-32436][CORE] Initialize numNonEmptyBlocks in HighlyCompressedMapStatus.readExternal

dossett commented on pull request #29231: URL: https://github.com/apache/spark/pull/29231#issuecomment-710012954 @dongjoon-hyun Will this be included in a Spark 3.0.x release or is the plan to wait for a fix on the scala side? I ran into this very issue today, so just wondering. Thank

[GitHub] [spark] SparkQA commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-710011513 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34499/

[GitHub] [spark] AmplabJenkins commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710011549 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins removed a comment on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710011549 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

SparkQA removed a comment on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-709899037 **[Test build #129885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129885/testReport)** for PR 30026 at commit

[GitHub] [spark] SparkQA commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

SparkQA commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710010756 **[Test build #129885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129885/testReport)** for PR 30026 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506354101 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -55,10 +55,11 @@ private[sql] class SharedState(

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506352466 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -55,10 +55,11 @@ private[sql] class SharedState(

[GitHub] [spark] tanelk commented on a change in pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

tanelk commented on a change in pull request #30018: URL: https://github.com/apache/spark/pull/30018#discussion_r506348894 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -477,6 +478,25 @@ object RemoveRedundantAliases

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710006244 **[Test build #129895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129895/testReport)** for PR 30018 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

AmplabJenkins removed a comment on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-710005147 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710005412 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34498/

[GitHub] [spark] SparkQA commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

SparkQA commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-710005123 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34497/

[GitHub] [spark] tanelk commented on a change in pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

tanelk commented on a change in pull request #30018: URL: https://github.com/apache/spark/pull/30018#discussion_r506346341 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -477,6 +478,25 @@ object RemoveRedundantAliases

[GitHub] [spark] AmplabJenkins commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

AmplabJenkins commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-710005147 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] tanelk commented on a change in pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

tanelk commented on a change in pull request #30018: URL: https://github.com/apache/spark/pull/30018#discussion_r506346510 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -477,6 +478,25 @@ object RemoveRedundantAliases

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506343027 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala ## @@ -172,7 +172,7 @@ object SetCommand { case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-70394 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709984531 **[Test build #129893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129893/testReport)** for PR 29982 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-70394 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-70006 **[Test build #129893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129893/testReport)** for PR 29982 at commit

[GitHub] [spark] akiyamaneko edited a comment on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

akiyamaneko edited a comment on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997845 I have attached the screenshot, or you can visit this:

[GitHub] [spark] akiyamaneko commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

akiyamaneko commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997845 I have attached the screenshot, or you can vist [fix-screenshot](https://user-images.githubusercontent.com/52202080/95977319-50734600-0e4b-11eb-93c0-b8deb565bcd8.png)

[GitHub] [spark] SparkQA commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

SparkQA commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997808 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34497/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709993810 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

SparkQA commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709993795 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34496/

[GitHub] [spark] AmplabJenkins commented on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

AmplabJenkins commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709993810 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] ScrapCodes commented on a change in pull request #30025: [SPARK-33095][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MySQL dialect)

ScrapCodes commented on a change in pull request #30025: URL: https://github.com/apache/spark/pull/30025#discussion_r506320770 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ## @@ -48,4 +48,26 @@ private case object MySQLDialect extends

[GitHub] [spark] cloud-fan commented on pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan commented on pull request #30029: URL: https://github.com/apache/spark/pull/30029#issuecomment-709989015 @ulysses-you can you send backport PRs for 3.0 and 2.4? thanks! This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan commented on pull request #30029: URL: https://github.com/apache/spark/pull/30029#issuecomment-709988668 GA passed, thanks, merging to master! This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan closed pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan closed pull request #30029: URL: https://github.com/apache/spark/pull/30029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709988169 **[Test build #129894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129894/testReport)** for PR 2 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

AmplabJenkins removed a comment on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709985348 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #29881: [SPARK-32852][SQL] spark.sql.hive.metastore.jars support HDFS location

cloud-fan commented on a change in pull request #29881: URL: https://github.com/apache/spark/pull/29881#discussion_r506311427 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala ## @@ -80,20 +81,41 @@ private[spark] object HiveUtils extends Logging

[GitHub] [spark] beliefer commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

beliefer commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709985924 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #29881: [SPARK-32852][SQL] spark.sql.hive.metastore.jars support HDFS location

cloud-fan commented on a change in pull request #29881: URL: https://github.com/apache/spark/pull/29881#discussion_r506311033 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala ## @@ -80,20 +81,41 @@ private[spark] object HiveUtils extends Logging

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

AmplabJenkins removed a comment on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709985337 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

AmplabJenkins commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709985337 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

SparkQA removed a comment on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709878764 **[Test build #129883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129883/testReport)** for PR 30045 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29881: [SPARK-32852][SQL] spark.sql.hive.metastore.jars support HDFS location

cloud-fan commented on a change in pull request #29881: URL: https://github.com/apache/spark/pull/29881#discussion_r506310103 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala ## @@ -396,23 +440,43 @@ private[spark] object HiveUtils extends

[GitHub] [spark] SparkQA commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

SparkQA commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709984802 **[Test build #129883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129883/testReport)** for PR 30045 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins removed a comment on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709984478 Test FAILed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   8   9   >